usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

PATCH Superseded Ladislav Michl 2 participants 4 messages Jan 18, 2018 1 message not in the archive

Subsystems (3)

USB USB ehci driver OMAP USB support

lore

Share & tools

lore

Ladislav Michl

author

2018-01-18 08:04 UTC #0 lore raw

PATCH v3 1/1 usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later.

Signed-off-by Ladislav Michl <ladis-6z/[email protected]>

Acked-by Tony Lindgren <[email protected]>

Acked-by Roger Quadros <[email protected]>

---
Changes:
- v2: None, just added Tony's ack
- v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack

 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/usb/host/ehci-omap.c +3 -2

index 854b146a457d..fd6170962a1a 100644
@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;
 
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}

Signature · 6 lines

2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Alan Stern

2018-01-18 15:18 UTC #1 lore raw

Quoted 10 lines · Ladislav Michl

Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later.
Signed-off-by Ladislav Michl <ladis-6z/[email protected]>
Acked-by Tony Lindgren <[email protected]>
Acked-by Roger Quadros <[email protected]>
---
Changes:
- v2: None, just added Tony's ack
- v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack

Although there's nothing wrong with making this change, people don't like to see character strings broken up just to avoid long lines. Can you redo the patch without breaking the error message string?

Alan Stern

Quoted 8 lines

 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/usb/host/ehci-omap.c +0 -0

index 854b146a457d..fd6170962a1a 100644

drivers/usb/host/ehci-omap.c static int ehci_hcd_omap_probe(struct platform_device *pdev) · line 174

Quoted 10 lines

drivers/usb/host/ehci-omap.c +3 -2

@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;
 
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): Pine.LNX.4.44L0.1801181016540.1733-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org

Ladislav Michl

author

2018-01-18 15:26 UTC #3 lore raw

Quoted 13 lines · Alan Stern

Quoted 10 lines · Ladislav Michl
Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later.
Signed-off-by Ladislav Michl <ladis-6z/[email protected]>
Acked-by Tony Lindgren <[email protected]>
Acked-by Roger Quadros <[email protected]>
---
Changes:
- v2: None, just added Tony's ack
- v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack

Quoted 3 lines

Although there's nothing wrong with making this change, people don't like to see character strings broken up just to avoid long lines. Can you redo the patch without breaking the error message string?

Sure I could, but I broke that long line intentionaly. Line lenght rule is normally broken for string just to allow people grepping for error message in source files and I guess everyone sane would grep for "Can't get PHY device for port" which is on single line. So this way we:
1) respect 80 chars limit
2) have error message grepable.

Do you still insist on making this one long line? (I have no problem sending v4, just wanted to give some rationale before I eventually do so)

Best regards,
ladis

Quoted 10 lines

 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/usb/host/ehci-omap.c +0 -0

index 854b146a457d..fd6170962a1a 100644
@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;

Quoted 8 lines

drivers/usb/host/ehci-omap.c static int ehci_hcd_omap_probe(struct platform_device *pdev) · line 174
Quoted 8 lines
drivers/usb/host/ehci-omap.c +3 -2
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Alan Stern

Acked-by

2018-01-18 18:50 UTC #4 lore raw

Quoted 25 lines · Ladislav Michl

Quoted 13 lines · Alan Stern
Quoted 10 lines · Ladislav Michl
Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later.
Signed-off-by Ladislav Michl <ladis-6z/[email protected]>
Acked-by Tony Lindgren <[email protected]>
Acked-by Roger Quadros <[email protected]>
---
Changes:
- v2: None, just added Tony's ack
- v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack
Quoted 3 lines
Although there's nothing wrong with making this change, people don't like to see character strings broken up just to avoid long lines. Can you redo the patch without breaking the error message string?
Sure I could, but I broke that long line intentionaly. Line lenght rule is normally broken for string just to allow people grepping for error message in source files and I guess everyone sane would grep for "Can't get PHY device for port" which is on single line. So this way we:
1) respect 80 chars limit
2) have error message grepable.

Quoted 2 lines

Do you still insist on making this one long line? (I have no problem sending v4, just wanted to give some rationale before I eventually do so)

I don't have hard, set-in-stone views on this. And I have broken quite a few printk strings in my time -- but that was before people reached a consensus on whether it should be done.

Even with the rationale, it's quite likely that somebody will complain if we merge a patch that splits the string. And it's good practice to make sure that checkpatch.pl doesn't complain, in any case.

So yes, please do resubmit the patch with one long line. When you do, you may add

Acked-by Alan Stern <stern-nwvwT67g6+6dFdvTe/[email protected]>

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html