ARM: dts: imx: Add support for Advantech DMS-BA16
Subsystems (3)
PATCH v2 1/1 ARM: dts: imx: Add support for Advantech DMS-BA16
Add support for Advantech DMS-BA16 board, which uses the Advantech BA-16 module.
---
Change in v2:
- Fix the order issue in Makefile
- Sort out the nodes alphabetically
- Use SPDX tag
- Fix some property issues
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-dms-ba16.dts | 146 +++++++++++++++++++++++++++++++++++ 2 files changed, 147 insertions(+) create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6q-dfi-fs700-m60.dtb \ imx6q-display5-tianma-tm070-1280x768.dtb \ imx6q-dmo-edmqmx6.dtb \ + imx6q-dms-ba16.dtb \ imx6q-evi.dtb \ imx6q-gk802.dtb \ imx6q-gw51xx.dtb \
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +146 -0
146 lines not on this page · raw message
Signature · 1 line
2.11.0
Fabio Estevam
reviewerHi Ken,
Quoted 18 lines · Ken Lin
arch/arm/boot/dts/Makefile +1
-0@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6q-dfi-fs700-m60.dtb \ imx6q-display5-tianma-tm070-1280x768.dtb \ imx6q-dmo-edmqmx6.dtb \ + imx6q-dms-ba16.dtb \ imx6q-evi.dtb \ imx6q-gk802.dtb \ imx6q-gw51xx.dtb \arch/arm/boot/dts/imx6q-dms-ba16.dts new file +0
-0
arch/arm/boot/dts/imx6q-dms-ba16.dts line 4
Quoted 4 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +4
-0@@ -0,0 +1,146 @@ +/* + * Copyright 2018 Advantech Corporation + * + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
You should put the SPDX line as the first line and it should start with //:
// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
arch/arm/boot/dts/imx6q-dms-ba16.dts line 7
Quoted 3 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +3
-0+ */ + +
No need for two blank lines. One is enough.
Quoted 2 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +2
-0+/dts-v1/; +
...
Quoted 2 lines
+&ecspi5 {
+ num-cs = <1>;
You can remove this property.
arch/arm/boot/dts/imx6q-dms-ba16.dts line 57
Quoted 7 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +7
-0+ cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi5>; + status = "okay"; + + m25_eeprom: m25p80 at 0 { + compatible = "atmel,at25";
According to Documentation/devicetree/bindings/eeprom/at25.txt this should have the following format:
compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
Hi Fabio,
Thank you for your comments.
Will provide the v3 for the fixes
Quoted 59 lines · Fabio Estevam
Hi Ken,
Quoted 18 lines · Ken Lin
arch/arm/boot/dts/Makefile +1
-0@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ imx6q-dfi-fs700-m60.dtb \ imx6q-display5-tianma-tm070-1280x768.dtb \ imx6q-dmo-edmqmx6.dtb \ + imx6q-dms-ba16.dtb \ imx6q-evi.dtb \ imx6q-gk802.dtb \ imx6q-gw51xx.dtb \arch/arm/boot/dts/imx6q-dms-ba16.dts new file +0
-0arch/arm/boot/dts/imx6q-dms-ba16.dts line 4
Quoted 4 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +4
-0@@ -0,0 +1,146 @@ +/* + * Copyright 2018 Advantech Corporation + * + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)You should put the SPDX line as the first line and it should start with //:
// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
arch/arm/boot/dts/imx6q-dms-ba16.dts line 7
Quoted 3 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +3
-0+ */ + +No need for two blank lines. One is enough.
Quoted 2 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +2
-0+/dts-v1/; +...
Quoted 2 lines
+&ecspi5 {
+ num-cs = <1>;You can remove this property.
arch/arm/boot/dts/imx6q-dms-ba16.dts line 57
Quoted 7 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +7
-0+ cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi5>; + status = "okay"; + + m25_eeprom: m25p80 at 0 { + compatible = "atmel,at25";According to
Documentation/devicetree/bindings/eeprom/at25.txtthis should have the following format:compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".