Eliminate warnings from rpcgen generated code
Subsystems (2)
cover Eliminate warnings from rpcgen generated code
For years, the rpcgen generated code causes a number of -Wunused-variable. Taking a closer look at rpcgen , it turns out these warnings were caused by rpcgen trying inline the code.
Inlining is a technique that allows xdr routines to run faster and more efficiently. It turns out only one routine, xdr_ppathcnf(), was taking advantage of this technique.
So by turning off rpcgen inline the warnings are eliminated with no lost of speed or efficiency
The patch also eliminates a -Wmissing-prototypes by a hack to the nsm/Makefile.am.
Steve Dickson (1):
Remove warnings from rpcgen genrated files
support/export/Makefile.am | 2 +- support/nsm/Makefile.am | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.14.3
PATCH 1/1 Remove warnings from rpcgen generated files
The xdr c-files, generated from .x by rpcgen, in both libnsm.a and libexport.a libraries cause the following warnings:
mount_xdr.c:43:20: warning: unused variable 'buf' [-Wunused-variable] sm_inter_xdr.c:37:20: warning: unused variable 'buf' [-Wunused-variable] sm_inter_xdr.c:51:6: warning: unused variable 'i' [-Wunused-variable]
These warnings are caused by rpcgen trying in inline the xdr routines. It turns out no inlining was happening, except for one routine. So turning off inlining eliminated these warnings.
This patch also eliminates a Werror missing-prototypes in sm_inter.h
--- support/export/Makefile.am | 2 +- support/nsm/Makefile.am | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
support/export/Makefile.am +1 -1
@@ -35,7 +35,7 @@ $(GENFILES_CLNT): %_clnt.c: %.x $(RPCGEN) $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true - $(RPCGEN) -c -o $@ $< + $(RPCGEN) -c -i 0 -o $@ $< $(GENFILES_H): %.h: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true
support/nsm/Makefile.am +2 -1
@@ -32,11 +32,12 @@ $(GENFILES_SVC): %_svc.c: %.x $(RPCGEN) $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true - $(RPCGEN) -c -o $@ $< + $(RPCGEN) -c -i 0 -o $@ $< $(GENFILES_H): %.h: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true $(RPCGEN) -h -o $@ $< + echo "void sm_prog_1(struct svc_req *, SVCXPRT *);" >> $@ rm -f $(top_builddir)/support/include/sm_inter.h $(LN_S) ../nsm/sm_inter.h $(top_builddir)/support/include/sm_inter.h
Signature · 1 line
2.14.3
Re: [PATCH 1/1] Remove warnings from rpcgen generated files
Quoted 8 lines · Steve Dickson
The xdr c-files, generated from .x by rpcgen, in both libnsm.a and libexport.a libraries cause the following warnings:
mount_xdr.c:43:20: warning: unused variable 'buf' [-Wunused-variable] sm_inter_xdr.c:37:20: warning: unused variable 'buf' [-Wunused-variable] sm_inter_xdr.c:51:6: warning: unused variable 'i' [-Wunused-variable]
Quoted 8 lines
These warnings are caused by rpcgen trying in inline the xdr routines. It turns out no inlining was happening, except for one routine. So turning off inlining eliminated these warnings.
This patch also eliminates a Werror missing-prototypes in
sm_inter.hSigned-off-by Steve Dickson <[email protected]>
Committed...
steved.
Quoted 37 lines
--- support/export/Makefile.am | 2 +- support/nsm/Makefile.am | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)support/export/Makefile.am +1
-1@@ -35,7 +35,7 @@ $(GENFILES_CLNT): %_clnt.c: %.x $(RPCGEN) $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true - $(RPCGEN) -c -o $@ $< + $(RPCGEN) -c -i 0 -o $@ $< $(GENFILES_H): %.h: %.x $(RPCGEN) test -f $@ && rm -rf $@ || truesupport/nsm/Makefile.am +2
-1@@ -32,11 +32,12 @@ $(GENFILES_SVC): %_svc.c: %.x $(RPCGEN) $(GENFILES_XDR): %_xdr.c: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true - $(RPCGEN) -c -o $@ $< + $(RPCGEN) -c -i 0 -o $@ $< $(GENFILES_H): %.h: %.x $(RPCGEN) test -f $@ && rm -rf $@ || true $(RPCGEN) -h -o $@ $< + echo "void sm_prog_1(struct svc_req *, SVCXPRT *);" >> $@ rm -f $(top_builddir)/support/include/sm_inter.h $(LN_S) ../nsm/sm_inter.h $(top_builddir)/support/include/sm_inter.h