Skip to content

Eliminate warnings from rpcgen generated code

Steve Dickson linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1Remove warnings from rpcgen generated filessupport/export/Makefile.am support/nsm/Makefile.am+3 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Eliminate warnings from rpcgen generated code

For years, the rpcgen generated code causes a number of -Wunused-variable. Taking a closer look at rpcgen , it turns out these warnings were caused by rpcgen trying inline the code.

Inlining is a technique that allows xdr routines to run faster and more efficiently. It turns out only one routine, xdr_ppathcnf(), was taking advantage of this technique.

So by turning off rpcgen inline the warnings are eliminated with no lost of speed or efficiency

The patch also eliminates a -Wmissing-prototypes by a hack to the nsm/Makefile.am.

Steve Dickson (1):
Remove warnings from rpcgen genrated files

 support/export/Makefile.am | 2 +-
 support/nsm/Makefile.am    | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.14.3