Skip to contentSkip to conversation

tests/perf_pmu: Use perf timestamps in a few more places

PATCH Superseded Tvrtko Ursulin 4 participants 23 messages Feb 8, 2018 – Feb 12, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 tests/perf_pmu: Use perf timestamps in a few more places

From: Tvrtko Ursulin <[email protected]>

Use perf timestamps in more places where possible.

---
 tests/perf_pmu.c | 48 +++++++++++++++++++++++-------------------------
 1 file changed, 23 insertions(+), 25 deletions(-)
tests/perf_pmu.c +23 -25
index a27a8a81ec89..70fb6bd55e53 100644
@@ -203,9 +203,8 @@ single(int gem_fd, const struct intel_execution_engine2 *e, unsigned int flags)
 static void
 busy_start(int gem_fd, const struct intel_execution_engine2 *e)
 {
-	unsigned long slept;
+	uint64_t val, ts[2];
 	igt_spin_t *spin;
-	uint64_t val;
 	int fd;
 
 	/*
@@ -224,14 +223,14 @@ busy_start(int gem_fd, const struct intel_execution_engine2 *e)
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
 
-	val = pmu_read_single(fd);
-	slept = measured_usleep(batch_duration_ns / 1000);
-	val = pmu_read_single(fd) - val;
+	val = __pmu_read_single(fd, &ts[0]);
+	measured_usleep(batch_duration_ns / 1000);
+	val = __pmu_read_single(fd, &ts[1]) - val;
 
 	igt_spin_batch_free(gem_fd, spin);
 	close(fd);
 
-	assert_within_epsilon(val, slept, tolerance);
+	assert_within_epsilon(val, ts[1] - ts[0], tolerance);
 	gem_quiescent_gpu(gem_fd);
 }
 
@@ -243,9 +242,8 @@ busy_start(int gem_fd, const struct intel_execution_engine2 *e)
 static void
 busy_double_start(int gem_fd, const struct intel_execution_engine2 *e)
 {
-	unsigned long slept;
+	uint64_t val, val2, ts[2];
 	igt_spin_t *spin[2];
-	uint64_t val, val2;
 	uint32_t ctx;
 	int fd;
 
@@ -272,9 +270,9 @@ busy_double_start(int gem_fd, const struct intel_execution_engine2 *e)
 	 */
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
 
-	val = pmu_read_single(fd);
-	slept = measured_usleep(batch_duration_ns / 1000);
-	val = pmu_read_single(fd) - val;
+	val = __pmu_read_single(fd, &ts[0]);
+	measured_usleep(batch_duration_ns / 1000);
+	val = __pmu_read_single(fd, &ts[1]) - val;
 
 	igt_spin_batch_end(spin[0]);
 	igt_spin_batch_end(spin[1]);
@@ -295,7 +293,7 @@ busy_double_start(int gem_fd, const struct intel_execution_engine2 *e)
 
 	gem_context_destroy(gem_fd, ctx);
 
-	assert_within_epsilon(val, slept, tolerance);
+	assert_within_epsilon(val, ts[1] - ts[0], tolerance);
 	igt_assert_eq(val2, 0);
 
 	gem_quiescent_gpu(gem_fd);
@@ -821,9 +819,8 @@ static void
 multi_client(int gem_fd, const struct intel_execution_engine2 *e)
 {
 	uint64_t config = I915_PMU_ENGINE_BUSY(e->class, e->instance);
-	unsigned int slept[2];
+	uint64_t val[2], ts[2], slept[2];
 	igt_spin_t *spin;
-	uint64_t val[2];
 	int fd[2];
 
 	gem_quiescent_gpu(gem_fd);
@@ -839,13 +836,15 @@ multi_client(int gem_fd, const struct intel_execution_engine2 *e)
 
 	spin = igt_spin_batch_new(gem_fd, 0, e2ring(gem_fd, e), 0);
 
-	val[0] = val[1] = pmu_read_single(fd[0]);
-	slept[1] = measured_usleep(batch_duration_ns / 1000);
-	val[1] = pmu_read_single(fd[1]) - val[1];
+	val[0] = val[1] = __pmu_read_single(fd[0], &ts[0]);
+	measured_usleep(batch_duration_ns / 1000);
+	val[1] = __pmu_read_single(fd[1], &ts[1]) - val[1];
+	slept[1] = ts[1] - ts[0];
 	close(fd[1]);
 
-	slept[0] = measured_usleep(batch_duration_ns / 1000) + slept[1];
-	val[0] = pmu_read_single(fd[0]) - val[0];
+	measured_usleep(batch_duration_ns / 1000);
+	val[0] = __pmu_read_single(fd[0], &ts[1]) - val[0];
+	slept[0] = ts[1] - ts[0];
 
 	igt_spin_batch_end(spin);
 	gem_sync(gem_fd, spin->handle);
@@ -1252,8 +1251,7 @@ static void
 test_rc6(int gem_fd, unsigned int flags)
 {
 	int64_t duration_ns = 2e9;
-	uint64_t idle, busy, prev;
-	unsigned int slept;
+	uint64_t idle, busy, prev, ts[2];
 	int fd, fw;
 
 	gem_quiescent_gpu(gem_fd);
@@ -1288,11 +1286,11 @@ test_rc6(int gem_fd, unsigned int flags)
 	igt_require(wait_for_rc6(fd));
 
 	/* While idle check full RC6. */
-	prev = pmu_read_single(fd);
-	slept = measured_usleep(duration_ns / 1000);
-	idle = pmu_read_single(fd);
+	prev = __pmu_read_single(fd, &ts[0]);
+	measured_usleep(duration_ns / 1000);
+	idle = __pmu_read_single(fd, &ts[1]);
 
-	assert_within_epsilon(idle - prev, slept, tolerance);
+	assert_within_epsilon(idle - prev, ts[1] - ts[0], tolerance);
 
 	/* Wake up device and check no RC6. */
 	fw = igt_open_forcewake_handle(gem_fd);
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH 2/3 tests/perf_pmu: Handle thermally throttled devices

From: Tvrtko Ursulin <[email protected]>

Some systems cannot reach the advertised maximum frequency due throttling. Handle them by considering a 100MHz lower limit.

---
 tests/perf_pmu.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
tests/perf_pmu.c +6 -1
index 70fb6bd55e53..07b25765f1f6 100644
@@ -1222,8 +1222,13 @@ test_frequency(int gem_fd)
 		 min[0], min[1]);
 	igt_info("Max frequency: requested %.1f, actual %.1f\n",
 		 max[0], max[1]);
+
 	assert_within_epsilon(min[0], min_freq, tolerance);
-	assert_within_epsilon(max[0], max_freq, tolerance);
+	/*
+	 * On thermally throttled devices we cannot be sure maximum frequency
+	 * can be reached so use a lower limit.
+	 */
+	igt_assert(max[0] >= ((double)max_freq - 100.0));
 }
 
 static bool wait_for_rc6(int fd)
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 2/3] tests/perf_pmu: Handle thermally throttled devices

Quoting Tvrtko Ursulin (2018-02-08 08:01:30)

Quoted 16 lines

From: Tvrtko Ursulin <[email protected]>

Some systems cannot reach the advertised maximum frequency due throttling. Handle them by considering a 100MHz lower limit.

---
 tests/perf_pmu.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
tests/perf_pmu.c +0 -0
index 70fb6bd55e53..07b25765f1f6 100644
@@ -1222,8 +1222,13 @@ test_frequency(int gem_fd)
                 min[0], min[1]);

tests/perf_pmu.c test_frequency(int gem_fd) · line 1231

Quoted 10 lines
tests/perf_pmu.c +6 -1
        igt_info("Max frequency: requested %.1f, actual %.1f\n",
                 max[0], max[1]);
+
        assert_within_epsilon(min[0], min_freq, tolerance);
-       assert_within_epsilon(max[0], max_freq, tolerance);
+       /*
+        * On thermally throttled devices we cannot be sure maximum frequency
+        * can be reached so use a lower limit.
+        */
+       igt_assert(max[0] >= ((double)max_freq - 100.0));

We still want a 2-sided check though. We shouldn't be reporting max > max_freq (beyond reasonable calculation errors).
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

PATCH v2 2/3 tests/perf_pmu: Handle thermally throttled devices

From: Tvrtko Ursulin <[email protected]>

Some systems cannot reach the advertised maximum frequency due throttling. Handle them by considering a 100MHz lower limit.

v2: Use more relaxed tolerance only in the downward direction.
(Chris Wilson)

---
 tests/perf_pmu.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)
tests/perf_pmu.c +15 -5
index afc7dc992681..a5224b05c7d3 100644
@@ -120,11 +120,16 @@ static uint64_t pmu_read_multi(int fd, unsigned int num, uint64_t *val)
 	return buf[1];
 }
 
+#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
+	igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
+		     (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
+		     "'%s' != '%s' (%f not within %f%%/%f%% tolerance of %f)\n",\
+		     #x, #ref, (double)(x), \
+		     (tol_up) * 100.0, (tol_down) * 100.0, \
+		     (double)(ref))
+
 #define assert_within_epsilon(x, ref, tolerance) \
-	igt_assert_f((double)(x) <= (1.0 + (tolerance)) * (double)(ref) && \
-		     (double)(x) >= (1.0 - (tolerance)) * (double)(ref), \
-		     "'%s' != '%s' (%f not within %f%% tolerance of %f)\n",\
-		     #x, #ref, (double)(x), (tolerance) * 100.0, (double)(ref))
+	__assert_within_epsilon(x, ref, tolerance, tolerance)
 
 /*
  * Helper for cases where we assert on time spent sleeping (directly or
@@ -1229,8 +1234,13 @@ test_frequency(int gem_fd)
 		 min[0], min[1]);
 	igt_info("Max frequency: requested %.1f, actual %.1f\n",
 		 max[0], max[1]);
+
 	assert_within_epsilon(min[0], min_freq, tolerance);
-	assert_within_epsilon(max[0], max_freq, tolerance);
+	/*
+	 * On thermally throttled devices we cannot be sure maximum frequency
+	 * can be reached so use larger tolerance downards.
+	 */
+	__assert_within_epsilon(max[0], max_freq, tolerance, 0.15f);
 }
 
 static bool wait_for_rc6(int fd)
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v2 2/3
#4 lore raw

Re: [igt-dev] [PATCH i-g-t v2 2/3] tests/perf_pmu: Handle thermally throttled devices

Quoting Tvrtko Ursulin (2018-02-12 09:47:24)

Quoted 18 lines

From: Tvrtko Ursulin <[email protected]>

Some systems cannot reach the advertised maximum frequency due throttling. Handle them by considering a 100MHz lower limit.

v2: Use more relaxed tolerance only in the downward direction.
(Chris Wilson)

---
 tests/perf_pmu.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)
tests/perf_pmu.c +0 -0
index afc7dc992681..a5224b05c7d3 100644

tests/perf_pmu.c static uint64_t pmu_read_multi(int fd, unsigned int num, uint64_t *val) · line 126

Quoted 7 lines
tests/perf_pmu.c +4 -0
@@ -120,11 +120,16 @@ static uint64_t pmu_read_multi(int fd, unsigned int num, uint64_t *val)
        return buf[1];
 }
 
+#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
+       igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
+                    (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
+                    "'%s' != '%s' (%f not within %f%%/%f%% tolerance of %f)\n",\

Would "not within (-%%, +%%)" or "...(%% below, %% above)" read better?

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw

PATCH v3 2/3 tests/perf_pmu: Handle thermally throttled devices

From: Tvrtko Ursulin <[email protected]>

Some systems cannot reach the advertised maximum frequency due throttling. Handle them by considering a 100MHz lower limit.

v2: Use more relaxed tolerance only in the downward direction.
(Chris Wilson)

v3: Improved assert message. (Chris Wilson)

---
 tests/perf_pmu.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)
tests/perf_pmu.c +15 -5
index afc7dc992681..cf701bbd3f18 100644
@@ -120,11 +120,16 @@ static uint64_t pmu_read_multi(int fd, unsigned int num, uint64_t *val)
 	return buf[1];
 }
 
+#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
+	igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
+		     (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
+		     "'%s' != '%s' (%f not within +%f%%/-%f%% tolerance of %f)\n",\
+		     #x, #ref, (double)(x), \
+		     (tol_up) * 100.0, (tol_down) * 100.0, \
+		     (double)(ref))
+
 #define assert_within_epsilon(x, ref, tolerance) \
-	igt_assert_f((double)(x) <= (1.0 + (tolerance)) * (double)(ref) && \
-		     (double)(x) >= (1.0 - (tolerance)) * (double)(ref), \
-		     "'%s' != '%s' (%f not within %f%% tolerance of %f)\n",\
-		     #x, #ref, (double)(x), (tolerance) * 100.0, (double)(ref))
+	__assert_within_epsilon(x, ref, tolerance, tolerance)
 
 /*
  * Helper for cases where we assert on time spent sleeping (directly or
@@ -1229,8 +1234,13 @@ test_frequency(int gem_fd)
 		 min[0], min[1]);
 	igt_info("Max frequency: requested %.1f, actual %.1f\n",
 		 max[0], max[1]);
+
 	assert_within_epsilon(min[0], min_freq, tolerance);
-	assert_within_epsilon(max[0], max_freq, tolerance);
+	/*
+	 * On thermally throttled devices we cannot be sure maximum frequency
+	 * can be reached so use larger tolerance downards.
+	 */
+	__assert_within_epsilon(max[0], max_freq, tolerance, 0.15f);
 }
 
 static bool wait_for_rc6(int fd)
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#6 lore raw

PATCH 3/3 tests/perf_pmu: Give sampling more time

In reply to Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We get occasional errors like:

(perf_pmu:21315) CRITICAL: Test assertion failure function sema_wait, file perf_pmu.c:631:
(perf_pmu:21315) CRITICAL: Failed assertion: (double)(val[1] - val[0]) <= (1.0 + (tolerance)) * (double)(slept) && (double)(val[1] - val[0]) >= (1.0 - (tolerance)) * (double)(slept) (perf_pmu:21315) CRITICAL: 'val[1] - val[0]' != 'slept' (450000000.000000 not within 5.000000% tolerance of 500129618.000000)

Suggesting a time disagreement between userspace and the PMU.

At the moment I got no better ideas than fiddling with delays to see if it improves things.

---
 tests/perf_pmu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/perf_pmu.c +3 -1
index 07b25765f1f6..34aab6fd537f 100644
@@ -608,7 +608,9 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
 	do { /* wait for the batch to start executing */
 		usleep(5e3);
 	} while (!obj_ptr[1]);
-	usleep(5e3); /* wait for the register sampling */
+
+	pmu_read_single(fd); /* dummy read to prime pmu? */
+	usleep(50e3); /* wait for the register sampling */
 
 	val[0] = pmu_read_single(fd);
 	slept = measured_usleep(batch_duration_ns / 1000);
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#7 lore raw

Re: [igt-dev] [PATCH i-g-t 3/3] tests/perf_pmu: Give sampling more time

Quoting Tvrtko Ursulin (2018-02-08 08:01:31)

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

We get occasional errors like:

(perf_pmu:21315) CRITICAL: Test assertion failure function sema_wait, file perf_pmu.c:631:
(perf_pmu:21315) CRITICAL: Failed assertion: (double)(val[1] - val[0]) <= (1.0 + (tolerance)) * (double)(slept) && (double)(val[1] - val[0]) >= (1.0 - (tolerance)) * (double)(slept) (perf_pmu:21315) CRITICAL: 'val[1] - val[0]' != 'slept' (450000000.000000 not within 5.000000% tolerance of 500129618.000000)

Something to remember when reporting pmu errors is whether it's sampling. In this case sema_wait is always sampling... But I wonder if we can report it from pmu somehow?
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw

Re: [igt-dev] [PATCH i-g-t 3/3] tests/perf_pmu: Give sampling more time

Quoted 5 lines · Chris Wilson

Quoting Tvrtko Ursulin (2018-02-08 08:01:31)

Quoted 4 lines

From: Tvrtko Ursulin <[email protected]>

We get occasional errors like:

Quoted 7 lines
Quoted 3 lines

(perf_pmu:21315) CRITICAL: Test assertion failure function sema_wait, file perf_pmu.c:631:
(perf_pmu:21315) CRITICAL: Failed assertion: (double)(val[1] - val[0]) <= (1.0 + (tolerance)) * (double)(slept) && (double)(val[1] - val[0]) >= (1.0 - (tolerance)) * (double)(slept) (perf_pmu:21315) CRITICAL: 'val[1] - val[0]' != 'slept' (450000000.000000 not within 5.000000% tolerance of 500129618.000000)

Something to remember when reporting pmu errors is whether it's sampling. In this case sema_wait is always sampling... But I wonder if we can report it from pmu somehow?

Theoretically I think we could add our own file to sysfs, alongside <counter-name>(.unit|.scale) etc.. like ".resolution" or something. Not sure how polite that would be though.. not very I think. Alternative would be to create additional pmu hierarchy in debugfs with this data.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#9 lore raw

Re: [igt-dev] [PATCH i-g-t 3/3] tests/perf_pmu: Give sampling more time

In reply to Tvrtko Ursulin

Quoting Tvrtko Ursulin (2018-02-08 08:01:31)

Quoted 23 lines

From: Tvrtko Ursulin <[email protected]>

We get occasional errors like:

(perf_pmu:21315) CRITICAL: Test assertion failure function sema_wait, file perf_pmu.c:631:
(perf_pmu:21315) CRITICAL: Failed assertion: (double)(val[1] - val[0]) <= (1.0 + (tolerance)) * (double)(slept) && (double)(val[1] - val[0]) >= (1.0 - (tolerance)) * (double)(slept) (perf_pmu:21315) CRITICAL: 'val[1] - val[0]' != 'slept' (450000000.000000 not within 5.000000% tolerance of 500129618.000000)

Suggesting a time disagreement between userspace and the PMU.

At the moment I got no better ideas than fiddling with delays to see if it improves things.

---
 tests/perf_pmu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/perf_pmu.c +0 -0
index 07b25765f1f6..34aab6fd537f 100644

tests/perf_pmu.c sema_wait(int gem_fd, const struct intel_execution_engine2 *e, · line 613

Quoted 7 lines
tests/perf_pmu.c +3 -1
@@ -608,7 +608,9 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
        do { /* wait for the batch to start executing */
                usleep(5e3);
        } while (!obj_ptr[1]);
-       usleep(5e3); /* wait for the register sampling */
+
+       pmu_read_single(fd); /* dummy read to prime pmu? */
+       usleep(50e3); /* wait for the register sampling */

Maybe something like igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10),

	"sampling failed to start within 10msecs");

Bonus is that we will get an igt_debug() telling us how long it took. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#10 lore raw

PATCH v2 3/3 tests/perf_pmu: Give sampling more time

From: Tvrtko Ursulin <[email protected]>

We get occasional errors like:

(perf_pmu:21315) CRITICAL: Test assertion failure function sema_wait, file perf_pmu.c:631:
(perf_pmu:21315) CRITICAL: Failed assertion: (double)(val[1] - val[0]) <= (1.0 + (tolerance)) * (double)(slept) && (double)(val[1] - val[0]) >= (1.0 - (tolerance)) * (double)(slept) (perf_pmu:21315) CRITICAL: 'val[1] - val[0]' != 'slept' (450000000.000000 not within 5.000000% tolerance of 500129618.000000)

Suggesting a time disagreement between userspace and the PMU.

At the moment I got no better ideas than fiddling with delays to see if it improves things.

v2: Wait for sampling to start instead of hardcoded sleep. (Chris Wilson)

---
 tests/perf_pmu.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tests/perf_pmu.c +5 -1
index cf701bbd3f18..28ce89399623 100644
@@ -613,11 +613,15 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
 
 	fd = open_pmu(I915_PMU_ENGINE_SEMA(e->class, e->instance));
 
+	val[0] = pmu_read_single(fd);
+
 	gem_execbuf(gem_fd, &eb);
 	do { /* wait for the batch to start executing */
 		usleep(5e3);
 	} while (!obj_ptr[1]);
-	usleep(5e3); /* wait for the register sampling */
+
+	igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
+		     "sampling failed to start withing 10ms");
 
 	val[0] = pmu_read_single(fd);
 	slept = measured_usleep(batch_duration_ns / 1000);
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v2 3/3
#11 lore raw

Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/perf_pmu: Give sampling more time

Quoting Tvrtko Ursulin (2018-02-12 11:36:07)

Quoted 8 lines

From: Tvrtko Ursulin <[email protected]>

We get occasional errors like:

(perf_pmu:21315) CRITICAL: Test assertion failure function sema_wait, file perf_pmu.c:631:
(perf_pmu:21315) CRITICAL: Failed assertion: (double)(val[1] - val[0]) <= (1.0 + (tolerance)) * (double)(slept) && (double)(val[1] - val[0]) >= (1.0 - (tolerance)) * (double)(slept) (perf_pmu:21315) CRITICAL: 'val[1] - val[0]' != 'slept' (450000000.000000 not within 5.000000% tolerance of 500129618.000000)

Quoted 8 lines

Suggesting a time disagreement between userspace and the PMU.

At the moment I got no better ideas than fiddling with delays to see if it improves things.

v2: Wait for sampling to start instead of hardcoded sleep. (Chris Wilson)

Sadly a consequence is going to be that 1ms minimum delay, but shucks. I'm looking at the open-coded wait for batch to start next :) -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#13 lore raw

PATCH v2 1/3 tests/perf_pmu: Use perf timestamps in a few more places

From: Tvrtko Ursulin <[email protected]>

Use perf timestamps in more places where possible.

v2: Log measure_usleep vs perf timestamps. (Chris Wilson)

---
 tests/perf_pmu.c | 47 +++++++++++++++++++++++++++--------------------
 1 file changed, 27 insertions(+), 20 deletions(-)
tests/perf_pmu.c +27 -20
index a27a8a81ec89..afc7dc992681 100644
@@ -204,8 +204,8 @@ static void
 busy_start(int gem_fd, const struct intel_execution_engine2 *e)
 {
 	unsigned long slept;
+	uint64_t val, ts[2];
 	igt_spin_t *spin;
-	uint64_t val;
 	int fd;
 
 	/*
@@ -224,14 +224,15 @@ busy_start(int gem_fd, const struct intel_execution_engine2 *e)
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
 
-	val = pmu_read_single(fd);
+	val = __pmu_read_single(fd, &ts[0]);
 	slept = measured_usleep(batch_duration_ns / 1000);
-	val = pmu_read_single(fd) - val;
+	val = __pmu_read_single(fd, &ts[1]) - val;
+	igt_debug("slept=%lu perf=%"PRIu64"\n", slept, ts[1] - ts[0]);
 
 	igt_spin_batch_free(gem_fd, spin);
 	close(fd);
 
-	assert_within_epsilon(val, slept, tolerance);
+	assert_within_epsilon(val, ts[1] - ts[0], tolerance);
 	gem_quiescent_gpu(gem_fd);
 }
 
@@ -244,8 +245,8 @@ static void
 busy_double_start(int gem_fd, const struct intel_execution_engine2 *e)
 {
 	unsigned long slept;
+	uint64_t val, val2, ts[2];
 	igt_spin_t *spin[2];
-	uint64_t val, val2;
 	uint32_t ctx;
 	int fd;
 
@@ -272,9 +273,10 @@ busy_double_start(int gem_fd, const struct intel_execution_engine2 *e)
 	 */
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(e->class, e->instance));
 
-	val = pmu_read_single(fd);
+	val = __pmu_read_single(fd, &ts[0]);
 	slept = measured_usleep(batch_duration_ns / 1000);
-	val = pmu_read_single(fd) - val;
+	val = __pmu_read_single(fd, &ts[1]) - val;
+	igt_debug("slept=%lu perf=%"PRIu64"\n", slept, ts[1] - ts[0]);
 
 	igt_spin_batch_end(spin[0]);
 	igt_spin_batch_end(spin[1]);
@@ -295,7 +297,7 @@ busy_double_start(int gem_fd, const struct intel_execution_engine2 *e)
 
 	gem_context_destroy(gem_fd, ctx);
 
-	assert_within_epsilon(val, slept, tolerance);
+	assert_within_epsilon(val, ts[1] - ts[0], tolerance);
 	igt_assert_eq(val2, 0);
 
 	gem_quiescent_gpu(gem_fd);
@@ -821,9 +823,9 @@ static void
 multi_client(int gem_fd, const struct intel_execution_engine2 *e)
 {
 	uint64_t config = I915_PMU_ENGINE_BUSY(e->class, e->instance);
-	unsigned int slept[2];
+	unsigned long slept[2];
+	uint64_t val[2], ts[2], perf_slept[2];
 	igt_spin_t *spin;
-	uint64_t val[2];
 	int fd[2];
 
 	gem_quiescent_gpu(gem_fd);
@@ -839,21 +841,25 @@ multi_client(int gem_fd, const struct intel_execution_engine2 *e)
 
 	spin = igt_spin_batch_new(gem_fd, 0, e2ring(gem_fd, e), 0);
 
-	val[0] = val[1] = pmu_read_single(fd[0]);
+	val[0] = val[1] = __pmu_read_single(fd[0], &ts[0]);
 	slept[1] = measured_usleep(batch_duration_ns / 1000);
-	val[1] = pmu_read_single(fd[1]) - val[1];
+	val[1] = __pmu_read_single(fd[1], &ts[1]) - val[1];
+	perf_slept[1] = ts[1] - ts[0];
+	igt_debug("slept=%lu perf=%"PRIu64"\n", slept[1], perf_slept[1]);
 	close(fd[1]);
 
 	slept[0] = measured_usleep(batch_duration_ns / 1000) + slept[1];
-	val[0] = pmu_read_single(fd[0]) - val[0];
+	val[0] = __pmu_read_single(fd[0], &ts[1]) - val[0];
+	perf_slept[0] = ts[1] - ts[0];
+	igt_debug("slept=%lu perf=%"PRIu64"\n", slept[0], perf_slept[0]);
 
 	igt_spin_batch_end(spin);
 	gem_sync(gem_fd, spin->handle);
 	igt_spin_batch_free(gem_fd, spin);
 	close(fd[0]);
 
-	assert_within_epsilon(val[0], slept[0], tolerance);
-	assert_within_epsilon(val[1], slept[1], tolerance);
+	assert_within_epsilon(val[0], perf_slept[0], tolerance);
+	assert_within_epsilon(val[1], perf_slept[1], tolerance);
 }
 
 /**
@@ -1252,8 +1258,8 @@ static void
 test_rc6(int gem_fd, unsigned int flags)
 {
 	int64_t duration_ns = 2e9;
-	uint64_t idle, busy, prev;
-	unsigned int slept;
+	uint64_t idle, busy, prev, ts[2];
+	unsigned long slept;
 	int fd, fw;
 
 	gem_quiescent_gpu(gem_fd);
@@ -1288,11 +1294,12 @@ test_rc6(int gem_fd, unsigned int flags)
 	igt_require(wait_for_rc6(fd));
 
 	/* While idle check full RC6. */
-	prev = pmu_read_single(fd);
+	prev = __pmu_read_single(fd, &ts[0]);
 	slept = measured_usleep(duration_ns / 1000);
-	idle = pmu_read_single(fd);
+	idle = __pmu_read_single(fd, &ts[1]);
+	igt_debug("slept=%lu perf=%"PRIu64"\n", slept, ts[1] - ts[0]);
 
-	assert_within_epsilon(idle - prev, slept, tolerance);
+	assert_within_epsilon(idle - prev, ts[1] - ts[0], tolerance);
 
 	/* Wake up device and check no RC6. */
 	fw = igt_open_forcewake_handle(gem_fd);
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v2 1/3
#14 lore raw

Quoting Tvrtko Ursulin (2018-02-12 09:46:38)

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

Use perf timestamps in more places where possible.

v2: Log measure_usleep vs perf timestamps. (Chris Wilson)

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#15 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tests/perf_pmu: Use perf timestamps in a few more places

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/3] tests/perf_pmu: Use perf timestamps in a few more places
URL : https://patchwork.freedesktop.org/series/37874/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
3af87d45da24015b7a6124b59b2c4b854381cab6 tools/intel_aubdump: Simulate "enhanced execlist" submission for gen11+

with latest DRM-Tip kernel build CI_DRM_3741
02138262c598 drm-tip: 2018y-02m-08d-09h-37m-41s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> FAIL       (fi-cnl-y3) fdo#103167

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:420s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:426s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:377s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:494s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:288s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:485s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:491s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:473s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:457s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:564s
fi-cnl-y3        total:288  pass:261  dwarn:0   dfail:0   fail:1   skip:26  time:581s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:418s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:286s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:394s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:415s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:461s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:419s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:460s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:499s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:454s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:501s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:603s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:431s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:508s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:528s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:488s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:488s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:417s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:434s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:524s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:402s

Blacklisted hosts:
fi-glk-dsi total:288 pass:152 dwarn:1 dfail:4 fail:0 skip:131 time:280s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_888/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#16 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/3] tests/perf_pmu: Use perf timestamps in a few more places

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,1/3] tests/perf_pmu: Use perf timestamps in a few more places
URL : https://patchwork.freedesktop.org/series/37874/
State : failure

== Summary ==

Test kms_flip:

        Subgroup 2x-flip-vs-expired-vblank:
                fail       -> PASS       (shard-hsw) fdo#102887
        Subgroup 2x-plain-flip-ts-check-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368
Test drv_suspend:
        Subgroup debugfs-reader:
                skip       -> PASS       (shard-snb) fdo#102365 +2
Test gem_softpin:
        Subgroup noreloc-s3:
                pass       -> SKIP       (shard-snb) fdo#103375 +1
Test gem_eio:
        Subgroup suspend:
                pass       -> INCOMPLETE (shard-hsw)

fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375

shard-hsw        total:3414 pass:1744 dwarn:1   dfail:0   fail:11  skip:1656 time:11484s
shard-snb        total:3444 pass:1349 dwarn:1   dfail:0   fail:10  skip:2084 time:6391s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_888/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#17 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev3)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev3)
URL : https://patchwork.freedesktop.org/series/37874/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 8b9f68a13442c9307ef602cb9f0282e0c4ec43e2 igt/pm_rc6_residency: Check debugfs existence before reading

with latest DRM-Tip kernel build CI_DRM_3754
28dc2a502747 drm-tip: 2018y-02m-12d-09h-02m-17s UTC integration manifest

No testlist changes.

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-cnl-y3) fdo#103191

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:430s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:425s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:376s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:496s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:291s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:485s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:474s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:460s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:574s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:570s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:419s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:282s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:511s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:393s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:418s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:463s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:414s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:461s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:498s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:502s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:592s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:433s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:509s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:532s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:485s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:484s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:416s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:432s
fi-snb-2520m     total:3    pass:2    dwarn:0   dfail:0   fail:0   skip:0  
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:401s

Blacklisted hosts:
fi-glk-dsi total:288 pass:256 dwarn:0 dfail:0 fail:2 skip:30 time:491s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_901/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#18 lore raw

[igt-dev] ✗ Fi.CI.IGT: warning for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev3)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev3)
URL : https://patchwork.freedesktop.org/series/37874/
State : warning

== Summary ==

Test kms_frontbuffer_tracking:

        Subgroup fbc-rgb565-draw-blt:
                fail       -> PASS       (shard-apl) fdo#101623 +1
Test kms_fbcon_fbt:
        Subgroup fbc-suspend:
                pass       -> DMESG-WARN (shard-snb)
Test kms_cursor_legacy:
        Subgroup flip-vs-cursor-atomic:
                fail       -> PASS       (shard-hsw) fdo#102670
        Subgroup cursor-vs-flip-atomic-transitions:
                fail       -> PASS       (shard-apl) fdo#103355
Test kms_flip:
        Subgroup modeset-vs-vblank-race:
                pass       -> FAIL       (shard-hsw) fdo#103060 +1
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (shard-hsw) fdo#103928
        Subgroup flip-vs-expired-vblank-interruptible:
                pass       -> FAIL       (shard-apl) fdo#102887
Test gem_softpin:
        Subgroup noreloc-s3:
                dmesg-warn -> PASS       (shard-snb) fdo#103375
Test gem_eio:
        Subgroup in-flight-suspend:
                fail       -> PASS       (shard-hsw) fdo#104676
Test perf:
        Subgroup buffer-fill:
                pass       -> FAIL       (shard-apl) fdo#103755
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252
Test perf_pmu:
        Subgroup rc6:
                skip       -> PASS       (shard-hsw)
Test kms_sysfs_edid_timing:
                pass       -> WARN       (shard-apl) fdo#100047
Test pm_rps:
        Subgroup min-max-config-loaded:
                fail       -> PASS       (shard-apl) fdo#104060

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#104060 https://bugs.freedesktop.org/show_bug.cgi?id=104060

shard-apl        total:3405 pass:1759 dwarn:1   dfail:0   fail:24  skip:1619 time:12542s
shard-hsw        total:3444 pass:1758 dwarn:1   dfail:0   fail:13  skip:1671 time:11822s
shard-snb        total:3444 pass:1350 dwarn:2   dfail:0   fail:10  skip:2082 time:6750s

Blacklisted hosts:
shard-kbl total:3444 pass:1895 dwarn:19 dfail:2 fail:22 skip:1506 time:9724s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_901/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#19 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)
URL : https://patchwork.freedesktop.org/series/37874/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 3f62e3da85b792ff74c0420e62f2d39a09ddcc1f tests/kms_rotation_crc: Test all pixel formats on all planes.

with latest DRM-Tip kernel build CI_DRM_3756
9c365b708180 drm-tip: 2018y-02m-12d-15h-35m-40s UTC integration manifest

No testlist changes.

fi-bdw-5557u     total:288  pass:265  dwarn:0   dfail:0   fail:2   skip:21  time:441s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:432s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:377s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:499s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:291s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:484s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:474s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:463s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:577s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:592s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:417s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:284s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:512s
fi-hsw-4770      total:288  pass:259  dwarn:0   dfail:0   fail:2   skip:27  time:412s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:413s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:448s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:413s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:461s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:499s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:500s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:595s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:429s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:508s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:529s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:495s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:478s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:432s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:402s

Blacklisted hosts:
fi-glk-dsi total:117 pass:105 dwarn:0 dfail:0 fail:0 skip:12

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_902/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#20 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)
URL : https://patchwork.freedesktop.org/series/37874/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 3f62e3da85b792ff74c0420e62f2d39a09ddcc1f tests/kms_rotation_crc: Test all pixel formats on all planes.

with latest DRM-Tip kernel build CI_DRM_3756
9c365b708180 drm-tip: 2018y-02m-12d-15h-35m-40s UTC integration manifest

No testlist changes.

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-bdw-5557u) fdo#104162

fdo#104162 https://bugs.freedesktop.org/show_bug.cgi?id=104162

fi-bdw-5557u     total:245  pass:227  dwarn:0   dfail:0   fail:0   skip:17 
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:430s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:377s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:493s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:289s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:485s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:486s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:478s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:462s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:567s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:580s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:419s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:292s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:516s
fi-hsw-4770      total:288  pass:259  dwarn:0   dfail:0   fail:2   skip:27  time:411s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:417s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:413s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:460s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:500s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:500s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:589s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:430s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:516s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:532s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:493s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:475s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:437s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:407s

Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:470s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_903/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#21 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)
URL : https://patchwork.freedesktop.org/series/37874/
State : failure

== Summary ==

Test pm_rpm:

        Subgroup modeset-non-lpsp:
                fail       -> PASS       (shard-hsw)
        Subgroup gem-execbuf:
                fail       -> PASS       (shard-hsw)
Test perf:
        Subgroup enable-disable:
                pass       -> FAIL       (shard-apl) fdo#103715
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252
Test kms_vblank:
        Subgroup pipe-c-ts-continuation-dpms-rpm:
                fail       -> PASS       (shard-hsw)
Test kms_flip:
        Subgroup 2x-flip-vs-expired-vblank-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#102887
        Subgroup dpms-vs-vblank-race:
                pass       -> FAIL       (shard-apl) fdo#103060 +2
Test gem_eio:
        Subgroup in-flight-external:
                fail       -> PASS       (shard-hsw) fdo#104676 +1
Test kms_rotation_crc:
        Subgroup sprite-rotation-180:
                pass       -> FAIL       (shard-apl)

fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676

shard-apl        total:3351 pass:1731 dwarn:1   dfail:0   fail:23  skip:1595 time:13565s
shard-hsw        total:3427 pass:1717 dwarn:1   dfail:0   fail:54  skip:1654 time:14802s
shard-snb        total:3427 pass:1349 dwarn:1   dfail:0   fail:10  skip:2067 time:7708s

Blacklisted hosts:
shard-kbl total:3427 pass:1906 dwarn:1 dfail:0 fail:21 skip:1499 time:11032s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_902/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#22 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/3] tests/perf_pmu: Use perf timestamps in a few more places (rev5)
URL : https://patchwork.freedesktop.org/series/37874/
State : failure

== Summary ==

Test gem_softpin:

        Subgroup noreloc-s3:
                pass       -> SKIP       (shard-snb) fdo#103375
Test kms_flip:
        Subgroup 2x-plain-flip-fb-recreate:
                pass       -> FAIL       (shard-hsw) fdo#100368
        Subgroup flip-vs-expired-vblank:
                pass       -> FAIL       (shard-apl) fdo#102887
        Subgroup modeset-vs-vblank-race:
                fail       -> PASS       (shard-hsw) fdo#103060
Test pm_rpm:
        Subgroup modeset-stress-extra-wait:
                fail       -> PASS       (shard-hsw)
Test kms_vblank:
        Subgroup pipe-c-ts-continuation-dpms-rpm:
                fail       -> PASS       (shard-hsw)
Test gem_eio:
        Subgroup in-flight-external:
                fail       -> PASS       (shard-hsw) fdo#104676 +1
Test pm_rc6_residency:
        Subgroup rc6-accuracy:
                skip       -> PASS       (shard-snb)
Test kms_rotation_crc:
        Subgroup sprite-rotation-180:
                pass       -> FAIL       (shard-snb)
Test gem_linear_blits:
        Subgroup interruptible:
                pass       -> SKIP       (shard-apl)

fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676

shard-apl        total:3338 pass:1730 dwarn:1   dfail:0   fail:20  skip:1586 time:13781s
shard-hsw        total:3427 pass:1716 dwarn:1   dfail:0   fail:55  skip:1654 time:14776s
shard-snb        total:3427 pass:1348 dwarn:1   dfail:0   fail:11  skip:2067 time:7639s

Blacklisted hosts:
shard-kbl total:3427 pass:1907 dwarn:1 dfail:0 fail:21 skip:1498 time:11025s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_903/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev