Skip to contentSkip to conversation

Kconfig: cmd: Make networking command dependent on NET

PATCH Superseded Michal Simek 4 participants 8 messages Feb 26, 2018 – Mar 28, 2018

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

---
 cmd/Kconfig                              | 5 ++++-
 configs/aspenite_defconfig               | 2 --
 configs/at91sam9rlek_dataflash_defconfig | 2 --
 configs/at91sam9rlek_mmc_defconfig       | 2 --
 configs/at91sam9rlek_nandflash_defconfig | 2 --
 configs/bcm23550_w1d_defconfig           | 2 --
 configs/bcm28155_ap_defconfig            | 2 --
 configs/cairo_defconfig                  | 5 ++---
 configs/mx23evk_defconfig                | 2 --
 configs/omap3_pandora_defconfig          | 2 --
 configs/origen_defconfig                 | 4 ++--
 configs/s5p_goni_defconfig               | 2 --
 configs/s5pc210_universal_defconfig      | 5 ++---
 configs/thunderx_88xx_defconfig          | 4 +---
 configs/topic_miami_defconfig            | 2 --
 configs/topic_miamilite_defconfig        | 2 --
 configs/trats2_defconfig                 | 5 ++---
 configs/trats_defconfig                  | 5 ++---
 configs/tricorder_defconfig              | 2 --
 configs/tricorder_flash_defconfig        | 2 --
 configs/warp_defconfig                   | 2 --
 configs/zynq_zc770_xm011_defconfig       | 2 --
 configs/zynq_zc770_xm011_x16_defconfig   | 2 --
 23 files changed, 15 insertions(+), 50 deletions(-)
cmd/Kconfig +4 -1
index 18aac7f7d4c3..83a36bc1927e 100644
@@ -1012,9 +1012,10 @@ endmenu
 
 menu "Network commands"
 
+if NET
+
 config CMD_NET
 	bool "bootp, tftpboot"
-        select NET
 	default y
 	help
 	  Network commands.
@@ -1091,6 +1092,8 @@ config CMD_ETHSW
 	  operations such as enabling / disabling a port and
 	  viewing/maintaining the filtering database (FDB)
 
+endif
+
 endmenu
 
 menu "Misc commands"
configs/aspenite_defconfig +0 -2
index 7503fec2c976..3ecc55cbd620 100644
@@ -7,8 +7,6 @@ CONFIG_BOOTDELAY=3
 CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_MMC is not set
 CONFIG_SYS_NS16550=y
 CONFIG_OF_LIBFDT=y
configs/at91sam9rlek_dataflash_defconfig +0 -2
index ac929ff3c1a2..4908eceb0d0c 100644
@@ -23,8 +23,6 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_SF=y
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
configs/at91sam9rlek_mmc_defconfig +0 -2
index 1d4928f20c59..200667b1f2bd 100644
@@ -23,8 +23,6 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_SF=y
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_FAT=y
configs/at91sam9rlek_nandflash_defconfig +0 -2
index f5f3b9bbfff0..a9874146bf00 100644
@@ -23,8 +23,6 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_SF=y
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_NAND=y
configs/bcm23550_w1d_defconfig +0 -2
index d8ea336adff9..b5b10aeb93f4 100644
@@ -19,8 +19,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
configs/bcm28155_ap_defconfig +0 -2
index 49605cc85770..eb96771c5c1c 100644
@@ -20,8 +20,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
configs/cairo_defconfig +2 -3
index 7369d578e066..edd37cb64a21 100644
@@ -23,16 +23,15 @@ CONFIG_CMD_NAND=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_NET is not set
-CONFIG_CMD_DHCP=y
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_ENV_IS_IN_NAND=y
+CONFIG_NET=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_NAND=y
 CONFIG_SPL_NAND_SIMPLE=y
 CONFIG_SYS_NS16550=y
 CONFIG_OMAP3_SPI=y
 CONFIG_FAT_WRITE=y
+# CONFIG_REGEX is not set
 CONFIG_OF_LIBFDT=y
configs/mx23evk_defconfig +0 -2
index a6fd9c384687..1343c121c32b 100644
@@ -20,8 +20,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_BMP=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
configs/omap3_pandora_defconfig +0 -2
index 47371f24e6e1..2805ec50c884 100644
@@ -17,8 +17,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
configs/origen_defconfig +2 -2
index eabc160fd660..c8e61e9314e7 100644
@@ -19,13 +19,12 @@ CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_NET is not set
-CONFIG_CMD_DHCP=y
 # CONFIG_CMD_NFS is not set
-CONFIG_CMD_MII=y
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
+CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
@@ -41,3 +40,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x6601
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_FUNCTION_THOR=y
+# CONFIG_REGEX is not set
configs/s5p_goni_defconfig +0 -2
index 5c2921a3fd1d..e0788d1aab8b 100644
@@ -20,8 +20,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_ONENAND=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4=y
configs/s5pc210_universal_defconfig +2 -3
index 453ed7a57612..4e19820ac2e9 100644
@@ -19,15 +19,13 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_NET is not set
-CONFIG_CMD_DHCP=y
 # CONFIG_CMD_NFS is not set
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_MTDPARTS_DEFAULT="mtdparts=samsung-onenand:128k(s-boot),896k(bootloader),256k(params),2816k(config),8m(csa),7m(kernel),1m(log),12m(modem),60m(qboot),-(UBI)"
 CONFIG_OF_CONTROL=y
+CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_SYS_I2C_S3C24X0=y
 CONFIG_DM_MMC=y
@@ -46,3 +44,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x6601
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_FUNCTION_THOR=y
+# CONFIG_REGEX is not set
configs/thunderx_88xx_defconfig +1 -3
index 4b25c0814c81..2d6eefc82395 100644
@@ -18,8 +18,7 @@ CONFIG_SYS_PROMPT="ThunderX_88XX> "
 # CONFIG_CMD_SAVEENV is not set
 # CONFIG_CMD_ENV_EXISTS is not set
 # CONFIG_CMD_FLASH is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
+CONFIG_NET=y
 CONFIG_DM=y
 # CONFIG_MMC is not set
 CONFIG_DM_SERIAL=y
@@ -27,4 +26,3 @@ CONFIG_DEBUG_UART_PL011=y
 CONFIG_DEBUG_UART_BASE=0x87e024000000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SKIP_INIT=y
-CONFIG_REGEX=y
configs/topic_miami_defconfig +0 -2
index d5929a1801af..e937acff0881 100644
@@ -23,8 +23,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_OF_EMBED=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
configs/topic_miamilite_defconfig +0 -2
index a318e50f8f29..cea7c5cae5eb 100644
@@ -23,8 +23,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_OF_EMBED=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
configs/trats2_defconfig +2 -3
index a266325bcb5a..67a6c1fc437d 100644
@@ -22,14 +22,12 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_NET is not set
-CONFIG_CMD_DHCP=y
 # CONFIG_CMD_NFS is not set
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
+CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_DM_I2C_GPIO=y
 CONFIG_SYS_I2C_S3C24X0=y
@@ -49,4 +47,5 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x6601
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_FUNCTION_THOR=y
+# CONFIG_REGEX is not set
 CONFIG_LIB_HW_RAND=y
configs/trats_defconfig +2 -3
index 670a916c4547..f24c65f1450b 100644
@@ -21,14 +21,12 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_NET is not set
-CONFIG_CMD_DHCP=y
 # CONFIG_CMD_NFS is not set
-CONFIG_CMD_MII=y
-CONFIG_CMD_PING=y
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
+CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_DM_I2C_GPIO=y
 CONFIG_SYS_I2C_S3C24X0=y
@@ -48,4 +46,5 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x6601
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_FUNCTION_THOR=y
+# CONFIG_REGEX is not set
 CONFIG_LIB_HW_RAND=y
configs/tricorder_defconfig +0 -2
index fffd9ed1ee25..b3111945ba83 100644
@@ -15,8 +15,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
configs/tricorder_flash_defconfig +0 -2
index 1be58211a4ef..095bc2e57353 100644
@@ -15,8 +15,6 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
configs/warp_defconfig +0 -2
index 5d1dfe481b97..a729c11a869f 100644
@@ -18,8 +18,6 @@ CONFIG_CMD_PART=y
 CONFIG_CMD_USB=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
configs/zynq_zc770_xm011_defconfig +0 -2
index e78d18d244b5..b9fd74b5d941 100644
@@ -24,8 +24,6 @@ CONFIG_CMD_FPGA_LOADP=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_ISO_PARTITION is not set
configs/zynq_zc770_xm011_x16_defconfig +0 -2
index 8018831074e1..ef6f46e73c73 100644
@@ -24,8 +24,6 @@ CONFIG_CMD_FPGA_LOADP=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_ISO_PARTITION is not set
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Kconfig +9 -9
index efd77f3129f9..43540614ce66 100644
@@ -69,22 +69,22 @@ config DISTRO_DEFAULTS
 	imply USE_BOOTCOMMAND
 	select CMD_BOOTZ if ARM && !ARM64
 	select CMD_BOOTI if ARM64
-	select CMD_DHCP if NET
-	select CMD_PXE if NET
+	select CMD_DHCP if NET && CMD_NET
+	select CMD_PXE if NET && CMD_NET
 	select CMD_EXT2
 	select CMD_EXT4
 	select CMD_FAT
 	select CMD_FS_GENERIC
-	select CMD_MII if NET
+	imply CMD_MII if NET
 	select CMD_PING if NET
 	select CMD_PART if PARTITIONS
 	select HUSH_PARSER
-	select BOOTP_BOOTPATH if NET
-	select BOOTP_DNS if NET
-	select BOOTP_GATEWAY if NET
-	select BOOTP_HOSTNAME if NET
-	select BOOTP_PXE if NET
-	select BOOTP_SUBNETMASK if NET
+	select BOOTP_BOOTPATH if NET && CMD_NET
+	select BOOTP_DNS if NET && CMD_NET
+	select BOOTP_GATEWAY if NET && CMD_NET
+	select BOOTP_HOSTNAME if NET && CMD_NET
+	select BOOTP_PXE if NET && CMD_NET
+	select BOOTP_SUBNETMASK if NET && CMD_NET
 	select CMDLINE_EDITING
 	select AUTO_COMPLETE
 	select SYS_LONGHELP
cmd/Kconfig +2 -0
index 83a36bc1927e..136836d14657 100644
@@ -1039,11 +1039,13 @@ config CMD_RARP
 
 config CMD_DHCP
 	bool "dhcp"
+	depends on CMD_NET
 	help
 	  Boot image via network using DHCP/TFTP protocol
 
 config CMD_PXE
 	bool "pxe"
+	depends on CMD_NET
 	select MENU
 	help
 	  Boot image via network using PXE protocol
cmd/bootefi.c +2 -2
index 2106ed9c8c8b..c17fa2ca2363 100644
@@ -42,7 +42,7 @@ static void efi_init_obj_list(void)
 #if defined(CONFIG_LCD) || defined(CONFIG_DM_VIDEO)
 	efi_gop_register();
 #endif
-#ifdef CONFIG_NET
+#ifdef CONFIG_CMD_NET
 	efi_net_register();
 #endif
 #ifdef CONFIG_GENERATE_SMBIOS_TABLE
@@ -450,7 +450,7 @@ void efi_set_bootdev(const char *dev, const char *devnr, const char *path)
 
 		bootefi_device_path = efi_dp_from_part(desc, part);
 	} else {
-#ifdef CONFIG_NET
+#ifdef CONFIG_CMD_NET
 		bootefi_device_path = efi_dp_from_eth();
 #endif
 	}
configs/M52277EVB_defconfig +1 -2
index c5978468d7cb..fc6ee0ec5b82 100644
@@ -12,12 +12,11 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_DATE=y
 CONFIG_CMD_JFFS2=y
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
configs/M52277EVB_stmicro_defconfig +1 -2
index 962a96e46f87..900020826208 100644
@@ -11,12 +11,11 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_DATE=y
 CONFIG_CMD_JFFS2=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
configs/M5249EVB_defconfig +1 -1
index d61422f5b599..8478136c6b22 100644
@@ -8,6 +8,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_CMD_IMLS=y
 CONFIG_LOOPW=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
 CONFIG_CMD_CACHE=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
configs/M5253EVBE_defconfig +1 -1
index 7383c65263ba..754787c7d8ea 100644
@@ -8,9 +8,9 @@ CONFIG_BOOTDELAY=5
 CONFIG_CMD_IMLS=y
 CONFIG_CMD_IDE=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_MAC_PARTITION=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
configs/am335x_pdu001_defconfig +1 -2
index c6bffe0fa3fd..58d7676fa996 100644
@@ -28,13 +28,12 @@ CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_PMIC=y
 CONFIG_CMD_REGULATOR=y
 CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_EMBED=y
+# CONFIG_NET is not set
 CONFIG_SPL_DM=y
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
configs/am3517_crane_defconfig +1 -1
index 0fce9e3659ab..b70e54d71408 100644
@@ -20,7 +20,6 @@ CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 # CONFIG_CMD_NET is not set
 CONFIG_CMD_DHCP=y
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_JFFS2=y
@@ -34,3 +33,4 @@ CONFIG_USB=y
 CONFIG_USB_MUSB_HCD=y
 CONFIG_USB_AM35X=y
 CONFIG_USB_STORAGE=y
+# CONFIG_REGEX is not set
configs/amcore_defconfig +1 -2
index f884eb6aca2b..ce61e16c8d5a 100644
@@ -13,12 +13,11 @@ CONFIG_CMD_IMLS=y
 # CONFIG_CMD_XIMG is not set
 CONFIG_LOOPW=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIMER=y
 CONFIG_CMD_DIAG=y
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_DM=y
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_DM_SERIAL=y
configs/ap143_defconfig +1 -2
index 656ab7c3b187..7848b9d2fcf4 100644
@@ -22,13 +22,12 @@ CONFIG_SYS_PROMPT="ap143 # "
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_MTDPARTS=y
 CONFIG_MTDIDS_DEFAULT="nor0=spi-flash.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=spi-flash.0:256k(u-boot),64k(u-boot-env),6336k(rootfs),1472k(uImage),64k(ART)"
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+# CONFIG_NET is not set
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_BAR=y
configs/aspenite_defconfig +1 -0
index 3ecc55cbd620..59dd24f63edf 100644
@@ -7,6 +7,7 @@ CONFIG_BOOTDELAY=3
 CONFIG_BOARD_EARLY_INIT_F=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
+# CONFIG_NET is not set
 # CONFIG_MMC is not set
 CONFIG_SYS_NS16550=y
 CONFIG_OF_LIBFDT=y
configs/astro_mcf5373l_defconfig +1 -2
index 1da339c93f48..2302b1f1f3a3 100644
@@ -12,11 +12,10 @@ CONFIG_CMD_IMLS=y
 CONFIG_CMD_FPGA_LOADMK=y
 CONFIG_CMD_I2C=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_DATE=y
 CONFIG_CMD_JFFS2=y
+# CONFIG_NET is not set
 CONFIG_FPGA_ALTERA=y
 CONFIG_FPGA_CYCLON2=y
 CONFIG_FPGA_XILINX=y
configs/at91sam9rlek_dataflash_defconfig +1 -0
index 4908eceb0d0c..e80d43c79d31 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_SF=y
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+# CONFIG_NET is not set
 CONFIG_DM=y
 CONFIG_CLK=y
 CONFIG_CLK_AT91=y
configs/at91sam9rlek_mmc_defconfig +1 -0
index 200667b1f2bd..b18f2d42b010 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_SF=y
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_FAT=y
+# CONFIG_NET is not set
 CONFIG_DM=y
 CONFIG_CLK=y
 CONFIG_CLK_AT91=y
configs/at91sam9rlek_nandflash_defconfig +1 -0
index a9874146bf00..5e8c97d6f7d7 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_SF=y
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_NAND=y
+# CONFIG_NET is not set
 CONFIG_DM=y
 CONFIG_CLK=y
 CONFIG_CLK_AT91=y
configs/bcm11130_defconfig +1 -2
index 810120216aef..640d4accba52 100644
@@ -14,13 +14,12 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
 # CONFIG_PARTITION_UUIDS is not set
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_KONA=y
configs/bcm11130_nand_defconfig +1 -2
index e09940d1098b..064def01db0e 100644
@@ -13,13 +13,12 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
 # CONFIG_PARTITION_UUIDS is not set
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_KONA=y
configs/bcm23550_w1d_defconfig +1 -0
index b5b10aeb93f4..9a986ca9ae8a 100644
@@ -24,6 +24,7 @@ CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
 # CONFIG_PARTITION_UUIDS is not set
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_KONA=y
configs/bcm28155_ap_defconfig +1 -0
index eb96771c5c1c..d26cde5b0ed0 100644
@@ -25,6 +25,7 @@ CONFIG_CMD_FAT=y
 CONFIG_EFI_PARTITION=y
 # CONFIG_PARTITION_UUIDS is not set
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_KONA=y
configs/cairo_defconfig +0 -1
index edd37cb64a21..70540fb50d28 100644
@@ -26,7 +26,6 @@ CONFIG_CMD_SPI=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_ENV_IS_IN_NAND=y
-CONFIG_NET=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_NAND=y
 CONFIG_SPL_NAND_SIMPLE=y
configs/comtrend_ar5315u_ram_defconfig +1 -2
index d9e869342a96..892977a649b4 100644
@@ -27,9 +27,8 @@ CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
configs/comtrend_ar5387un_ram_defconfig +1 -2
index 16edbd21922f..12dbf0bc27a2 100644
@@ -27,9 +27,8 @@ CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
configs/comtrend_ct5361_ram_defconfig +1 -2
index 55787afca5e0..108e8ea267c1 100644
@@ -24,9 +24,8 @@ CONFIG_CMD_LICENSE=y
 # CONFIG_CMD_CRC32 is not set
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/comtrend_vr3032u_ram_defconfig +1 -2
index f85c6bfdb6a0..8149fabbc3e3 100644
@@ -25,9 +25,8 @@ CONFIG_CMD_LICENSE=y
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_LOADS is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
configs/comtrend_wap5813n_ram_defconfig +1 -2
index b123eae8ce61..6112725a81a9 100644
@@ -24,9 +24,8 @@ CONFIG_CMD_LICENSE=y
 # CONFIG_CMD_CRC32 is not set
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/efi-x86_defconfig +1 -0
index ed4faee0308d..83850d478fb9 100644
@@ -33,5 +33,6 @@ CONFIG_DEBUG_EFI_CONSOLE=y
 CONFIG_DEBUG_UART_BASE=0
 CONFIG_DEBUG_UART_CLOCK=0
 CONFIG_ICH_SPI=y
+# CONFIG_REGEX is not set
 CONFIG_EFI=y
 # CONFIG_EFI_LOADER is not set
configs/huawei_hg556a_ram_defconfig +1 -2
index 36a85f3cf5e2..b9208ff325c4 100644
@@ -24,9 +24,8 @@ CONFIG_CMD_LICENSE=y
 # CONFIG_CMD_CRC32 is not set
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/mpr2_defconfig +1 -2
index 63ad21ded55b..238f8f5287b7 100644
@@ -21,10 +21,9 @@ CONFIG_VERSION_VARIABLE=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SCIF_CONSOLE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
configs/ms7720se_defconfig +1 -2
index 0a3589194755..7434a1ff86e3 100644
@@ -24,12 +24,11 @@ CONFIG_CMD_SDRAM=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT2=y
 CONFIG_DOS_PARTITION=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SCIF_CONSOLE=y
 CONFIG_USE_PRIVATE_LIBGCC=y
configs/ms7750se_defconfig +1 -2
index 9d7eb462bf8f..db2d6b03a3fd 100644
@@ -21,10 +21,9 @@ CONFIG_BOOTARGS="console=ttySC0,38400"
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_BAUDRATE=38400
 CONFIG_SCIF_CONSOLE=y
configs/mx23evk_defconfig +1 -0
index 1343c121c32b..ebdc108ebcea 100644
@@ -25,6 +25,7 @@ CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_MMC_MXS=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
configs/mx6memcal_defconfig +1 -2
index 35759374b7ba..bf0b4f297840 100644
@@ -30,9 +30,8 @@ CONFIG_CMD_MEMTEST=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_LOADB is not set
 # CONFIG_CMD_LOADS is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
+# CONFIG_NET is not set
 # CONFIG_MMC is not set
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
configs/netgear_cg3100d_ram_defconfig +1 -2
index 0fe786ed2d46..595ad6cfaff2 100644
@@ -26,9 +26,8 @@ CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/nokia_rx51_defconfig +1 -2
index 7b6e6ce7308f..2d28e0aafe5b 100644
@@ -17,11 +17,10 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_FAT=y
+# CONFIG_NET is not set
 CONFIG_MMC_OMAP_HS=y
 CONFIG_SYS_NS16550=y
 CONFIG_OMAP3_SPI=y
configs/omap3_pandora_defconfig +3 -0
index 2805ec50c884..649a57458fd2 100644
@@ -17,6 +17,8 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_NAND=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_NET is not set
+# CONFIG_CMD_MII is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
@@ -30,3 +32,4 @@ CONFIG_SYS_NS16550=y
 CONFIG_OMAP3_SPI=y
 CONFIG_FAT_WRITE=y
 CONFIG_OF_LIBFDT=y
+# CONFIG_REGEX is not set
configs/omap4_sdp4430_defconfig +0 -2
index 59526fd1dc35..0c7c80b67bc8 100644
@@ -20,13 +20,11 @@ CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
 # CONFIG_CMD_NFS is not set
 CONFIG_CMD_EXT4_WRITE=y
 # CONFIG_EFI_PARTITION is not set
 CONFIG_SPL_PARTITION_UUIDS=y
 CONFIG_ENV_IS_IN_MMC=y
-CONFIG_NET=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_SYS_NS16550=y
 CONFIG_OMAP3_SPI=y
configs/origen_defconfig +0 -1
index c8e61e9314e7..884ee8993d7a 100644
@@ -24,7 +24,6 @@ CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
-CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_DW=y
configs/s5p_goni_defconfig +1 -0
index e0788d1aab8b..237b590ad7cd 100644
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_DFU_MMC=y
 CONFIG_DM_I2C_GPIO=y
 CONFIG_MMC_SDHCI=y
configs/s5pc210_universal_defconfig +0 -1
index 4e19820ac2e9..5014216c9b04 100644
@@ -25,7 +25,6 @@ CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_MTDPARTS_DEFAULT="mtdparts=samsung-onenand:128k(s-boot),896k(bootloader),256k(params),2816k(config),8m(csa),7m(kernel),1m(log),12m(modem),60m(qboot),-(UBI)"
 CONFIG_OF_CONTROL=y
-CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_SYS_I2C_S3C24X0=y
 CONFIG_DM_MMC=y
configs/sagem_f at st1704_ram_defconfig +1 -2
index dc227424d540..886e3676af24 100644
@@ -27,9 +27,8 @@ CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/sfr_nb4-ser_ram_defconfig +1 -2
index dba8aff66a65..57ca22c4d6f5 100644
@@ -25,9 +25,8 @@ CONFIG_CMD_LICENSE=y
 # CONFIG_CMD_CRC32 is not set
 CONFIG_CMD_MEMINFO=y
 # CONFIG_CMD_LOADS is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
+# CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/stm32h743-disco_defconfig +1 -2
index ea1405d8ca9f..c6a0d10bdbd7 100644
@@ -19,8 +19,6 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_TIMER=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
@@ -29,6 +27,7 @@ CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_CONTROL=y
 CONFIG_OF_EMBED=y
+# CONFIG_NET is not set
 CONFIG_DM_MMC=y
 CONFIG_STM32_SDMMC2=y
 # CONFIG_PINCTRL_FULL is not set
configs/stm32h743-eval_defconfig +1 -2
index 521089fb0642..ab5273ba90aa 100644
@@ -19,8 +19,6 @@ CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_TIMER=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
@@ -29,6 +27,7 @@ CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_CONTROL=y
 CONFIG_OF_EMBED=y
+# CONFIG_NET is not set
 CONFIG_DM_MMC=y
 CONFIG_STM32_SDMMC2=y
 # CONFIG_PINCTRL_FULL is not set
configs/stmark2_defconfig +1 -2
index 5226de45253b..572827200087 100644
@@ -15,13 +15,12 @@ CONFIG_SYS_PROMPT="stmark2 $ "
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_MTDIDS_DEFAULT="nor0=spi-flash.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)"
 CONFIG_ENV_IS_IN_SPI_FLASH=y
+# CONFIG_NET is not set
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_MTD=y
 CONFIG_CF_SPI=y
configs/thunderx_88xx_defconfig +3 -1
index 2d6eefc82395..4b25c0814c81 100644
@@ -18,7 +18,8 @@ CONFIG_SYS_PROMPT="ThunderX_88XX> "
 # CONFIG_CMD_SAVEENV is not set
 # CONFIG_CMD_ENV_EXISTS is not set
 # CONFIG_CMD_FLASH is not set
-CONFIG_NET=y
+# CONFIG_CMD_NET is not set
+# CONFIG_CMD_NFS is not set
 CONFIG_DM=y
 # CONFIG_MMC is not set
 CONFIG_DM_SERIAL=y
@@ -26,3 +27,4 @@ CONFIG_DEBUG_UART_PL011=y
 CONFIG_DEBUG_UART_BASE=0x87e024000000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SKIP_INIT=y
+CONFIG_REGEX=y
configs/topic_miami_defconfig +3 -0
index e937acff0881..945431c77b51 100644
@@ -23,6 +23,8 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_NET is not set
+# CONFIG_CMD_MII is not set
 CONFIG_CMD_CACHE=y
 CONFIG_OF_EMBED=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
@@ -52,3 +54,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_FUNCTION_THOR=y
+# CONFIG_REGEX is not set
configs/topic_miamilite_defconfig +3 -0
index cea7c5cae5eb..c6a3f545430e 100644
@@ -23,6 +23,8 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_NET is not set
+# CONFIG_CMD_MII is not set
 CONFIG_CMD_CACHE=y
 CONFIG_OF_EMBED=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
@@ -53,3 +55,4 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x0300
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_USB_FUNCTION_THOR=y
+# CONFIG_REGEX is not set
configs/trats2_defconfig +0 -1
index 67a6c1fc437d..3ca154b1fac5 100644
@@ -27,7 +27,6 @@ CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
-CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_DM_I2C_GPIO=y
 CONFIG_SYS_I2C_S3C24X0=y
configs/trats_defconfig +0 -1
index f24c65f1450b..019dca3602ff 100644
@@ -26,7 +26,6 @@ CONFIG_CMD_CACHE=y
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_OF_CONTROL=y
-CONFIG_NET=y
 CONFIG_DFU_MMC=y
 CONFIG_DM_I2C_GPIO=y
 CONFIG_SYS_I2C_S3C24X0=y
configs/tricorder_defconfig +1 -0
index b3111945ba83..480b0aa190f4 100644
@@ -21,6 +21,7 @@ CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:128k(SPL),1m(u-boot),384k(u-boot-env1),1152k(mtdoops),384k(u-boot-env2),5m(kernel),2m(fdt),-(ubi)"
 CONFIG_CMD_UBI=y
 CONFIG_ENV_IS_IN_NAND=y
+# CONFIG_NET is not set
 CONFIG_LED_STATUS=y
 CONFIG_LED_STATUS0=y
 CONFIG_LED_STATUS_BIT=1
configs/tricorder_flash_defconfig +1 -0
index 095bc2e57353..aeedbb28e5d4 100644
@@ -20,6 +20,7 @@ CONFIG_CMD_FAT=y
 CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
 CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:128k(SPL),1m(u-boot),384k(u-boot-env1),1152k(mtdoops),384k(u-boot-env2),5m(kernel),2m(fdt),-(ubi)"
 CONFIG_CMD_UBI=y
+# CONFIG_NET is not set
 CONFIG_LED_STATUS=y
 CONFIG_LED_STATUS0=y
 CONFIG_LED_STATUS_BIT=1
configs/vct_platinum_onenand_small_defconfig +1 -2
index c5a413fadfcb..f941f2d29cc8 100644
@@ -19,8 +19,6 @@ CONFIG_CMD_ONENAND=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_JFFS2=y
 CONFIG_MTDIDS_DEFAULT="onenand0=onenand"
@@ -29,4 +27,5 @@ CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_ONENAND=y
+# CONFIG_NET is not set
 CONFIG_SYS_NS16550=y
configs/vct_platinum_small_defconfig +1 -2
index ec7b849706d4..79f0811bfbbe 100644
@@ -17,10 +17,9 @@ CONFIG_CMD_IMLS=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SYS_NS16550=y
configs/vct_platinumavc_defconfig +1 -0
index 32624c3d53c3..57b30779390b 100644
@@ -16,3 +16,4 @@ CONFIG_CMD_DHCP=y
 CONFIG_ENV_IS_IN_FLASH=y
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SYS_NS16550=y
+# CONFIG_REGEX is not set
configs/vct_platinumavc_onenand_defconfig +1 -0
index 8f0f551c5d49..de1c1e8589a8 100644
@@ -22,3 +22,4 @@ CONFIG_CMD_UBI=y
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_ONENAND=y
 CONFIG_SYS_NS16550=y
+# CONFIG_REGEX is not set
configs/vct_platinumavc_onenand_small_defconfig +1 -2
index 24413de7f4fc..21d4c2db0805 100644
@@ -19,8 +19,6 @@ CONFIG_CMD_ONENAND=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_JFFS2=y
 CONFIG_MTDIDS_DEFAULT="onenand0=onenand"
@@ -29,4 +27,5 @@ CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_ONENAND=y
+# CONFIG_NET is not set
 CONFIG_SYS_NS16550=y
configs/vct_platinumavc_small_defconfig +1 -2
index 157597ce501d..f3cab1c1c350 100644
@@ -17,10 +17,9 @@ CONFIG_CMD_IMLS=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SYS_NS16550=y
configs/vct_premium_onenand_small_defconfig +1 -2
index 6175bb615c10..7b2d7152ee91 100644
@@ -19,8 +19,6 @@ CONFIG_CMD_ONENAND=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 CONFIG_CMD_JFFS2=y
 CONFIG_MTDIDS_DEFAULT="onenand0=onenand"
@@ -29,4 +27,5 @@ CONFIG_CMD_UBI=y
 # CONFIG_CMD_UBIFS is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_ONENAND=y
+# CONFIG_NET is not set
 CONFIG_SYS_NS16550=y
configs/vct_premium_small_defconfig +1 -2
index 33364fefa9e2..93bb30568cbc 100644
@@ -17,10 +17,9 @@ CONFIG_CMD_IMLS=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 # CONFIG_ISO_PARTITION is not set
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_SYS_NS16550=y
configs/warp_defconfig +1 -0
index a729c11a869f..bddf4bcf1db4 100644
@@ -25,6 +25,7 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_ENV_IS_IN_MMC=y
+# CONFIG_NET is not set
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
configs/xilinx_zynqmp_mini_emmc_defconfig +1 -2
index 0e4bd2d3bfb7..b15120e0fae4 100644
@@ -35,11 +35,10 @@ CONFIG_CMD_MMC=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_EMBED=y
+# CONFIG_NET is not set
 # CONFIG_DM_WARN is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_DM_MMC=y
configs/xilinx_zynqmp_mini_nand_defconfig +1 -2
index 6474167d3737..55200bcb058d 100644
@@ -35,10 +35,9 @@ CONFIG_SYS_PROMPT="ZynqMP> "
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_PARTITIONS is not set
 CONFIG_OF_EMBED=y
+# CONFIG_NET is not set
 # CONFIG_DM_WARN is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 # CONFIG_MMC is not set
configs/zipitz2_defconfig +1 -2
index 548327f3494c..9f78de3d729b 100644
@@ -13,12 +13,11 @@ CONFIG_CMD_MMC=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
 CONFIG_CMD_FAT=y
 CONFIG_ENV_IS_IN_FLASH=y
+# CONFIG_NET is not set
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_PXA_SERIAL=y
 CONFIG_USB=y
configs/zynq_cse_qspi_defconfig +1 -2
index 1d08dd2ba29b..80bb26c69f3a 100644
@@ -40,11 +40,10 @@ CONFIG_CMD_SF=y
 # CONFIG_CMD_ITEST is not set
 # CONFIG_CMD_SOURCE is not set
 # CONFIG_CMD_SETEXPR is not set
-# CONFIG_CMD_NET is not set
-# CONFIG_CMD_NFS is not set
 # CONFIG_CMD_MISC is not set
 # CONFIG_PARTITIONS is not set
 CONFIG_OF_EMBED=y
+# CONFIG_NET is not set
 # CONFIG_DM_WARN is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_SPL_DM_SEQ_ALIAS=y
configs/zynq_zc770_xm011_defconfig +1 -0
index b9fd74b5d941..59db4c5f6280 100644
@@ -24,6 +24,7 @@ CONFIG_CMD_FPGA_LOADP=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 # CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_NET is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_ISO_PARTITION is not set
configs/zynq_zc770_xm011_x16_defconfig +1 -0
index ef6f46e73c73..d67f78163e3a 100644
@@ -24,6 +24,7 @@ CONFIG_CMD_FPGA_LOADP=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_NAND_LOCK_UNLOCK=y
 # CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_NET is not set
 CONFIG_CMD_CACHE=y
 # CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_ISO_PARTITION is not set
include/configs/topic_miami.h +0 -3
index 400a7fc4a4d8..e32fab25137e 100644
@@ -133,7 +133,4 @@
 	"fi; fi; run $modeboot"
 #undef CONFIG_DISPLAY_BOARDINFO
 
-/* Further tweaks to reduce image size */
-#undef CONFIG_CMD_NET
-
 #endif /* __CONFIG_TOPIC_MIAMI_H */
include/env_callback.h +1 -1
index 5c4a30c2deee..48da32a67b6e 100644
@@ -45,7 +45,7 @@
 #define DNS_CALLBACK
 #endif
 
-#ifdef CONFIG_NET
+#ifdef CONFIG_CMD_NET
 #define NET_CALLBACKS \
 	"bootfile:bootfile," \
 	"ipaddr:ipaddr," \
lib/efi_loader/Makefile +1 -1
index 2722265ee3d1..2a87d9ed7760 100644
@@ -21,5 +21,5 @@ obj-y += efi_file.o efi_variable.o efi_bootmgr.o efi_watchdog.o
 obj-$(CONFIG_LCD) += efi_gop.o
 obj-$(CONFIG_DM_VIDEO) += efi_gop.o
 obj-$(CONFIG_PARTITIONS) += efi_disk.o
-obj-$(CONFIG_NET) += efi_net.o
+obj-$(CONFIG_CMD_NET) += efi_net.o
 obj-$(CONFIG_GENERATE_SMBIOS_TABLE) += efi_smbios.o
lib/efi_loader/efi_device_path.c +1 -1
index ecc4eda3f85e..3c735e60d3bc 100644
@@ -746,7 +746,7 @@ struct efi_device_path *efi_dp_from_file(struct blk_desc *desc, int part,
 	return start;
 }
 
-#ifdef CONFIG_NET
+#ifdef CONFIG_CMD_NET
 struct efi_device_path *efi_dp_from_eth(void)
 {
 	struct efi_device_path_mac_addr *ndp;
net/Kconfig +11 -0
index 184b7c15d460..143c4416cddd 100644
@@ -4,6 +4,7 @@
 
 menuconfig NET
 	bool "Networking support"
+	default y
 
 if NET
 
@@ -23,6 +24,7 @@ config NETCONSOLE
 
 config NET_TFTP_VARS
 	bool "Control TFTP timeout and count through environment"
+	depends on CMD_NET
 	default y
 	help
 	  If set, allows controlling the TFTP timeout through the
@@ -33,30 +35,39 @@ config NET_TFTP_VARS
 
 config BOOTP_BOOTPATH
 	bool "Enable BOOTP BOOTPATH"
+	depends on CMD_NET
 
 config BOOTP_DNS
 	bool "Enable bootp DNS"
+	depends on CMD_NET
 
 config BOOTP_GATEWAY
 	bool "Enable BOOTP gateway"
+	depends on CMD_NET
 
 config BOOTP_HOSTNAME
 	bool "Enable BOOTP hostname"
+	depends on CMD_NET
 
 config BOOTP_PXE
 	bool "Enable BOOTP PXE"
+	depends on CMD_NET
 
 config BOOTP_SUBNETMASK
 	bool "Enable BOOTP subnetmask"
+	depends on CMD_NET
+	depends on CMD_NET
 
 config BOOTP_PXE_CLIENTARCH
 	hex
+	depends on CMD_NET
         default 0x16 if ARM64
         default 0x15 if ARM
         default 0 if X86
 
 config BOOTP_VCI_STRING
 	string
+	depends on CMD_NET
 	default "U-Boot.armv7" if CPU_V7 || CPU_V7M
 	default "U-Boot.armv8" if ARM64
 	default "U-Boot.arm" if ARM
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180227/23740448/attachment.sig>
#2 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Quoted 15 lines · Tom Rini
Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

Quoted 15 lines

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Hello Tom,

in spite of you comments above I do not understand why you changed cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

This was not part of Michal's patch.

I would prefer if changes would be sent to the list for review *before* being applied.

As the patch that you applied is not Michal's patch your authorship should be documented in the git log.

I cannot see any reason why network support should be disabled in bootefi if there are no network commands available.

Please, undo this change.

Best regards

Heinrich

#3 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Quoted 32 lines · Heinrich Schuchardt
Quoted 15 lines · Tom Rini
Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

Quoted 15 lines

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Quoted 4 lines

Hello Tom,

in spite of you comments above I do not understand why you changed cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

Because the underlying generic network functionality that efi_loader uses is actually gated under CONFIG_CMD_NET and not CONFIG_NET. This should be corrected, in the long term.

Quoted 7 lines

This was not part of Michal's patch.

I would prefer if changes would be sent to the list for review *before* being applied.

As the patch that you applied is not Michal's patch your authorship should be documented in the git log.

Ah, I forgot to add my S-o-B? Oops, that was unintentional.

Quoted 2 lines

I cannot see any reason why network support should be disabled in bootefi if there are no network commands available.

In theory and concept, I agree. In current implementation, that is not the case and I would welcome further changes that make the code reflect the general intention.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180228/2dc49d1b/attachment.sig>
#4 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Quoted 44 lines · Tom Rini
Quoted 32 lines · Heinrich Schuchardt
Quoted 15 lines · Tom Rini
Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

Quoted 15 lines

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Quoted 4 lines

Hello Tom,

in spite of you comments above I do not understand why you changed cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

Because the underlying generic network functionality that efi_loader uses is actually gated under CONFIG_CMD_NET and not CONFIG_NET. This should be corrected, in the long term.

Quoted 2 lines

This was not part of Michal's patch.

Quoted 7 lines
Quoted 5 lines

I would prefer if changes would be sent to the list for review *before* being applied.

As the patch that you applied is not Michal's patch your authorship should be documented in the git log.

Ah, I forgot to add my S-o-B? Oops, that was unintentional.

It is not that your Signed-of-by is missing. But your signature follows directly Michal's. So it looks as if you applied the patch signed by Michal unchanged.

Best regards

Heinrich

Quoted 8 lines
Quoted 3 lines

I cannot see any reason why network support should be disabled in bootefi if there are no network commands available.

In theory and concept, I agree. In current implementation, that is not the case and I would welcome further changes that make the code reflect the general intention.

#5 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

In reply to Heinrich Schuchardt

Hi Heinrich,

Quoted 41 lines · Heinrich Schuchardt
Quoted 17 lines · Tom Rini
Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

Quoted 15 lines

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Hello Tom,

in spite of you comments above I do not understand why you changed cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

This was not part of Michal's patch.

Quoted 8 lines

I would prefer if changes would be sent to the list for review *before* being applied.

As the patch that you applied is not Michal's patch your authorship should be documented in the git log.

I cannot see any reason why network support should be disabled in bootefi if there are no network commands available.

I think there is a fair amount of conflation since some of the basic functions like bootp and dhcp are only accessible through the commands, but you're right that it should be possible to use networking with a static IP and no network commands.

Quoted 11 lines

Please, undo this change.

Best regards

Heinrich

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#6 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Quoted 51 lines · Joe Hershberger

Hi Heinrich,

Quoted 47 lines · Heinrich Schuchardt
Quoted 17 lines · Tom Rini
Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

Quoted 15 lines

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Hello Tom,

in spite of you comments above I do not understand why you changed cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

This was not part of Michal's patch.

I would prefer if changes would be sent to the list for review *before* being applied.

As the patch that you applied is not Michal's patch your authorship should be documented in the git log.

Quoted 7 lines
Quoted 2 lines

I cannot see any reason why network support should be disabled in bootefi if there are no network commands available.

I think there is a fair amount of conflation since some of the basic functions like bootp and dhcp are only accessible through the commands, but you're right that it should be possible to use networking with a static IP and no network commands.

Can you please be more specific how you can use network without network commands?

Thanks,
Michal

#7 lore raw

PATCH v2 1/1 Kconfig: cmd: Make networking command dependent on NET

Quoted 55 lines · Michal Simek
Quoted 54 lines · Joe Hershberger

Hi Heinrich,

Quoted 49 lines · Heinrich Schuchardt
Quoted 17 lines · Tom Rini
Quoted 4 lines · Michal Simek

Enable networking command only when NET is enabled. And remove selecting NET for CMD_NET

Quoted 8 lines

---

Changes in v2:
- Check several boards by hand.

There is a huge impact on defconfigs because of select NET. But this change makes sense to do but it just needs to be syncup properly. Do we have a tool for this kind of change?

Quoted 15 lines

So, I've applied this patch, with a good bit of modification. What I wasn't clear about before, sorry, was that we need to make NET default y in here too. However, we also have some decent areas of the code that use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least conceptually. But in order to make everything work as-is today, and leave these fixes to a later point in time (as they are fixes and should happen) we change some areas today that reference CONFIG_NET to reference CONFIG_CMD_NET. Once net/ gets cleaned up, we can use CONFIG_NET without CONFIG_CMD_NET in more area. It's also not quite 100% size-neutral as the topic_miami* boards were playing some games that can't quite be done as they were before, but I believe the end result is they can now more easily and thoroughly disable the networking stuff that intended to be removed.

Hello Tom,

in spite of you comments above I do not understand why you changed cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.

This was not part of Michal's patch.

I would prefer if changes would be sent to the list for review *before* being applied.

As the patch that you applied is not Michal's patch your authorship should be documented in the git log.

I cannot see any reason why network support should be disabled in bootefi if there are no network commands available.

Quoted 7 lines
Quoted 4 lines

I think there is a fair amount of conflation since some of the basic functions like bootp and dhcp are only accessible through the commands, but you're right that it should be possible to use networking with a static IP and no network commands.

Can you please be more specific how you can use network without network commands?

In this case, if EFI is using the network, then U-Boot need not have any commands that use it. NetConsole is probably another example.

-Joe