Skip to contentSkip to conversation

crypto: ensure we use a predictable TLS priority setting

PATCH In review Daniel P. Berrangé 2 participants 2 messages Feb 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 crypto: ensure we use a predictable TLS priority setting

The TLS test cert generation relies on a fixed set of algorithms that are only usable under GNUTLS' default priority setting. When building QEMU with a custom distro specific priority setting, this can cause the TLS tests to fail. By forcing the tests to always use "NORMAL" priority we can make them more robust.

---

Changed in v2:

- Fix both test cases which use TLS creds !

 tests/test-crypto-tlssession.c | 1 +
 tests/test-io-channel-tls.c    | 1 +
 2 files changed, 2 insertions(+)
tests/test-crypto-tlssession.c +1 -0
index 1a4a066d76..82f21c27f2 100644
@@ -75,6 +75,7 @@ static QCryptoTLSCreds *test_tls_creds_create(QCryptoTLSCredsEndpoint endpoint,
                      "server" : "client"),
         "dir", certdir,
         "verify-peer", "yes",
+        "priority", "NORMAL",
         /* We skip initial sanity checks here because we
          * want to make sure that problems are being
          * detected at the TLS session validation stage,
tests/test-io-channel-tls.c +1 -0
index a210d01ba5..47ba603e8d 100644
@@ -78,6 +78,7 @@ static QCryptoTLSCreds *test_tls_creds_create(QCryptoTLSCredsEndpoint endpoint,
                      "server" : "client"),
         "dir", certdir,
         "verify-peer", "yes",
+        "priority", "NORMAL",
         /* We skip initial sanity checks here because we
          * want to make sure that problems are being
          * detected at the TLS session validation stage,
Signature · 1 line
2.14.3
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Daniel P. Berrangé

The TLS test cert generation relies on a fixed set of algorithms that are only usable under GNUTLS' default priority setting. When building QEMU with a custom distro specific priority setting, this can cause the TLS tests to fail. By forcing the tests to always use "NORMAL" priority we can make them more robust.

Quoted 6 lines

---

Changed in v2:

- Fix both test cases which use TLS creds !

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org