crypto: ensure we use a predictable TLS priority setting
PATCH v2 1/1 crypto: ensure we use a predictable TLS priority setting
The TLS test cert generation relies on a fixed set of algorithms that are only usable under GNUTLS' default priority setting. When building QEMU with a custom distro specific priority setting, this can cause the TLS tests to fail. By forcing the tests to always use "NORMAL" priority we can make them more robust.
---
Changed in v2:
- Fix both test cases which use TLS creds !
tests/test-crypto-tlssession.c | 1 + tests/test-io-channel-tls.c | 1 + 2 files changed, 2 insertions(+)
tests/test-crypto-tlssession.c +1 -0
@@ -75,6 +75,7 @@ static QCryptoTLSCreds *test_tls_creds_create(QCryptoTLSCredsEndpoint endpoint, "server" : "client")," dir", certdir, " verify-peer", " yes", +" priority", " NORMAL ", /* We skip initial sanity checks here because we * want to make sure that problems are being * detected at the TLS session validation stage,
tests/test-io-channel-tls.c +1 -0
@@ -78,6 +78,7 @@ static QCryptoTLSCreds *test_tls_creds_create(QCryptoTLSCredsEndpoint endpoint, "server" : "client")," dir", certdir, " verify-peer", " yes", +" priority", " NORMAL ", /* We skip initial sanity checks here because we * want to make sure that problems are being * detected at the TLS session validation stage,
Signature · 1 line
2.14.3
Quoted 6 lines · Daniel P. Berrangé
The TLS test cert generation relies on a fixed set of algorithms that are only usable under GNUTLS' default priority setting. When building QEMU with a custom distro specific priority setting, this can cause the TLS tests to fail. By forcing the tests to always use "NORMAL" priority we can make them more robust.
Quoted 6 lines
Signed-off-by Daniel P. Berrangé <[email protected]>---
Changed in v2:
- Fix both test cases which use TLS creds !
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org