Skip to contentSkip to conversation

Set name of regmap_config

PATCH Superseded Jeffy Chen 2 participants 7 messages Mar 8, 2018 – Mar 9, 2018

Subsystems (9)

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Jeffy Chen

author
#0 lore raw

v3 cover Set name of regmap_config

After 9b947a13e7f6 ("regmap: use debugfs even when no device"), we are allowing regmap to create debugfs without a valid device. Some of them would end up using "dummy*" as debugfs name.

This series try to set names in some regmap_config to avoid that.

Changes in v3:
Modify commit message.

Jeffy Chen (4):
mfd: syscon: Set name of regmap_config
rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()
clk: lpc32xx: Set name of regmap_config
ARM: rockchip: Set name of regmap_config

 arch/arm/mach-rockchip/platsmp.c | 1 +
 drivers/clk/nxp/clk-lpc32xx.c    | 1 +
 drivers/mfd/syscon.c             | 1 +
 drivers/rtc/rtc-at91sam9.c       | 2 +-
 4 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH v3 1/4 mfd: syscon: Set name of regmap_config

We are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.

---

Changes in v3:
Modify commit message.

 drivers/mfd/syscon.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mfd/syscon.c +1 -0
index fc9ba0ea4e44..b6d05cd934e6 100644
@@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
 	syscon_config.reg_stride = reg_io_width;
 	syscon_config.val_bits = reg_io_width * 8;
 	syscon_config.max_register = resource_size(&res) - reg_io_width;
+	syscon_config.name = of_node_full_name(np);
 
 	regmap = regmap_init_mmio(NULL, base, &syscon_config);
 	if (IS_ERR(regmap)) {
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH v3 2/4 rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()

In reply to Jeffy Chen

Otherwise it would use "dummy*" to create regmap debugfs dir.

---

Changes in v3: None

 drivers/rtc/rtc-at91sam9.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-at91sam9.c +1 -1
index 7418a763ce52..0d6a17a77841 100644
@@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
 		if (IS_ERR(gpbr))
 			return PTR_ERR(gpbr);
 
-		rtc->gpbr = regmap_init_mmio(NULL, gpbr,
+		rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr,
 					     &gpbr_regmap_config);
 	} else {
 		struct of_phandle_args args;
Signature · 1 line
2.11.0
#3 lore raw

Re: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()

Quoted 15 lines · Jeffy Chen

Otherwise it would use "dummy*" to create regmap debugfs dir.

---

Changes in v3: None

 drivers/rtc/rtc-at91sam9.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-at91sam9.c +0 -0
index 7418a763ce52..0d6a17a77841 100644

drivers/rtc/rtc-at91sam9.c static int at91_rtc_probe(struct platform_device *pdev) · line 406

Quoted 6 lines
drivers/rtc/rtc-at91sam9.c +1 -1
@@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
 		if (IS_ERR(gpbr))
 			return PTR_ERR(gpbr);
 
-		rtc->gpbr = regmap_init_mmio(NULL, gpbr,
+		rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr,
 					     &gpbr_regmap_config);

This would be misleading as the gpbr is not directly related to the rtc.

Signature · 3 lines
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#4 lore raw

Re: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()

Hi Alexandre,

Quoted 19 lines · Alexandre Belloni
Quoted 18 lines · Jeffy Chen

Otherwise it would use "dummy*" to create regmap debugfs dir.

---

Changes in v3: None

  drivers/rtc/rtc-at91sam9.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-at91sam9.c +0 -0
index 7418a763ce52..0d6a17a77841 100644
@@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
  		if (IS_ERR(gpbr))
  			return PTR_ERR(gpbr);
 
Quoted 5 lines

drivers/rtc/rtc-at91sam9.c static int at91_rtc_probe(struct platform_device *pdev) · line 406

Quoted 3 lines
drivers/rtc/rtc-at91sam9.c +1 -1
-		rtc->gpbr = regmap_init_mmio(NULL, gpbr,
+		rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr,
  					     &gpbr_regmap_config);

This would be misleading as the gpbr is not directly related to the rtc.

ok, will fix that, thanks.

Quoted 1 line
author
#5 lore raw

PATCH v3 3/4 clk: lpc32xx: Set name of regmap_config

In reply to Jeffy Chen

We are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.

---

Changes in v3: None

 drivers/clk/nxp/clk-lpc32xx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/nxp/clk-lpc32xx.c +1 -0
index f5d815f577e0..a2a0a7f3bc57 100644
@@ -67,6 +67,7 @@
 #define LPC32XX_USB_CLK_STS		0xF8
 
 static struct regmap_config lpc32xx_scb_regmap_config = {
+	.name = "lpc32xx-scb",
 	.reg_bits = 32,
 	.val_bits = 32,
 	.reg_stride = 4,
Signature · 1 line
2.11.0
author
#6 lore raw

PATCH v3 4/4 ARM: rockchip: Set name of regmap_config

In reply to Jeffy Chen

We are now allowing to register debugfs without a valid device, and not having a valid name will end up using "dummy*" to create debugfs dir.

---

Changes in v3: None

 arch/arm/mach-rockchip/platsmp.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-rockchip/platsmp.c +1 -0
index ecec340ca345..51984a40b097 100644
@@ -208,6 +208,7 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node)
 }
 
 static const struct regmap_config rockchip_pmu_regmap_config = {
+	.name = "rockchip-pmu",
 	.reg_bits = 32,
 	.val_bits = 32,
 	.reg_stride = 4,
Signature · 1 line
2.11.0