amdkfd: always select MMU_NOTIFIER
Subsystems (3)
PATCH 1/1 amdkfd: always select MMU_NOTIFIER
Building amdkfd without MMU notifiers is broken:
In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time.
--- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/Kconfig +1 -0
@@ -4,6 +4,7 @@ config HSA_AMD tristate "HSA kernel driver for AMD GPU devices" + select MMU_NOTIFIER depends on DRM_AMDGPU && X86_64 imply AMD_IOMMU_V2 help
Signature · 6 lines
2.9.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
Quoted 9 lines
Building amdkfd without MMU notifiers is broken:
In file included from
drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete typeThis adds the missing 'select
MMU_NOTIFIER' line to make it build cleanly all the time.Signed-off-by Arnd Bergmann <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdkfd/Kconfig +0
-0
drivers/gpu/drm/amd/amdkfd/Kconfig line 10
Quoted 7 lines
drivers/gpu/drm/amd/amdkfd/Kconfig +1
-0@@ -4,6 +4,7 @@ config HSA_AMD tristate "HSA kernel driver for AMD GPU devices" + select MMU_NOTIFIER depends on DRM_AMDGPU && X86_64 imply AMD_IOMMU_V2 help
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Anders Roxell
Tested-byQuoted 8 lines · Christian König
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
Quoted 7 lines
Building amdkfd without MMU notifiers is broken:
In file included from
drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
Quoted 8 lines
Quoted 4 lines
This adds the missing 'select
MMU_NOTIFIER' line to make it build cleanly all the time.Signed-off-by Arnd Bergmann <[email protected]>what Felix says to that.
Randy sent the same patch [1] and its still required.
Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/
Quoted 20 lines
Quoted 18 lines
--- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdkfd/Kconfig +1
-0@@ -4,6 +4,7 @@ config HSA_AMD tristate "HSA kernel driver for AMD GPU devices" + select MMU_NOTIFIER depends on DRM_AMDGPU && X86_64 imply AMD_IOMMU_V2 help
Quoted 15 lines · Anders Roxell
Quoted 7 lines · Christian König
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
Quoted 6 lines
Building amdkfd without MMU notifiers is broken:
In file included from
drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete typeQuoted 7 lines
Quoted 4 lines
This adds the missing 'select
MMU_NOTIFIER' line to make it build cleanly all the time.Signed-off-by Arnd Bergmann <[email protected]>what Felix says to that.
Quoted 7 lines
Tested-by Anders Roxell <[email protected]>Randy sent the same patch [1] and its still required.
Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/
Yes, looks good. I think this probably broke when we relaxed the dependency on iommuv2.
Regards,
Felix
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
--- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/amd/amdkfd/Kconfig +0
-1--- a/drivers/gpu/drm/amd/amdkfd/KconfigQuoted 9 lines
drivers/gpu/drm/amd/amdkfd/Kconfig line 9
Quoted 8 lines
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
drivers/gpu/drm/amd/amdkfd/Kconfig +1
-0@@ -4,6 +4,7 @@ config HSA_AMD tristate "HSA kernel driver for AMD GPU devices" + select MMU_NOTIFIER depends on DRM_AMDGPU && X86_64 imply AMD_IOMMU_V2 help
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks, but I took Randy's patch as it was earlier in my email queue.
Oded
Quoted 23 lines · Felix Kuehling
Quoted 15 lines · Anders Roxell
Quoted 7 lines · Christian König
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
Quoted 6 lines
Building amdkfd without MMU notifiers is broken:
In file included from
drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete typeQuoted 7 lines
Quoted 4 lines
This adds the missing 'select
MMU_NOTIFIER' line to make it build cleanly all the time.Signed-off-by Arnd Bergmann <[email protected]>what Felix says to that.
Quoted 7 lines
Tested-by Anders Roxell <[email protected]>Randy sent the same patch [1] and its still required.
Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/
Quoted 29 lines
Yes, looks good. I think this probably broke when we relaxed the dependency on iommuv2.
Reviewed-by Felix Kuehling <[email protected]>Regards,
FelixQuoted 19 lines
Quoted 19 lines
Quoted 18 lines
--- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdkfd/Kconfig +1
-0@@ -4,6 +4,7 @@ config HSA_AMD tristate "HSA kernel driver for AMD GPU devices" + select MMU_NOTIFIER depends on DRM_AMDGPU && X86_64 imply AMD_IOMMU_V2 help
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx