Skip to contentSkip to conversation

amdkfd: always select MMU_NOTIFIER

PATCH In review Arnd Bergmann 5 participants 5 messages Mar 28, 2018 – Apr 24, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amdkfd: always select MMU_NOTIFIER

Building amdkfd without MMU notifiers is broken:

In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type

This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time.

---
 drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/Kconfig +1 -0
index ed2f06c9f346..5a26acb90e19 100644
@@ -4,6 +4,7 @@
 
 config HSA_AMD
 	tristate "HSA kernel driver for AMD GPU devices"
+	select MMU_NOTIFIER
 	depends on DRM_AMDGPU && X86_64
 	imply AMD_IOMMU_V2
 	help
Signature · 6 lines
2.9.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Acked-by on v1 1/1
#1 lore raw

Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:

Quoted 9 lines

Building amdkfd without MMU notifiers is broken:

In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type

This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/Kconfig +0 -0
index ed2f06c9f346..5a26acb90e19 100644

drivers/gpu/drm/amd/amdkfd/Kconfig line 10

Quoted 7 lines
drivers/gpu/drm/amd/amdkfd/Kconfig +1 -0
@@ -4,6 +4,7 @@
 
  config HSA_AMD
  	tristate "HSA kernel driver for AMD GPU devices"
+	select MMU_NOTIFIER
  	depends on DRM_AMDGPU && X86_64
  	imply AMD_IOMMU_V2
  	help

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Tested-by
#2 lore raw
Quoted 8 lines · Christian König

Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:

Quoted 7 lines

Building amdkfd without MMU notifiers is broken:

In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type

Quoted 8 lines
Quoted 4 lines

This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time.

what Felix says to that.

Randy sent the same patch [1] and its still required.

Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/

Quoted 20 lines
Quoted 18 lines

---
  drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/Kconfig +1 -0
index ed2f06c9f346..5a26acb90e19 100644
@@ -4,6 +4,7 @@
    config HSA_AMD
        tristate "HSA kernel driver for AMD GPU devices"
+       select MMU_NOTIFIER
        depends on DRM_AMDGPU && X86_64
        imply AMD_IOMMU_V2
        help
maintainer Reviewed-by
#3 lore raw
Quoted 15 lines · Anders Roxell
Quoted 7 lines · Christian König

Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:

Quoted 6 lines

Building amdkfd without MMU notifiers is broken:

In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type

Quoted 7 lines
Quoted 4 lines

This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time.

what Felix says to that.

Quoted 7 lines

Randy sent the same patch [1] and its still required.

Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/

Yes, looks good. I think this probably broke when we relaxed the dependency on iommuv2.

Regards,
  Felix

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

---
  drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
  1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/amd/amdkfd/Kconfig +0 -1
index ed2f06c9f346..5a26acb90e19 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
Quoted 9 lines

drivers/gpu/drm/amd/amdkfd/Kconfig line 9

Quoted 8 lines

+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig

drivers/gpu/drm/amd/amdkfd/Kconfig +1 -0
@@ -4,6 +4,7 @@
    config HSA_AMD
        tristate "HSA kernel driver for AMD GPU devices"
+       select MMU_NOTIFIER
        depends on DRM_AMDGPU && X86_64
        imply AMD_IOMMU_V2
        help

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Thanks, but I took Randy's patch as it was earlier in my email queue.

Oded

Quoted 23 lines · Felix Kuehling
Quoted 15 lines · Anders Roxell
Quoted 7 lines · Christian König

Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:

Quoted 6 lines

Building amdkfd without MMU notifiers is broken:

In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type

Quoted 7 lines
Quoted 4 lines

This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all the time.

what Felix says to that.

Quoted 7 lines

Randy sent the same patch [1] and its still required.

Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/

Quoted 29 lines

Yes, looks good. I think this probably broke when we relaxed the dependency on iommuv2.

Regards,
Felix

Quoted 19 lines
Quoted 19 lines
Quoted 18 lines

---
  drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/Kconfig +1 -0
index ed2f06c9f346..5a26acb90e19 100644
@@ -4,6 +4,7 @@
    config HSA_AMD
        tristate "HSA kernel driver for AMD GPU devices"
+       select MMU_NOTIFIER
        depends on DRM_AMDGPU && X86_64
        imply AMD_IOMMU_V2
        help

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx