iommu: amd: hide unused iommu_table_lock
PATCH 1/1 iommu: amd: hide unused iommu_table_lock
The newly introduced lock is only used when CONFIG_IRQ_REMAP is enabled:
drivers/iommu/amd_iommu.c:86:24: error: 'iommu_table_lock' defined but not used [-Werror=unused-variable]
static DEFINE_SPINLOCK(iommu_table_lock);
This moves the definition next to the user, within the #ifdef protected section of the file.
--- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu.c +1 -1
@@ -83,7 +83,6 @@static DEFINE_SPINLOCK (amd_iommu_devtable_lock);static DEFINE_SPINLOCK (pd_bitmap_lock); -static DEFINE_SPINLOCK (iommu_table_lock);/* List of all available dev_data structures */ static LLIST_HEAD (dev_data_list);
@@ -3562,6 +3561,7 @@ EXPORT_SYMBOL(amd_iommu_device_info);*****************************************************************************/ static struct irq_chip amd_ir_chip; +static DEFINE_SPINLOCK (iommu_table_lock);static void set_dte_irq_entry (u16 devid,struct irq_remap_table *table) {
Signature · 1 line
2.9.0
Quoted 10 lines · Arnd Bergmann
The newly introduced lock is only used when
CONFIG_IRQ_REMAPis enabled:
drivers/iommu/amd_iommu.c:86:24: error: 'iommu_table_lock' defined but not used [-Werror=unused-variable]
staticDEFINE_SPINLOCK(iommu_table_lock);This moves the definition next to the user, within the #ifdef protected section of the file.
Fixes ea6166f4b83e ("iommu/amd: Split irq_lookup_table out of the amd_iommu_devtable_lock")Signed-off-by Arnd Bergmann <[email protected]>
Thank you Arnd.
Sebastian
Quoted 5 lines · Arnd Bergmann
The newly introduced lock is only used when
CONFIG_IRQ_REMAPis enabled:
drivers/iommu/amd_iommu.c:86:24: error: 'iommu_table_lock' defined but not used [-Werror=unused-variable]
staticDEFINE_SPINLOCK(iommu_table_lock);
Quoted 8 lines
This moves the definition next to the user, within the #ifdef protected section of the file.
Fixes ea6166f4b83e ("iommu/amd: Split irq_lookup_table out of the amd_iommu_devtable_lock")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.