Skip to contentSkip to conversation

ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

PATCH Superseded Marek Vasut 3 participants 8 messages Mar 18, 2018 – Apr 16, 2018

Subsystems (4)
Device tree bindings Arm i.MX and Layerscape Arm and arm64 SoC sub-architectures (common parts) Dh electronics dhsom som and board support
lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Add support for the DH i.MX6 Quad based SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, mSATA, analog audio, PCIe and HDMI video output.

All of the aforementioned features are supported by this patch.

Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>

---
V2: - Rename the DT nodes to match upstream expectations
- Connect reg_arm and reg_soc regulators
V3: - Drop fsl,spi-num-chipselects
- Use macros for interrupt and GPIO types
- Drop power-gpios

---
 arch/arm/boot/dts/Makefile             |   1 +
 arch/arm/boot/dts/imx6q-dhcom-pdk2.dts | 150 +++++++++++
 arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 476 +++++++++++++++++++++++++++++++++
 3 files changed, 627 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-dhcom-pdk2.dts
 create mode 100644 arch/arm/boot/dts/imx6q-dhcom-som.dtsi
arch/arm/boot/dts/Makefile +1 -0
index 3b4cc1b64a1e..b53aaa60e7a3 100644
@@ -439,6 +439,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-cubox-i-emmc-som-v15.dtb \
 	imx6q-cubox-i-som-v15.dtb \
 	imx6q-dfi-fs700-m60.dtb \
+	imx6q-dhcom-pdk2.dtb \
 	imx6q-display5-tianma-tm070-1280x768.dtb \
 	imx6q-dmo-edmqmx6.dtb \
 	imx6q-dms-ba16.dtb \
arch/arm/boot/dts/imx6q-dhcom-pdk2.dts new file +150 -0

150 lines not on this page · raw message

arch/arm/boot/dts/imx6q-dhcom-som.dtsi new file +476 -0

476 lines not on this page · raw message

Signature · 1 line
2.16.2
reviewer
#1 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Quoted 10 lines · Marek Vasut

Add support for the DH i.MX6 Quad based SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, mSATA, analog audio, PCIe and HDMI video output.

All of the aforementioned features are supported by this patch.

Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
author
#2 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Quoted 6 lines · Fabio Estevam
Quoted 5 lines · Marek Vasut

Add support for the DH i.MX6 Quad based SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, mSATA, analog audio, PCIe and HDMI video output.

Quoted 7 lines
Quoted 5 lines

All of the aforementioned features are supported by this patch.

Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

Shawn, any response to this ?

Signature · 2 lines
Best regards,
Marek Vasut
author
#3 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Quoted 9 lines · Marek Vasut
Quoted 8 lines · Fabio Estevam
Quoted 7 lines · Marek Vasut

Add support for the DH i.MX6 Quad based SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, mSATA, analog audio, PCIe and HDMI video output.

All of the aforementioned features are supported by this patch.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

Shawn, any response to this ?

Another two weeks have passed and still zero feedback.

I was complaining about getting no feedback on patches from you for long periods of time before, and that it is extremely demotivating for a contributor. It seems the situation has not improved at all.

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Quoted 16 lines · Marek Vasut
Quoted 15 lines · Marek Vasut
Quoted 13 lines · Fabio Estevam
Quoted 10 lines · Marek Vasut

Add support for the DH i.MX6 Quad based SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, mSATA, analog audio, PCIe and HDMI video output.

All of the aforementioned features are supported by this patch.

Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
Quoted 7 lines
Quoted 1 line

Shawn, any response to this ?

Another two weeks have passed and still zero feedback.

I was complaining about getting no feedback on patches from you for long periods of time before, and that it is extremely demotivating for a contributor. It seems the situation has not improved at all.

This version looks good to me. But please be aware of that we are in the middle of 4.17 merge window, and my tree is kinda frozen until 4.17-rc1 is available.

Shawn

author
#5 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Quoted 21 lines · Shawn Guo
Quoted 20 lines · Marek Vasut
Quoted 9 lines · Marek Vasut
Quoted 8 lines · Fabio Estevam
Quoted 7 lines · Marek Vasut

Add support for the DH i.MX6 Quad based SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, mSATA, analog audio, PCIe and HDMI video output.

All of the aforementioned features are supported by this patch.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Marek Vasut <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

Shawn, any response to this ?

Another two weeks have passed and still zero feedback.

Quoted 7 lines
Quoted 3 lines

I was complaining about getting no feedback on patches from you for long periods of time before, and that it is extremely demotivating for a contributor. It seems the situation has not improved at all.

This version looks good to me. But please be aware of that we are in the middle of 4.17 merge window, and my tree is kinda frozen until 4.17-rc1 is available.

I see, so another release missed ?

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

In reply to Marek Vasut

arch/arm/boot/dts/imx6q-dhcom-pdk2.dts line 54

Quoted 4 lines · Marek Vasut

+&i2c2 {

arch/arm/boot/dts/imx6q-dhcom-pdk2.dts new file +3 -0
+	sgtl5000: codec at a {
+		compatible = "fsl,sgtl5000";
+		reg = <0x0a>;

Since commit c4e50b1d87fb ("ASoC: sgtl5000: Pass the required '#sound-dai-cells'"), #sound-dai-cells is required for sgtl5000 device. I added the following line here, and applied the patch.

	#sound-dai-cells = <0>;

Shawn

Quoted 5 lines
arch/arm/boot/dts/imx6q-dhcom-pdk2.dts new file +5 -0
+		clocks = <&clk_ext_audio_codec>;
+		VDDA-supply = <&reg_3p3v>;
+		VDDIO-supply = <&reg_3p3v>;
+	};
+};
author
#7 lore raw

PATCH v3 1/1 ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2

Quoted 11 lines · Shawn Guo

arch/arm/boot/dts/imx6q-dhcom-pdk2.dts line 54

Quoted 4 lines · Marek Vasut

+&i2c2 {

arch/arm/boot/dts/imx6q-dhcom-pdk2.dts new file +3 -0
+	sgtl5000: codec at a {
+		compatible = "fsl,sgtl5000";
+		reg = <0x0a>;

Since commit c4e50b1d87fb ("ASoC: sgtl5000: Pass the required '#sound-dai-cells'"), #sound-dai-cells is required for sgtl5000 device. I added the following line here, and applied the patch.

	#sound-dai-cells = <0>;

Thanks

Signature · 2 lines
Best regards,
Marek Vasut