Skip to contentSkip to conversation

net/i40e:fix checking offloading fail for Tx

PATCH Superseded Yanglong Wu 2 participants 4 messages Apr 19, 2018 – Apr 27, 2018 Network drivers

lore
Share & tools
lore

Yanglong Wu

author
#0 lore raw

PATCH 1/1 net/i40e:fix checking offloading fail for Tx

Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.

Fixes b43290f1ade2 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
---
 drivers/net/i40e/i40e_rxtx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_rxtx.c +3 -1
index bc660596b..2ce930827 100644
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 			" or supported offloads 0x%" PRIx64,
 			(void *)dev, tx_conf->offloads,
 			dev->data->dev_conf.txmode.offloads,
-			dev_info.tx_offload_capa); }
+			dev_info.tx_offload_capa);
+			return -ENOTSUP;
+	}
 
 	if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
 		vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH v2 1/1 net/i40e: fix checking offloading fail for Tx

Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.

Fixes b43290f1ade2 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework fix line

---
 drivers/net/i40e/i40e_rxtx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_rxtx.c +3 -1
index bc660596b..2ce930827 100644
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 			" or supported offloads 0x%" PRIx64,
 			(void *)dev, tx_conf->offloads,
 			dev->data->dev_conf.txmode.offloads,
-			dev_info.tx_offload_capa); }
+			dev_info.tx_offload_capa);
+			return -ENOTSUP;
+	}
 
 	if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
 		vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH v2 1/1 net/i40e: fix checking offloading fail for Tx

In reply to Yanglong Wu

Missing "return -ENOTSUP" will alays leads to
illegal offload passing through offload checking.

Fixes 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework fix line

---
 drivers/net/i40e/i40e_rxtx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_rxtx.c +3 -1
index bc660596b..2ce930827 100644
@@ -2038,7 +2038,9 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 			" or supported offloads 0x%" PRIx64,
 			(void *)dev, tx_conf->offloads,
 			dev->data->dev_conf.txmode.offloads,
-			dev_info.tx_offload_capa); }
+			dev_info.tx_offload_capa);
+			return -ENOTSUP;
+	}
 
 	if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
 		vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
Signature · 1 line
2.11.0
Acked-by on v2 1/1
#3 lore raw

Re: [PATCH v2] net/i40e: fix checking offloading fail for Tx

Quoted 9 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Friday, April 27, 2018 4:14 PM
To: [email protected]
Cc: Zhang, Helin; Zhang, Qi Z; Dai, Wei; Wu, Yanglong
Subject: [PATCH v2] net/i40e: fix checking offloading fail for Tx

Quoted 5 lines

Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking.

Fixes 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Helin Zhang <[email protected]>