Skip to contentSkip to conversation

net: MVGBE don't automatically select PHYLIB

PATCH New Chris Packham 3 participants 8 messages May 17, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

Not all users of MVGBE need PHYLIB and it increases the size of the openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Cc Tom Rini <[email protected]>
Cc Stefan Roese <[email protected]>

---

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -1
index c962d7a72c0c..f2cc75f494e8 100644
@@ -181,7 +181,6 @@ config FTMAC100
 config MVGBE
 	bool "Marvell Orion5x/Kirkwood network interface support"
 	depends on KIRKWOOD || ORION5X
-	select PHYLIB
 	help
 	  This driver supports the network interface units in the
 	  Marvell Orion5x and Kirkwood SoCs
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 18 lines · Chris Packham

Not all users of MVGBE need PHYLIB and it increases the size of the openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Cc Tom Rini <[email protected]>
Cc Stefan Roese <[email protected]>

---

  drivers/net/Kconfig | 1 -
  1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -0
index c962d7a72c0c..f2cc75f494e8 100644

drivers/net/Kconfig config FTMAC100 · line 186

Quoted 7 lines
drivers/net/Kconfig +0 -1
@@ -181,7 +181,6 @@ config FTMAC100
  config MVGBE
  	bool "Marvell Orion5x/Kirkwood network interface support"
  	depends on KIRKWOOD || ORION5X
-	select PHYLIB
  	help
  	  This driver supports the network interface units in the
  	  Marvell Orion5x and Kirkwood SoCs

Thanks,
Stefan

#2 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

In reply to Chris Packham

Hi Joe,

Quoted 18 lines · Chris Packham

Not all users of MVGBE need PHYLIB and it increases the size of the openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Cc Tom Rini <[email protected]>
Cc Stefan Roese <[email protected]>

---

  drivers/net/Kconfig | 1 -
  1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -0
index c962d7a72c0c..f2cc75f494e8 100644

drivers/net/Kconfig config FTMAC100 · line 186

Quoted 7 lines
drivers/net/Kconfig +0 -1
@@ -181,7 +181,6 @@ config FTMAC100
  config MVGBE
  	bool "Marvell Orion5x/Kirkwood network interface support"
  	depends on KIRKWOOD || ORION5X
-	select PHYLIB
  	help
  	  This driver supports the network interface units in the
  	  Marvell Orion5x and Kirkwood SoCs

Joe, are you okay with me pulling this patch via the Marvell repository? As it fixes a size limitation error on some of the Kirkwood board, where I have some device-tree patches queued.

Thanks,
Stefan

#3 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

In reply to Chris Packham
Quoted 17 lines · Chris Packham

Not all users of MVGBE need PHYLIB and it increases the size of the openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Cc Tom Rini <[email protected]>
Cc Stefan Roese <[email protected]>

---

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -0
index c962d7a72c0c..f2cc75f494e8 100644

drivers/net/Kconfig config FTMAC100 · line 186

Quoted 7 lines
drivers/net/Kconfig +0 -1
@@ -181,7 +181,6 @@ config FTMAC100
 config MVGBE
 	bool "Marvell Orion5x/Kirkwood network interface support"
 	depends on KIRKWOOD || ORION5X
-	select PHYLIB
 	help
 	  This driver supports the network interface units in the
 	  Marvell Orion5x and Kirkwood SoCs

This results in phylib never being set now as the configs were getting it implicitly. Do any of the boards need it? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/91861414/attachment.sig>
#4 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 13 lines · Tom Rini,
Quoted 12 lines · Chris Packham

Not all users of MVGBE need PHYLIB and it increases the size of the openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Cc Tom Rini <[email protected]>
Cc Stefan Roese <[email protected]>

---

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)
Quoted 16 lines

drivers/net/Kconfig config FTMAC100 · line 186

Quoted 12 lines
drivers/net/Kconfig +0 -1
index c962d7a72c0c..f2cc75f494e8 100644
@@ -181,7 +181,6 @@ config FTMAC100
 config MVGBE
      bool "Marvell Orion5x/Kirkwood network interface support"
      depends on KIRKWOOD || ORION5X
-     select PHYLIB
      help
        This driver supports the network interface units in the
        Marvell Orion5x and Kirkwood SoCs

This results in phylib never being set now as the configs were getting it implicitly. Do any of the boards need it?

I compile tested the affected boards and they all build. I've fired this at github and should have some travis results soon.

My mistake was to copy the mvneta kconfig which had the select. Commit ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB lines so if they need it it's already in the board.h file or selected somewhere else.

#5 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 36 lines · Chris Packham

On Thu, 17 May 2018, 11:09 PM Tom Rini, <[email protected] <mailto:[email protected]>> wrote:

On Thu, May 17, 2018 at 09:03:15PM +1200, Chris Packham wrote:
> Not all users of MVGBE need PHYLIB and it increases the size of the > openrd images too much.
>
> Fixes: commit ed52ea507f12 ("net: add Kconfig for MVGBE") > Signed-off-by: Chris Packham <[email protected]
<mailto:[email protected]>>
> Cc: Tom Rini <trini at konsulko.com <mailto:[email protected]>> > Cc: Stefan Roese <sr at denx.de <mailto:[email protected]>>
> ---
>
>  drivers/net/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index c962d7a72c0c..f2cc75f494e8 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -181,7 +181,6 @@ config FTMAC100
>  config MVGBE
>       bool "Marvell Orion5x/Kirkwood network interface support" >       depends on KIRKWOOD || ORION5X
> -     select PHYLIB
>       help
>         This driver supports the network interface units in the >         Marvell Orion5x and Kirkwood SoCs

This results in phylib never being set now as the configs were getting it implicitly.  Do any of the boards need it?

Quoted 7 lines

I compile tested the affected boards and they all build. I've fired this at github and should have some travis results soon.

My mistake was to copy the mvneta kconfig which had the select. Commit ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB lines so if they need it it's already in the board.h file or selected somewhere else.

Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for MVGBE") selected PHYLIB via Kconfig, which changed the configuration for these Kirkwood boards. *If* some of them needed / selected PHYLIB before this patch, it was most likely done in their config header.

So this patch restores the board configuration again. PHYLIB is not needed for MVGBE - it compiles without it as well.

Thanks,
Stefan

#6 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 45 lines · Stefan Roese
Quoted 36 lines · Chris Packham

On Thu, 17 May 2018, 11:09 PM Tom Rini, <[email protected] <mailto:[email protected]>> wrote:

Quoted 5 lines · Chris Packham

Not all users of MVGBE need PHYLIB and it increases the size of the openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")

<mailto:[email protected]>>

Quoted 12 lines
Cc Tom Rini <trini at konsulko.com <mailto:[email protected]>>
Cc Stefan Roese <sr at denx.de <mailto:[email protected]>>

---

  drivers/net/Kconfig | 1 -

  1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -0
index c962d7a72c0c..f2cc75f494e8 100644
@@ -181,7 +181,6 @@ config FTMAC100
Quoted 7 lines

  config MVGBE
       bool "Marvell Orion5x/Kirkwood network interface support" depends on KIRKWOOD || ORION5X
-     select PHYLIB
       help
         This driver supports the network interface units in the Marvell Orion5x and Kirkwood SoCs

This results in phylib never being set now as the configs were getting it implicitly.  Do any of the boards need it?

Quoted 7 lines

I compile tested the affected boards and they all build. I've fired this at github and should have some travis results soon.

My mistake was to copy the mvneta kconfig which had the select. Commit ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any CONFIG_PHYLIB lines so if they need it it's already in the board.h file or selected somewhere else.

Quoted 7 lines

Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for MVGBE") selected PHYLIB via Kconfig, which changed the configuration for these Kirkwood boards. *If* some of them needed / selected PHYLIB before this patch, it was most likely done in their config header.

So this patch restores the board configuration again. PHYLIB is not needed for MVGBE - it compiles without it as well.

OK, thanks. Can you please do a v2 with a commit message that reflects this and a Fixes tag?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/1700f6f4/attachment.sig>
#7 lore raw

PATCH 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 9 lines · Tom Rini
Quoted 8 lines · Stefan Roese
Quoted 7 lines · Chris Packham

On Thu, 17 May 2018, 11:09 PM Tom Rini, <[email protected] <mailto:[email protected]>> wrote:

Quoted 1 line · Chris Packham

Not all users of MVGBE need PHYLIB and it increases the size of

the

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 4 lines

openrd images too much.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")

<mailto:[email protected]>>

Quoted 19 lines
Cc Tom Rini <trini at konsulko.com <mailto:[email protected]>>
Cc Stefan Roese <sr at denx.de <mailto:[email protected]>>

---

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -1
index c962d7a72c0c..f2cc75f494e8 100644
@@ -181,7 +181,6 @@ config FTMAC100
 config MVGBE
      bool "Marvell Orion5x/Kirkwood network interface support"
      depends on KIRKWOOD || ORION5X
-     select PHYLIB
      help
        This driver supports the network interface units in the
        Marvell Orion5x and Kirkwood SoCs
Quoted 1 line
Quoted 1 line
Quoted 1 line

This results in phylib never being set now as the configs were

getting

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

it implicitly. Do any of the boards need it?

I compile tested the affected boards and they all build. I've fired

this

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

at github and should have some travis results soon.

My mistake was to copy the mvneta kconfig which had the select. Commit ed52ea507f ("net: add Kconfig for MVGBE") didn't remove any

CONFIG_PHYLIB

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines

lines so if they need it it's already in the board.h file or selected somewhere else.

Yes, this is also my understanding. ed52ea507f ("net: add Kconfig for MVGBE") selected PHYLIB via Kconfig, which changed the configuration for these Kirkwood boards. *If* some of them needed / selected PHYLIB before this patch, it was most likely done in their config header.

Quoted 5 lines
Quoted 2 lines

So this patch restores the board configuration again. PHYLIB is not needed for MVGBE - it compiles without it as well.

OK, thanks. Can you please do a v2 with a commit message that reflects this and a Fixes tag?

Done http://patchwork.ozlabs.org/patch/915392/
Travis builds running now
https://travis-ci.org/cpackham/u-boot/builds/380175749