Skip to contentSkip to conversation

drm/i915/psr: Nuke PSR support for VLV and CHV

PATCH In review José Roberto de Souza 4 participants 20 messages May 17, 2018 – Jun 13, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/7 drm/i915/psr: Nuke PSR support for VLV and CHV

From: Dhinakaran Pandiyan <[email protected]>

PSR hardware and hence the driver code for VLV and CHV deviates a lot from their DDI counterparts. While the feature has been disabled for a long time now, retaining support for these platforms is a maintenance burden. There have been multiple refactoring commits to just keep the existing code for these platforms in line with the rest. There are known issues that need to be fixed to enable PSR on these platforms, and there is no PSR capable platform in CI to ensure the code does not break again if we get around to fixing the existing issues. On account of all these reasons, let's nuke this code for now and bring it back if a need arises in the future.

---

Please review this one here: https://patchwork.freedesktop.org/patch/222230/

 drivers/gpu/drm/i915/i915_debugfs.c      |  42 +---
 drivers/gpu/drm/i915/i915_drv.h          |   1 -
 drivers/gpu/drm/i915/i915_pci.c          |   2 -
 drivers/gpu/drm/i915/intel_drv.h         |   2 -
 drivers/gpu/drm/i915/intel_frontbuffer.c |   2 -
 drivers/gpu/drm/i915/intel_psr.c         | 248 ++---------------------
 6 files changed, 27 insertions(+), 270 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +5 -37
index 13e7b9e4a6e6..0096e209fe04 100644
@@ -2630,8 +2630,6 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
 {
 	struct drm_i915_private *dev_priv = node_to_i915(m->private);
 	u32 psrperf = 0;
-	u32 stat[3];
-	enum pipe pipe;
 	bool enabled = false;
 	bool sink_support;
 
@@ -2652,47 +2650,17 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
 	seq_printf(m, "Re-enable work scheduled: %s\n",
 		   yesno(work_busy(&dev_priv->psr.work.work)));
 
-	if (HAS_DDI(dev_priv)) {
-		if (dev_priv->psr.psr2_enabled)
-			enabled = I915_READ(EDP_PSR2_CTL) & EDP_PSR2_ENABLE;
-		else
-			enabled = I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE;
-	} else {
-		for_each_pipe(dev_priv, pipe) {
-			enum transcoder cpu_transcoder =
-				intel_pipe_to_cpu_transcoder(dev_priv, pipe);
-			enum intel_display_power_domain power_domain;
-
-			power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder);
-			if (!intel_display_power_get_if_enabled(dev_priv,
-								power_domain))
-				continue;
-
-			stat[pipe] = I915_READ(VLV_PSRSTAT(pipe)) &
-				VLV_EDP_PSR_CURR_STATE_MASK;
-			if ((stat[pipe] == VLV_EDP_PSR_ACTIVE_NORFB_UP) ||
-			    (stat[pipe] == VLV_EDP_PSR_ACTIVE_SF_UPDATE))
-				enabled = true;
-
-			intel_display_power_put(dev_priv, power_domain);
-		}
-	}
+	if (dev_priv->psr.psr2_enabled)
+		enabled = I915_READ(EDP_PSR2_CTL) & EDP_PSR2_ENABLE;
+	else
+		enabled = I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE;
 
 	seq_printf(m, "Main link in standby mode: %s\n",
 		   yesno(dev_priv->psr.link_standby));
 
-	seq_printf(m, "HW Enabled & Active bit: %s", yesno(enabled));
-
-	if (!HAS_DDI(dev_priv))
-		for_each_pipe(dev_priv, pipe) {
-			if ((stat[pipe] == VLV_EDP_PSR_ACTIVE_NORFB_UP) ||
-			    (stat[pipe] == VLV_EDP_PSR_ACTIVE_SF_UPDATE))
-				seq_printf(m, " pipe %c", pipe_name(pipe));
-		}
-	seq_puts(m, "\n");
+	seq_printf(m, "HW Enabled & Active bit: %s\n", yesno(enabled));
 
 	/*
-	 * VLV/CHV PSR has no kind of performance counter
 	 * SKL+ Perf counter is reset to 0 everytime DC state is entered
 	 */
 	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
drivers/gpu/drm/i915/i915_drv.h +0 -1
index 34c125e2d90c..c58c5dae4424 100644
@@ -607,7 +607,6 @@ struct i915_psr {
 	bool link_standby;
 	bool colorimetry_support;
 	bool alpm;
-	bool has_hw_tracking;
 	bool psr2_enabled;
 	u8 sink_sync_latency;
 	bool debug;
drivers/gpu/drm/i915/i915_pci.c +0 -2
index 4364922e935d..97a91e6af7e3 100644
@@ -340,7 +340,6 @@ static const struct intel_device_info intel_valleyview_info = {
 	GEN(7),
 	.is_lp = 1,
 	.num_pipes = 2,
-	.has_psr = 1,
 	.has_runtime_pm = 1,
 	.has_rc6 = 1,
 	.has_gmch_display = 1,
@@ -433,7 +432,6 @@ static const struct intel_device_info intel_cherryview_info = {
 	.is_lp = 1,
 	.ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING,
 	.has_64bit_reloc = 1,
-	.has_psr = 1,
 	.has_runtime_pm = 1,
 	.has_resource_streamer = 1,
 	.has_rc6 = 1,
drivers/gpu/drm/i915/intel_drv.h +0 -2
index 12002fc77235..4508be628450 100644
@@ -1917,8 +1917,6 @@ void intel_psr_flush(struct drm_i915_private *dev_priv,
 		     unsigned frontbuffer_bits,
 		     enum fb_op_origin origin);
 void intel_psr_init(struct drm_i915_private *dev_priv);
-void intel_psr_single_frame_update(struct drm_i915_private *dev_priv,
-				   unsigned frontbuffer_bits);
 void intel_psr_compute_config(struct intel_dp *intel_dp,
 			      struct intel_crtc_state *crtc_state);
 void intel_psr_irq_control(struct drm_i915_private *dev_priv, bool debug);
drivers/gpu/drm/i915/intel_frontbuffer.c +0 -2
index 7fff0a0eceb4..c3379bde266f 100644
@@ -153,8 +153,6 @@ void intel_frontbuffer_flip_prepare(struct drm_i915_private *dev_priv,
 	/* Remove stale busy bits due to the old buffer. */
 	dev_priv->fb_tracking.busy_bits &= ~frontbuffer_bits;
 	spin_unlock(&dev_priv->fb_tracking.lock);
-
-	intel_psr_single_frame_update(dev_priv, frontbuffer_bits);
 }
 
 /**
drivers/gpu/drm/i915/intel_psr.c +22 -226

345 lines not on this page · raw message

Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v3 2/7 drm/i915/dp: Use intel_dp_aux_wait_done() to wait for previous aux xfer

This reduces the spaghetti that intel_dp_aux_xfer() and reuses code. The only difference is that now it will wait up to 10ms instead of 3ms.

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +3 -17
index 2cc58596ff5a..b86da48fd38e 100644
@@ -1102,23 +1102,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	intel_dp_check_edp(intel_dp);
 
 	/* Try to wait for any previous AUX channel activity */
-	for (try = 0; try < 3; try++) {
-		status = I915_READ_NOTRACE(ch_ctl);
-		if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
-			break;
-		msleep(1);
-	}
-
-	if (try == 3) {
-		static u32 last_status = -1;
-		const u32 status = I915_READ(ch_ctl);
-
-		if (status != last_status) {
-			WARN(1, "dp_aux_ch not started status 0x%08x\n",
-			     status);
-			last_status = status;
-		}
-
+	status = intel_dp_aux_wait_done(intel_dp, has_aux_irq);
+	if (status & DP_AUX_CH_CTL_SEND_BUSY) {
+		DRM_WARN("dp_aux_ch not started status 0x%08x\n", status);
 		ret = -EBUSY;
 		goto out;
 	}
Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [PATCH v3 2/7] drm/i915/dp: Use intel_dp_aux_wait_done() to wait for previous aux xfer

Quoted 27 lines · PDT José Roberto de Souza

This reduces the spaghetti that intel_dp_aux_xfer() and reuses code. The only difference is that now it will wait up to 10ms instead of 3ms.

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_dp.c index 2cc58596ff5a..b86da48fd38e 100644

drivers/gpu/drm/i915/intel_dp.c +0 -8
@@ -1102,23 +1102,9 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	intel_dp_check_edp(intel_dp);
 
 	/* Try to wait for any previous AUX channel activity */
-	for (try = 0; try < 3; try++) {
-		status = I915_READ_NOTRACE(ch_ctl);
-		if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
-			break;
-		msleep(1);
-	}
-
-	if (try == 3) {

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 1105

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +1 -9
-		static u32 last_status = -1;
-		const u32 status = I915_READ(ch_ctl);
-
-		if (status != last_status) {
-			WARN(1, "dp_aux_ch not started status 0x%08x\n",
-			     status);
-			last_status = status;
-		}
-
+	status = intel_dp_aux_wait_done(intel_dp, has_aux_irq);

Isn't intel_dp_aux_wait_done(intel_dp, false) better? Assuming busy bit is set for HW initiated AUX transactions, the current behavior of polling for idle is better.

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 1107

Quoted 2 lines
drivers/gpu/drm/i915/intel_dp.c +2 -0
+	if (status & DP_AUX_CH_CTL_SEND_BUSY) {
+		DRM_WARN("dp_aux_ch not started status 0x%08x\n", status);

Retain the current code to avoid log spam and fix it in a second patch with a per AUX channel flag?

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 1110

Quoted 3 lines
drivers/gpu/drm/i915/intel_dp.c +0 -0
 		ret = -EBUSY;
 		goto out;
 	}

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

PATCH v3 3/7 drm/i915/psr: Remove intel_crtc_state parameter from disable()

In reply to José Roberto de Souza

It was only used in VLV/CHV so after the removal of the PSR support for those platforms it is not necessary any more.

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/i915_drv.h  | 3 +--
 drivers/gpu/drm/i915/intel_psr.c | 5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -2
index c58c5dae4424..34e3449ea182 100644
@@ -615,8 +615,7 @@ struct i915_psr {
 
 	void (*enable_source)(struct intel_dp *,
 			      const struct intel_crtc_state *);
-	void (*disable_source)(struct intel_dp *,
-			       const struct intel_crtc_state *);
+	void (*disable_source)(struct intel_dp *intel_dp);
 	void (*enable_sink)(struct intel_dp *);
 	void (*activate)(struct intel_dp *);
 	void (*setup_vsc)(struct intel_dp *, const struct intel_crtc_state *);
drivers/gpu/drm/i915/intel_psr.c +2 -3
index 29443d2c35bb..d88799482875 100644
@@ -698,8 +698,7 @@ void intel_psr_enable(struct intel_dp *intel_dp,
 	mutex_unlock(&dev_priv->psr.lock);
 }
 
-static void hsw_psr_disable(struct intel_dp *intel_dp,
-			    const struct intel_crtc_state *old_crtc_state)
+static void hsw_psr_disable(struct intel_dp *intel_dp)
 {
 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 	struct drm_device *dev = intel_dig_port->base.base.dev;
@@ -768,7 +767,7 @@ void intel_psr_disable(struct intel_dp *intel_dp,
 		return;
 	}
 
-	dev_priv->psr.disable_source(intel_dp, old_crtc_state);
+	dev_priv->psr.disable_source(intel_dp);
 
 	/* Disable PSR on Sink */
 	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Re: [PATCH v3 3/7] drm/i915/psr: Remove intel_crtc_state parameter from disable()

Quoted 2 lines · José Roberto de Souza

It was only used in VLV/CHV so after the removal of the PSR support for those platforms it is not necessary any more.

Right, Reviewed-by: Dhinakaran Pandiyan <[email protected]>

Quoted 48 lines
Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>

---
 drivers/gpu/drm/i915/i915_drv.h  | 3 +--
 drivers/gpu/drm/i915/intel_psr.c | 5 ++---

 2 files changed, 3 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +0 -0
index c58c5dae4424..34e3449ea182 100644
@@ -615,8 +615,7 @@ struct i915_psr {


  void (*enable_source)(struct intel_dp *, const struct intel_crtc_state *);

drivers/gpu/drm/i915/i915_drv.h +1 -2
-	void (*disable_source)(struct intel_dp *,
-			       const struct intel_crtc_state *);
+	void (*disable_source)(struct intel_dp *intel_dp);

  void (*enable_sink)(struct intel_dp *); void (*activate)(struct intel_dp *); void (*setup_vsc)(struct intel_dp *, const struct intel_crtc_state *);

drivers/gpu/drm/i915/intel_psr.c +0 -0
index 29443d2c35bb..d88799482875 100644
@@ -698,8 +698,7 @@ void intel_psr_enable(struct intel_dp *intel_dp,
  	mutex_unlock(&dev_priv->psr.lock);
  }

drivers/gpu/drm/i915/intel_psr.c +0 -2
-static void hsw_psr_disable(struct intel_dp *intel_dp,
-			    const struct intel_crtc_state

*old_crtc_state)
+static void hsw_psr_disable(struct intel_dp *intel_dp) {
  struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
  struct drm_device *dev = intel_dig_port->base.base.dev;

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -768,7 +767,7 @@ void intel_psr_disable(struct intel_dp *intel_dp,
  		return;
  	}

drivers/gpu/drm/i915/intel_psr.c +1 -1
-	dev_priv->psr.disable_source(intel_dp, old_crtc_state);
+	dev_priv->psr.disable_source(intel_dp);
Quoted 3 lines


  /* Disable PSR on Sink */ drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

PATCH v3 4/7 drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

In reply to José Roberto de Souza

eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.

Here taking the safest approach and disabling PSR(at least until the next modeset), to avoid multiple rendering issues due to bad pannels.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c  |  2 ++
 drivers/gpu/drm/i915/intel_drv.h |  1 +
 drivers/gpu/drm/i915/intel_psr.c | 62 +++++++++++++++++++++++++-------
 3 files changed, 52 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -0
index b86da48fd38e..fa2851d4fb36 100644
@@ -4479,6 +4479,8 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
 	if (intel_dp_needs_link_retrain(intel_dp))
 		return false;
 
+	intel_psr_short_pulse(intel_dp);
+
 	if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING) {
 		DRM_DEBUG_KMS("Link Training Compliance Test requested\n");
 		/* Send a Hotplug Uevent to userspace to start modeset */
drivers/gpu/drm/i915/intel_drv.h +1 -0
index 4508be628450..892da65358e9 100644
@@ -1921,6 +1921,7 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
 			      struct intel_crtc_state *crtc_state);
 void intel_psr_irq_control(struct drm_i915_private *dev_priv, bool debug);
 void intel_psr_irq_handler(struct drm_i915_private *dev_priv, u32 psr_iir);
+void intel_psr_short_pulse(struct intel_dp *intel_dp);
 
 /* intel_runtime_pm.c */
 int intel_power_domains_init(struct drm_i915_private *);
drivers/gpu/drm/i915/intel_psr.c +49 -13

78 lines not on this page · raw message

Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

Re: [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

Quoted 119 lines · José Roberto de Souza

eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.

Here taking the safest approach and disabling PSR(at least until the next modeset), to avoid multiple rendering issues due to bad pannels.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>

---
 drivers/gpu/drm/i915/intel_dp.c  |  2 ++ drivers/gpu/drm/i915/intel_drv.h |  1 + drivers/gpu/drm/i915/intel_psr.c | 62 +++++++++++++++++++++++++----- --

 3 files changed, 52 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -0
index b86da48fd38e..fa2851d4fb36 100644
@@ -4479,6 +4479,8 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
  	if (intel_dp_needs_link_retrain(intel_dp))
  		return false;

drivers/gpu/drm/i915/intel_dp.c +2 -0
+	intel_psr_short_pulse(intel_dp);
+

  if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING) {
  DRM_DEBUG_KMS("Link Training Compliance Test requested\n");
  /* Send a Hotplug Uevent to userspace to start modeset */

drivers/gpu/drm/i915/intel_drv.h +0 -0
index 4508be628450..892da65358e9 100644
@@ -1921,6 +1921,7 @@ void intel_psr_compute_config(struct intel_dp
 *intel_dp,
  			      struct intel_crtc_state *crtc_state);

 void intel_psr_irq_control(struct drm_i915_private *dev_priv, bool debug);
 void intel_psr_irq_handler(struct drm_i915_private *dev_priv, u32 psr_iir);
+void intel_psr_short_pulse(struct intel_dp *intel_dp);

 /* intel_runtime_pm.c */
 int intel_power_domains_init(struct drm_i915_private *);

drivers/gpu/drm/i915/intel_psr.c +0 -0
index d88799482875..60797c8f9f0e 100644
@@ -741,6 +741,23 @@ static void hsw_psr_disable(struct intel_dp
 *intel_dp)
  	psr_aux_io_power_put(intel_dp);
  }

drivers/gpu/drm/i915/intel_psr.c +3 -0
+static void psr_disable(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *intel_dig_port =

dp_to_dig_port(intel_dp);

drivers/gpu/drm/i915/intel_psr.c +14 -0
+	struct drm_device *dev = intel_dig_port->base.base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+
+	if (!dev_priv->psr.enabled)
+		return;
+
+	dev_priv->psr.disable_source(intel_dp);
+
+	/* Disable PSR on Sink */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
+	dev_priv->psr.enabled = NULL;
+	cancel_delayed_work_sync(&dev_priv->psr.work);
+}
+

 /**
  * intel_psr_disable - Disable PSR
  * @intel_dp: Intel DP

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -762,20 +779,8 @@ void intel_psr_disable(struct intel_dp
 *intel_dp,
  		return;


  mutex_lock(&dev_priv->psr.lock);

drivers/gpu/drm/i915/intel_psr.c +1 -11
-	if (!dev_priv->psr.enabled) {
-		mutex_unlock(&dev_priv->psr.lock);
-		return;
-	}
-
-	dev_priv->psr.disable_source(intel_dp);
-
-	/* Disable PSR on Sink */
-	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
-
-	dev_priv->psr.enabled = NULL;
+	psr_disable(intel_dp);

  mutex_unlock(&dev_priv->psr.lock);

drivers/gpu/drm/i915/intel_psr.c +0 -2
-
-	cancel_delayed_work_sync(&dev_priv->psr.work);

 }

 static bool psr_wait_for_idle(struct drm_i915_private *dev_priv)

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -1014,3 +1019,34 @@ void intel_psr_init(struct drm_i915_private
 *dev_priv)
  	dev_priv->psr.setup_vsc = hsw_psr_setup_vsc;


 }

drivers/gpu/drm/i915/intel_psr.c +4 -0
+
+void intel_psr_short_pulse(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *intel_dig_port =

dp_to_dig_port(intel_dp);

drivers/gpu/drm/i915/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1032

Quoted 7 lines
drivers/gpu/drm/i915/intel_psr.c +7 -0
+	struct drm_device *dev = intel_dig_port->base.base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct i915_psr *psr = &dev_priv->psr;
+	uint8_t val;
+
+	if (!HAS_PSR(dev_priv) || !intel_dp_is_edp(intel_dp))
+		return;

CAN_PSR(dev_priv) should take care of this.

drivers/gpu/drm/i915/intel_psr.c

Quoted 2 lines
drivers/gpu/drm/i915/intel_psr.c +2 -0
+
+	mutex_lock(&psr->lock);

Do we really need to acquire the mutex here? How about

drivers/gpu/drm/i915/intel_psr.c

Quoted 2 lines
drivers/gpu/drm/i915/intel_psr.c +2 -0
+
+	if (psr->enabled != intel_dp)

not doing this check?

drivers/gpu/drm/i915/intel_psr.c

Quoted 13 lines
drivers/gpu/drm/i915/intel_psr.c +3 -0
+		goto exit;
+
+	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS, &val)

!= 1) {

drivers/gpu/drm/i915/intel_psr.c +5 -0
+		DRM_ERROR("PSR_STATUS dpcd read failed\n");
+		goto exit;
+	}
+
+	if ((val & DP_PSR_SINK_STATE_MASK) ==

DP_PSR_SINK_INTERNAL_ERROR) {

drivers/gpu/drm/i915/intel_psr.c +1 -0
+		DRM_DEBUG_KMS("PSR sink internal error, disabling

PSR\n");

drivers/gpu/drm/i915/intel_psr.c +1 -0
+		psr_disable(intel_dp);

And calling intel_psr_disable() here?

By doing this, we can minimize the time for which the lock is held.

drivers/gpu/drm/i915/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1052

Quoted 6 lines
drivers/gpu/drm/i915/intel_psr.c +6 -0
+	}
+
+	/* TODO: handle other PSR/PSR2 errors */
+exit:
+	mutex_unlock(&psr->lock);
+}

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

Quoted 118 lines · Dhinakaran Pandiyan
Quoted 117 lines · José Roberto de Souza

eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.

Here taking the safest approach and disabling PSR(at least until the next modeset), to avoid multiple rendering issues due to bad pannels.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c  |  2 ++
 drivers/gpu/drm/i915/intel_drv.h |  1 +
 drivers/gpu/drm/i915/intel_psr.c | 62 +++++++++++++++++++++++++---
--
--
 3 files changed, 52 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -0
index b86da48fd38e..fa2851d4fb36 100644
@@ -4479,6 +4479,8 @@ intel_dp_short_pulse(struct intel_dp
 *intel_dp)
 	if (intel_dp_needs_link_retrain(intel_dp))
 		return false;
 
+	intel_psr_short_pulse(intel_dp);
+
 	if (intel_dp->compliance.test_type ==
 DP_TEST_LINK_TRAINING)

{
DRM_DEBUG_KMS("Link Training Compliance Test
requested\n");
/* Send a Hotplug Uevent to userspace to start
modeset */

drivers/gpu/drm/i915/intel_drv.h +0 -0
index 4508be628450..892da65358e9 100644
@@ -1921,6 +1921,7 @@ void intel_psr_compute_config(struct intel_dp
 *intel_dp,
 			      struct intel_crtc_state
 *crtc_state);
 void intel_psr_irq_control(struct drm_i915_private *dev_priv, bool
 debug);
 void intel_psr_irq_handler(struct drm_i915_private *dev_priv, u32

psr_iir);

drivers/gpu/drm/i915/intel_drv.h +1 -0
+void intel_psr_short_pulse(struct intel_dp *intel_dp);
 
 /* intel_runtime_pm.c */
 int intel_power_domains_init(struct drm_i915_private *);
drivers/gpu/drm/i915/intel_psr.c +17 -0
index d88799482875..60797c8f9f0e 100644
@@ -741,6 +741,23 @@ static void hsw_psr_disable(struct intel_dp
 *intel_dp)
 	psr_aux_io_power_put(intel_dp);
 }
 
+static void psr_disable(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *intel_dig_port =
 dp_to_dig_port(intel_dp);
+	struct drm_device *dev = intel_dig_port->base.base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+
+	if (!dev_priv->psr.enabled)
+		return;
+
+	dev_priv->psr.disable_source(intel_dp);
+
+	/* Disable PSR on Sink */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
+	dev_priv->psr.enabled = NULL;
+	cancel_delayed_work_sync(&dev_priv->psr.work);
+}
+
 /**

* intel_psr_disable - Disable PSR
* @intel_dp: Intel DP

drivers/gpu/drm/i915/intel_psr.c +1 -13
@@ -762,20 +779,8 @@ void intel_psr_disable(struct intel_dp
 *intel_dp,
 		return;
 
 	mutex_lock(&dev_priv->psr.lock);
-	if (!dev_priv->psr.enabled) {
-		mutex_unlock(&dev_priv->psr.lock);
-		return;
-	}
-
-	dev_priv->psr.disable_source(intel_dp);
-
-	/* Disable PSR on Sink */
-	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
-
-	dev_priv->psr.enabled = NULL;
+	psr_disable(intel_dp);
 	mutex_unlock(&dev_priv->psr.lock);
-
-	cancel_delayed_work_sync(&dev_priv->psr.work);
 }
 

static bool psr_wait_for_idle(struct drm_i915_private *dev_priv)

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -1014,3 +1019,34 @@ void intel_psr_init(struct drm_i915_private
 *dev_priv)
 	dev_priv->psr.setup_vsc = hsw_psr_setup_vsc;
 
Quoted 15 lines

drivers/gpu/drm/i915/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1032

Quoted 13 lines
drivers/gpu/drm/i915/intel_psr.c +4 -0
 }
+
+void intel_psr_short_pulse(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *intel_dig_port =

dp_to_dig_port(intel_dp);

drivers/gpu/drm/i915/intel_psr.c +7 -0
+	struct drm_device *dev = intel_dig_port->base.base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct i915_psr *psr = &dev_priv->psr;
+	uint8_t val;
+
+	if (!HAS_PSR(dev_priv) || !intel_dp_is_edp(intel_dp))
+		return;

CAN_PSR(dev_priv) should take care of this.

CAN_PSR is better and I will use that, but to remove the lock and 'if (psr->enabled != intel_dp)' we would also need to check i915_modparams.enable_psr. Even although we could end up doing the aux transactions bellow and PSR is disabled(because of one of the errors bellow), what do you think it is still worthy do it lockless?

Quoted 26 lines

drivers/gpu/drm/i915/intel_psr.c

Quoted 3 lines
drivers/gpu/drm/i915/intel_psr.c +2 -0
+
+	mutex_lock(&psr->lock);

Do we really need to acquire the mutex here? How about

drivers/gpu/drm/i915/intel_psr.c

Quoted 2 lines
drivers/gpu/drm/i915/intel_psr.c +2 -0
+
+	if (psr->enabled != intel_dp)

not doing this check?

drivers/gpu/drm/i915/intel_psr.c

Quoted 13 lines
drivers/gpu/drm/i915/intel_psr.c +3 -0
+		goto exit;
+
+	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS, &val)

!= 1) {

drivers/gpu/drm/i915/intel_psr.c +5 -0
+		DRM_ERROR("PSR_STATUS dpcd read failed\n");
+		goto exit;
+	}
+
+	if ((val & DP_PSR_SINK_STATE_MASK) ==

DP_PSR_SINK_INTERNAL_ERROR) {

drivers/gpu/drm/i915/intel_psr.c +1 -0
+		DRM_DEBUG_KMS("PSR sink internal error, disabling

PSR\n");

drivers/gpu/drm/i915/intel_psr.c +1 -0
+		psr_disable(intel_dp);

And calling intel_psr_disable() here?

Quoted 8 lines

By doing this, we can minimize the time for which the lock is held.

drivers/gpu/drm/i915/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1052

Quoted 6 lines
drivers/gpu/drm/i915/intel_psr.c +6 -0
+	}
+
+	/* TODO: handle other PSR/PSR2 errors */
+exit:
+	mutex_unlock(&psr->lock);
+}

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

Re: [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

Quoted 70 lines · Jose
Quoted 69 lines · Dhinakaran Pandiyan
Quoted 67 lines · José Roberto de Souza

eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.

Here taking the safest approach and disabling PSR(at least until the next modeset), to avoid multiple rendering issues due to bad pannels.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>

---
 drivers/gpu/drm/i915/intel_dp.c  |  2 ++ drivers/gpu/drm/i915/intel_drv.h |  1 + drivers/gpu/drm/i915/intel_psr.c | 62 +++++++++++++++++++++++++- --
--
--

 3 files changed, 52 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -0
index b86da48fd38e..fa2851d4fb36 100644
@@ -4479,6 +4479,8 @@ intel_dp_short_pulse(struct intel_dp
 *intel_dp)
  	if (intel_dp_needs_link_retrain(intel_dp))
  		return false;

drivers/gpu/drm/i915/intel_dp.c +2 -0
+	intel_psr_short_pulse(intel_dp);
+

  if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING)
{
  DRM_DEBUG_KMS("Link Training Compliance Test requested\n");
  /* Send a Hotplug Uevent to userspace to start modeset */

drivers/gpu/drm/i915/intel_drv.h +0 -0
index 4508be628450..892da65358e9 100644
@@ -1921,6 +1921,7 @@ void intel_psr_compute_config(struct

intel_dp
*intel_dp,
        struct intel_crtc_state *crtc_state);
 void intel_psr_irq_control(struct drm_i915_private *dev_priv, bool
debug);
 void intel_psr_irq_handler(struct drm_i915_private *dev_priv, u32
psr_iir);
+void intel_psr_short_pulse(struct intel_dp *intel_dp);
 /* intel_runtime_pm.c */
 int intel_power_domains_init(struct drm_i915_private *);

drivers/gpu/drm/i915/intel_psr.c +0 -0
index d88799482875..60797c8f9f0e 100644
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -741,6 +741,23 @@ static void hsw_psr_disable(struct intel_dp
 *intel_dp)
  	psr_aux_io_power_put(intel_dp);
  }


+static void psr_disable(struct intel_dp *intel_dp)

nit: How about __psr_disable()? Might be worth checking other files what the right convention is.

Quoted 61 lines
Quoted 53 lines
Quoted 53 lines

+{+ struct intel_digital_port *intel_dig_port =
dp_to_dig_port(intel_dp);

drivers/gpu/drm/i915/intel_psr.c +14 -0
+	struct drm_device *dev = intel_dig_port->base.base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+
+	if (!dev_priv->psr.enabled)
+		return;
+
+	dev_priv->psr.disable_source(intel_dp);
+
+	/* Disable PSR on Sink */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
+	dev_priv->psr.enabled = NULL;
+	cancel_delayed_work_sync(&dev_priv->psr.work);
+}
+

 /**
  * intel_psr_disable - Disable PSR
  * @intel_dp: Intel DP

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -762,20 +779,8 @@ void intel_psr_disable(struct intel_dp
 *intel_dp,
  		return;


  mutex_lock(&dev_priv->psr.lock);

drivers/gpu/drm/i915/intel_psr.c +1 -11
-	if (!dev_priv->psr.enabled) {
-		mutex_unlock(&dev_priv->psr.lock);
-		return;
-	}
-
-	dev_priv->psr.disable_source(intel_dp);
-
-	/* Disable PSR on Sink */
-	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
-
-	dev_priv->psr.enabled = NULL;
+	psr_disable(intel_dp);

  mutex_unlock(&dev_priv->psr.lock);

drivers/gpu/drm/i915/intel_psr.c +0 -2
-
-	cancel_delayed_work_sync(&dev_priv->psr.work);

 }

 static bool psr_wait_for_idle(struct drm_i915_private *dev_priv)

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -1014,3 +1019,34 @@ void intel_psr_init(struct

drm_i915_private
*dev_priv)
  dev_priv->psr.setup_vsc = hsw_psr_setup_vsc;
 }

drivers/gpu/drm/i915/intel_psr.c +4 -0
+
+void intel_psr_short_pulse(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *intel_dig_port =

dp_to_dig_port(intel_dp);

Quoted 8 lines

drivers/gpu/drm/i915/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1032

Quoted 7 lines
drivers/gpu/drm/i915/intel_psr.c +7 -0
+	struct drm_device *dev = intel_dig_port->base.base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct i915_psr *psr = &dev_priv->psr;
+	uint8_t val;
+
+	if (!HAS_PSR(dev_priv) || !intel_dp_is_edp(intel_dp))
+		return;

CAN_PSR(dev_priv) should take care of this.

Quoted 6 lines

CAN_PSR is better and I will use that, but to remove the lock and 'if (psr->enabled != intel_dp)' we would also need to check i915_modparams.enable_psr. Even although we could end up doing the aux
transactions bellow and PSR is disabled(because of one of the errors bellow), what do you think it is still worthy do it lockless?

That is a good point, avoiding DPCD read in case PSR is disabled is indeed better.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

Re: [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

Quoted 81 lines · Dhinakaran Pandiyan
Quoted 80 lines · Jose
Quoted 79 lines · Dhinakaran Pandiyan
Quoted 77 lines · José Roberto de Souza

eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.

Here taking the safest approach and disabling PSR(at least until
the next modeset), to avoid multiple rendering issues due to bad pannels.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c  |  2 ++
 drivers/gpu/drm/i915/intel_drv.h |  1 +
 drivers/gpu/drm/i915/intel_psr.c | 62

+++++++++++++++++++++++++-
--
--
--

 3 files changed, 52 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -0
index b86da48fd38e..fa2851d4fb36 100644
@@ -4479,6 +4479,8 @@ intel_dp_short_pulse(struct intel_dp
 *intel_dp)
 	if (intel_dp_needs_link_retrain(intel_dp))
 		return false;
 
+	intel_psr_short_pulse(intel_dp);
+
 	if (intel_dp->compliance.test_type ==
 DP_TEST_LINK_TRAINING)

{
DRM_DEBUG_KMS("Link Training Compliance Test
requested\n");
/* Send a Hotplug Uevent to userspace to start
modeset */

drivers/gpu/drm/i915/intel_drv.h +0 -0
index 4508be628450..892da65358e9 100644
@@ -1921,6 +1921,7 @@ void intel_psr_compute_config(struct

intel_dp
*intel_dp,
struct intel_crtc_state
*crtc_state);
void intel_psr_irq_control(struct drm_i915_private *dev_priv,
bool
debug);
void intel_psr_irq_handler(struct drm_i915_private *dev_priv,
u32
psr_iir);

drivers/gpu/drm/i915/intel_drv.h +1 -0
+void intel_psr_short_pulse(struct intel_dp *intel_dp);
 
 /* intel_runtime_pm.c */
 int intel_power_domains_init(struct drm_i915_private *);
drivers/gpu/drm/i915/intel_psr.c +0 -0
index d88799482875..60797c8f9f0e 100644
@@ -741,6 +741,23 @@ static void hsw_psr_disable(struct

intel_dp
*intel_dp)
psr_aux_io_power_put(intel_dp);
}

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

+static void psr_disable(struct intel_dp *intel_dp)

nit: How about __psr_disable()? Might be worth checking other files what the right convention is.

It varies from file to file but inside of intel_psr.c we are not adding
"__" so better keep that, right?

Quoted 76 lines
Quoted 67 lines
Quoted 58 lines
Quoted 58 lines

+{+ struct intel_digital_port *intel_dig_port =
dp_to_dig_port(intel_dp);

drivers/gpu/drm/i915/intel_psr.c +1 -0
+	struct drm_device *dev = intel_dig_port-
Quoted 1 line

base.base.dev;

drivers/gpu/drm/i915/intel_psr.c +14 -13
+	struct drm_i915_private *dev_priv = to_i915(dev);
+
+	if (!dev_priv->psr.enabled)
+		return;
+
+	dev_priv->psr.disable_source(intel_dp);
+
+	/* Disable PSR on Sink */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
+	dev_priv->psr.enabled = NULL;
+	cancel_delayed_work_sync(&dev_priv->psr.work);
+}
+
 /**
  * intel_psr_disable - Disable PSR
  * @intel_dp: Intel DP
@@ -762,20 +779,8 @@ void intel_psr_disable(struct intel_dp
 *intel_dp,
 		return;
 
 	mutex_lock(&dev_priv->psr.lock);
-	if (!dev_priv->psr.enabled) {
-		mutex_unlock(&dev_priv->psr.lock);
-		return;
-	}
-
-	dev_priv->psr.disable_source(intel_dp);
-
-	/* Disable PSR on Sink */
-	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);
-
-	dev_priv->psr.enabled = NULL;
+	psr_disable(intel_dp);
 	mutex_unlock(&dev_priv->psr.lock);
-
-	cancel_delayed_work_sync(&dev_priv->psr.work);
 }
 

static bool psr_wait_for_idle(struct drm_i915_private
*dev_priv)

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -1014,3 +1019,34 @@ void intel_psr_init(struct

drm_i915_private
*dev_priv)

drivers/gpu/drm/i915/intel_psr.c +4 -0
 	dev_priv->psr.setup_vsc = hsw_psr_setup_vsc;
 
 }
+
+void intel_psr_short_pulse(struct intel_dp *intel_dp)
+{
+	struct intel_digital_port *intel_dig_port =

dp_to_dig_port(intel_dp);

drivers/gpu/drm/i915/intel_psr.c +1 -0
+	struct drm_device *dev = intel_dig_port-
Quoted 1 line

base.base.dev;

Quoted 8 lines

drivers/gpu/drm/i915/intel_psr.c void intel_psr_init(struct drm_i915_private *dev_priv) · line 1032

Quoted 6 lines
drivers/gpu/drm/i915/intel_psr.c +6 -0
+	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct i915_psr *psr = &dev_priv->psr;
+	uint8_t val;
+
+	if (!HAS_PSR(dev_priv) || !intel_dp_is_edp(intel_dp))
+		return;

CAN_PSR(dev_priv) should take care of this.

Quoted 8 lines

CAN_PSR is better and I will use that, but to remove the lock and 'if
(psr->enabled != intel_dp)' we would also need to check i915_modparams.enable_psr. Even although we could end up doing the aux
transactions bellow and PSR is disabled(because of one of the errors
bellow), what do you think it is still worthy do it lockless?

Quoted 2 lines

That is a good point, avoiding DPCD read in case PSR is disabled is indeed better.

Cool, I will send the new version soon.

Thanks
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Re: [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

Quoted 93 lines · Jose
Quoted 84 lines · Dhinakaran Pandiyan
Quoted 82 lines · Jose
Quoted 80 lines · Dhinakaran Pandiyan
Quoted 77 lines · José Roberto de Souza

eDP spec states that sink device will do a short pulse in HPD line when there is a PSR/PSR2 error that needs to be handled by
source, this is handling the first and most simples error:
DP_PSR_SINK_INTERNAL_ERROR.

Here taking the safest approach and disabling PSR(at least until
the next modeset), to avoid multiple rendering issues due to bad pannels.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>

---
 drivers/gpu/drm/i915/intel_dp.c  |  2 ++
 drivers/gpu/drm/i915/intel_drv.h |  1 +
 drivers/gpu/drm/i915/intel_psr.c | 62
+++++++++++++++++++++++++-
--
--
--

 3 files changed, 52 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -0
index b86da48fd38e..fa2851d4fb36 100644
@@ -4479,6 +4479,8 @@ intel_dp_short_pulse(struct intel_dp
 *intel_dp)
  	if (intel_dp_needs_link_retrain(intel_dp))
  		return false;

drivers/gpu/drm/i915/intel_dp.c +2 -0
+	intel_psr_short_pulse(intel_dp);
+

  if (intel_dp->compliance.test_type == DP_TEST_LINK_TRAINING)
{
  DRM_DEBUG_KMS("Link Training Compliance Test requested\n");
  /* Send a Hotplug Uevent to userspace to start
modeset */

drivers/gpu/drm/i915/intel_drv.h +0 -0
index 4508be628450..892da65358e9 100644
@@ -1921,6 +1921,7 @@ void intel_psr_compute_config(struct

intel_dp
*intel_dp,
        struct intel_crtc_state *crtc_state);
 void intel_psr_irq_control(struct drm_i915_private *dev_priv,
bool
debug);
 void intel_psr_irq_handler(struct drm_i915_private *dev_priv,
u32
psr_iir);
+void intel_psr_short_pulse(struct intel_dp *intel_dp);
 /* intel_runtime_pm.c */
 int intel_power_domains_init(struct drm_i915_private *);

drivers/gpu/drm/i915/intel_psr.c +0 -0
index d88799482875..60797c8f9f0e 100644
@@ -741,6 +741,23 @@ static void hsw_psr_disable(struct
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

intel_dp
*intel_dp)
  psr_aux_io_power_put(intel_dp);
 }

+static void psr_disable(struct intel_dp *intel_dp)

nit: How about __psr_disable()? Might be worth checking other files what the right convention is.

Quoted 3 lines

It varies from file to file but inside of intel_psr.c we are not adding
 "__" so better keep that, right?

Sure, either way is okay with me.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

PATCH v3 5/7 drm/i915/psr: Handle PSR RFB storage error

In reply to José Roberto de Souza

Sink will interrupt source when it have any problem saving or reading the remote frame buffer.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_psr.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/gpu/drm/i915/intel_psr.c +14 -0
index 60797c8f9f0e..f72e3f91809f 100644
@@ -1046,6 +1046,20 @@ void intel_psr_short_pulse(struct intel_dp *intel_dp)
 		psr_disable(intel_dp);
 	}
 
+	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_ERROR_STATUS, &val) != 1) {
+		DRM_ERROR("PSR_ERROR_STATUS dpcd read failed\n");
+		goto exit;
+	}
+
+	if (val & DP_PSR_RFB_STORAGE_ERROR) {
+		DRM_DEBUG_KMS("PSR RFB storage error, exiting PSR\n");
+		psr_disable(intel_dp);
+	}
+	if (val & (DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR | DP_PSR_LINK_CRC_ERROR))
+		DRM_ERROR("PSR_ERROR_STATUS not handled %x\n", val);
+	/* clear status register */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, val);
+
 	/* TODO: handle other PSR/PSR2 errors */
 exit:
 	mutex_unlock(&psr->lock);
Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v3 5/7
#12 lore raw

Re: [PATCH v3 5/7] drm/i915/psr: Handle PSR RFB storage error

Quoted 8 lines · José Roberto de Souza

Sink will interrupt source when it have any problem saving or reading the remote frame buffer.

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Quoted 31 lines

---
 drivers/gpu/drm/i915/intel_psr.c | 14 ++++++++++++++

 1 file changed, 14 insertions(+)
drivers/gpu/drm/i915/intel_psr.c +0 -0
index 60797c8f9f0e..f72e3f91809f 100644
@@ -1046,6 +1046,20 @@ void intel_psr_short_pulse(struct intel_dp
 *intel_dp)
  		psr_disable(intel_dp);
  	}

drivers/gpu/drm/i915/intel_psr.c +1 -0
+	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_ERROR_STATUS,

&val) != 1) {

drivers/gpu/drm/i915/intel_psr.c +6 -0
+		DRM_ERROR("PSR_ERROR_STATUS dpcd read failed\n");
+		goto exit;
+	}
+
+	if (val & DP_PSR_RFB_STORAGE_ERROR) {
+		DRM_DEBUG_KMS("PSR RFB storage error, exiting

PSR\n");

drivers/gpu/drm/i915/intel_psr.c +3 -0
+		psr_disable(intel_dp);
+	}
+	if (val & (DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR |

DP_PSR_LINK_CRC_ERROR))

drivers/gpu/drm/i915/intel_psr.c +3 -0
+		DRM_ERROR("PSR_ERROR_STATUS not handled %x\n", val);
+	/* clear status register */
+	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS,
Quoted 5 lines

val);
+
  /* TODO: handle other PSR/PSR2 errors */
 exit:
  mutex_unlock(&psr->lock);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

PATCH v3 6/7 drm/i915/psr/bdw+: Enable CRC check in the static frame on the sink side

In reply to José Roberto de Souza

Sink can be configured to calculate the CRC over the static frame and compare with the CRC calculated and transmited in the VSC SDP by source, if there is a mismatch sink will do a short pulse in HPD and set DP_PSR_LINK_CRC_ERROR on DP_PSR_ERROR_STATUS.

Also spec recommends to disable MAX_SLEEP as a trigger to exit PSR when CRC check is enabled to improve power savings.

Spec: 7723

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/i915_reg.h  |  1 +
 drivers/gpu/drm/i915/intel_psr.c | 29 ++++++++++++++++++++---------
 2 files changed, 21 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 196a0eb79272..1add22e664ea 100644
@@ -4020,6 +4020,7 @@ enum {
 #define   EDP_PSR_SKIP_AUX_EXIT			(1<<12)
 #define   EDP_PSR_TP1_TP2_SEL			(0<<11)
 #define   EDP_PSR_TP1_TP3_SEL			(1<<11)
+#define   EDP_PSR_CRC_ENABLE			(1<<10) /* BDW+ */
 #define   EDP_PSR_TP2_TP3_TIME_500us		(0<<8)
 #define   EDP_PSR_TP2_TP3_TIME_100us		(1<<8)
 #define   EDP_PSR_TP2_TP3_TIME_2500us		(2<<8)
drivers/gpu/drm/i915/intel_psr.c +20 -9
index f72e3f91809f..2f29dcd6f69e 100644
@@ -363,6 +363,8 @@ static void hsw_psr_enable_sink(struct intel_dp *intel_dp)
 		dpcd_val |= DP_PSR_ENABLE_PSR2;
 	if (dev_priv->psr.link_standby)
 		dpcd_val |= DP_PSR_MAIN_LINK_ACTIVE;
+	if (!dev_priv->psr.psr2_enabled && INTEL_GEN(dev_priv) >= 8)
+		dpcd_val |= DP_PSR_CRC_VERIFICATION;
 	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, dpcd_val);
 
 	drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER, DP_SET_POWER_D0);
@@ -418,6 +420,9 @@ static void hsw_activate_psr1(struct intel_dp *intel_dp)
 	else
 		val |= EDP_PSR_TP1_TP2_SEL;
 
+	if (INTEL_GEN(dev_priv) >= 8)
+		val |= EDP_PSR_CRC_ENABLE;
+
 	val |= I915_READ(EDP_PSR_CTL) & EDP_PSR_RESTORE_PSR_ACTIVE_CTX_MASK;
 	I915_WRITE(EDP_PSR_CTL, val);
 }
@@ -635,11 +640,14 @@ static void hsw_psr_enable_source(struct intel_dp *intel_dp,
 		 * preventing  other hw tracking issues now we can rely
 		 * on frontbuffer tracking.
 		 */
-		I915_WRITE(EDP_PSR_DEBUG,
-			   EDP_PSR_DEBUG_MASK_MEMUP |
-			   EDP_PSR_DEBUG_MASK_HPD |
-			   EDP_PSR_DEBUG_MASK_LPSP |
-			   EDP_PSR_DEBUG_MASK_DISP_REG_WRITE);
+		u32 val = EDP_PSR_DEBUG_MASK_MEMUP |
+			  EDP_PSR_DEBUG_MASK_HPD |
+			  EDP_PSR_DEBUG_MASK_LPSP |
+			  EDP_PSR_DEBUG_MASK_DISP_REG_WRITE;
+
+		if (INTEL_GEN(dev_priv) >= 8)
+			val |= EDP_PSR_DEBUG_MASK_MAX_SLEEP;
+		I915_WRITE(EDP_PSR_DEBUG, val);
 	}
 }
 
@@ -1051,16 +1059,19 @@ void intel_psr_short_pulse(struct intel_dp *intel_dp)
 		goto exit;
 	}
 
-	if (val & DP_PSR_RFB_STORAGE_ERROR) {
-		DRM_DEBUG_KMS("PSR RFB storage error, exiting PSR\n");
+	if (val & (DP_PSR_RFB_STORAGE_ERROR | DP_PSR_LINK_CRC_ERROR)) {
+		if (val & DP_PSR_RFB_STORAGE_ERROR)
+			DRM_DEBUG_KMS("PSR RFB storage error, disabling PSR\n");
+		if (val & DP_PSR_LINK_CRC_ERROR)
+			DRM_DEBUG_KMS("PSR Link CRC error, disabling PSR\n");
 		psr_disable(intel_dp);
 	}
-	if (val & (DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR | DP_PSR_LINK_CRC_ERROR))
+	if (val & DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR)
 		DRM_ERROR("PSR_ERROR_STATUS not handled %x\n", val);
 	/* clear status register */
 	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, val);
 
-	/* TODO: handle other PSR/PSR2 errors */
+	/* TODO: handle PSR2 errors */
 exit:
 	mutex_unlock(&psr->lock);
 }
Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#14 lore raw

Re: [PATCH v3 6/7] drm/i915/psr/bdw+: Enable CRC check in the static frame on the sink side

Quoted 72 lines · José Roberto de Souza

Sink can be configured to calculate the CRC over the static frame and compare with the CRC calculated and transmited in the VSC SDP by source, if there is a mismatch sink will do a short pulse in HPD and set DP_PSR_LINK_CRC_ERROR on DP_PSR_ERROR_STATUS.

Also spec recommends to disable MAX_SLEEP as a trigger to exit PSR when
CRC check is enabled to improve power savings.

Spec: 7723

v3:
disabling PSR instead of exiting on error

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>

---
 drivers/gpu/drm/i915/i915_reg.h  |  1 + drivers/gpu/drm/i915/intel_psr.c | 29 ++++++++++++++++++++---------

 2 files changed, 21 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 196a0eb79272..1add22e664ea 100644
@@ -4020,6 +4020,7 @@ enum {
  #define   EDP_PSR_SKIP_AUX_EXIT			(1<<12)
  #define   EDP_PSR_TP1_TP2_SEL			(0<<11)
  #define   EDP_PSR_TP1_TP3_SEL			(1<<11)
+#define   EDP_PSR_CRC_ENABLE			(1<<10) /* BDW+
 */
  #define   EDP_PSR_TP2_TP3_TIME_500us		(0<<8)
  #define   EDP_PSR_TP2_TP3_TIME_100us		(1<<8)

 #define   EDP_PSR_TP2_TP3_TIME_2500us (2<<8)

drivers/gpu/drm/i915/intel_psr.c +2 -0
index f72e3f91809f..2f29dcd6f69e 100644
@@ -363,6 +363,8 @@ static void hsw_psr_enable_sink(struct intel_dp
 *intel_dp)
  		dpcd_val |= DP_PSR_ENABLE_PSR2;
  	if (dev_priv->psr.link_standby)
  		dpcd_val |= DP_PSR_MAIN_LINK_ACTIVE;
+	if (!dev_priv->psr.psr2_enabled && INTEL_GEN(dev_priv) >= 8)
+		dpcd_val |= DP_PSR_CRC_VERIFICATION;
  	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, dpcd_val);


  drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER, DP_SET_POWER_D0);

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -418,6 +420,9 @@ static void hsw_activate_psr1(struct intel_dp
 *intel_dp)

  else
  val |= EDP_PSR_TP1_TP2_SEL;

drivers/gpu/drm/i915/intel_psr.c +3 -0
+	if (INTEL_GEN(dev_priv) >= 8)
+		val |= EDP_PSR_CRC_ENABLE;
+

  val |= I915_READ(EDP_PSR_CTL) &
EDP_PSR_RESTORE_PSR_ACTIVE_CTX_MASK;
  I915_WRITE(EDP_PSR_CTL, val);
 }

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -635,11 +640,14 @@ static void hsw_psr_enable_source(struct
 intel_dp *intel_dp,
  		 * preventing  other hw tracking issues now we can

rely
   * on frontbuffer tracking.
   */

drivers/gpu/drm/i915/intel_psr.c +0 -2
-		I915_WRITE(EDP_PSR_DEBUG,
-			   EDP_PSR_DEBUG_MASK_MEMUP |

drivers/gpu/drm/i915/intel_psr.c static void hsw_psr_enable_source(struct intel_dp *intel_dp, · line 649

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +7 -3
-			   EDP_PSR_DEBUG_MASK_HPD |
-			   EDP_PSR_DEBUG_MASK_LPSP |
-			   EDP_PSR_DEBUG_MASK_DISP_REG_WRITE);
+		u32 val = EDP_PSR_DEBUG_MASK_MEMUP |
+			  EDP_PSR_DEBUG_MASK_HPD |
+			  EDP_PSR_DEBUG_MASK_LPSP |
+			  EDP_PSR_DEBUG_MASK_DISP_REG_WRITE;
+
+		if (INTEL_GEN(dev_priv) >= 8)
+			val |= EDP_PSR_DEBUG_MASK_MAX_SLEEP;

Move Patch 7/7 ahead of this one to avoid removing this check again?

Quoted 32 lines
drivers/gpu/drm/i915/intel_psr.c +1 -0
+		I915_WRITE(EDP_PSR_DEBUG, val);

  }
 }

drivers/gpu/drm/i915/intel_psr.c +0 -0
@@ -1051,16 +1059,19 @@ void intel_psr_short_pulse(struct intel_dp
 *intel_dp)
  		goto exit;
  	}

drivers/gpu/drm/i915/intel_psr.c +0 -2
-	if (val & DP_PSR_RFB_STORAGE_ERROR) {
-		DRM_DEBUG_KMS("PSR RFB storage error, exiting

PSR\n");

drivers/gpu/drm/i915/intel_psr.c +1 -0
+	if (val & (DP_PSR_RFB_STORAGE_ERROR |

DP_PSR_LINK_CRC_ERROR)) {

drivers/gpu/drm/i915/intel_psr.c +2 -0
+		if (val & DP_PSR_RFB_STORAGE_ERROR)
+			DRM_DEBUG_KMS("PSR RFB storage error,

disabling PSR\n");

drivers/gpu/drm/i915/intel_psr.c +2 -0
+		if (val & DP_PSR_LINK_CRC_ERROR)
+			DRM_DEBUG_KMS("PSR Link CRC error, disabling

PSR\n");
  psr_disable(intel_dp);
  }

drivers/gpu/drm/i915/intel_psr.c +0 -1
-	if (val & (DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR |

DP_PSR_LINK_CRC_ERROR))

drivers/gpu/drm/i915/intel_psr.c +1 -0
+	if (val & DP_PSR_VSC_SDP_UNCORRECTABLE_ERROR)

  DRM_ERROR("PSR_ERROR_STATUS not handled %x\n", val); /* clear status register */ drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, val);

drivers/gpu/drm/i915/intel_psr.c +1 -1
-	/* TODO: handle other PSR/PSR2 errors */
+	/* TODO: handle PSR2 errors */
Quoted 3 lines

 exit:
  mutex_unlock(&psr->lock);
 }

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw

PATCH v3 7/7 drm/i915/psr: Avoid PSR exit max time timeout

In reply to José Roberto de Souza

Also masking max time as a trigger to exit PSR for the remaning platforms that do not support sink CRC check(gen <= 8). This will make PSR exits more deterministic and only when really needed. If this was used to fix a issue in some pannel than can only self-refresh for a few seconds, that panel will interrupt and assert one of the PSR errors handled in:
'drm/i915/psr: Handle PSR RFB storage error' and 'drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink'

Cc Dhinakaran Pandiyan <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/intel_psr.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/intel_psr.c +4 -8
index 2f29dcd6f69e..8e2e90d139b5 100644
@@ -376,7 +376,6 @@ static void hsw_activate_psr1(struct intel_dp *intel_dp)
 	struct drm_device *dev = dig_port->base.base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 
-	uint32_t max_sleep_time = 0x1f;
 	/*
 	 * Let's respect VBT in case VBT asks a higher idle_frame value.
 	 * Let's use 6 as the minimum to cover all known cases including
@@ -387,7 +386,6 @@ static void hsw_activate_psr1(struct intel_dp *intel_dp)
 	uint32_t idle_frames = max(6, dev_priv->vbt.psr.idle_frames);
 	uint32_t val = EDP_PSR_ENABLE;
 
-	val |= max_sleep_time << EDP_PSR_MAX_SLEEP_TIME_SHIFT;
 	val |= idle_frames << EDP_PSR_IDLE_FRAME_SHIFT;
 
 	if (IS_HASWELL(dev_priv))
@@ -640,14 +638,12 @@ static void hsw_psr_enable_source(struct intel_dp *intel_dp,
 		 * preventing  other hw tracking issues now we can rely
 		 * on frontbuffer tracking.
 		 */
-		u32 val = EDP_PSR_DEBUG_MASK_MEMUP |
+		I915_WRITE(EDP_PSR_DEBUG,
+			  EDP_PSR_DEBUG_MASK_MEMUP |
 			  EDP_PSR_DEBUG_MASK_HPD |
 			  EDP_PSR_DEBUG_MASK_LPSP |
-			  EDP_PSR_DEBUG_MASK_DISP_REG_WRITE;
-
-		if (INTEL_GEN(dev_priv) >= 8)
-			val |= EDP_PSR_DEBUG_MASK_MAX_SLEEP;
-		I915_WRITE(EDP_PSR_DEBUG, val);
+			  EDP_PSR_DEBUG_MASK_DISP_REG_WRITE |
+			  EDP_PSR_DEBUG_MASK_MAX_SLEEP);
 	}
 }
 
Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#16 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV
URL : https://patchwork.freedesktop.org/series/43368/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6e561e557b3d drm/i915/psr: Nuke PSR support for VLV and CHV
76eeb06056e8 drm/i915/dp: Use intel_dp_aux_wait_done() to wait for previous aux xfer
03733f0d0e8c drm/i915/psr: Remove intel_crtc_state parameter from disable()
704b28a727be drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink
3a64512fbe43 drm/i915/psr: Handle PSR RFB storage error
1e477b3f6103 drm/i915/psr/bdw+: Enable CRC check in the static frame on the sink side
-:35: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#35: FILE: drivers/gpu/drm/i915/i915_reg.h:4023:
+#define   EDP_PSR_CRC_ENABLE			(1<<10) /* BDW+ */
                             			  ^

total: 0 errors, 0 warnings, 1 checks, 66 lines checked b3fc76974022 drm/i915/psr: Avoid PSR exit max time timeout -:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #48: FILE: drivers/gpu/drm/i915/intel_psr.c:642:
+ I915_WRITE(EDP_PSR_DEBUG,
+ EDP_PSR_DEBUG_MASK_MEMUP |

total: 0 errors, 0 warnings, 1 checks, 32 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#17 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV
URL : https://patchwork.freedesktop.org/series/43368/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Commit: drm/i915/psr: Nuke PSR support for VLV and CHV
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3663:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3662:16: warning: expression using sizeof(void)

Commit: drm/i915/dp: Use intel_dp_aux_wait_done() to wait for previous aux xfer Okay!

Commit: drm/i915/psr: Remove intel_crtc_state parameter from disable() -drivers/gpu/drm/i915/selftests/../i915_drv.h:3662:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3661:16: warning: expression using sizeof(void)

Commit: drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink Okay!

Commit: drm/i915/psr: Handle PSR RFB storage error Okay!

Commit: drm/i915/psr/bdw+: Enable CRC check in the static frame on the sink side Okay!

Commit: drm/i915/psr: Avoid PSR exit max time timeout -O:drivers/gpu/drm/i915/intel_psr.c:387:32: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_psr.c:386:32: warning: expression using sizeof(void)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#18 lore raw

✓ Fi.CI.BAT: success for series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV
URL : https://patchwork.freedesktop.org/series/43368/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4201 -> Patchwork_9039 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/43368/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9039 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-4200u:       PASS -> DMESG-FAIL (fdo#102614, fdo#106103)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-cnl-y3:          FAIL (fdo#104724, fdo#103167) -> PASS

fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103

== Participating hosts (43 -> 39) ==

Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4201 -> Patchwork_9039

CI_DRM_4201: 5e68b6c9b2d2781edec45e84460517704f557126 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4487: eccae1360d6d01e73c6af2bd97122cef708207ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9039: b3fc769740221068d91eb1879d9daa75ef108dd3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4487: 6ab75f7eb5e1dccbb773e1739beeb2d7cbd6ad0d @ git://anongit.freedesktop.org/piglit

== Linux commits ==

b3fc76974022 drm/i915/psr: Avoid PSR exit max time timeout
1e477b3f6103 drm/i915/psr/bdw+: Enable CRC check in the static frame on the sink side 3a64512fbe43 drm/i915/psr: Handle PSR RFB storage error
704b28a727be drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink 03733f0d0e8c drm/i915/psr: Remove intel_crtc_state parameter from disable() 76eeb06056e8 drm/i915/dp: Use intel_dp_aux_wait_done() to wait for previous aux xfer 6e561e557b3d drm/i915/psr: Nuke PSR support for VLV and CHV

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9039/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#19 lore raw

✗ Fi.CI.IGT: failure for series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: series starting with [v3,1/7] drm/i915/psr: Nuke PSR support for VLV and CHV
URL : https://patchwork.freedesktop.org/series/43368/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4201_full -> Patchwork_9039_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_9039_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9039_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/43368/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9039_full:

=== IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          PASS -> DMESG-FAIL

    
    ==== Warnings ====

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS

    igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
      shard-apl:          PASS -> SKIP +24

== Known issues ==

Here are the changes found in Patchwork_9039_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_eio@in-flight-suspend:
      shard-kbl:          PASS -> FAIL (fdo#105957)

    igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing:
      shard-hsw:          PASS -> DMESG-WARN (fdo#102614)

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-apl:          PASS -> DMESG-WARN (fdo#103558)

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368) +1

    igt@kms_flip@flip-vs-blocking-wf-vblank:
      shard-hsw:          PASS -> FAIL (fdo#100368)

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724)

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822, fdo#104724)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS +1

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105957 https://bugs.freedesktop.org/show_bug.cgi?id=105957
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (9 -> 9) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4201 -> Patchwork_9039

CI_DRM_4201: 5e68b6c9b2d2781edec45e84460517704f557126 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4487: eccae1360d6d01e73c6af2bd97122cef708207ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9039: b3fc769740221068d91eb1879d9daa75ef108dd3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4487: 6ab75f7eb5e1dccbb773e1739beeb2d7cbd6ad0d @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9039/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx