drivers/i2c: SPDX-License-header information
Subsystems (2)
PATCH 1/1 drivers/i2c: SPDX-License-header information
SPDX License header included to easy developers and machine to know the license governing a particular file
--- drivers/i2c/i2c-core-slave.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/i2c/i2c-core-slave.c +1 -6
@@ -1,12 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Linux I2C core slave support code -* * Copyright (C) 2014 by Wolfram Sang <[email protected]> -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of the GNU General Public License as published by the Free -* Software Foundation; either version 2 of the License, or (at your option) -* any later version. */ #include <dt-bindings/i2c/i2c.h>
Signature · 1 line
2.7.4
Quoted 8 lines · Mawanda Henry
SPDX License header included to easy developers and machine to know the license governing a particular file
Signed-off-by Mawanda Henry <[email protected]>--- drivers/i2c/i2c-core-slave.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
It is customary to make note of the patch revision in the subject. In your case that would be [PATCH v3] for this patch and [PATCH v4] for the next iteration. Speaking of the subject, a better subject for this message would have been
Subject: [PATCH v3] i2c: slave: use SPDX license information
Also, when doing multiple revisions of a patch it is valuable to record the history of changes, so that reviewers get a reminder of what has happened. For a single patch, this space here, just before the first "diff" line is a good spot for that patch history. For a trivial patch like this, this is not super-important, but still best practice.
drivers/i2c/i2c-core-slave.c line 1
Quoted 6 lines
drivers/i2c/i2c-core-slave.c +1
-0@@ -1,12 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0+
Apparently, GPL-2.0+ is a thing of the past. Should be GPL-2.0-or-later according to https://spdx.org/licenses/
drivers/i2c/i2c-core-slave.c line 3
Quoted 3 lines
drivers/i2c/i2c-core-slave.c +0
-1/* * Linux I2C core slave support code -*
I said "line", not "lines". The above line should be left as-is.
Cheers,
Peter
Quoted 10 lines
drivers/i2c/i2c-core-slave.c +0
-5* Copyright (C) 2014 by Wolfram Sang <[email protected]> -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of the GNU General Public License as published by the Free -* Software Foundation; either version 2 of the License, or (at your option) -* any later version. */ #include <dt-bindings/i2c/i2c.h>