Skip to contentSkip to conversation

ata: Remove depends on HAS_DMA in case of platform dependency

PATCH Applied Geert Uytterhoeven 2 participants 4 messages Jun 22, 2018 – Jul 2, 2018 libata

v4 of 5 Applied Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 ata: Remove depends on HAS_DMA in case of platform dependency

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.

This simplifies the dependencies, and allows to improve compile-testing.

---
v4:
- Rebase to v4.18-rc1 (applies to next-20180622, too),

v3:
- Rebase to v4.17-rc1,

v2:
- Add Reviewed-by, Acked-by,
- Drop RFC state,
- Split per subsystem.

---
 drivers/ata/Kconfig | 2 --
 1 file changed, 2 deletions(-)
drivers/ata/Kconfig +0 -2
index 2b16e7c8fff35764..39b181d6bd0d8cf2 100644
@@ -398,7 +398,6 @@ config SATA_DWC_VDEBUG
 
 config SATA_HIGHBANK
 	tristate "Calxeda Highbank SATA support"
-	depends on HAS_DMA
 	depends on ARCH_HIGHBANK || COMPILE_TEST
 	help
 	  This option enables support for the Calxeda Highbank SoC's
@@ -408,7 +407,6 @@ config SATA_HIGHBANK
 
 config SATA_MV
 	tristate "Marvell SATA support"
-	depends on HAS_DMA
 	depends on PCI || ARCH_DOVE || ARCH_MV78XX0 || \
 		   ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST
 	select GENERIC_PHY
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Geert Uytterhoeven

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.

Quoted 5 lines

This simplifies the dependencies, and allows to improve compile-testing.

This looks fine to me but how do you wanna route it? Should I apply it to for-4.18-fixes or should it go with arch changes in some other tree?

Thanks.

Signature · 1 line
tejun
#2 lore raw

Hi Tejun,

Quoted 12 lines · Tejun Heo
Quoted 11 lines · Geert Uytterhoeven

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.

This simplifies the dependencies, and allows to improve compile-testing.

Quoted 7 lines
Quoted 3 lines

This looks fine to me but how do you wanna route it? Should I apply it to for-4.18-fixes or should it go with arch changes in some other tree?

Please queue it in the ata tree. There are no related arch changes. Thanks!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Applied
#3 lore raw
In reply to Geert Uytterhoeven
Quoted 9 lines · Geert Uytterhoeven

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.

Quoted 5 lines

This simplifies the dependencies, and allows to improve compile-testing.

Applied to libata/for-4.18-fixes.

Thanks.

Signature · 1 line
tejun