ata: Remove depends on HAS_DMA in case of platform dependency
PATCH v4 1/1 ata: Remove depends on HAS_DMA in case of platform dependency
Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.
Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.
This simplifies the dependencies, and allows to improve compile-testing.
---
v4:
- Rebase to v4.18-rc1 (applies to next-20180622, too),
v3:
- Rebase to v4.17-rc1,
v2:
- Add Reviewed-by, Acked-by,
- Drop RFC state,
- Split per subsystem.
--- drivers/ata/Kconfig | 2 -- 1 file changed, 2 deletions(-)
drivers/ata/Kconfig +0 -2
@@ -398,7 +398,6 @@ config SATA_DWC_VDEBUG config SATA_HIGHBANK tristate "Calxeda Highbank SATA support" - depends on HAS_DMA depends on ARCH_HIGHBANK || COMPILE_TEST help This option enables support for the Calxeda Highbank SoC's
@@ -408,7 +407,6 @@ config SATA_HIGHBANK config SATA_MV tristate "Marvell SATA support" - depends on HAS_DMA depends on PCI || ARCH_DOVE || ARCH_MV78XX0 || \ ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST select GENERIC_PHY
Signature · 1 line
2.17.1
Quoted 9 lines · Geert Uytterhoeven
Remove dependencies on
HAS_DMAwhere aKconfigsymbol depends on another symbol that impliesHAS_DMA, and, optionally, on "||COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.Generic symbols and drivers without platform dependencies keep their dependencies on
HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.
Quoted 5 lines
This simplifies the dependencies, and allows to improve compile-testing.
Signed-off-by Geert Uytterhoeven <[email protected]>Reviewed-by Mark Brown <[email protected]>Acked-by Robin Murphy <[email protected]>
This looks fine to me but how do you wanna route it? Should I apply it to for-4.18-fixes or should it go with arch changes in some other tree?
Thanks.
Signature · 1 line
tejun
Hi Tejun,
Quoted 12 lines · Tejun Heo
Quoted 11 lines · Geert Uytterhoeven
Remove dependencies on
HAS_DMAwhere aKconfigsymbol depends on another symbol that impliesHAS_DMA, and, optionally, on "||COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.Generic symbols and drivers without platform dependencies keep their dependencies on
HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.This simplifies the dependencies, and allows to improve compile-testing.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Geert Uytterhoeven <[email protected]>Reviewed-by Mark Brown <[email protected]>Acked-by Robin Murphy <[email protected]>This looks fine to me but how do you wanna route it? Should I apply it to for-4.18-fixes or should it go with arch changes in some other tree?
Please queue it in the ata tree. There are no related arch changes. Thanks!
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Tejun Heo
AppliedQuoted 9 lines · Geert Uytterhoeven
Remove dependencies on
HAS_DMAwhere aKconfigsymbol depends on another symbol that impliesHAS_DMA, and, optionally, on "||COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.Generic symbols and drivers without platform dependencies keep their dependencies on
HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.
Quoted 5 lines
This simplifies the dependencies, and allows to improve compile-testing.
Signed-off-by Geert Uytterhoeven <[email protected]>Reviewed-by Mark Brown <[email protected]>Acked-by Robin Murphy <[email protected]>
Applied to libata/for-4.18-fixes.
Thanks.
Signature · 1 line
tejun