Skip to contentSkip to conversation

fbdev: Remove depends on HAS_DMA in case of platform dependency

PATCH In review Geert Uytterhoeven 2 participants 2 messages Dec 3, 2018 – Dec 20, 2018 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 fbdev: Remove depends on HAS_DMA in case of platform dependency

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.

This simplifies the dependencies, and allows to improve compile-testing.

---
v5:
- Rebase to v4.20-rc5,

v4:
- Rebase to v4.18-rc1,

v3:
- Add Acked-by,
- Rebase to v4.17-rc1,

v2:
- Add Reviewed-by, Acked-by,
- Drop RFC state,
- Split per subsystem.

---
 drivers/video/fbdev/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/video/fbdev/Kconfig +2 -1
index e413f54208f4b038..23f991340e3faccd 100644
@@ -2037,7 +2037,8 @@ config FB_XILINX
 
 config FB_GOLDFISH
 	tristate "Goldfish Framebuffer"
-	depends on FB && HAS_DMA && (GOLDFISH || COMPILE_TEST)
+	depends on FB
+	depends on GOLDFISH || COMPILE_TEST
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Geert Uytterhoeven

Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway.

Quoted 6 lines

This simplifies the dependencies, and allows to improve compile-testing.

Patch queued for 4.21, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics