Skip to contentSkip to conversation

armv8: dts: fsl-ls1043a: add sata node support

PATCH New Peng Ma 2 participants 8 messages Aug 1, 2018 – Sep 28, 2018

Subsystems (2)
lore
Share & tools
lore

Peng Ma

author
#0 lore raw

PATCH v2 1/3 armv8: dts: fsl-ls1043a: add sata node support

Add sata node to support ls1043a.

---
v2:
-no changes

 arch/arm/dts/fsl-ls1043a-qds.dtsi |    4 ++++
 arch/arm/dts/fsl-ls1043a.dtsi     |    8 ++++++++
 2 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/dts/fsl-ls1043a-qds.dtsi +4 -0
index addb9ab..3841aee 100644
@@ -174,3 +174,7 @@
 &lpuart0 {
 	status = "okay";
 };
+
+&sata {
+	status = "okay";
+};
arch/arm/dts/fsl-ls1043a.dtsi +8 -0
index a804f51..bb70992 100644
@@ -287,5 +287,13 @@
 			ranges = <0x81000000 0x0 0x00000000 0x50 0x00020000 0x0 0x00010000   /* downstream I/O */
 				  0x82000000 0x0 0x40000000 0x50 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
 		};
+
+		sata: sata at 3200000 {
+			compatible = "fsl,ls1043a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>;
+			interrupts = <0 69 4>;
+			clocks = <&clockgen 4 0>;
+			status = "disabled";
+		};
 	};
 };
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH v2 2/3 scsi: ceva: add ls1043a soc support

Add ahci compatible support for ls1043a soc.

---
v2:
-move compatible to orginal position
-rebase from master

 drivers/ata/sata_ceva.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/ata/sata_ceva.c +3 -0
index 047cff7..327ffa5 100644
@@ -88,6 +88,7 @@
 enum ceva_soc {
 	CEVA_1V84,
 	CEVA_LS1012A,
+	CEVA_LS1043A,
 };
 
 struct ceva_sata_priv {
@@ -114,6 +115,7 @@ static int ceva_init_sata(struct ceva_sata_priv *priv)
 		break;
 
 	case CEVA_LS1012A:
+	case CEVA_LS1043A:
 		writel(ECC_DIS_ADDR_CH2, ECC_DIS_VAL_CH2);
 		writel(CEVA_PHY1_CFG, base + AHCI_VEND_PPCFG);
 		writel(CEVA_TRANS_CFG, base + AHCI_VEND_PTC);
@@ -144,6 +146,7 @@ static int sata_ceva_probe(struct udevice *dev)
 static const struct udevice_id sata_ceva_ids[] = {
 	{ .compatible = "ceva,ahci-1v84", .data = CEVA_1V84 },
 	{ .compatible = "fsl,ls1012a-ahci", .data = CEVA_LS1012A },
+	{ .compatible = "fsl,ls1043a-ahci", .data = CEVA_LS1043A },
 	{ }
 };
 
Signature · 1 line
1.7.1
author
#2 lore raw

PATCH v2 3/3 arm64: ls1043aqds: enable DM support for sata

In reply to Peng Ma

Enable related configs to support sata DM feature.

---
v2:
-no changes

 configs/ls1043aqds_defconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
configs/ls1043aqds_defconfig +5 -0
index 73f7f8a..5510509 100644
@@ -48,3 +48,8 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
 CONFIG_BLK=y
 CONFIG_DM_MMC=y
+CONFIG_DM_SCSI=y
+CONFIG_SATA_CEVA=y
+CONFIG_SCSI_AHCI=y
+CONFIG_SCSI=y
+CONFIG_AHCI=y
Signature · 1 line
1.7.1
#3 lore raw

PATCH v2 3/3 arm64: ls1043aqds: enable DM support for sata

Quoted 16 lines · Peng Ma

Enable related configs to support sata DM feature.

---
v2:
-no changes

 configs/ls1043aqds_defconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
configs/ls1043aqds_defconfig +0 -0
index 73f7f8a..5510509 100644

configs/ls1043aqds_defconfig CONFIG_USB_XHCI_DWC3=y · line 55

Quoted 8 lines
configs/ls1043aqds_defconfig +5 -0
@@ -48,3 +48,8 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
 CONFIG_BLK=y
 CONFIG_DM_MMC=y
+CONFIG_DM_SCSI=y
+CONFIG_SATA_CEVA=y
+CONFIG_SCSI_AHCI=y
+CONFIG_SCSI=y
+CONFIG_AHCI=y

Peng,

I noticed your code base seems to have CONFIG_BLK=y. However upstream code doesn't have this option enabled. I can add it for you, but I am afraid I may miss other things you have locally. Please rebase your patch and confirm SATA works as you expected.

York

author
#4 lore raw

PATCH v2 3/3 arm64: ls1043aqds: enable DM support for sata

Hi york,

This patch depend on https://patchwork.ozlabs.org/patch/941093/ , At V2 review I forgot to write depend on. Could I add "depend on" in My patch at V3 or not?

Best regards
Peng Ma

-----Original Message-----
From: York Sun
Sent: 2018年8月8日 5:44
To: Peng Ma <[email protected]>
Cc: albert.u.boot at aribaud.net; Mingkai Hu <[email protected]>; Pankaj Bansal <[email protected]>; Fabio Estevam <[email protected]>; Yinbo Zhu <[email protected]>; michal.simek at xilinx.com; sjg at chromium.org; Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH 3/3,v2] arm64: ls1043aqds: enable DM support for sata

Quoted 17 lines · Peng Ma

Enable related configs to support sata DM feature.

---
v2:
-no changes

 configs/ls1043aqds_defconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/configs/ls1043aqds_defconfig index 73f7f8a..5510509 100644

configs/ls1043aqds_defconfig +0 -0
@@ -48,3 +48,8 @@ CONFIG_USB_XHCI_DWC3=y  CONFIG_USB_STORAGE=y  

CONFIG_BLK=y CONFIG_DM_MMC=y

configs/ls1043aqds_defconfig CONFIG_USB_XHCI_DWC3=y · line 55

Quoted 5 lines
configs/ls1043aqds_defconfig +5 -0
+CONFIG_DM_SCSI=y
+CONFIG_SATA_CEVA=y
+CONFIG_SCSI_AHCI=y
+CONFIG_SCSI=y
+CONFIG_AHCI=y

Peng,

I noticed your code base seems to have CONFIG_BLK=y. However upstream code doesn't have this option enabled. I can add it for you, but I am afraid I may miss other things you have locally. Please rebase your patch and confirm SATA works as you expected.

York

#5 lore raw

PATCH v2 3/3 arm64: ls1043aqds: enable DM support for sata

Quoted 4 lines · Peng Ma

Hi york,

This patch depend on https://patchwork.ozlabs.org/patch/941093/ , At V2 review I forgot to write depend on. Could I add "depend on" in My patch at V3 or not?

Do not send another version just to explain the dependency, since I know it now.

York

author
#6 lore raw

PATCH v2 3/3 arm64: ls1043aqds: enable DM support for sata

-----Original Message-----
From: York Sun
Sent: 2018年8月8日 10:00
To: Peng Ma <[email protected]>
Cc: albert.u.boot at aribaud.net; Mingkai Hu <[email protected]>; Pankaj Bansal <[email protected]>; Fabio Estevam <[email protected]>; Yinbo Zhu <[email protected]>; michal.simek at xilinx.com; sjg at chromium.org; Andy Tang <[email protected]>; u-boot at lists.denx.de
Subject: Re: [PATCH 3/3,v2] arm64: ls1043aqds: enable DM support for sata

Quoted 4 lines · Peng Ma

Hi york,

This patch depend on https://patchwork.ozlabs.org/patch/941093/ , At V2 review I forgot to write depend on. Could I add "depend on" in My patch at V3 or not?

Do not send another version just to explain the dependency, since I know it now.

York

OK, THANKS
Peng

#7 lore raw

PATCH v2 1/3 armv8: dts: fsl-ls1043a: add sata node support

In reply to Peng Ma
Quoted 6 lines · Peng Ma

Add sata node to support ls1043a.

---
v2:
-no changes

This patch set has been applied to fsl-qoriq master, awaiting upstream. Thanks.

York