Skip to contentSkip to conversation

dmaengine: fsl-edma: add ColdFire mcf5441x edma support

PATCH Superseded Angelo Dureghello 1 participant 1 message Aug 6, 2018 dmaengine

v8 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

PATCH v8 3/3 dmaengine: fsl-edma: add ColdFire mcf5441x edma support

Hi Stefan,

Quoted 40 lines · Stefan Agner
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Angelo Dureghello

This patch adds support for ColdFire mcf5441x-family edma module.

The ColdFire edma module is slightly different from fsl-edma, so a new driver is added. But most of the code is common between fsl-edma and mcf-edma so it has been collected into a separate common module fsl-edma-common (patch 1/3).

[...]

Quoted 28 lines
Quoted 14 lines
include/linux/platform_data/dma-mcf-edma.h new file +8 -0
new file mode 100644
index 000000000000..9a1819acb28f
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Freescale eDMA platform data, ColdFire SoC's family.
+ *
+ * Copyright (c) 2017 Angelo Dureghello <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as

include/linux/platform_data/dma-mcf-edma.h line 18

Quoted 10 lines
include/linux/platform_data/dma-mcf-edma.h new file +10 -0
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __MACH_MCF_EDMA_H__
+#define __MACH_MCF_EDMA_H__

The guard should rather match current location, e.g. __LINUX_PLATFORM_DATA_MCF_EDMA_H__

Quoted 6 lines
Quoted 2 lines

So this revision fixed the issue we had seen with the previous version? Do we know what it was exactly?

Well, no. I restarted completely the patch from scratch moving/changing the code carefully. I avoided changes to Freescale code as much as possible.

Quoted 6 lines

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Regards,
Angelo
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html