Skip to contentSkip to conversation

staging/bcm2835-audio: Fix alignment of function arguments - Style

PATCH In review Greg Gallagher 3 participants 5 messages Aug 8, 2018 – Aug 9, 2018

Subsystems (3)
Staging Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Greg Gallagher

author
#0 lore raw

PATCH v2 1/1 staging/bcm2835-audio: Fix alignment of function arguments - Style

Fix warnings generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

Signed-off-by Greg Gallagher <[email protected]>

---
Changes in v2:
- Clean up all the alignment warnings in the file

---
 .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +9 -9
index ec468d5719b1..8af303e25036 100644
@@ -94,7 +94,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
-				struct snd_ctl_elem_value *ucontrol)
+			       struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	int changed = 0;

@@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
 };
 
 static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+					  struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;

@@ -182,7 +182,7 @@ static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					 struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	int i;

@@ -199,7 +199,7 @@ static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					 struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	unsigned int val = 0;

@@ -219,7 +219,7 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_mask_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+				       struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;

@@ -227,7 +227,7 @@ static int snd_bcm2835_spdif_mask_info(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+				      struct snd_ctl_elem_value *ucontrol)
 {
 	/*
 	 * bcm2835 supports only consumer mode and sets all other format flags

@@ -238,7 +238,7 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_stream_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+					 struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;

@@ -246,7 +246,7 @@ static int snd_bcm2835_spdif_stream_info(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_stream_get(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	int i;

@@ -263,7 +263,7 @@ static int snd_bcm2835_spdif_stream_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_stream_put(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	unsigned int val = 0;
Signature · 1 line
2.14.1
maintainer
#1 lore raw
Quoted 10 lines · Greg Gallagher

Fix warnings generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

Signed-off-by Greg Gallagher <[email protected]>

---
Changes in v2:
- Clean up all the alignment warnings in the file

---
 .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

You sent 2 patches that did the same thing, with different subjects :(

Please fix up and send only the "correct" one.

greg k-h

author
#2 lore raw
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · Greg Gallagher

Fix warnings generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

Signed-off-by Greg Gallagher <[email protected]>

---
Changes in v2:
- Clean up all the alignment warnings in the file

---
 .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
Quoted 5 lines

You sent 2 patches that did the same thing, with different subjects :(

Please fix up and send only the "correct" one.

greg k-h

Sorry, the first one was a mistake and I should have sent something saying to ignore it.? I will double check the second one is correct.? Is there a best
practice when I'd like a patch ignored?

thanks

Greg

maintainer
#3 lore raw
Quoted 14 lines · Greg Gallagner
Quoted 13 lines · Greg Kroah-Hartman
Quoted 10 lines · Greg Gallagher

Fix warnings generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

Signed-off-by Greg Gallagher <[email protected]>

---
Changes in v2:
- Clean up all the alignment warnings in the file

---
 .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

You sent 2 patches that did the same thing, with different subjects :(

Quoted 7 lines
Quoted 3 lines

Please fix up and send only the "correct" one.

greg k-h

Sorry, the first one was a mistake and I should have sent something saying to ignore it.? I will double check the second one is correct.? Is there a best
practice when I'd like a patch ignored?

Just respond to the email and say "please ignore this patch" or something like that.

thanks,
greg k-h