Skip to contentSkip to conversation

staging/vc04_services: Fix alignment of function arguments

PATCH Superseded Greg Gallagher 2 participants 3 messages Aug 6, 2018

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging/vc04_services: Fix alignment of function arguments

Fix warning generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +1 -1
index ec468d5719b1..33ae8ae8663b 100644
@@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
 };
 
 static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+					  struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;
Signature · 1 line
2.14.1
#1 lore raw

Hi,

Am 06.08.2018 um 06:07 schrieb Greg Gallagher:

Quoted 13 lines

Fix warning generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

---
  drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +0 -0
index ec468d5719b1..33ae8ae8663b 100644

drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c static struct snd_kcontrol_new snd_bcm2835_ctl[] = { · line 180

Quoted 8 lines
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +1 -1
@@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
  };
 
  static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+					  struct snd_ctl_elem_info *uinfo)
  {
  	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
  	uinfo->count = 1;

in case this is the only alignment issue in the whole driver, you can have my acked-by.
Otherwise please fix the other ones in the second version.

Btw there are more drivers under vc04_services so a "staging:
bcm2835-audio: Fix alignment of functions arguments" would be better.

Stefan

#2 lore raw

Hi,

Quoted 32 lines · Stefan Wahren

Hi,

Am 06.08.2018 um 06:07 schrieb Greg Gallagher:

Quoted 15 lines

Fix warning generated by checkpatch.pl for alignment should match open parenthesis. This is a coding style change only.

---
  drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +0 -0
index ec468d5719b1..33ae8ae8663b 100644

drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c static struct snd_kcontrol_new snd_bcm2835_ctl[] = { · line 180

Quoted 8 lines
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c +1 -1
@@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
  };
    static int snd_bcm2835_spdif_default_info(struct snd_kcontrol
 *kcontrol,
-       struct snd_ctl_elem_info *uinfo)
+                                         struct snd_ctl_elem_info *uinfo)
  {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
        uinfo->count = 1;

in case this is the only alignment issue in the whole driver, you can have my acked-by.
Otherwise please fix the other ones in the second version.

Quoted 4 lines

Btw there are more drivers under vc04_services so a "staging: bcm2835-audio:
Fix alignment of functions arguments" would be better.

Stefan

I'll fix the other alignment issues as well in the second version and fix up the subject line to staging: bcm2835-audio.

thanks

Greg