Skip to contentSkip to conversation

locks: remove misleading obsolete comment

PATCH New Jeff Layton 1 participant 1 message Aug 8, 2018

Subsystems (2)
lore
Share & tools
lore

Jeff Layton

author maintainer
#0 lore raw

PATCH 1/1 locks: remove misleading obsolete comment

The spinlock handling in this file has changed significantly since this comment was written, and the file_lock_lock is no more. In addition, this overall comment no longer applies. Deleting an entry now requires both locks.

---
 fs/locks.c | 4 ----
 1 file changed, 4 deletions(-)
fs/locks.c +0 -4
index 6138a9bcd924..11a4d698aba8 100644
@@ -202,10 +202,6 @@ static DEFINE_HASHTABLE(blocked_hash, BLOCKED_HASH_BITS);
  * we often hold the flc_lock as well. In certain cases, when reading the fields
  * protected by this lock, we can skip acquiring it iff we already hold the
  * flc_lock.
- *
- * In particular, adding an entry to the fl_block list requires that you hold
- * both the flc_lock and the blocked_lock_lock (acquired in that order).
- * Deleting an entry from the list however only requires the file_lock_lock.
  */
 static DEFINE_SPINLOCK(blocked_lock_lock);
 
Signature · 1 line
2.17.1