linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS
PATCH 1/1 linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS
Since the last update of the DTC package, linux build breaks at some point with the following error:
In file included from {output}/host/include/libfdt.h:54:0,
from scripts/dtc/libfdt/fdt.c:54:
{output}/host/include/libfdt_env.h:82:24: error: redefinition of \
?fdt16_to_cpu?
static inline uint16_t fdt16_to_cpu(fdt16_t x)
^~~~~~~~~~~~
In file included from scripts/dtc/libfdt/fdt.c:51:0:
scripts/dtc/libfdt/libfdt_env.h:81:24: note: previous definition of \
?fdt16_to_cpu? was hereThis is because the HOST_CFLAGS is added before Linux's makefile add it's own local ones (-Iscripts/dtc/libfdt), resulting in a mix of local and host headers beeing used.
So, to fix this the '-I' is substituted by '-isystem' to let it search for the headers in the right location first.
--- linux/linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -1
@@ -115,7 +115,7 @@ LINUX_EXTRA_DOWNLOADS += $(ARCH_XTENSA_OVERLAY_URL) endif LINUX_MAKE_FLAGS = \ - HOSTCC="$(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS)" \ + HOSTCC="$(HOSTCC) $(patsubst -I%,-isystem %,$(HOST_CFLAGS)) $(HOST_LDFLAGS)" \ ARCH=$(KERNEL_ARCH) \ INSTALL_MOD_PATH=$(TARGET_DIR) \ CROSS_COMPILE="$(TARGET_CROSS)" \
Signature · 1 line
2.13.6
PATCH 1/1 linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS
Hello,
Quoted 17 lines · David De Grave (Essensium/Mind)
Since the last update of the DTC package, linux build breaks at some point with the following error:
In file included from {output}/host/include/libfdt.h:54:0, from scripts/dtc/libfdt/fdt.c:54: {output}/host/include/libfdt_env.h:82:24: error: redefinition of \ ?fdt16_to_cpu? static inline uint16_t fdt16_to_cpu(fdt16_t x) ^~~~~~~~~~~~ In file included from scripts/dtc/libfdt/fdt.c:51:0: scripts/dtc/libfdt/libfdt_env.h:81:24: note: previous definition of \ ?fdt16_to_cpu? was hereThis is because the
HOST_CFLAGSis added before Linux's makefile add it's own local ones (-Iscripts/dtc/libfdt), resulting in a mix of local and host headers beeing used.
Quoted 7 lines
So, to fix this the '-I' is substituted by '-isystem' to let it search for the headers in the right location first.
Signed-off-by David De Grave (Essensium/Mind) <[email protected]>--- linux/linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I suspect this one is superseded by your new patch series
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524, so I've marked this patch as Changes Requested.
Note that
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524
doesn't contain PATCH 2/3 due to a patchwork issue when associating patches to series, but PATCH 2/3 has been recorded by patchwork.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS
Hi Thomas,
Indeed the series can replace that one... Thanks.
Regards,
David.
Quoted 50 lines · Thomas Petazzoni
Hello,
Quoted 1 line · David De Grave (Essensium/Mind)
Since the last update of the DTC package, linux build breaks at some
point
Quoted 10 lines
with the following error:
In file included from {output}/host/include/libfdt.h:54:0, from scripts/dtc/libfdt/fdt.c:54: {output}/host/include/libfdt_env.h:82:24: error: redefinition of \ ?fdt16_to_cpu? static inline uint16_t fdt16_to_cpu(fdt16_t x) ^~~~~~~~~~~~ In file included from scripts/dtc/libfdt/fdt.c:51:0: scripts/dtc/libfdt/libfdt_env.h:81:24: note: previous definition of\
Quoted 4 lines
?fdt16_to_cpu? was hereThis is because the
HOST_CFLAGSis added before Linux's makefile add it's own local ones (-Iscripts/dtc/libfdt), resulting in a mix of local andhost
Quoted 3 lines
headers beeing used.
So, to fix this the '-I' is substituted by '-isystem' to let it search
for
Quoted 6 lines
the headers in the right location first.
Signed-off-by David De Grave (Essensium/Mind) <[email protected]>--- linux/linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)I suspect this one is superseded by your new patch series
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524, so I've marked this patch as Changes Requested.Note that
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524
doesn't contain PATCH 2/3 due to a patchwork issue when associating patches to series, but PATCH 2/3 has been recorded by patchwork.Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com
Signature · 8 lines
*David De Grave* Senior Embedded Software Developer Gsm : +32(0)496.364.960 | Tel : +32-16-28.65.00 | Fax : +32-16-28a.65.01 Essensium-Mind <https://www.mind.be/> - Gaston Geenslaan 9, B-3001 Leuven, Belgium -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180901/0006c9ec/attachment.html>
PATCH 1/1 linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS
In reply to Thomas PetazzoniQuoted 24 lines · Thomas Petazzoni
Hello,
Quoted 20 lines · David De Grave (Essensium/Mind)
Since the last update of the DTC package, linux build breaks at some point with the following error:
In file included from {output}/host/include/libfdt.h:54:0, from scripts/dtc/libfdt/fdt.c:54: {output}/host/include/libfdt_env.h:82:24: error: redefinition of \ ?fdt16_to_cpu? static inline uint16_t fdt16_to_cpu(fdt16_t x) ^~~~~~~~~~~~ In file included from scripts/dtc/libfdt/fdt.c:51:0: scripts/dtc/libfdt/libfdt_env.h:81:24: note: previous definition of \ ?fdt16_to_cpu? was hereThis is because the
HOST_CFLAGSis added before Linux's makefile add it's own local ones (-Iscripts/dtc/libfdt), resulting in a mix of local and host headers beeing used.So, to fix this the '-I' is substituted by '-isystem' to let it search for the headers in the right location first.
Quoted 8 lines
Quoted 4 lines
Signed-off-by David De Grave (Essensium/Mind) <[email protected]>--- linux/linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)I suspect this one is superseded by your new patch series
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524, so I've marked this patch as Changes Requested.
Actually, the idea was to apply this patch on master because it fixes a bug,
and the series on next because it is more invasive.
It turns out, however, that the problem only occurs for the beaglebone kernel
on github, because that one builds its fdtoverlay host tool. "Normal" kernels don't build libfdt at all for the host, so the error reported doesn't occur.
Quoted 5 lines
Note that
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524
doesn't contain PATCH 2/3 due to a patchwork issue when associating patches to series, but PATCH 2/3 has been recorded by patchwork.
Patch 2/3 actually doesn't apply, it's a revert of this patch... So I've marked
that one as N/A.
Regards,
Arnout
Quoted 5 lines
Best regards,
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF