Skip to contentSkip to conversation

ARM: dts: Makefile: fix build for at91family

PATCH New Eugen Hristev 2 participants 4 messages Aug 9, 2018 – Sep 11, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: Makefile: fix build for at91family

For at91family, makefile was building unwanted DTBs Moved them under specific target configuration.

---
 arch/arm/dts/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/dts/Makefile +4 -4
index ebfa227..79fdc0d 100644
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0+
 
-dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
-	at91sam9g20-taurus.dtb \
-	at91sam9g45-corvus.dtb \
-	at91sam9g45-gurnard.dtb
+dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
+dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
+dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
+dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
 
 dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
 dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 at91: fix devicetree warnings

This commit fixes various devicetree warnings in the at91 devicetrees
like:
arch/arm/dts/sama5d36ek_cmp.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

These warnings make buildman report failed builds for most of at91 boards. Thus, fixing it.

---
 arch/arm/dts/at91-vinco.dts      | 2 ++
 arch/arm/dts/at91sam9260.dtsi    | 3 ---
 arch/arm/dts/at91sam9261.dtsi    | 3 ---
 arch/arm/dts/at91sam9263.dtsi    | 3 ---
 arch/arm/dts/at91sam9g45.dtsi    | 9 ---------
 arch/arm/dts/at91sam9n12.dtsi    | 3 ---
 arch/arm/dts/at91sam9rl.dtsi     | 5 -----
 arch/arm/dts/at91sam9x5.dtsi     | 5 -----
 arch/arm/dts/sama5d27_som1.dtsi  | 1 -
 arch/arm/dts/sama5d3.dtsi        | 4 ----
 arch/arm/dts/sama5d3xmb_cmp.dtsi | 2 --
 arch/arm/dts/usb_a9263.dts       | 2 --
 12 files changed, 2 insertions(+), 40 deletions(-)
arch/arm/dts/at91-vinco.dts +2 -0
index ff6d2e3..0ecb64e 100644
@@ -152,6 +152,8 @@
 			};
 
 			tcb2: timer at fc024000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
 				timer at 0 {
 					compatible = "atmel,tcb-timer";
 					reg = <0>;
arch/arm/dts/at91sam9260.dtsi +0 -3
index 69d9cea..476ad1d 100644
@@ -37,9 +37,6 @@
 		spi0 = &spi0;
 	};
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
arch/arm/dts/at91sam9261.dtsi +0 -3
index 69c2d6e..b6357d3 100644
@@ -34,9 +34,6 @@
 	};
 
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
arch/arm/dts/at91sam9263.dtsi +0 -3
index 0b594be..61b0562 100644
@@ -36,9 +36,6 @@
 	};
 
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
arch/arm/dts/at91sam9g45.dtsi +0 -9
index 1be1270..c9b2e46 100644
@@ -41,9 +41,6 @@
 		pwm0 = &pwm0;
 	};
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
@@ -1042,8 +1039,6 @@
 			};
 
 			adc0: adc at fffb0000 {
-				#address-cells = <1>;
-				#size-cells = <0>;
 				compatible = "atmel,at91sam9g45-adc";
 				reg = <0xfffb0000 0x100>;
 				interrupts = <20 IRQ_TYPE_LEVEL_HIGH 0>;
@@ -1086,10 +1081,6 @@
 				clocks = <&isi_clk>;
 				clock-names = "isi_clk";
 				status = "disabled";
-				port {
-					#address-cells = <1>;
-					#size-cells = <0>;
-				};
 			};
 
 			pwm0: pwm at fffb8000 {
arch/arm/dts/at91sam9n12.dtsi +0 -3
index 7ba7116..024be13 100644
@@ -38,9 +38,6 @@
 		spi0 = &spi0;
 	};
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
arch/arm/dts/at91sam9rl.dtsi +0 -5
index 4602cd2..6d6aee5 100644
@@ -38,9 +38,6 @@
 	};
 
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
@@ -253,8 +250,6 @@
 			};
 
 			adc0: adc at fffd0000 {
-				#address-cells = <1>;
-				#size-cells = <0>;
 				compatible = "atmel,at91sam9rl-adc";
 				reg = <0xfffd0000 0x100>;
 				interrupts = <20 IRQ_TYPE_LEVEL_HIGH 0>;
arch/arm/dts/at91sam9x5.dtsi +0 -5
index a422c98..ea319cc 100644
@@ -41,9 +41,6 @@
 	};
 
 	cpus {
-		#address-cells = <0>;
-		#size-cells = <0>;
-
 		cpu {
 			compatible = "arm,arm926ej-s";
 			device_type = "cpu";
@@ -1048,8 +1045,6 @@
 			};
 
 			adc0: adc at f804c000 {
-				#address-cells = <1>;
-				#size-cells = <0>;
 				compatible = "atmel,at91sam9x5-adc";
 				reg = <0xf804c000 0x100>;
 				interrupts = <19 IRQ_TYPE_LEVEL_HIGH 0>;
arch/arm/dts/sama5d27_som1.dtsi +0 -1
index 0c44a97..9efcf63 100644
@@ -55,7 +55,6 @@
 
 	aliases {
 		spi0 = &qspi1;
-		u-boot,dm-pre-reloc;
 	};
 
 	ahb {
arch/arm/dts/sama5d3.dtsi +0 -4
index ee0e14e..ba707b0 100644
@@ -238,10 +238,6 @@
 				clocks = <&isi_clk>;
 				clock-names = "isi_clk";
 				status = "disabled";
-				port {
-					#address-cells = <1>;
-					#size-cells = <0>;
-				};
 			};
 
 			sfr: sfr at f0038000 {
arch/arm/dts/sama5d3xmb_cmp.dtsi +0 -2
index 77f989c..9792b2a 100644
@@ -221,8 +221,6 @@
 		compatible = "gpio-keys";
 		status = "okay";
 
-		#address-cells = <1>;
-		#size-cells = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_gpio_keys>;
 
arch/arm/dts/usb_a9263.dts +0 -2
index bfc48a2..9adc12a 100644
@@ -127,8 +127,6 @@
 
 	gpio_keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 
 		user_pb {
 			label = "user_pb";
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 at91: fix devicetree warnings

Quoted 8 lines · Eugen Hristev

This commit fixes various devicetree warnings in the at91 devicetrees
like:
arch/arm/dts/sama5d36ek_cmp.dtb: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

These warnings make buildman report failed builds for most of at91 boards. Thus, fixing it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180911/efd1a575/attachment.sig>
#3 lore raw

PATCH 1/2 ARM: dts: Makefile: fix build for at91family

In reply to Eugen Hristev
Quoted 4 lines · Eugen Hristev

For at91family, makefile was building unwanted DTBs Moved them under specific target configuration.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180911/f72501c5/attachment.sig>