Skip to contentSkip to conversation

linux-libc-headers: Don't do useless configuration

PATCH Superseded Alexey Brodkin 2 participants 4 messages Sep 12, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-libc-headers: Don't do useless configuration

There's no point in configuring Linux kernel before headers installation.

Moreover in come cases it might lead to problems on kernels starting from 4.17 with architecture or platfrom sets CROSS_COMPILE variable automatically, see [1].

Also note Buildroot doesn't do that kind of confiuration as well, see [2].

[1] https://lkml.org/lkml/2018/9/12/486
[2] https://git.buildroot.org/buildroot/tree/package/linux-headers/linux-headers.mk#n106

---
 meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +0 -1
index 05c82558e653..1a365ddeb6a9 100644
@@ -54,7 +54,6 @@ S = "${WORKDIR}/linux-${PV}"
 EXTRA_OEMAKE = " HOSTCC="${BUILD_CC}" HOSTCPP="${BUILD_CPP}""
 
 do_configure() {
-	oe_runmake allnoconfig
 }
 
 do_compile () {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Alexey Brodkin

There's no point in configuring Linux kernel before headers installation.

At one point the headers install did not work with out a .config file, has that changed ?
if so then this is fine to remove it but this change needs to be done a bit differently if thats what it did in this task

remove do_configure and then add

do_configure[noexec] = "1"

Quoted 35 lines

Moreover in come cases it might lead to problems on kernels starting from 4.17 with architecture or platfrom sets CROSS_COMPILE variable automatically, see [1].

Also note Buildroot doesn't do that kind of confiuration as well, see [2].

[1] https://lkml.org/lkml/2018/9/12/486
[2] https://git.buildroot.org/buildroot/tree/package/linux-headers/linux-headers.mk#n106

---
 meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +0 -2
index 05c82558e653..1a365ddeb6a9 100644
@@ -54,7 +54,6 @@ S = "${WORKDIR}/linux-${PV}"
 EXTRA_OEMAKE = " HOSTCC="${BUILD_CC}" HOSTCPP="${BUILD_CPP}""
 
 do_configure() {
-       oe_runmake allnoconfig
 }
 
 do_compile () {
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

Hi Khem,

Quoted 9 lines · Khem Raj
Quoted 4 lines · Alexey Brodkin

There's no point in configuring Linux kernel before headers installation.

At one point the headers install did not work with out a .config file, has that changed ?

Well that's hard to tell as I have no idea when and what kind of breakage was seen :)

I'd say with up-to-date kernels it shouldn't happen and that's the point Masahiro-san made here: https://lkml.org/lkml/2018/9/12/678

Quoted 6 lines

if so then this is fine to remove it but this change needs to be done a bit differently if thats what it did in this task

remove do_configure and then add

do_configure[noexec] = "1"

Ok will do that. But why do we have 2 lines below:
------------------------------>8-------------------------- do_compile ()
{
} ------------------------------>8--------------------------

-Alexey

#3 lore raw
Quoted 11 lines · Alexey Brodkin

Hi Khem,

Quoted 7 lines · Khem Raj
Quoted 4 lines · Alexey Brodkin

There's no point in configuring Linux kernel before headers installation.

Quoted 9 lines
Quoted 2 lines

At one point the headers install did not work with out a .config file, has that changed ?

Well that's hard to tell as I have no idea when and what kind of breakage was seen :)

I'd say with up-to-date kernels it shouldn't happen and that's the point Masahiro-san made here: https://lkml.org/lkml/2018/9/12/678

We lock the kernel-headers anyway to if it is how it is in 4.18 we should be fine

Quoted 6 lines
Quoted 6 lines

if so then this is fine to remove it but this change needs to be done a bit differently if thats what it did in this task

remove do_configure and then add

Quoted 9 lines
Quoted 1 line

do_configure[noexec] = "1"

Ok will do that. But why do we have 2 lines below:
------------------------------>8-------------------------- do_compile ()
{
} ------------------------------>8--------------------------

you can change that too. Probably its there before noexec approach was adopted widely.

Quoted 1 line

-Alexey