Skip to contentSkip to conversation

kbuild: make missing $DEPMOD a Warning instead of an Error

PATCH New Maxim Zhukov 1 participant 1 message Sep 13, 2018 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: make missing $DEPMOD a Warning instead of an Error

From: Randy Dunlap <[email protected]>

[ Upstream commit 914b087ff9e0e9a399a4927fa30793064afc0178 ]

When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status:

Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package.

Change the Error to a Warning because "not all build hosts for cross compiling Linux are Linux systems and are able to provide a working port of depmod, especially at the file patch /sbin/depmod."

I.e., "make modules_install" may be used to copy/install the loadable modules files to a target directory on a build system and then transferred to an embedded device where /sbin/depmod is run instead of it being run on the build system.

Fixes 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
Cc Lucas De Marchi <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Michal Marek <[email protected]>
Cc Jessica Yu <[email protected]>
Cc Chih-Wei Huang <[email protected]>
---
 scripts/depmod.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/depmod.sh +2 -2
index f41b0a4b575c..cf5b2b24b3cf 100755
@@ -16,9 +16,9 @@ if ! test -r System.map ; then
 fi
 
 if [ -z $(command -v $DEPMOD) ]; then
-	echo "'make modules_install' requires $DEPMOD. Please install it." >&2
+	echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
 	echo "This is probably in the kmod package." >&2
-	exit 1
+	exit 0
 fi
 
 # older versions of depmod don't support -P <symbol-prefix>
Signature · 1 line
2.19.0