Skip to contentSkip to conversation

Reworked rk3288-tinker-s devicetree

PATCH Superseded Heiko Stuebner 5 participants 8 messages Sep 23, 2018 – Oct 8, 2018 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

v4 cover Reworked rk3288-tinker-s devicetree

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way later on. Biggest change is of course making patch 1 solely about moving the shared parts to the dtsi and adding the tinker-s.dts including the emmc in the second patch.

Apart from that you can also see some previously missing style-related fixes. For example patch subject lines are somewhat specific, to allow people browsing the git history to realize the core patch contents just from the "headline" and also use the "correct" prefixes which vary depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts" (change directory depending on location of the change of course), to see that arm32 dts use "ARM: dts: $soc-vendor: foo".

Also providing a commit message describing the individual change in a bit more detail is important.

The wifi patch is a different issue, so I'll reply there.

Heiko

David Summers (2):
ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
ARM: dts: rockchip: add rk3288-based Tinker board S

 .../devicetree/bindings/arm/rockchip.txt      |   4 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/rk3288-tinker-s.dts         |  26 +
 arch/arm/boot/dts/rk3288-tinker.dts           | 498 +----------------
 arch/arm/boot/dts/rk3288-tinker.dtsi          | 504 ++++++++++++++++++
 5 files changed, 537 insertions(+), 496 deletions(-)
 create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts
 create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi
Signature · 1 line
2.18.0
author maintainer
#1 lore raw

PATCH v4 1/2 ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi

From: David Summers <[email protected]>

Tinker Board and Tinker Board S share most of their components, so should also not replicate these for each variant.

So move them to a shared dtsi that then can get included by both boards.

---
 arch/arm/boot/dts/rk3288-tinker.dts  | 498 +-------------------------
 arch/arm/boot/dts/rk3288-tinker.dtsi | 504 +++++++++++++++++++++++++++
 2 files changed, 506 insertions(+), 496 deletions(-)
 create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi
arch/arm/boot/dts/rk3288-tinker.dts +2 -496
index ceade5962899..1e43527aa196 100644
@@ -5,503 +5,9 @@
 
 /dts-v1/;
 
-#include "rk3288.dtsi"
-#include <dt-bindings/input/input.h>
+#include "rk3288-tinker.dtsi"
 
 / {
-	model = "Rockchip RK3288 Tinker Board";
+	model = "Rockchip RK3288 Asus Tinker Board";
 	compatible = "asus,rk3288-tinker", "rockchip,rk3288";
-
-	chosen {
-		stdout-path = "serial2:115200n8";
-	};
-
-	memory {
-		reg = <0x0 0x0 0x0 0x80000000>;
-		device_type = "memory";
-	};
-
-	ext_gmac: external-gmac-clock {
-		compatible = "fixed-clock";
-		#clock-cells = <0>;
-		clock-frequency = <125000000>;
-		clock-output-names = "ext_gmac";
-	};
-
-	gpio-keys {
-		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
-		autorepeat;
-
-		pinctrl-names = "default";
-		pinctrl-0 = <&pwrbtn>;
-
-		button at 0 {
-			gpios = <&gpio0 RK_PA5 GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_POWER>;
-			label = "GPIO Key Power";
-			linux,input-type = <1>;
-			wakeup-source;
-			debounce-interval = <100>;
-		};
-	};
-
-	gpio-leds {
-		compatible = "gpio-leds";
-
-		act-led {
-			gpios=<&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger="mmc0";
-		};
-
-		heartbeat-led {
-			gpios=<&gpio1 RK_PD1 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger="heartbeat";
-		};
-
-		pwr-led {
-			gpios = <&gpio0 RK_PA3 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-on";
-		};
-	};
-
-	sound {
-		compatible = "simple-audio-card";
-		simple-audio-card,format = "i2s";
-		simple-audio-card,name = "rockchip,tinker-codec";
-		simple-audio-card,mclk-fs = <512>;
-
-		simple-audio-card,codec {
-			sound-dai = <&hdmi>;
-		};
-
-		simple-audio-card,cpu {
-			sound-dai = <&i2s>;
-		};
-	};
-
-	vcc_sys: vsys-regulator {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc_sys";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
-		regulator-boot-on;
-	};
-
-	vcc_sd: sdmmc-regulator {
-		compatible = "regulator-fixed";
-		gpio = <&gpio7 11 GPIO_ACTIVE_LOW>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&sdmmc_pwr>;
-		regulator-name = "vcc_sd";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-		startup-delay-us = <100000>;
-		vin-supply = <&vcc_io>;
-	};
-};
-
-&cpu0 {
-	cpu0-supply = <&vdd_cpu>;
-};
-
-&gmac {
-	assigned-clocks = <&cru SCLK_MAC>;
-	assigned-clock-parents = <&ext_gmac>;
-	clock_in_out = "input";
-	phy-mode = "rgmii";
-	phy-supply = <&vcc33_lan>;
-	pinctrl-names = "default";
-	pinctrl-0 = <&rgmii_pins>;
-	snps,reset-gpio = <&gpio4 7 0>;
-	snps,reset-active-low;
-	snps,reset-delays-us = <0 10000 1000000>;
-	tx_delay = <0x30>;
-	rx_delay = <0x10>;
-	status = "ok";
-};
-
-&gpu {
-	mali-supply = <&vdd_gpu>;
-	status = "okay";
-};
-
-&hdmi {
-	ddc-i2c-bus = <&i2c5>;
-	status = "okay";
-};
-
-&i2c0 {
-	clock-frequency = <400000>;
-	status = "okay";
-
-	rk808: pmic at 1b {
-		compatible = "rockchip,rk808";
-		reg = <0x1b>;
-		interrupt-parent = <&gpio0>;
-		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
-		#clock-cells = <1>;
-		clock-output-names = "xin32k", "rk808-clkout2";
-		dvs-gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
-				<&gpio0 12 GPIO_ACTIVE_HIGH>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&pmic_int &global_pwroff &dvs_1 &dvs_2>;
-		rockchip,system-power-controller;
-		wakeup-source;
-
-		vcc1-supply = <&vcc_sys>;
-		vcc2-supply = <&vcc_sys>;
-		vcc3-supply = <&vcc_sys>;
-		vcc4-supply = <&vcc_sys>;
-		vcc6-supply = <&vcc_sys>;
-		vcc7-supply = <&vcc_sys>;
-		vcc8-supply = <&vcc_io>;
-		vcc9-supply = <&vcc_io>;
-		vcc10-supply = <&vcc_io>;
-		vcc11-supply = <&vcc_sys>;
-		vcc12-supply = <&vcc_io>;
-		vddio-supply = <&vcc_io>;
-
-		regulators {
-			vdd_cpu: DCDC_REG1 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <1350000>;
-				regulator-name = "vdd_arm";
-				regulator-ramp-delay = <6000>;
-				regulator-state-mem {
-					regulator-off-in-suspend;
-				};
-			};
-
-			vdd_gpu: DCDC_REG2 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <850000>;
-				regulator-max-microvolt = <1250000>;
-				regulator-name = "vdd_gpu";
-				regulator-ramp-delay = <6000>;
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1000000>;
-				};
-			};
-
-			vcc_ddr: DCDC_REG3 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-name = "vcc_ddr";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-				};
-			};
-
-			vcc_io: DCDC_REG4 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vcc_io";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3300000>;
-				};
-			};
-
-			vcc18_ldo1: LDO_REG1 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc18_ldo1";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vcc33_mipi: LDO_REG2 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vcc33_mipi";
-				regulator-state-mem {
-					regulator-off-in-suspend;
-				};
-			};
-
-			vdd_10: LDO_REG3 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1000000>;
-				regulator-max-microvolt = <1000000>;
-				regulator-name = "vdd_10";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1000000>;
-				};
-			};
-
-			vcc18_codec: LDO_REG4 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc18_codec";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vccio_sd: LDO_REG5 {
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-name = "vccio_sd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <3300000>;
-				};
-			};
-
-			vdd10_lcd: LDO_REG6 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1000000>;
-				regulator-max-microvolt = <1000000>;
-				regulator-name = "vdd10_lcd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1000000>;
-				};
-			};
-
-			vcc_18: LDO_REG7 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc_18";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vcc18_lcd: LDO_REG8 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <1800000>;
-				regulator-name = "vcc18_lcd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-					regulator-suspend-microvolt = <1800000>;
-				};
-			};
-
-			vcc33_sd: SWITCH_REG1 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-name = "vcc33_sd";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-				};
-			};
-
-			vcc33_lan: SWITCH_REG2 {
-				regulator-always-on;
-				regulator-boot-on;
-				regulator-name = "vcc33_lan";
-				regulator-state-mem {
-					regulator-on-in-suspend;
-				};
-			};
-		};
-	};
-};
-
-&i2c2 {
-	status = "okay";
-};
-
-&i2c5 {
-	status = "okay";
-};
-
-&i2s {
-	#sound-dai-cells = <0>;
-	status = "okay";
-};
-
-&io_domains {
-	status = "okay";
-
-	sdcard-supply = <&vccio_sd>;
-};
-
-&pinctrl {
-	pcfg_pull_none_drv_8ma: pcfg-pull-none-drv-8ma {
-		drive-strength = <8>;
-	};
-
-	pcfg_pull_up_drv_8ma: pcfg-pull-up-drv-8ma {
-		bias-pull-up;
-		drive-strength = <8>;
-	};
-
-	backlight {
-		bl_en: bl-en {
-			rockchip,pins = <7 2 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-
-	buttons {
-		pwrbtn: pwrbtn {
-			rockchip,pins = <0 5 RK_FUNC_GPIO &pcfg_pull_up>;
-		};
-	};
-
-	eth_phy {
-		eth_phy_pwr: eth-phy-pwr {
-			rockchip,pins = <0 6 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-
-	pmic {
-		pmic_int: pmic-int {
-			rockchip,pins = <RK_GPIO0 4 RK_FUNC_GPIO \
-					&pcfg_pull_up>;
-		};
-
-		dvs_1: dvs-1 {
-			rockchip,pins = <RK_GPIO0 11 RK_FUNC_GPIO \
-					&pcfg_pull_down>;
-		};
-
-		dvs_2: dvs-2 {
-			rockchip,pins = <RK_GPIO0 12 RK_FUNC_GPIO \
-					&pcfg_pull_down>;
-		};
-	};
-
-	sdmmc {
-		sdmmc_bus4: sdmmc-bus4 {
-			rockchip,pins = <6 16 RK_FUNC_1 &pcfg_pull_up_drv_8ma>,
-					<6 17 RK_FUNC_1 &pcfg_pull_up_drv_8ma>,
-					<6 18 RK_FUNC_1 &pcfg_pull_up_drv_8ma>,
-					<6 19 RK_FUNC_1 &pcfg_pull_up_drv_8ma>;
-		};
-
-		sdmmc_clk: sdmmc-clk {
-			rockchip,pins = <6 20 RK_FUNC_1 \
-					&pcfg_pull_none_drv_8ma>;
-		};
-
-		sdmmc_cmd: sdmmc-cmd {
-			rockchip,pins = <6 21 RK_FUNC_1 &pcfg_pull_up_drv_8ma>;
-		};
-
-		sdmmc_pwr: sdmmc-pwr {
-			rockchip,pins = <7 11 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-
-	usb {
-		host_vbus_drv: host-vbus-drv {
-			rockchip,pins = <0 14 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-
-		pwr_3g: pwr-3g {
-			rockchip,pins = <7 8 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-};
-
-&pwm0 {
-	status = "okay";
-};
-
-&saradc {
-	vref-supply = <&vcc18_ldo1>;
-	status ="okay";
-};
-
-&sdmmc {
-	bus-width = <4>;
-	cap-mmc-highspeed;
-	cap-sd-highspeed;
-	card-detect-delay = <200>;
-	disable-wp;			/* wp not hooked up */
-	pinctrl-names = "default";
-	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
-	status = "okay";
-	vmmc-supply = <&vcc33_sd>;
-	vqmmc-supply = <&vccio_sd>;
-};
-
-&tsadc {
-	rockchip,hw-tshut-mode = <1>; /* tshut mode 0:CRU 1:GPIO */
-	rockchip,hw-tshut-polarity = <1>; /* tshut polarity 0:LOW 1:HIGH */
-	status = "okay";
-};
-
-&uart0 {
-	status = "okay";
-};
-
-&uart1 {
-	status = "okay";
-};
-
-&uart2 {
-	status = "okay";
-};
-
-&uart3 {
-	status = "okay";
-};
-
-&uart4 {
-	status = "okay";
-};
-
-&usbphy {
-	status = "okay";
-};
-
-&usb_host0_ehci {
-	status = "okay";
-};
-
-&usb_host1 {
-	status = "okay";
-};
-
-&usb_otg {
-	status= "okay";
-};
-
-&vopb {
-	status = "okay";
-};
-
-&vopb_mmu {
-	status = "okay";
-};
-
-&vopl {
-	status = "okay";
-};
-
-&vopl_mmu {
-	status = "okay";
-};
-
-&wdt {
-	status = "okay";
 };
arch/arm/boot/dts/rk3288-tinker.dtsi new file +502 -0

502 lines not on this page · raw message

Signature · 1 line
2.18.0
author maintainer
#2 lore raw

PATCH v4 2/2 ARM: dts: rockchip: add rk3288-based Tinker board S

In reply to Heiko Stuebner

From: David Summers <[email protected]>

Add the actual dts for the tinker board S, which brings its own emmc device, not therefore not requiring an sd-card to boot.

---
 .../devicetree/bindings/arm/rockchip.txt      |  4 +++
 arch/arm/boot/dts/Makefile                    |  1 +
 arch/arm/boot/dts/rk3288-tinker-s.dts         | 26 +++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts
Documentation/devicetree/bindings/arm/rockchip.txt +4 -0
index 6bb80f2b7c5d..624253fee7d5 100644
@@ -17,6 +17,10 @@ Rockchip platforms device tree bindings
     Required root node properties:
       - compatible = "asus,rk3288-tinker", "rockchip,rk3288";
 
+- Asus Tinker board S
+    Required root node properties:
+      - compatible = "asus,rk3288-tinker-s", "rockchip,rk3288";
+
 - Kylin RK3036 board:
     Required root node properties:
       - compatible = "rockchip,kylin-rk3036", "rockchip,rk3036";
arch/arm/boot/dts/Makefile +1 -0
index b5bd3de87c33..dc86080c60e3 100644
@@ -864,6 +864,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rk3288-r89.dtb \
 	rk3288-rock2-square.dtb \
 	rk3288-tinker.dtb \
+	rk3288-tinker-s.dtb \
 	rk3288-veyron-brain.dtb \
 	rk3288-veyron-jaq.dtb \
 	rk3288-veyron-jerry.dtb \
arch/arm/boot/dts/rk3288-tinker-s.dts new file +26 -0
new file mode 100644
index 000000000000..37093922b482
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd.
+ */
+
+/dts-v1/;
+
+#include "rk3288-tinker.dtsi"
+
+/ {
+	model = "Rockchip RK3288 Asus Tinker Board S";
+	compatible = "asus,rk3288-tinker-s", "rockchip,rk3288";
+};
+
+&emmc {
+	bus-width = <8>;
+	cap-mmc-highspeed;
+	disable-wp;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_pwr &emmc_bus8>;
+	max-frequency = <150000000>;
+	mmc-hs200-1_8v;
+	mmc-ddr-1_8v;
+	status = "okay";
+};
Signature · 1 line
2.18.0
maintainer
#3 lore raw

PATCH v4 2/2 ARM: dts: rockchip: add rk3288-based Tinker board S

Quoted 5 lines · Heiko Stuebner

From: David Summers <[email protected]>

Add the actual dts for the tinker board S, which brings its own emmc device, not therefore not requiring an sd-card to boot.

Quoted 9 lines
---
 .../devicetree/bindings/arm/rockchip.txt      |  4 +++
 arch/arm/boot/dts/Makefile                    |  1 +
 arch/arm/boot/dts/rk3288-tinker-s.dts         | 26 +++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts
#4 lore raw

v4 cover Reworked rk3288-tinker-s devicetree

In reply to Heiko Stuebner

Thanks Heiko,

Yes I like the refactoring. Patch 1 effectively making no changes, but rearranging files so the tinker board device tree can be used as a template for others. Patch 2 then adding the Tinker Board S, with the only major change being adding the eMMC - and that change is relatively simple.

These two patches by themselves are enough to get the Tinker Board S functional, and that they should be uncontroversial hopefully means they will go through.

The WiFi change, I also had my doubts over - hence why it was a separate patch. For what it is worth, it was what was needed to get the WiFi up
on: https://paste.pound-python.org/show/SFdoQHC3z2hvoufdAmxs/ - hence why submitted.

My own problems with it:
1) I believe that the tinker board has wi-fi in which case it should be common - but know of no one with a plain tinker board - hence why to post, so if someone can test. Then if so apply to the tinker-board.dtsi
2) Parts of the patch are clear (e.g. enabling sdio0 - as that is how the wifi data is wired up); but other parts (e.g. uart0 pinctrl, and the sdio_pwrseq) and although these seem needed - the connection is vague to the WiFi. What can I say, but these were in the original ASUS patch.

So on WiFi I can understand if discussion is needed.

Regards,

David.

P.S. and thanks for the git commands - first time I've used git in anger, e.g. hadn't realised the importance of the "git commit" message for how it is used in "git format-patch". I'll get better at this with time ....

Quoted 39 lines · Heiko Stuebner

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way later on. Biggest change is of course making patch 1 solely about moving the shared parts to the dtsi and adding the tinker-s.dts including the emmc in the second patch.

Apart from that you can also see some previously missing style-related fixes. For example patch subject lines are somewhat specific, to allow people browsing the git history to realize the core patch contents just from the "headline" and also use the "correct" prefixes which vary depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts" (change directory depending on location of the change of course), to see that arm32 dts use "ARM: dts: $soc-vendor: foo".

Also providing a commit message describing the individual change in a bit more detail is important.

The wifi patch is a different issue, so I'll reply there.

Heiko

David Summers (2):
ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
ARM: dts: rockchip: add rk3288-based Tinker board S

  .../devicetree/bindings/arm/rockchip.txt      |   4 +
  arch/arm/boot/dts/Makefile                    |   1 +
  arch/arm/boot/dts/rk3288-tinker-s.dts         |  26 +
  arch/arm/boot/dts/rk3288-tinker.dts           | 498 +----------------
  arch/arm/boot/dts/rk3288-tinker.dtsi          | 504 ++++++++++++++++++
  5 files changed, 537 insertions(+), 496 deletions(-)

create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi

author maintainer
#5 lore raw

v4 cover Reworked rk3288-tinker-s devicetree

In reply to Heiko Stuebner

Am Sonntag, 23. September 2018, 13:38:05 CEST schrieb Heiko Stuebner:

Quoted 21 lines

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way later on. Biggest change is of course making patch 1 solely about moving the shared parts to the dtsi and adding the tinker-s.dts including the emmc in the second patch.

Apart from that you can also see some previously missing style-related fixes. For example patch subject lines are somewhat specific, to allow people browsing the git history to realize the core patch contents just from the "headline" and also use the "correct" prefixes which vary depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts" (change directory depending on location of the change of course), to see that arm32 dts use "ARM: dts: $soc-vendor: foo".

Also providing a commit message describing the individual change in a bit more detail is important.

Quoted 8 lines

The wifi patch is a different issue, so I'll reply there.

Heiko

David Summers (2):
ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
ARM: dts: rockchip: add rk3288-based Tinker board S

applied for 4.20

A message that is not in the archive (sent off-list or not yet received): 20180923113807.11558-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org

#7 lore raw

Hi Heiko,

Re: http://lists.infradead.org/pipermail/linux-rockchip/2018-September/021762.html

We've just had another use on Arm Arch interested in installing on a Tinker Board. So this gives the chance to test the wi-fi patch on a Tinker Board as well as Tinker Board S; so give better of where to apply the patch.

So half thinking of having another go at the wi-fi patch.

But should first check, what problems did you see with the patch? Let me know and I'll see if I can incorporate in patch update. As much as anything, I want to minimize the number of tb{s}.dtb that I send out to arch arm users, as testing before submission. E.g. the users have limited tolerance, may be able to try a few device trees with them - but if it takes too many iterations, they will just switch to linarno kernel ...

Ta,

David.

Quoted 39 lines · Heiko Stuebner

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way later on. Biggest change is of course making patch 1 solely about moving the shared parts to the dtsi and adding the tinker-s.dts including the emmc in the second patch.

Apart from that you can also see some previously missing style-related fixes. For example patch subject lines are somewhat specific, to allow people browsing the git history to realize the core patch contents just from the "headline" and also use the "correct" prefixes which vary depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts" (change directory depending on location of the change of course), to see that arm32 dts use "ARM: dts: $soc-vendor: foo".

Also providing a commit message describing the individual change in a bit more detail is important.

The wifi patch is a different issue, so I'll reply there.

Heiko

David Summers (2):
ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
ARM: dts: rockchip: add rk3288-based Tinker board S

  .../devicetree/bindings/arm/rockchip.txt      |   4 +
  arch/arm/boot/dts/Makefile                    |   1 +
  arch/arm/boot/dts/rk3288-tinker-s.dts         |  26 +
  arch/arm/boot/dts/rk3288-tinker.dts           | 498 +----------------
  arch/arm/boot/dts/rk3288-tinker.dtsi          | 504 ++++++++++++++++++
  5 files changed, 537 insertions(+), 496 deletions(-)

create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi

A message that is not in the archive (sent off-list or not yet received): 5dc8cdc9-20d5-bafa-3693-67ec09577234-8lkWs+DogrrqRUWtDFdff/[email protected]

#9 lore raw

Hi David,

Am Samstag, 6. Oktober 2018, 14:54:37 CEST schrieb David Summers:

Quoted 10 lines

Hi Heiko,

Re:
http://lists.infradead.org/pipermail/linux-rockchip/2018-September/021762.html

We've just had another use on Arm Arch interested in installing on a Tinker Board. So this gives the chance to test the wi-fi patch on a Tinker Board as well as Tinker Board S; so give better of where to apply the patch.

Quoted 8 lines

So half thinking of having another go at the wi-fi patch.

But should first check, what problems did you see with the patch? Let me know and I'll see if I can incorporate in patch update. As much as anything, I want to minimize the number of tb{s}.dtb that I send out to arch arm users, as testing before submission. E.g. the users have limited tolerance, may be able to try a few device trees with them - but if it takes too many iterations, they will just switch to linarno kernel ...

I did seem to have procrastinated a bit with my reply there, sorry about that. I've replied to the original patch now.

Heiko

Quoted 47 lines

Ta,

David.

Quoted 39 lines · Heiko Stuebner

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way later on. Biggest change is of course making patch 1 solely about moving the shared parts to the dtsi and adding the tinker-s.dts including the emmc in the second patch.

Apart from that you can also see some previously missing style-related fixes. For example patch subject lines are somewhat specific, to allow people browsing the git history to realize the core patch contents just from the "headline" and also use the "correct" prefixes which vary depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts" (change directory depending on location of the change of course), to see that arm32 dts use "ARM: dts: $soc-vendor: foo".

Also providing a commit message describing the individual change in a bit more detail is important.

The wifi patch is a different issue, so I'll reply there.

Heiko

David Summers (2):
ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
ARM: dts: rockchip: add rk3288-based Tinker board S

  .../devicetree/bindings/arm/rockchip.txt      |   4 +
  arch/arm/boot/dts/Makefile                    |   1 +
  arch/arm/boot/dts/rk3288-tinker-s.dts         |  26 +
  arch/arm/boot/dts/rk3288-tinker.dts           | 498 +----------------
  arch/arm/boot/dts/rk3288-tinker.dtsi          | 504 ++++++++++++++++++
  5 files changed, 537 insertions(+), 496 deletions(-)

create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi