Skip to contentSkip to conversation

ARM: dts: gta04: add serial console wakeup irq

PATCH In review Andreas Kemnade 2 participants 4 messages Sep 23, 2018 – Sep 25, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: gta04: add serial console wakeup irq

This enables the possibility to have more aggressive runtime pm by providing proper wakeup irq for the serial console.

---
 arch/arm/boot/dts/omap3-gta04.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
index ac830b917776..edb7cdd33632 100644
@@ -493,6 +493,7 @@
 &uart3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart3_pins>;
+	interrupts-extended = <&intc 74 &omap3_pmx_core OMAP3_UART3_RX>;
 };
 
 &charger {
Signature · 1 line
2.11.0
#1 lore raw
Quoted 2 lines · Andreas Kemnade

This enables the possibility to have more aggressive runtime pm by providing proper wakeup irq for the serial console.

Thanks applying to omap-for-v4.20/dt.

FYI, you can now grep wake /proc/interrupts and see the wakeirq counts increase when they trigger. Might be handy for debugging PM stuff.

Regards,

Tony

#2 lore raw

Hi Tony,

Quoted 10 lines · On Mon, 24 Sep 2018 15:03:45 -0700 Tony Lindgren <[email protected]> wrote:
Quoted 2 lines · Andreas Kemnade

This enables the possibility to have more aggressive runtime pm by providing proper wakeup irq for the serial console.

Thanks applying to omap-for-v4.20/dt.

FYI, you can now grep wake /proc/interrupts and see the wakeirq counts increase when they trigger. Might be handy for debugging PM stuff.

thanks for that information, you also had a patch for checking pm which was explicitely marked as not-to-merge. Is there any up-to-date version of it?

Well, for debugging I check first average currents via bq27000 attached to omap_hdq. omap_hdq gets stuck after first transaction after idling uarts which does not happen when CM_AUTOIDLE1_CORE.AUTO_HDQ is cleared. Reloading the omap_hdq module to try to fix things makes w1 really freak out (patch already sent for that). Well, will do some rtfm and hopefully come back with a patch. afaicr there was something special...
The result are power management problem in /dev/brain ;-)

Regards,
Andreas

#3 lore raw
Quoted 11 lines · Andreas Kemnade

Hi Tony,

Quoted 6 lines · On Mon, 24 Sep 2018 15:03:45 -0700 Tony Lindgren <[email protected]> wrote:
Quoted 2 lines · Andreas Kemnade

This enables the possibility to have more aggressive runtime pm by providing proper wakeup irq for the serial console.

Thanks applying to omap-for-v4.20/dt.

Quoted 7 lines
Quoted 4 lines

FYI, you can now grep wake /proc/interrupts and see the wakeirq counts increase when they trigger. Might be handy for debugging PM stuff.

thanks for that information, you also had a patch for checking pm which was explicitely marked as not-to-merge. Is there any up-to-date version of it?

It's still the same so no updates to it.

Quoted 7 lines

Well, for debugging I check first average currents via bq27000 attached to omap_hdq. omap_hdq gets stuck after first transaction after idling uarts which does not happen when CM_AUTOIDLE1_CORE.AUTO_HDQ is cleared. Reloading the omap_hdq module to try to fix things makes w1 really freak out (patch already sent for that). Well, will do some rtfm and hopefully come back with a patch. afaicr there was something special...

Hmm sounds like drivers/w1/masters/omap_hdq.c needs to implement PM runtime calls, it's probably just enabled because of only needing the interconnect fck that the uart happens to keep enabled.

Quoted 1 line

The result are power management problem in /dev/brain ;-)

:)

Tony