staging: axis-fifo: Remove parentheses in axis-fifo.c
PATCH 1/1 staging: axis-fifo: Remove parentheses in axis-fifo.c
staging: axis-fifo: remove parentheses in axis-fifo.c
Remove parentheses from the end of line and conform to the coding style guidelines. Reported by checkpatch.
Add an extra space to the function arguments to fix indentation.
--- drivers/staging/axis-fifo/axis-fifo.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +10 -10
@@ -364,11 +364,11 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,* if nothing is currently available */ spin_lock_irq (&fifo->read_queue_lock); - ret =wait_event_interruptible_lock_irq_timeout ( - fifo->read_queue, -ioread32 (fifo->base_addr +XLLF_RDFO_OFFSET ), - fifo->read_queue_lock, - (read_timeout >=0 ) ?msecs_to_jiffies (read_timeout) : + ret =wait_event_interruptible_lock_irq_timeout + (fifo->read_queue, +ioread32 (fifo->base_addr +XLLF_RDFO_OFFSET ), + fifo->read_queue_lock, + (read_timeout >=0 ) ?msecs_to_jiffies (read_timeout) :MAX_SCHEDULE_TIMEOUT );spin_unlock_irq (&fifo->read_queue_lock);
@@ -482,12 +482,12 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,* currently enough room in the fifo */ spin_lock_irq (&fifo->write_queue_lock); - ret =wait_event_interruptible_lock_irq_timeout ( - fifo->write_queue, -ioread32 (fifo->base_addr +XLLF_TDFV_OFFSET ) + ret =wait_event_interruptible_lock_irq_timeout + (fifo->write_queue, +ioread32 (fifo->base_addr +XLLF_TDFV_OFFSET ) >= words_to_write, - fifo->write_queue_lock, - (write_timeout >=0 ) ?msecs_to_jiffies (write_timeout) : + fifo->write_queue_lock, + (write_timeout >=0 ) ?msecs_to_jiffies (write_timeout) :MAX_SCHEDULE_TIMEOUT );spin_unlock_irq (&fifo->write_queue_lock);
Signature · 1 line
2.19.0
Quoted 1 line · Ioannis Valasakis
staging: axis-fifo: remove parentheses in
axis-fifo.c
This line is not required. Subject already states it.
Quoted 8 lines
Remove parentheses from the end of line and conform to the coding style guidelines. Reported by checkpatch.
Add an extra space to the function arguments to fix indentation.
Signed-off-by Ioannis Valasakis <[email protected]>---
New version with changelog should be written here, just right below the ---
v2: fixed ... ..
Also, subject should be:
[PATCH v2] staging: axis-fifo: Remove parentheses in axis-fifo.c
I see patches being sent through Mutt and you can easily send using git send-email instead.
Often times configuring Mutt to the right config is difficult for newbies.
Quoted 11 lines
drivers/staging/axis-fifo/axis-fifo.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)drivers/staging/axis-fifo/axis-fifo.c +0
-0@@ -364,11 +364,11 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,* if nothing is currently available */ spin_lock_irq (&fifo->read_queue_lock);
drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char __user *buf, · line 371
Quoted 10 lines
drivers/staging/axis-fifo/axis-fifo.c +5
-5- ret = wait_event_interruptible_lock_irq_timeout( - fifo->read_queue, - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), - fifo->read_queue_lock, - (read_timeout >= 0) ? msecs_to_jiffies(read_timeout) : + ret = wait_event_interruptible_lock_irq_timeout + (fifo->read_queue, + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), + fifo->read_queue_lock, + (read_timeout >= 0) ? msecs_to_jiffies(read_timeout) :
I don't really like this change.
But anyway, wait for the maintainer to reply.
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Quoted 14 lines · Himanshu Jha
Quoted 1 line · Ioannis Valasakis
staging: axis-fifo: remove parentheses in
axis-fifo.cThis line is not required. Subject already states it.
Quoted 8 lines
Remove parentheses from the end of line and conform to the coding style guidelines. Reported by checkpatch.
Add an extra space to the function arguments to fix indentation.
Signed-off-by Ioannis Valasakis <[email protected]>---
Quoted 8 lines
New version with changelog should be written here, just right below the
---v2: fixed ... ..
Also, subject should be:
[PATCH v2] staging: axis-fifo: Remove parentheses in
axis-fifo.c
Thank you Himanshu, I wasn't sure how I need to note that this is a different patch.
Quoted 4 lines
I see patches being sent through Mutt and you can easily send using
git send-emailinstead.
Actually it was easier for me to configure mutt with my own mail domain than git send-email. If you reckon that's a best practice though I may consider it.
Quoted 3 lines
Often times configuring Mutt to the right config is difficult for newbies.
Would you have any recommendation on setting up the mutt as to be helpful for my patches?
Quoted 31 lines
Quoted 11 lines
drivers/staging/axis-fifo/axis-fifo.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)drivers/staging/axis-fifo/axis-fifo.c +0
-0@@ -364,11 +364,11 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,* if nothing is currently available */ spin_lock_irq (&fifo->read_queue_lock);drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char __user *buf, · line 371
Quoted 10 lines
drivers/staging/axis-fifo/axis-fifo.c +5
-5- ret = wait_event_interruptible_lock_irq_timeout( - fifo->read_queue, - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), - fifo->read_queue_lock, - (read_timeout >= 0) ? msecs_to_jiffies(read_timeout) : + ret = wait_event_interruptible_lock_irq_timeout + (fifo->read_queue, + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), + fifo->read_queue_lock, + (read_timeout >= 0) ? msecs_to_jiffies(read_timeout) :I don't really like this change.
But anyway, wait for the maintainer to reply.Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Quoted 28 lines · Ioannis Valasakis
Quoted 14 lines · Himanshu Jha
Quoted 1 line · Ioannis Valasakis
staging: axis-fifo: remove parentheses in
axis-fifo.cThis line is not required. Subject already states it.
Quoted 8 lines
Remove parentheses from the end of line and conform to the coding style guidelines. Reported by checkpatch.
Add an extra space to the function arguments to fix indentation.
Signed-off-by Ioannis Valasakis <[email protected]>---
Quoted 8 lines
New version with changelog should be written here, just right below the
---v2: fixed ... ..
Also, subject should be:
[PATCH v2] staging: axis-fifo: Remove parentheses in
axis-fifo.cThank you Himanshu, I wasn't sure how I need to note that this is a different patch.
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
I see patches being sent through Mutt and you can easily send using
git send-emailinstead.Actually it was easier for me to configure mutt with my own mail domain than git send-email. If you reckon that's a best practice though I may consider it.
Well, sending patches via mutt is an old way of doing things, and I rarely see anyone using it.
Quoted 6 lines
Quoted 3 lines
Often times configuring Mutt to the right config is difficult for newbies.
Would you have any recommendation on setting up the mutt as to be helpful for my patches?
"... helpful for patches" ?
No.
It is just an email client, don't waste your time on configuring it.
On the other hand, maintainers use numerous config to test/apply and automate patches *within* mutt. But that is not your current goal!
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology