staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
PATCH v5 1/1 staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
---
changes in v5:
-Fixed Change log
-Change in subject line.Do not send as 'Re:'
changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
to fix checkpatch Error.
changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
Adjust the chars to 75 per line
-Modified log message.
-Added change log.
changes in v2:
-comedi_pci_auto_config() function prototype is exceeds
75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
characters. Modified contents to adjust 75 chars per line.
drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/comedi_pci.h +1 -1
@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI * driver * @__comedi_driver: comedi_driver struct * @__pci_driver: pci_driver struct
Signature · 1 line
2.17.1
Review
Quoted 8 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Signed-off-by Bhanusree Pola <[email protected]>---
changes in v5:
(quoted diff) +0
-2-Fixed Change log -Change in subject line.Do not send as 'Re:'
It doesn't matter here, because this text will go away, but please get in the habit of putting at least one space after punctuation. That is:
Change in subject line. Do not send as 'Re:'
Then things don't run together, and it is easier to read.
julia
Quoted 45 lines
changes in v4:
-Remove Whitespace in comment section ofmodule_comedi_pci_driver()
to fix checkpatch Error.changes in v3:
(quoted diff) +0
-3-Comment section of module_pci_driver() exceeds 75 characters. Adjust the chars to 75 per line -Modified log message. -Added change log.changes in v2:
(quoted diff) +0
-2-comedi_pci_auto_config() function prototype is exceeds 75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses. -Comment section of module_comedi_pci_driver() exceeds 75 characters. Modified contents to adjust 75 chars per line. drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/comedi/comedi_pci.h +1
-2@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI * driver * @__comedi_driver: comedi_driver struct * @__pci_driver: pci_driver struct -- 2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006190246.GA14037%40veda-VGN-CS3AGH-R.
For more options, visit https://groups.google.com/d/optout.
Quoted 14 lines · Julia Lawall
Review
Quoted 8 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Signed-off-by Bhanusree Pola <[email protected]>---
changes in v5:
(quoted diff) +0
-2-Fixed Change log -Change in subject line.Do not send as 'Re:'It doesn't matter here, because this text will go away, but please get in the habit of putting at least one space after punctuation. That is:
Quoted 3 lines
Change in subject line. Do not send as 'Re:'
Then things don't run together, and it is easier to read.
It is taking time for me to understand. Sometimes I'm doing it in haste. Thank you for making me understand.
Quoted 35 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Signed-off-by Bhanusree Pola <[email protected]>---
changes in v5:
(quoted diff) +0
-2-Fixed Change log -Change in subject line.Do not send as 'Re:'changes in v4:
-Remove Whitespace in comment section ofmodule_comedi_pci_driver()
to fix checkpatch Error.changes in v3:
(quoted diff) +0
-3-Comment section of module_pci_driver() exceeds 75 characters. Adjust the chars to 75 per line -Modified log message. -Added change log.changes in v2:
(quoted diff) +0
-2-comedi_pci_auto_config() function prototype is exceeds 75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses. -Comment section of module_comedi_pci_driver() exceeds 75 characters. Modified contents to adjust 75 chars per line. drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/comedi/comedi_pci.h +0
-0
drivers/staging/comedi/comedi_pci.h void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, · line 45
Quoted 5 lines
drivers/staging/comedi/comedi_pci.h +1
-1@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI
The original line is:
* module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
The patch looks dubious to me.
Always base your work on latest -next tree.
https://www.kernel.org/doc/man-pages/linux-next.html
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
Quoted 44 lines · Himanshu Jha
Quoted 35 lines · Bhanusree Pola
Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
Signed-off-by Bhanusree Pola <[email protected]>---
changes in v5:
(quoted diff) +0
-2-Fixed Change log -Change in subject line.Do not send as 'Re:'changes in v4:
-Remove Whitespace in comment section ofmodule_comedi_pci_driver()
to fix checkpatch Error.changes in v3:
(quoted diff) +0
-3-Comment section of module_pci_driver() exceeds 75 characters. Adjust the chars to 75 per line -Modified log message. -Added change log.changes in v2:
(quoted diff) +0
-2-comedi_pci_auto_config() function prototype is exceeds 75 characters per line. Adjust to 75 chars to improve readability and also adjust the arguments to match open parantheses. -Comment section of module_comedi_pci_driver() exceeds 75 characters. Modified contents to adjust 75 chars per line. drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/comedi/comedi_pci.h +0
-0drivers/staging/comedi/comedi_pci.h void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, · line 45
Quoted 5 lines
drivers/staging/comedi/comedi_pci.h +1
-1@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver, struct pci_driver *pci_driver);/** -* module_comedi_pci_driver()-Helper macro for registering a comedi PCI +* module_comedi_pci_driver()-Helper macro for registering a comedi PCI The original line is:
Quoted 8 lines
*
module_comedi_pci_driver()- Helper macro for registering a comedi PCI driverThe patch looks dubious to me.
Always base your work on latest -next tree.
https://www.kernel.org/doc/man-pages/linux-next.html
Bhanusree,
I think you made your new patch on top of your old one.
julia
Quoted 14 lines
--
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006193150.GA8922%40himanshu-Vostro-3559.
For more options, visit https://groups.google.com/d/optout.