staging: comedi: comedi_pci.h: prefer a maximum 75 chars per line
PATCH 1/1 staging: comedi: comedi_pci.h: prefer a maximum 75 chars per line
comedi_pci_auto_config() function prototype is exceeding more than 75 characters per line. Adjusted to less than 75 characters to improve readability.
Signed-off-by Bhanusree Pola <[email protected]>
--- drivers/staging/comedi/comedi_pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/comedi_pci.h +2 -2
@@ -31,8 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);void comedi_pci_disable (struct comedi_device *dev);void comedi_pci_detach (struct comedi_device *dev); -int comedi_pci_auto_config (struct pci_dev *pcidev,struct comedi_driver *driver, -unsigned long context); +int comedi_pci_auto_config (struct pci_dev *pcidev, +struct comedi_driver *driver,unsigned long context);void comedi_pci_auto_unconfig (struct pci_dev *pcidev); int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
Signature · 1 line
2.7.4
Quoted 1 line · Bhanusree Pola
comedi_pci_auto_config()function prototype is exceeding more than 75 characters per line.
Run checkpatch on your generated patch too before sending. Wrap commit log to 75 characters as well.
Quoted 4 lines
Adjusted to less than 75 characters to improve readability.
Signed-off-by Bhanusree Pola <[email protected]>---
Send new verion with a changelog here.
Quoted 8 lines
drivers/staging/comedi/comedi_pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/comedi/comedi_pci.h +0
-0
drivers/staging/comedi/comedi_pci.h int comedi_pci_enable(struct comedi_device *dev); · line 35
Quoted 7 lines
drivers/staging/comedi/comedi_pci.h +2
-2@@ -31,8 +31,8 @@ int comedi_pci_enable(struct comedi_device *dev);void comedi_pci_disable (struct comedi_device *dev);void comedi_pci_detach (struct comedi_device *dev); -int comedi_pci_auto_config (struct pci_dev *pcidev,struct comedi_driver *driver, -unsigned long context); +int comedi_pci_auto_config (struct pci_dev *pcidev, +struct comedi_driver *driver,unsigned long context);
No! Adjust arguments to match open parentheses.
Something like the following:
int comedi_pci_auto_config(struct pci_dev *pcidev,
struct comedi_driver *driver,unsigned long context);
Signature · 4 lines
Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology