Skip to contentSkip to conversation

target: improve Data-Out and NOP timeout error reporting

PATCH In review David Disseldorp 1 participant 1 message Oct 12, 2018 SCSI target

lore
Share & tools
lore
#0 lore raw

v2 cover target: improve Data-Out and NOP timeout error reporting

The following patchset converts existing Data-Out and NOP ping timeout messages from pr_debug() to pr_error(), to reflect the seriousness of unexpected connection termination events.

These events can be triggered using a couple of libiscsi client hacks:
https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-dataout-timeout
https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-nop-timeout

Cheers, David
---
Changes since v1
- split out and use a helper function for cxn timeout error stashing
- add I_T Nexus to error messages

 drivers/target/iscsi/iscsi_target_erl0.c | 15 +--------------
 drivers/target/iscsi/iscsi_target_erl1.c | 17 ++++++++++++-----
 drivers/target/iscsi/iscsi_target_stat.c |  4 ++--
 drivers/target/iscsi/iscsi_target_util.c | 43 ++++++++++++++++++++++++-------------------
 drivers/target/iscsi/iscsi_target_util.h |  1 +
 include/target/iscsi/iscsi_target_core.h |  6 +++---
 include/target/iscsi/iscsi_target_stat.h |  4 ++--
 7 files changed, 45 insertions(+), 45 deletions(-)