target: improve Data-Out and NOP timeout error reporting
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 2 repliesIn review
- v14 patches 5 repliesSuperseded
Changes in v2 from the cover letter
- split out and use a helper function for cxn timeout error stashing
- add I_T Nexus to error messages
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | target: use ISCSI_IQN_LEN in iscsi_target_statdrivers/ include/ include/ | +7 | 0 replies | |
| 2/5 | target: log Data-Out timeouts as errorsdrivers/ | +11 | 0 replies | |
| 3/5 | target: log NOP ping timeouts as errorsdrivers/ | +5 | 0 replies | |
| 4/5 | target: split out helper for cxn timeout error stashingdrivers/ drivers/ drivers/ | +20 | 2 replies | |
| 5/5 | target: stash sess_err_stats on Data-Out timeoutdrivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/5] target: improve Data-Out and NOP timeout error reporting
The following patchset converts existing Data-Out and NOP ping timeout messages from pr_debug() to pr_error(), to reflect the seriousness of unexpected connection termination events.
These events can be triggered using a couple of libiscsi client hacks:
https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-dataout-timeout
https://github.com/ddiss/libiscsi/tree/hack-lio-trigger-nop-timeout
Cheers, David
---
Changes since v1
- split out and use a helper function for cxn timeout error stashing
- add I_T Nexus to error messages
drivers/target/iscsi/iscsi_target_erl0.c | 15 +-------------- drivers/target/iscsi/iscsi_target_erl1.c | 17 ++++++++++++----- drivers/target/iscsi/iscsi_target_stat.c | 4 ++-- drivers/target/iscsi/iscsi_target_util.c | 43 ++++++++++++++++++++++++------------------- drivers/target/iscsi/iscsi_target_util.h | 1 + include/target/iscsi/iscsi_target_core.h | 6 +++--- include/target/iscsi/iscsi_target_stat.h | 4 ++-- 7 files changed, 45 insertions(+), 45 deletions(-)