target: log Data-Out timeouts as errors
PATCH v2 2/5 target: log Data-Out timeouts as errors
Data-Out timeouts resulting in connection outages should be logged as errors. Include the I_T Nexus in the message to aid path identification.
Signed-off-by David Disseldorp <[email protected]>
--- drivers/target/iscsi/iscsi_target_erl1.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-)
drivers/target/iscsi/iscsi_target_erl1.c +11 -5
@@ -1169,15 +1169,21 @@ void iscsit_handle_dataout_timeout(struct timer_list *t) na =iscsit_tpg_get_node_attrib (sess);if (!sess->sess_ops->ErrorRecoveryLevel) { -pr_debug ("Unable to recover from DataOut timeout while" -" in ERL=0.\n" ); +pr_err ("Unable to recover from DataOut timeout while" +" in ERL=0, closing iSCSI connection for I_T Nexus" +" %s,i,0x%6phN,%s,t,0x%02x\n" , + sess->sess_ops->InitiatorName, sess->isid, + sess->tpg->tpg_tiqn->tiqn, (u32 )sess->tpg->tpgt); goto failure; }if (++cmd->dataout_timeout_retries = na->dataout_timeout_retries) { -pr_debug ("Command ITT: 0x%08x exceeded max retries" -" for DataOUT timeout %u, closing iSCSI connection.\n" , - cmd->init_task_tag, na->dataout_timeout_retries); +pr_err ("Command ITT: 0x%08x exceeded max retries" +" for DataOUT timeout %u, closing iSCSI connection for" +" I_T Nexus %s,i,0x%6phN,%s,t,0x%02x\n" , + cmd->init_task_tag, na->dataout_timeout_retries, + sess->sess_ops->InitiatorName, sess->isid, + sess->tpg->tpg_tiqn->tiqn, (u32 )sess->tpg->tpgt); goto failure; }
Signature · 1 line
2.13.7