drm/drm_pci.c: Use dma_zalloc_coherent
Subsystems (2)
PATCH 1/1 drm/drm_pci.c: Use dma_zalloc_coherent
Replace dma_alloc_coherent + memset with dma_zalloc_coherent.
Signed-off-by Souptick Joarder <[email protected]>
--- drivers/gpu/drm/drm_pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_pci.c +2 -3
@@ -61,15 +61,14 @@ drm_dma_handle_t *drm_pci_alloc(struct drm_device * dev, size_t size, size_t alireturn NULL ; dmah->size = size; - dmah->vaddr =dma_alloc_coherent (&dev->pdev->dev, size, &dmah->busaddr,GFP_KERNEL | __GFP_COMP); + dmah->vaddr =dma_zalloc_coherent (&dev->pdev->dev, size, &dmah->busaddr, +GFP_KERNEL | __GFP_COMP);if (dmah->vaddr ==NULL ) {kfree (dmah);return NULL ; } -memset (dmah->vaddr,0 , size); -/* XXX - Is virt_to_page() legal for consistent mem? */ /* Reserve */ for (addr = (unsigned long)dmah->vaddr, sz = size;
Signature · 1 line
1.9.1
Daniel Vetter
AppliedQuoted 3 lines · Souptick Joarder
Replace
dma_alloc_coherent+ memset withdma_zalloc_coherent.Signed-off-by Souptick Joarder <[email protected]>
Applied, thanks for your patch.
-Daniel
Quoted 33 lines
--- drivers/gpu/drm/drm_pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_pci.c +2
-3@@ -61,15 +61,14 @@ drm_dma_handle_t *drm_pci_alloc(struct drm_device * dev, size_t size, size_t alireturn NULL ; dmah->size = size; - dmah->vaddr =dma_alloc_coherent (&dev->pdev->dev, size, &dmah->busaddr,GFP_KERNEL | __GFP_COMP); + dmah->vaddr =dma_zalloc_coherent (&dev->pdev->dev, size, &dmah->busaddr, +GFP_KERNEL | __GFP_COMP);if (dmah->vaddr ==NULL ) {kfree (dmah);return NULL ; } -memset (dmah->vaddr,0 , size); -/* XXX - Is virt_to_page() legal for consistent mem? */ /* Reserve */ for (addr = (unsigned long)dmah->vaddr, sz = size;Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch