drm/i915/gtt: Revert "Disable read-only support under GVT"
Subsystems (2)
PATCH 1/1 drm/i915/gtt: Revert "Disable read-only support under GVT"
From: Hang Yuan <[email protected]>
This reverts commit c9e666880de5a1fed04dc412b046916d542b72dd.
Checked GVT codes that guest PPGTT PTE flag bits are propagated to shadow PTE. Read/write bit is not changed. Further tested by i915 self-test case "igt_ctx_readonly". No error or GPU hang was detected. So enable read-only support under GVT.
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +2 -6
@@ -1602,12 +1602,8 @@ static struct i915_hw_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) 1ULL << 48 :1ULL <<32 ; -/* -* From bdw, there is support for read-only pages in the PPGTT. -* -* XXX GVT is not honouring the lack of RW in the PTE bits. -*/ - ppgtt->vm.has_read_only = !intel_vgpu_active (i915); +/* From bdw, there is support for read-only pages in the PPGTT. */ + ppgtt->vm.has_read_only = true;i915_address_space_init (&ppgtt->vm, i915);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for drm/i915/gtt: Revert "Disable read-only support under GVT"
== Series Details ==
== Series Details ==
Series: drm/i915/gtt: Revert "Disable read-only support under GVT"
URL : https://patchwork.freedesktop.org/series/51730/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: Revert "Disable read-only support under GVT" -drivers/gpu/drm/i915/i915_gem_gtt.c:348:14: warning: expression using sizeof(void) -drivers/gpu/drm/i915/i915_gem_gtt.c:348:14: warning: expression using sizeof(void) +drivers/gpu/drm/i915/i915_gem_gtt.c:348:14: warning: expression using sizeof(void) +drivers/gpu/drm/i915/i915_gem_gtt.c:348:14: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/gtt: Revert "Disable read-only support under GVT"
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/gtt: Revert "Disable read-only support under GVT"
URL : https://patchwork.freedesktop.org/series/51730/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5053 -> Patchwork_10644 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51730/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10644 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107859, fdo#107556, fdo#107774)
igt@kms_flip@basic-flip-vs-modeset:
fi-hsw-4770r: PASS -> DMESG-WARN (fdo#105602)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@drv_getparams_basic@basic-eu-total:
fi-kbl-7560u: INCOMPLETE (fdo#103665) -> PASS
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106725, fdo#106248) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859
== Participating hosts (47 -> 43) ==
Additional (1): fi-kbl-soraka
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5053 -> Patchwork_10644
CI_DRM_5053: fb5dde5f5303ed6eb6099f9435762ed70b3bfdb0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4699: 1270ec553741ac20c45178d2b26f9a9562ea565f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10644: cdbbe952e00992c1910756136b60be6341f14300 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
cdbbe952e009 drm/i915/gtt: Revert "Disable read-only support under GVT"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10644/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/gtt: Revert "Disable read-only support under GVT"
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/gtt: Revert "Disable read-only support under GVT"
URL : https://patchwork.freedesktop.org/series/51730/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5053_full -> Patchwork_10644_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10644_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10644_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10644_full:
=== IGT changes ===
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-cpu:
shard-snb: SKIP -> PASS +1== Known issues ==
Here are the changes found in Patchwork_10644_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_reloc@basic-cpu-gtt:
shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@gem_workarounds@suspend-resume-context:
shard-skl: PASS -> INCOMPLETE (fdo#104108, fdo#107773)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-apl: PASS -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-kbl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-a-legacy-gamma:
shard-apl: PASS -> FAIL (fdo#108145, fdo#104782)
igt@kms_cursor_crc@cursor-256x256-random:
shard-apl: PASS -> FAIL (fdo#103232) +4
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538)
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: PASS -> FAIL (fdo#103167) +5
igt@kms_frontbuffer_tracking@psr-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#104108, fdo#106978, fdo#107773)
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-skl: NOTRUN -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166) +3
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166)
igt@kms_vblank@pipe-c-wait-busy:
shard-apl: NOTRUN -> DMESG-WARN (fdo#103558, fdo#105602) +1
==== Possible fixes ====
igt@gem_exec_whisper@normal:
shard-skl: TIMEOUT (fdo#108592) -> PASS
igt@gem_tiled_blits@interruptible:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_color@pipe-c-degamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x42-offscreen:
shard-skl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: FAIL (fdo#103232) -> PASS +4
igt@kms_flip_tiling@flip-to-x-tiled:
shard-skl: FAIL (fdo#108134) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
shard-skl: FAIL (fdo#105682) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-apl: FAIL (fdo#103167, fdo#105682) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
shard-skl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-apl: FAIL (fdo#103166) -> PASS fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106978 https://bugs.freedesktop.org/show_bug.cgi?id=106978
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108134 https://bugs.freedesktop.org/show_bug.cgi?id=108134
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108592 https://bugs.freedesktop.org/show_bug.cgi?id=108592
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5053 -> Patchwork_10644
CI_DRM_5053: fb5dde5f5303ed6eb6099f9435762ed70b3bfdb0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4699: 1270ec553741ac20c45178d2b26f9a9562ea565f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10644: cdbbe952e00992c1910756136b60be6341f14300 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10644/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting [email protected] (2018-10-30 07:08:01)
Quoted 10 lines
From: Hang Yuan <[email protected]>
This reverts commit
c9e666880de5a1fed04dc412b046916d542b72dd.Checked GVT codes that guest PPGTT PTE flag bits are propagated to shadow PTE. Read/write bit is not changed. Further tested by i915 self-test case "
igt_ctx_readonly". No error or GPU hang was detected. So enable read-only support under GVT.Signed-off-by Hang Yuan <[email protected]>
Zhenyu, happy to give an r-b?
-Chris
Quoted 30 lines
--- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +2
-6@@ -1602,12 +1602,8 @@ static struct i915_hw_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) 1ULL << 48 :1ULL <<32 ; -/* -* From bdw, there is support for read-only pages in the PPGTT. -* -* XXX GVT is not honouring the lack of RW in the PTE bits. -*/ - ppgtt->vm.has_read_only = !intel_vgpu_active (i915); +/* From bdw, there is support for read-only pages in the PPGTT. */ + ppgtt->vm.has_read_only = true;i915_address_space_init (&ppgtt->vm, i915);Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 23 lines · On 2018.10.30 15:08:01 +0800, [email protected] wrote:
From: Hang Yuan <[email protected]>
This reverts commit
c9e666880de5a1fed04dc412b046916d542b72dd.Checked GVT codes that guest PPGTT PTE flag bits are propagated to shadow PTE. Read/write bit is not changed. Further tested by i915 self-test case "
igt_ctx_readonly". No error or GPU hang was detected. So enable read-only support under GVT.Signed-off-by Hang Yuan <[email protected]>--- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +0
-1@@ -1602,12 +1602,8 @@ static struct i915_hw_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) 1ULL << 48 :1ULL <<32 ; -/*
drivers/gpu/drm/i915/i915_gem_gtt.c static struct i915_hw_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) · line 1609
Quoted 10 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +2
-5-* From bdw, there is support for read-only pages in the PPGTT. -* -* XXX GVT is not honouring the lack of RW in the PTE bits. -*/ - ppgtt->vm.has_read_only = !intel_vgpu_active (i915); +/* From bdw, there is support for read-only pages in the PPGTT. */ + ppgtt->vm.has_read_only = true;i915_address_space_init (&ppgtt->vm, i915);
In consider we have that shadow logic from initial of gvt support, this is ok.
thanks
Signature · 3 lines
Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Zhenyu Wang (2018-10-31 05:17:48)
Quoted 32 lines · On 2018.10.30 15:08:01 +0800, [email protected] wrote:
Quoted 31 lines
From: Hang Yuan <[email protected]>
This reverts commit
c9e666880de5a1fed04dc412b046916d542b72dd.Checked GVT codes that guest PPGTT PTE flag bits are propagated to shadow PTE. Read/write bit is not changed. Further tested by i915 self-test case "
igt_ctx_readonly". No error or GPU hang was detected. So enable read-only support under GVT.Signed-off-by Hang Yuan <[email protected]>--- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_gem_gtt.c +2
-6@@ -1602,12 +1602,8 @@ static struct i915_hw_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) 1ULL << 48 :1ULL <<32 ; -/* -* From bdw, there is support for read-only pages in the PPGTT. -* -* XXX GVT is not honouring the lack of RW in the PTE bits. -*/ - ppgtt->vm.has_read_only = !intel_vgpu_active (i915); +/* From bdw, there is support for read-only pages in the PPGTT. */ + ppgtt->vm.has_read_only = true;
Quoted 7 lines
drivers/gpu/drm/i915/i915_gem_gtt.c static struct i915_hw_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915) · line 1609
Quoted 2 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +0
-0i915_address_space_init (&ppgtt->vm, i915);In consider we have that shadow logic from initial of gvt support, this is ok.
Acked-by Zhenyu Wang <[email protected]>
Thanks for the patch and confirmation, pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx