dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
Subsystems (2)
PATCH 1/1 dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
From: Heiko Stuebner <[email protected]>
The tmp108 does have an alert output that can be used as interrupt source and can of course also be used as part of a thermal sensor setup for things like thermal-based cpu frequencies, so document the necessary properties.
--- Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/hwmon/tmp108.txt +4 -0
@@ -7,6 +7,10 @@ Requires node properties: - compatible : "ti,tmp108" - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. +Optional properties: +- interrupts: Reference to the TMP108 alert interrupt. +- #thermal-sensor-cells: should be set to 0. + Example: tmp108@48 { compatible = "ti,tmp108";
Signature · 1 line
2.18.0
Guenter Roeck
maintainerHi,
Quoted 7 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The tmp108 does have an alert output that can be used as interrupt source and can of course also be used as part of a thermal sensor setup for things like thermal-based cpu frequencies, so document the necessary properties.
Signed-off-by Heiko Stuebner <[email protected]>
Do you also plan to actually implement interrupt support in the driver ?
Guenter
Quoted 22 lines
--- Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ 1 file changed, 4 insertions(+)Documentation/devicetree/bindings/hwmon/tmp108.txt +4
-0@@ -7,6 +7,10 @@ Requires node properties: - compatible : "ti,tmp108" - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. +Optional properties: +- interrupts: Reference to the TMP108 alert interrupt. +- #thermal-sensor-cells: should be set to 0. + Example: tmp108@48 { compatible = "ti,tmp108";Signature · 1 line
2.18.0
Hi Guenter,
Am Mittwoch, 7. November 2018, 19:39:58 CET schrieb Guenter Roeck:
Quoted 11 lines · Heiko Stuebner
Quoted 8 lines
From: Heiko Stuebner <[email protected]>
The tmp108 does have an alert output that can be used as interrupt source and can of course also be used as part of a thermal sensor setup for things
like thermal-based cpu frequencies, so document the necessary properties.Signed-off-by Heiko Stuebner <[email protected]>Do you also plan to actually implement interrupt support in the driver ?
Not right now but I'm hoping down the road.
The main argument for including this standard property is that the dt-binding is of course a description of the hardware and not the state of the linux driver and the tmp108 obviously has that alert output pin, hence I'd really like to already have it in the new board-dts I'm currently working on so it simply magically works once the driver can use it :-) .
Heiko
Quoted 24 lines
Quoted 24 lines
---
Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ 1 file changed, 4 insertions(+)(quoted diff) +0
-0
b/Documentation/devicetree/bindings/hwmon/tmp108.txtindex8c4b10df86d9..54d4beed4ee5100644Documentation/devicetree/bindings/hwmon/tmp108.txt +4
-0@@ -7,6 +7,10 @@ Requires node properties: - compatible : "ti,tmp108" - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. +Optional properties: +- interrupts: Reference to the TMP108 alert interrupt. +- #thermal-sensor-cells: should be set to 0. + Example: tmp108@48 {compatible = "ti,tmp108";
Guenter Roeck
maintainerQuoted 15 lines · Heiko Stübner
Hi Guenter,
Am Mittwoch, 7. November 2018, 19:39:58 CET schrieb Guenter Roeck:
Quoted 11 lines · Heiko Stuebner
Quoted 8 lines
From: Heiko Stuebner <[email protected]>
The tmp108 does have an alert output that can be used as interrupt source and can of course also be used as part of a thermal sensor setup for things
like thermal-based cpu frequencies, so document the necessary properties.Signed-off-by Heiko Stuebner <[email protected]>Do you also plan to actually implement interrupt support in the driver ?
Quoted 9 lines
Not right now but I'm hoping down the road.
The main argument for including this standard property is that the dt-binding is of course a description of the hardware and not the state of the linux driver and the tmp108 obviously has that alert output pin, hence I'd really like to already have it in the new board-dts I'm currently working on so it simply magically works once the driver can use it :-) .
NP, just asking. Let's wait for Rob's review, then I'll apply the patch unless he has issues.
Thanks,
Guenter
Quoted 31 lines
Heiko
Quoted 24 lines
Quoted 24 lines
---
Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ 1 file changed, 4 insertions(+)(quoted diff) +0
-0
b/Documentation/devicetree/bindings/hwmon/tmp108.txtindex8c4b10df86d9..54d4beed4ee5100644Documentation/devicetree/bindings/hwmon/tmp108.txt +4
-0@@ -7,6 +7,10 @@ Requires node properties: - compatible : "ti,tmp108" - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. +Optional properties: +- interrupts: Reference to the TMP108 alert interrupt. +- #thermal-sensor-cells: should be set to 0. + Example: tmp108@48 {compatible = "ti,tmp108";
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 7 lines · Rob Herring
Quoted 6 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
The tmp108 does have an alert output that can be used as interrupt source and can of course also be used as part of a thermal sensor setup for things like thermal-based cpu frequencies, so document the necessary properties.
Quoted 8 lines
Quoted 5 lines
Signed-off-by Heiko Stuebner <[email protected]>--- Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ 1 file changed, 4 insertions(+)Reviewed-by Rob Herring <[email protected]>
Applied to hwmon-next.
Thanks,
Guenter