Huawei laptops
Subsystems (2)
v6 cover Huawei laptops
Changes from v5:
* Review tags
Changes from v4:
* Consistency in file names
* How module would be enabled (Kconfig)
* Match license in SPDX and MODULE_LICENSE
Changes from v3:
* Code formatting
Changes from v2:
* Support for Huawei MBX
* Style and formatting issues
[PATCH 1/3]
The first patch adds support for missing hotkeys on some models.
[PATCH 2/3]
This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501
It simply uses the pins configurations generated by hdajackretast using the settings posted on the bug page https://imgur.com/a/N1xsCVZ
[PATCH 3/3]
This enables the micmute LED on Huawei laptops with these IDs:
1. Matebook X (19e5:3200)
2. Matebook X (19e5:3201)
3. Matebook X Pro (19e5:3204)
Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers on Huawei MBXP.
ALSA: hda: add support for Huawei WMI micmute LED
drivers/platform/x86/Kconfig | 10 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 215 +++++++++++++++++++ include/linux/platform_data/x86/huawei-wmi.h | 9 + sound/pci/hda/huawei_wmi_helper.c | 47 ++++ sound/pci/hda/patch_realtek.c | 30 +++ 6 files changed, 312 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c create mode 100644 include/linux/platform_data/x86/huawei-wmi.h create mode 100644 sound/pci/hda/huawei_wmi_helper.c
Signature · 1 line
2.17.2
PATCH v6 1/3 x86: add support for Huawei WMI hotkeys.
This driver adds support for missing hotkeys on some Huawei laptops. Currently, only Huawei Matebook X and Matebook X Pro is supported.
--- drivers/platform/x86/Kconfig | 10 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 215 +++++++++++++++++++ include/linux/platform_data/x86/huawei-wmi.h | 9 + 4 files changed, 235 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c create mode 100644 include/linux/platform_data/x86/huawei-wmi.h
drivers/platform/x86/Kconfig +13 -0
@@ -1288,6 +1288,19 @@ config INTEL_ATOMISP2_PM To compile this driver as a module, choose M here: the module will be called intel_atomisp2_pm. +config HUAWEI_WMI + tristate "Huawei WMI hotkeys driver" + depends on ACPI_WMI + depends on INPUT + select INPUT_SPARSEKMAP + help + This driver provides support for Huawei WMI hotkeys. + It enables the missing keys and adds support to the micmute + LED found on some of these laptops. + + To compile this driver as a module, choose M here: the module + will be called huawei-wmi. + endif # X86_PLATFORM_DEVICES config PMC_ATOM
drivers/platform/x86/Makefile +1 -0
@@ -32,6 +32,7 @@ obj-$(CONFIG_ACERHDF) += acerhdf.o obj-$(CONFIG_HP_ACCEL) += hp_accel.o obj-$(CONFIG_HP_WIRELESS) += hp-wireless.o obj-$(CONFIG_HP_WMI) += hp-wmi.o +obj-$(CONFIG_HUAWEI_WMI) += huawei-wmi.o obj-$(CONFIG_AMILO_RFKILL) += amilo-rfkill.o obj-$(CONFIG_GPD_POCKET_FAN) += gpd-pocket-fan.o obj-$(CONFIG_TC1100_WMI) += tc1100-wmi.o
drivers/platform/x86/huawei-wmi.c new file +214 -0
214 lines not on this page · raw message
include/linux/platform_data/x86/huawei-wmi.h new file +9 -0
@@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#if IS_ENABLED (CONFIG_HUAWEI_WMI ) +#ifndef __HUAWEI_WMI_H__ +#define __HUAWEI_WMI_H__ + +int huawei_wmi_micmute_led_set (bool on); + +#endif +#endif
Signature · 1 line
2.17.2
PATCH v6 2/3 ALSA: hda: fix front speakers on Huawei MBXP.
In reply to Ayman BagabasThis patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
https://bugzilla.kernel.org/show_bug.cgi?id=200501
It enables the front speakers on Huawei Matebook X Pro laptops. These laptops come with Dolby Atmos sound system and these pins configuration enables the front speakers.
--- sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
sound/pci/hda/patch_realtek.c +18 -0
@@ -5493,6 +5493,7 @@ enum {ALC298_FIXUP_TPT470_DOCK ,ALC255_FIXUP_DUMMY_LINEOUT_VERB ,ALC255_FIXUP_DELL_HEADSET_MIC , +ALC256_FIXUP_HUAWEI_MBXP_PINS ,ALC295_FIXUP_HP_X360 , ALC221_FIXUP_HP_HEADSET_MIC, };
@@ -5764,6 +5765,22 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id =ALC269_FIXUP_HEADSET_MIC }, + [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl []) { + {0x12 ,0x90a60130 }, + {0x13 ,0x40000000 }, + {0x14 ,0x90170110 }, + {0x18 ,0x411111f0 }, + {0x19 ,0x04a11040 }, + {0x1a ,0x411111f0 }, + {0x1b ,0x90170112 }, + {0x1d ,0x40759a05 }, + {0x1e ,0x411111f0 }, + {0x21 ,0x04211020 }, + { } + } + }, [ALC269_FIXUP_ASUS_X101_FUNC] = { .type = HDA_FIXUP_FUNC, .v.func = alc269_fixup_x101_headset_mic,
@@ -6594,6 +6611,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x511f ,"Thinkpad" ,ALC298_FIXUP_TPT470_DOCK ),SND_PCI_QUIRK (0x17aa ,0x3bf8 ,"Quanta FL1" ,ALC269_FIXUP_PCM_44K ),SND_PCI_QUIRK (0x17aa ,0x9e54 ,"LENOVO NB" ,ALC269_FIXUP_LENOVO_EAPD ), +SND_PCI_QUIRK (0x19e5 ,0x3204 ,"Huawei MBXP" ,ALC256_FIXUP_HUAWEI_MBXP_PINS ),SND_PCI_QUIRK (0x1b7d ,0xa831 ,"Ordissimo EVE2 " ,ALC269VB_FIXUP_ORDISSIMO_EVE2 ),/* Also known as Malata PC-B1303 */ #if 0
Signature · 1 line
2.17.2
PATCH v6 3/3 ALSA: hda: add support for Huawei WMI micmute LED
In reply to Ayman BagabasSome of Huawei laptops come with a LED in the micmute key. This patch enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)
--- sound/pci/hda/huawei_wmi_helper.c | 47 +++++++++++++++++++++++++++++++ sound/pci/hda/patch_realtek.c | 14 ++++++++- 2 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 sound/pci/hda/huawei_wmi_helper.c
sound/pci/hda/huawei_wmi_helper.c new file +47 -0
@@ -0,0 +1,47 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Helper functions for Huawei WMI micmute LED; +* to be included from codec driver +*/ + +#if IS_ENABLED (CONFIG_HUAWEI_WMI ) +#include <linux/platform_data/x86/huawei-wmi.h> + +static int (*huawei_wmi_micmute_led_set_func)(bool ); + +static void update_huawei_wmi_micmute_led (struct hda_codec *codec) +{ +struct hda_gen_spec *spec = codec->spec; +huawei_wmi_micmute_led_set_func (spec->micmute_led.led_value); +} + +static void alc_fixup_huawei_wmi (struct hda_codec *codec, +const struct hda_fixup *fix,int action) +{ +bool removefunc = false; + +if (action ==HDA_FIXUP_ACT_PROBE ) { +if (!huawei_wmi_micmute_led_set_func) + huawei_wmi_micmute_led_set_func =symbol_request (huawei_wmi_micmute_led_set); +if (!huawei_wmi_micmute_led_set_func) { +codec_warn (codec,"Failed to find huawei_wmi symbol huawei_wmi_micmute_led_set\n" ); +return ; + } + + removefunc = (huawei_wmi_micmute_led_set_func (false) <0 ) + || (snd_hda_gen_add_micmute_led (codec, update_huawei_wmi_micmute_led) <0 ); + } + +if (huawei_wmi_micmute_led_set_func && (action ==HDA_FIXUP_ACT_FREE || removefunc)) { +symbol_put (huawei_wmi_micmute_led_set); + huawei_wmi_micmute_led_set_func =NULL ; + } +} + +#else + +static void alc_fixup_huawei_wmi (struct hda_codec *codec, +const struct hda_fixup *fix,int action) +{ +} + +#endif
sound/pci/hda/patch_realtek.c +13 -1
@@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec,/* for alc295_fixup_hp_top_speakers */ #include "hp_x360_helper.c" +/* for alc_fixup_huawei_wmi */ +#include "huawei_wmi_helper.c" +enum {ALC269_FIXUP_SONY_VAIO ,ALC275_FIXUP_SONY_VAIO_GPIO2 ,
@@ -5494,6 +5497,7 @@ enum {ALC255_FIXUP_DUMMY_LINEOUT_VERB ,ALC255_FIXUP_DELL_HEADSET_MIC ,ALC256_FIXUP_HUAWEI_MBXP_PINS , +ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED ,ALC295_FIXUP_HP_X360 , ALC221_FIXUP_HP_HEADSET_MIC, };
@@ -5765,6 +5769,10 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id =ALC269_FIXUP_HEADSET_MIC }, + [ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_huawei_wmi + }, [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl []) {
@@ -5779,7 +5787,9 @@ static const struct hda_fixup alc269_fixups[] = { {0x1e, 0x411111f0}, {0x21, 0x04211020}, { } - } + }, + .chained = true, + .chain_id = ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED }, [ALC269_FIXUP_ASUS_X101_FUNC] = { .type = HDA_FIXUP_FUNC,
@@ -6611,6 +6621,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x511f ,"Thinkpad" ,ALC298_FIXUP_TPT470_DOCK ),SND_PCI_QUIRK (0x17aa ,0x3bf8 ,"Quanta FL1" ,ALC269_FIXUP_PCM_44K ),SND_PCI_QUIRK (0x17aa ,0x9e54 ,"LENOVO NB" ,ALC269_FIXUP_LENOVO_EAPD ), +SND_PCI_QUIRK (0x19e5 ,0x3200 ,"Huawei MBX" ,ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED ), +SND_PCI_QUIRK (0x19e5 ,0x3201 ,"Huawei MBX" ,ALC256_FIXUP_HUAWEI_WMI_MICMUTE_LED ),SND_PCI_QUIRK (0x19e5 ,0x3204 ,"Huawei MBXP" ,ALC256_FIXUP_HUAWEI_MBXP_PINS ), SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
Signature · 1 line
2.17.2
Quoted 1 line · Ayman Bagabas
Pushed to my review and testing queue, thanks!
Quoted 50 lines
Changes from v5:
* Review tagsChanges from v4:
* Consistency in file names
* How module would be enabled (Kconfig)
* Match license in SPDX andMODULE_LICENSEChanges from v3:
* Code formattingChanges from v2:
* Support for Huawei MBX
* Style and formatting issues[PATCH 1/3]
The first patch adds support for missing hotkeys on some models.[PATCH 2/3]
This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501
It simply uses the pins configurations generated by hdajackretast using the settings posted on the bug page https://imgur.com/a/N1xsCVZ[PATCH 3/3]
This enables the micmute LED on Huawei laptops with these IDs:
1. Matebook X (19e5:3200)
2. Matebook X (19e5:3201)
3. Matebook X Pro (19e5:3204)Ayman Bagabas (3):
x86: add support for Huawei WMI hotkeys.
ALSA: hda: fix front speakers on Huawei MBXP.
ALSA: hda: add support for Huawei WMI micmute LEDdrivers/platform/x86/Kconfig | 10 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 215 +++++++++++++++++++ include/linux/platform_data/x86/huawei-wmi.h | 9 + sound/pci/hda/huawei_wmi_helper.c | 47 ++++ sound/pci/hda/patch_realtek.c | 30 +++ 6 files changed, 312 insertions(+) create mode 100644 drivers/platform/x86/huawei-wmi.c create mode 100644 include/linux/platform_data/x86/huawei-wmi.h create mode 100644 sound/pci/hda/huawei_wmi_helper.c--
2.17.2
Signature · 2 lines
With Best Regards, Andy Shevchenko