input: touchscreen: Add goodix GT5553 CTP support
Subsystems (4)
v3 cover input: touchscreen: Add goodix GT5553 CTP support
This patchset support goodix GT5553 CTP.
Changes for v3:
- add cover-letter
- s/ADVV28/AVDD28 on commit head
- fix few typo
Changes for v2:
- Rename vcc-supply with AVDD28-supply
- disable regulator in remove
- fix to setup regulator in probe code
- add chipdata
- drop example node in dt-bindings
Jagan Teki (4):
dt-bindings: input: touchscreen: goodix: Document AVDD28-supply
property
Input: goodix - Add AVDD28-supply regulator support
dt-bindings: input: touchscreen: goodix: Add GT5663 compatible
Input: goodix - Add GT5663 CTP support
.../bindings/input/touchscreen/goodix.txt | 2 ++ drivers/input/touchscreen/goodix.c | 35 ++++++++++++++++--- 2 files changed, 32 insertions(+), 5 deletions(-)
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v3 1/4 dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1 -0
@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pin Example:
Signature · 1 line
2.18.0.321.gffc6fa0e3
Dmitry Torokhov
maintainerRe: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0
Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pin
I think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Thanks.
Signature · 1 line
Dmitry
Rob Herring
maintainerRe: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Please CC DT list if you want bindings reviewed.
Quoted 14 lines · Dmitry Torokhov
Quoted 12 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 9 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
Rob
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 14 lines · Dmitry Torokhov
Quoted 12 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Quoted 13 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 9 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
Rob Herring
maintainerRe: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Rob
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 40 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
+ DT ML
Quoted 54 lines · Jagan Teki
Quoted 40 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
Rob Herring
maintainerRe: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
In reply to Jagan TekiQuoted 47 lines · Jagan Teki
Quoted 45 lines · Rob Herring
Quoted 43 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 35 lines
Quoted 14 lines · Dmitry Torokhov
Quoted 12 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Quoted 13 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 9 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
or regulator which are not using are get via devm_regulator_get_optional.
Any suggestions?
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 66 lines · Jagan Teki
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
Quoted 7 lines
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
or regulator which are not using are get via
devm_regulator_get_optional.Any suggestions?
Just realized to go with bulk calls, please have a look at on v5 [1]
Dmitry Torokhov
maintainerRe: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 71 lines · Jagan Teki
Quoted 70 lines · Jagan Teki
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
Quoted 5 lines
Quoted 3 lines
or regulator which are not using are get via
devm_regulator_get_optional.Any suggestions?
Just realized to go with bulk calls, please have a look at on v5 [1]
I do not believe you can use bulk regulator API here as you need to implement the power up timing scheme mentioned on p. 12 of the spec you referenced earlier. And, because of that timing diagram, I believe if you want to control AVDD supply, you also have to control VDDIO supply as it has to be on only after enabling AVDD.
I also wonder if it is valid to have both AVDD28 and AVDD22 connected at the same time.
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Hi Dmitry,
Quoted 77 lines · Dmitry Torokhov
Quoted 75 lines · Jagan Teki
Quoted 73 lines · Jagan Teki
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
or regulator which are not using are get via
devm_regulator_get_optional.Any suggestions?
Quoted 7 lines
Quoted 1 line
Just realized to go with bulk calls, please have a look at on v5 [1]
I do not believe you can use bulk regulator API here as you need to implement the power up timing scheme mentioned on p. 12 of the spec you referenced earlier. And, because of that timing diagram, I believe if you want to control AVDD supply, you also have to control VDDIO supply as it has to be on only after enabling AVDD.
AVDD here is AVDD28 it' is an out name of pin (mentioned in p. 23). So the power scheme goes to enable AVDD28 and then VDDIO does that really mean bulk of two regulators?
Quoted 3 lines
I also wonder if it is valid to have both AVDD28 and AVDD22 connected at the same time.
Yes, DVDD12 and AVDD22 not been part of power-up schema at-least from the datasheet. I'm thinking we can skip these until any of other goodix CTP needed, what do you think Rob?
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 90 lines · Jagan Teki
Hi Dmitry,
Quoted 77 lines · Dmitry Torokhov
Quoted 75 lines · Jagan Teki
Quoted 73 lines · Jagan Teki
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
or regulator which are not using are get via
devm_regulator_get_optional.Any suggestions?
Quoted 7 lines
Quoted 1 line
Just realized to go with bulk calls, please have a look at on v5 [1]
I do not believe you can use bulk regulator API here as you need to implement the power up timing scheme mentioned on p. 12 of the spec you referenced earlier. And, because of that timing diagram, I believe if you want to control AVDD supply, you also have to control VDDIO supply as it has to be on only after enabling AVDD.
Quoted 3 lines
AVDD here is AVDD28 it' is an out name of pin (mentioned in p. 23). So the power scheme goes to enable AVDD28 and then VDDIO does that really mean bulk of two regulators?
The time between these two regulator operations is nearly 0, as per power scheme diagram T1 >= 0us. I think I can use bulk since there is no necessity of delay between these two regulator operations.
What do you think?
Dmitry Torokhov
maintainerRe: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 95 lines · Jagan Teki
Quoted 90 lines · Jagan Teki
Hi Dmitry,
Quoted 77 lines · Dmitry Torokhov
Quoted 75 lines · Jagan Teki
Quoted 73 lines · Jagan Teki
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 17 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin. which need to supply for controllers like GT5663 on some boards to trigger the power.
So, document the supply property so-that the require boards that used on GT5663 can enable it via device tree.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/input/touchscreen/goodix.txt +0
-0Documentation/devicetree/bindings/input/touchscreen/goodix.txt Optional properties: · line 26
Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1
-0@@ -23,6 +23,7 @@ Optional properties: - touchscreen-inverted-y : Y axis is inverted (boolean) - touchscreen-swapped-x-y : X and Y axis are swapped (boolean) (swapping is done after inverting the axis) + - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
or regulator which are not using are get via
devm_regulator_get_optional.Any suggestions?
Quoted 7 lines
Quoted 1 line
Just realized to go with bulk calls, please have a look at on v5 [1]
I do not believe you can use bulk regulator API here as you need to implement the power up timing scheme mentioned on p. 12 of the spec you referenced earlier. And, because of that timing diagram, I believe if you want to control AVDD supply, you also have to control VDDIO supply as it has to be on only after enabling AVDD.
Quoted 3 lines
AVDD here is AVDD28 it' is an out name of pin (mentioned in p. 23). So the power scheme goes to enable AVDD28 and then VDDIO does that really mean bulk of two regulators?
Quoted 5 lines
The time between these two regulator operations is nearly 0, as per power scheme diagram T1 >= 0us. I think I can use bulk since there is no necessity of delay between these two regulator operations.
What do you think?
Does the bulk enable provide any guarantees as to the order of operations? If it does not then I think we should ensure that they are powered up/down in the right order.
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Quoted 101 lines · Dmitry Torokhov
Quoted 99 lines · Jagan Teki
Quoted 90 lines · Jagan Teki
Hi Dmitry,
Quoted 77 lines · Dmitry Torokhov
Quoted 75 lines · Jagan Teki
Quoted 73 lines · Jagan Teki
Hi Dmitry and Rob,
Quoted 53 lines · Rob Herring
Quoted 51 lines · Jagan Teki
Quoted 48 lines · Rob Herring
Quoted 38 lines · Jagan Teki
Quoted 2 lines · Rob Herring
Please CC DT list if you want bindings reviewed.
Sorry I forgot.
Quoted 31 lines
Quoted 27 lines · Dmitry Torokhov
Quoted 21 lines · Jagan Teki
Most of the Goodix CTP controllers are supply with AVDD28 pin.
which need to supply for controllers like GT5663 on some boards
to trigger the power.So, document the supply property so-that the require boards
that used on GT5663 can enable it via device tree.Signed-off-by: Jagan Teki <[email protected]>
---
Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 +
1 file changed, 1 insertion(+)diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
index f7e95c52f3c7..c4622c983e08 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
@@ -23,6 +23,7 @@ Optional properties:
- touchscreen-inverted-y : Y axis is inverted (boolean)
- touchscreen-swapped-x-y : X and Y axis are swapped (boolean)
(swapping is done after inverting the axis)
+ - AVDD28-supply : Analog power supply regulator on AVDD28 pinI think we normally use lower case in DT bindings and rarely encode voltage in the supply name unless we are dealing with several supplies of the same kind, but I'll let Ron comment on this.
Quoted 6 lines
Quoted 4 lines
Yes on lowercase though there are some exceptions.
There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
You are missing the 3 other supplies the chip has: AVDD22, DVDD12 and VDDIO.
Quoted 8 lines
Quoted 3 lines
Though it has other supplies, only AVDD28 is connected in the Host interface design similar like 9. Reference Schematic on Page, 23 in attached manual.
That is for a particular board design. It still has other supplies. Just make the binding complete please. You can make them optional. I don't care if the driver supports controlling all the supplies or not (though Dmitry might).
So, Can I make bulk get and enable in all 4 regulators global to driver or specific to that chip, in either way the regulators which are not used to process via dummy regulators (which we all know).
or regulator which are not using are get via
devm_regulator_get_optional.Any suggestions?
Quoted 7 lines
Quoted 1 line
Just realized to go with bulk calls, please have a look at on v5 [1]
I do not believe you can use bulk regulator API here as you need to implement the power up timing scheme mentioned on p. 12 of the spec you referenced earlier. And, because of that timing diagram, I believe if you want to control AVDD supply, you also have to control VDDIO supply as it has to be on only after enabling AVDD.
Quoted 3 lines
AVDD here is AVDD28 it' is an out name of pin (mentioned in p. 23). So the power scheme goes to enable AVDD28 and then VDDIO does that really mean bulk of two regulators?
The time between these two regulator operations is nearly 0, as per power scheme diagram T1 >= 0us. I think I can use bulk since there is no necessity of delay between these two regulator operations.
Quoted 5 lines
Quoted 1 line
What do you think?
Does the bulk enable provide any guarantees as to the order of operations? If it does not then I think we should ensure that they are powered up/down in the right order.
At-least I can saw from the log, async enables based on the definition of supply arrays. Indeed the regulators with bulk calls enables based on the supply array order, this is what I usually think.
[ 3.676483] Goodix-TS 1-005d: 1-005d supply VDDIO not found, using dummy regulator [ 3.693159] regulator_bulk_enable_async: Supply AVDD28 [ 3.693162] regulator_bulk_enable_async: Supply VDDIO [ 3.806095] Goodix-TS 1-005d: ID 5663, version: 0100
Do we need to go reverse order for power-down? I couldn't see this information on the datasheet. If yes then we need to go for normal calls.
PATCH v3 2/4 Input: goodix - Add AVDD28-supply regulator support
In reply to Jagan TekiGoodix CTP controllers have AVDD28 pin connected to voltage regulator which may not be turned on by default, like for GT5663.
Add support for such ctp used boards by adding voltage regulator handling code to goodix ctp driver.
--- drivers/input/touchscreen/goodix.c | 33 +++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-)
drivers/input/touchscreen/goodix.c +28 -5
@@ -27,6 +27,7 @@#include <linux/delay.h> #include <linux/irq.h> #include <linux/interrupt.h> +#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/acpi.h> #include <linux/of.h>
@@ -47,6 +48,7 @@ struct goodix_ts_data {struct touchscreen_properties prop;unsigned int max_touch_num;unsigned int int_trigger_type; +struct regulator *avdd28;struct gpio_desc *gpiod_int;struct gpio_desc *gpiod_rst;u16 id;
@@ -786,25 +788,41 @@ static int goodix_ts_probe(struct i2c_client *client,if (error)return error; + ts->avdd28 =devm_regulator_get (&client->dev,"AVDD28" ); +if (IS_ERR (ts->avdd28)) { + error =PTR_ERR (ts->avdd28); +if (error != -EPROBE_DEFER ) +dev_err (&client->dev, +"Failed to get AVDD28 regulator: %d\n" , error); +return error; + } + +/* power the controller */ + error =regulator_enable (ts->avdd28); +if (error) { +dev_err (&client->dev,"Controller fail to enable AVDD28\n" ); +return error; + } +if (ts->gpiod_int && ts->gpiod_rst) {/* reset the controller */ error =goodix_reset (ts);if (error) {dev_err (&client->dev,"Controller reset failed.\n" ); -return error; + goto error; } } error =goodix_i2c_test (client);if (error) {dev_err (&client->dev,"I2C communication failure: %d\n" , error); -return error; + goto error; } error =goodix_read_version (ts);if (error) {dev_err (&client->dev,"Read version failed.\n" ); -return error; + goto error; } ts->chip =goodix_get_chip_data (ts->id);
@@ -823,23 +841,28 @@ static int goodix_ts_probe(struct i2c_client *client,dev_err (&client->dev,"Failed to invoke firmware loader: %d\n" , error); -return error; + goto error; }return 0 ; }else { error =goodix_configure_dev (ts);if (error) -return error; + goto error; }return 0 ; + +error: +regulator_disable (ts->avdd28); +return error; }static int goodix_ts_remove (struct i2c_client *client) {struct goodix_ts_data *ts =i2c_get_clientdata (client); +regulator_disable (ts->avdd28);if (ts->gpiod_int && ts->gpiod_rst)wait_for_completion (&ts->firmware_loading_complete);
Signature · 1 line
2.18.0.321.gffc6fa0e3
Dmitry Torokhov
maintainerRe: [PATCH v3 2/4] Input: goodix - Add AVDD28-supply regulator support
Hi Jagan,
Quoted 94 lines · Jagan Teki
Goodix CTP controllers have AVDD28 pin connected to voltage regulator which may not be turned on by default, like for GT5663.
Add support for such ctp used boards by adding voltage regulator handling code to goodix ctp driver.
Signed-off-by Jagan Teki <[email protected]>--- drivers/input/touchscreen/goodix.c | 33 +++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-)drivers/input/touchscreen/goodix.c +24
-5@@ -27,6 +27,7 @@#include <linux/delay.h> #include <linux/irq.h> #include <linux/interrupt.h> +#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/acpi.h> #include <linux/of.h> @@ -47,6 +48,7 @@ struct goodix_ts_data {struct touchscreen_properties prop;unsigned int max_touch_num;unsigned int int_trigger_type; +struct regulator *avdd28;struct gpio_desc *gpiod_int;struct gpio_desc *gpiod_rst;u16 id;@@ -786,25 +788,41 @@ static int goodix_ts_probe(struct i2c_client *client,if (error)return error; + ts->avdd28 =devm_regulator_get (&client->dev,"AVDD28" ); +if (IS_ERR (ts->avdd28)) { + error =PTR_ERR (ts->avdd28); +if (error != -EPROBE_DEFER ) +dev_err (&client->dev, +"Failed to get AVDD28 regulator: %d\n" , error); +return error; + } + +/* power the controller */ + error =regulator_enable (ts->avdd28); +if (error) { +dev_err (&client->dev,"Controller fail to enable AVDD28\n" ); +return error; + } +if (ts->gpiod_int && ts->gpiod_rst) {/* reset the controller */ error =goodix_reset (ts);if (error) {dev_err (&client->dev,"Controller reset failed.\n" ); -return error; + goto error; } } error =goodix_i2c_test (client);if (error) {dev_err (&client->dev,"I2C communication failure: %d\n" , error); -return error; + goto error; } error =goodix_read_version (ts);if (error) {dev_err (&client->dev,"Read version failed.\n" ); -return error; + goto error; } ts->chip =goodix_get_chip_data (ts->id);@@ -823,23 +841,28 @@ static int goodix_ts_probe(struct i2c_client *client,dev_err (&client->dev,"Failed to invoke firmware loader: %d\n" , error); -return error; + goto error; }return 0 ; }else { error =goodix_configure_dev (ts);if (error) -return error; + goto error; }return 0 ; +
drivers/input/touchscreen/goodix.c static int goodix_ts_probe(struct i2c_client *client, · line 865
Quoted 10 lines
drivers/input/touchscreen/goodix.c +4
-0+error: +regulator_disable (ts->avdd28); +return error; }static int goodix_ts_remove (struct i2c_client *client) {struct goodix_ts_data *ts =i2c_get_clientdata (client); +regulator_disable (ts->avdd28);
This may be disabling the regulator too early. Please use devm_add_action_or_reset() to install a custom devm handler that would disable the regulator in line with the rest of devm unwinding flow.
Quoted 6 lines
drivers/input/touchscreen/goodix.c +0
-0if (ts->gpiod_int && ts->gpiod_rst)wait_for_completion (&ts->firmware_loading_complete);Signature · 1 line
2.18.0.321.gffc6fa0e3
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v3 2/4] Input: goodix - Add AVDD28-supply regulator support
Quoted 107 lines · Dmitry Torokhov
Hi Jagan,
Quoted 103 lines · Jagan Teki
Goodix CTP controllers have AVDD28 pin connected to voltage regulator which may not be turned on by default, like for GT5663.
Add support for such ctp used boards by adding voltage regulator handling code to goodix ctp driver.
Signed-off-by Jagan Teki <[email protected]>--- drivers/input/touchscreen/goodix.c | 33 +++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-)drivers/input/touchscreen/goodix.c +27
-5@@ -27,6 +27,7 @@#include <linux/delay.h> #include <linux/irq.h> #include <linux/interrupt.h> +#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/acpi.h> #include <linux/of.h> @@ -47,6 +48,7 @@ struct goodix_ts_data {struct touchscreen_properties prop;unsigned int max_touch_num;unsigned int int_trigger_type; +struct regulator *avdd28;struct gpio_desc *gpiod_int;struct gpio_desc *gpiod_rst;u16 id;@@ -786,25 +788,41 @@ static int goodix_ts_probe(struct i2c_client *client,if (error)return error; + ts->avdd28 =devm_regulator_get (&client->dev,"AVDD28" ); +if (IS_ERR (ts->avdd28)) { + error =PTR_ERR (ts->avdd28); +if (error != -EPROBE_DEFER ) +dev_err (&client->dev, +"Failed to get AVDD28 regulator: %d\n" , error); +return error; + } + +/* power the controller */ + error =regulator_enable (ts->avdd28); +if (error) { +dev_err (&client->dev,"Controller fail to enable AVDD28\n" ); +return error; + } +if (ts->gpiod_int && ts->gpiod_rst) {/* reset the controller */ error =goodix_reset (ts);if (error) {dev_err (&client->dev,"Controller reset failed.\n" ); -return error; + goto error; } } error =goodix_i2c_test (client);if (error) {dev_err (&client->dev,"I2C communication failure: %d\n" , error); -return error; + goto error; } error =goodix_read_version (ts);if (error) {dev_err (&client->dev,"Read version failed.\n" ); -return error; + goto error; } ts->chip =goodix_get_chip_data (ts->id);@@ -823,23 +841,28 @@ static int goodix_ts_probe(struct i2c_client *client,dev_err (&client->dev,"Failed to invoke firmware loader: %d\n" , error); -return error; + goto error; }return 0 ; }else { error =goodix_configure_dev (ts);if (error) -return error; + goto error; }return 0 ; + +error: +regulator_disable (ts->avdd28); +return error; }static int goodix_ts_remove (struct i2c_client *client) {struct goodix_ts_data *ts =i2c_get_clientdata (client);
Quoted 5 lines
drivers/input/touchscreen/goodix.c static int goodix_ts_probe(struct i2c_client *client, · line 865
Quoted 1 line
drivers/input/touchscreen/goodix.c +1
-0+regulator_disable (ts->avdd28);This may be disabling the regulator too early. Please use
devm_add_action_or_reset()to install a custom devm handler that would disable the regulator in line with the rest of devm unwinding flow.
Like handler with only regulator_disable? and would that call from suspend or not need?
Dmitry Torokhov
maintainerRe: [PATCH v3 2/4] Input: goodix - Add AVDD28-supply regulator support
Quoted 110 lines · Jagan Teki
Quoted 107 lines · Dmitry Torokhov
Hi Jagan,
Quoted 103 lines · Jagan Teki
Goodix CTP controllers have AVDD28 pin connected to voltage regulator which may not be turned on by default, like for GT5663.
Add support for such ctp used boards by adding voltage regulator handling code to goodix ctp driver.
Signed-off-by Jagan Teki <[email protected]>--- drivers/input/touchscreen/goodix.c | 33 +++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-)drivers/input/touchscreen/goodix.c +27
-5@@ -27,6 +27,7 @@#include <linux/delay.h> #include <linux/irq.h> #include <linux/interrupt.h> +#include <linux/regulator/consumer.h> #include <linux/slab.h> #include <linux/acpi.h> #include <linux/of.h> @@ -47,6 +48,7 @@ struct goodix_ts_data {struct touchscreen_properties prop;unsigned int max_touch_num;unsigned int int_trigger_type; +struct regulator *avdd28;struct gpio_desc *gpiod_int;struct gpio_desc *gpiod_rst;u16 id;@@ -786,25 +788,41 @@ static int goodix_ts_probe(struct i2c_client *client,if (error)return error; + ts->avdd28 =devm_regulator_get (&client->dev,"AVDD28" ); +if (IS_ERR (ts->avdd28)) { + error =PTR_ERR (ts->avdd28); +if (error != -EPROBE_DEFER ) +dev_err (&client->dev, +"Failed to get AVDD28 regulator: %d\n" , error); +return error; + } + +/* power the controller */ + error =regulator_enable (ts->avdd28); +if (error) { +dev_err (&client->dev,"Controller fail to enable AVDD28\n" ); +return error; + } +if (ts->gpiod_int && ts->gpiod_rst) {/* reset the controller */ error =goodix_reset (ts);if (error) {dev_err (&client->dev,"Controller reset failed.\n" ); -return error; + goto error; } } error =goodix_i2c_test (client);if (error) {dev_err (&client->dev,"I2C communication failure: %d\n" , error); -return error; + goto error; } error =goodix_read_version (ts);if (error) {dev_err (&client->dev,"Read version failed.\n" ); -return error; + goto error; } ts->chip =goodix_get_chip_data (ts->id);@@ -823,23 +841,28 @@ static int goodix_ts_probe(struct i2c_client *client,dev_err (&client->dev,"Failed to invoke firmware loader: %d\n" , error); -return error; + goto error; }return 0 ; }else { error =goodix_configure_dev (ts);if (error) -return error; + goto error; }return 0 ; + +error: +regulator_disable (ts->avdd28); +return error; }static int goodix_ts_remove (struct i2c_client *client) {struct goodix_ts_data *ts =i2c_get_clientdata (client);
Quoted 7 lines
Quoted 5 lines
drivers/input/touchscreen/goodix.c static int goodix_ts_probe(struct i2c_client *client, · line 865
Quoted 1 line
drivers/input/touchscreen/goodix.c +1
-0+regulator_disable (ts->avdd28);This may be disabling the regulator too early. Please use
devm_add_action_or_reset()to install a custom devm handler that would disable the regulator in line with the rest of devm unwinding flow.Like handler with only
regulator_disable?
Right.
Quoted 1 line
and would that call from suspend or not need?
No, it will only be called when device is unbound from the driver or when probe fails. If you need to control regulator in suspend/resume you can do it with normal regulator_enable() and regulator_disable() calls.
Thanks.
Signature · 1 line
Dmitry
PATCH v3 3/4 dt-bindings: input: touchscreen: goodix: Add GT5663 compatible
In reply to Jagan TekiGT5663 is capacitive touch controller with customized smart wakeup gestures, it support chipdata which is similar to existing GT1151 and require AVDD28 supply for some boards.
Document the compatible for the same.
--- Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/input/touchscreen/goodix.txt +1 -0
@@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series touchscreen controller Required properties: - compatible : Should be "goodix,gt1151" + or "goodix,gt5663" or "goodix,gt911" or "goodix,gt9110" or "goodix,gt912"
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v3 4/4 Input: goodix - Add GT5663 CTP support
In reply to Jagan TekiGT5663 is capacitive touch controller with customized smart wakeup gestures.
Add support for it by adding compatible and supported chip data.
The chip data on GT5663 is similar to GT1151, like
- config data register has 0x8050 address
- config data register max len is 240
- config data checksum has 16-bit
--- drivers/input/touchscreen/goodix.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/input/touchscreen/goodix.c +2 -0
@@ -218,6 +218,7 @@ static const struct goodix_chip_data *goodix_get_chip_data(u16 id) {switch (id) {case 1151 : +case 5663 :return >1x_chip_data;case 911 :
@@ -965,6 +966,7 @@ MODULE_DEVICE_TABLE(acpi, goodix_acpi_match);#ifdef CONFIG_OF static const struct of_device_id goodix_of_match[] = { { .compatible ="goodix,gt1151" }, + { .compatible ="goodix,gt5663" }, { .compatible ="goodix,gt911" }, { .compatible ="goodix,gt9110" }, { .compatible = "goodix,gt912" },
Signature · 1 line
2.18.0.321.gffc6fa0e3
Quoted 13 lines · Jagan Teki
This patchset support goodix GT5553 CTP.
Changes for v3:
- add cover-letter
- s/ADVV28/AVDD28 on commit head
- fix few typo
Changes for v2:
- Rename vcc-supply with AVDD28-supply
- disable regulator in remove
- fix to setup regulator in probe code
- add chipdata
- drop example node in dt-bindings
Any comments?