Skip to contentSkip to conversation

dt-bindings: arm: amlogic: add amediatech x96-max bindings

PATCH Superseded Kevin Hilman 4 participants 9 messages Dec 19, 2018 – Jan 31, 2019

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Kevin Hilman

author maintainer
#0 lore raw

PATCH v2 1/2 dt-bindings: arm: amlogic: add amediatech x96-max bindings

Add new vendor for amediatech, and initial board: x96-max

---
 Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.txt +1 -0
index 8dbc259081e4..c50b084b6c59 100644
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
   - "amlogic,p281" (Meson gxl s905w)
   - "oranth,tx3-mini" (Meson gxl s905w)
 
+  - "amediatech,x96-max" (Meson gxm s912)
   - "amlogic,q200" (Meson gxm s912)
   - "amlogic,q201" (Meson gxm s912)
   - "khadas,vim2" (Meson gxm s912)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 8c413d8cc2a5..c1bb0c220429 100644
@@ -24,6 +24,7 @@ amarula	Amarula Solutions
 amazon	Amazon.com, Inc.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
 amd	Advanced Micro Devices (AMD), Inc.
+amediatech	Shenzhen Amediatech Technology Co., Ltd
 amlogic	Amlogic, Inc.
 ampire	Ampire Co., Ltd.
 ams	AMS AG
Signature · 1 line
2.19.2
author maintainer
#1 lore raw

PATCH v2 2/2 arm64: dts: meson: add g12a x96 max board

Add the G12a (S905X2) based X96 Max board[1].

There is no branding for the manufacturer anywhere on the product, so it took some digging to find the manufacturer. But since there's nothing about the maker on the product I've left it out of the DT name because
1) nobody will know that name and 2) keeps the DT filename shorter.

[1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/

---
 .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts new file +28 -0
new file mode 100644
index 000000000000..c62d3d5706ff
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 BayLibre SAS. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "meson-g12a.dtsi"
+
+/ {
+	compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a";
+	model = "Shenzhen Amediatech Technology Co., Ltd X96 Max";
+
+	aliases {
+		serial0 = &uart_AO;
+	};
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x0 0x0 0x40000000>;
+	};
+};
+
+&uart_AO {
+	status = "okay";
+};
Signature · 1 line
2.19.2
#2 lore raw

Re: [PATCH v2 2/2] arm64: dts: meson: add g12a x96 max board

Hi Kevin,

Quoted 7 lines · Kevin Hilman

Add the G12a (S905X2) based X96 Max board[1].

There is no branding for the manufacturer anywhere on the product, so it took some digging to find the manufacturer. But since there's nothing about the maker on the product I've left it out of the DT name because
1) nobody will know that name and 2) keeps the DT filename shorter.

Quoted 5 lines

[1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/

---
 .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++

Just found out you forgot to update the Makefile !!

Neil

[snip]

Quoted 5 lines
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts new file +4 -0
+
+&uart_AO {
+	status = "okay";
+};
author maintainer
#3 lore raw

Re: [PATCH v2 2/2] arm64: dts: meson: add g12a x96 max board

Quoted 10 lines · Neil Armstrong

Hi Kevin,

Quoted 7 lines · Kevin Hilman

Add the G12a (S905X2) based X96 Max board[1].

There is no branding for the manufacturer anywhere on the product, so it took some digging to find the manufacturer. But since there's nothing about the maker on the product I've left it out of the DT name because
1) nobody will know that name and 2) keeps the DT filename shorter.

Quoted 7 lines
Quoted 5 lines

[1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/

---
 .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++

Just found out you forgot to update the Makefile !!

D'oh, fixing for v3.

Kevin

#4 lore raw
In reply to Kevin Hilman

Hi,

Sorry for the repeat : I replied previously to v1 as I hadn't noticed that there was already a v2.

Le 20/12/2018 à 00:35, Kevin Hilman a écrit :

Quoted 13 lines

Add new vendor for amediatech, and initial board: x96-max

---
  Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
  2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.txt +0 -0
index 8dbc259081e4..c50b084b6c59 100644

Documentation/devicetree/bindings/arm/amlogic.txt Board compatible values (alphabetically, grouped by SoC): · line 102

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.txt +1 -0
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
    - "amlogic,p281" (Meson gxl s905w)
    - "oranth,tx3-mini" (Meson gxl s905w)
 
+  - "amediatech,x96-max" (Meson gxm s912)

Shouldn't that be Meson g12a s905x2 ?

Cheers,
Chris

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#5 lore raw
Quoted 22 lines · Chris Moore

Hi,

Sorry for the repeat : I replied previously to v1 as I hadn't noticed that there was already a v2.

Le 20/12/2018 à 00:35, Kevin Hilman a écrit :

Quoted 16 lines

Add new vendor for amediatech, and initial board: x96-max

---
  Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
  2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.txt +0 -0
index 8dbc259081e4..c50b084b6c59 100644
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
    - "amlogic,p281" (Meson gxl s905w)
    - "oranth,tx3-mini" (Meson gxl s905w)
 
Quoted 3 lines

Documentation/devicetree/bindings/arm/amlogic.txt Board compatible values (alphabetically, grouped by SoC): · line 102

Quoted 1 line
Documentation/devicetree/bindings/arm/amlogic.txt +1 -0
+  - "amediatech,x96-max" (Meson gxm s912)

Shouldn't that be Meson g12a s905x2 ?

Ugh, yes. Lazy copy/paste bug. Will fix that in a v3 next year. :)

Thanks for the review,

Kevin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#6 lore raw
In reply to Chris Moore
Quoted 22 lines · Chris Moore

Hi,

Sorry for the repeat : I replied previously to v1 as I hadn't noticed that there was already a v2.

Le 20/12/2018 à 00:35, Kevin Hilman a écrit :

Quoted 16 lines

Add new vendor for amediatech, and initial board: x96-max

---
  Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
  2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.txt +0 -0
index 8dbc259081e4..c50b084b6c59 100644
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
    - "amlogic,p281" (Meson gxl s905w)
    - "oranth,tx3-mini" (Meson gxl s905w)
 
Quoted 3 lines

Documentation/devicetree/bindings/arm/amlogic.txt Board compatible values (alphabetically, grouped by SoC): · line 102

Quoted 1 line
Documentation/devicetree/bindings/arm/amlogic.txt +1 -0
+  - "amediatech,x96-max" (Meson gxm s912)

Shouldn't that be Meson g12a s905x2 ?

Yes indeed.

Kevin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

reviewer Acked-by on v2 1/2
#7 lore raw
In reply to Kevin Hilman

Hi Kevin,

Quoted 2 lines · Kevin Hilman

Add new vendor for amediatech, and initial board: x96-max

as we have seen there is no "amediatech" branding anywhere on the board itself however, FCC gave us a clue about the manufacturer: [0]
can you please add this info to the patch description when re-sending?

Quoted 1 line

(with the two comments below)

Quoted 2 lines
 Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +

if Rob is fine with vendor-prefixes.txt being updated together with adding a new board then I'm as well :)

Documentation/devicetree/bindings/arm/amlogic.txt Board compatible values (alphabetically, grouped by SoC): · line 102

Quoted 11 lines
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.txt +1 -0
index 8dbc259081e4..c50b084b6c59 100644
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
   - "amlogic,p281" (Meson gxl s905w)
   - "oranth,tx3-mini" (Meson gxl s905w)
 
+  - "amediatech,x96-max" (Meson gxm s912)

I assume that you'll not only fix the SoC here (G12A) as reported by Chris Moore but also the ordering

Regards
Martin

[0] https://fccid.io/2AI6D-X96MAX

author maintainer
#8 lore raw
Quoted 8 lines · Martin Blumenstingl

Hi Kevin,

Quoted 2 lines · Kevin Hilman

Add new vendor for amediatech, and initial board: x96-max

as we have seen there is no "amediatech" branding anywhere on the board itself however, FCC gave us a clue about the manufacturer: [0]
can you please add this info to the patch description when re-sending?

Yes, will add.

Quoted 19 lines
Quoted 1 line

(with the two comments below)

Quoted 2 lines
 Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +

if Rob is fine with vendor-prefixes.txt being updated together with adding a new board then I'm as well :)

Quoted 10 lines
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.txt +0 -0
index 8dbc259081e4..c50b084b6c59 100644
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
   - "amlogic,p281" (Meson gxl s905w)
   - "oranth,tx3-mini" (Meson gxl s905w)
 
Quoted 3 lines

Documentation/devicetree/bindings/arm/amlogic.txt Board compatible values (alphabetically, grouped by SoC): · line 102

Quoted 1 line
Documentation/devicetree/bindings/arm/amlogic.txt +1 -0
+  - "amediatech,x96-max" (Meson gxm s912)

I assume that you'll not only fix the SoC here (G12A) as reported by Chris Moore but also the ordering

Yes, will fix.

Kevin