Skip to contentSkip to conversation

arm: socfpga: clean up socfpga_common.h

PATCH Superseded Simon Goldschmidt 3 participants 21 messages Jan 9, 2019 – Mar 1, 2019

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover arm: socfpga: clean up socfpga_common.h

This series cleans up the include/configs/socfpga_common.h file a bit.

It removes some defines that are used nowhere and cleans up some leftovers after various subsystems have been converted to use DM.

Simon Goldschmidt (3):
arm: socfpga: move legacy i2c defines to vining
arm: socfpga: clean up socfpga_common.h
arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

 include/configs/socfpga_common.h      | 41 ---------------------------
 include/configs/socfpga_vining_fpga.h | 24 ++++++++++++++++
 2 files changed, 24 insertions(+), 41 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 arm: socfpga: move legacy i2c defines to vining

All socfpga boards exept for vining_fpga use DM_I2C. Move the non-DM i2c defines from socfpga_common.h to socfpga_vining_fpga.h to prevent i2c getting enabled for those boards when DM_I2C is deselected.

---

 include/configs/socfpga_common.h      | 26 --------------------------
 include/configs/socfpga_vining_fpga.h | 24 ++++++++++++++++++++++++
 2 files changed, 24 insertions(+), 26 deletions(-)
include/configs/socfpga_common.h +0 -26
index bd8f5c8c41..087ed6e96d 100644
@@ -137,32 +137,6 @@
 #define CONFIG_SYS_NAND_DATA_BASE	SOCFPGA_NANDDATA_ADDRESS
 #endif
 
-/*
- * I2C support
- */
-#ifndef CONFIG_DM_I2C
-#define CONFIG_SYS_I2C
-#define CONFIG_SYS_I2C_BASE		SOCFPGA_I2C0_ADDRESS
-#define CONFIG_SYS_I2C_BASE1		SOCFPGA_I2C1_ADDRESS
-#define CONFIG_SYS_I2C_BASE2		SOCFPGA_I2C2_ADDRESS
-#define CONFIG_SYS_I2C_BASE3		SOCFPGA_I2C3_ADDRESS
-/* Using standard mode which the speed up to 100Kb/s */
-#define CONFIG_SYS_I2C_SPEED		100000
-#define CONFIG_SYS_I2C_SPEED1		100000
-#define CONFIG_SYS_I2C_SPEED2		100000
-#define CONFIG_SYS_I2C_SPEED3		100000
-/* Address of device when used as slave */
-#define CONFIG_SYS_I2C_SLAVE		0x02
-#define CONFIG_SYS_I2C_SLAVE1		0x02
-#define CONFIG_SYS_I2C_SLAVE2		0x02
-#define CONFIG_SYS_I2C_SLAVE3		0x02
-#ifndef __ASSEMBLY__
-/* Clock supplied to I2C controller in unit of MHz */
-unsigned int cm_get_l4_sp_clk_hz(void);
-#define IC_CLK				(cm_get_l4_sp_clk_hz() / 1000000)
-#endif
-#endif /* CONFIG_DM_I2C */
-
 /*
  * QSPI support
  */
include/configs/socfpga_vining_fpga.h +24 -0
index 5517ed722d..2c6fee6ece 100644
@@ -16,6 +16,30 @@
 #define CONFIG_LOADADDR		0x01000000
 #define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR
 
+/* I2C support */
+#ifndef CONFIG_DM_I2C
+#define CONFIG_SYS_I2C
+#define CONFIG_SYS_I2C_BASE		SOCFPGA_I2C0_ADDRESS
+#define CONFIG_SYS_I2C_BASE1		SOCFPGA_I2C1_ADDRESS
+#define CONFIG_SYS_I2C_BASE2		SOCFPGA_I2C2_ADDRESS
+#define CONFIG_SYS_I2C_BASE3		SOCFPGA_I2C3_ADDRESS
+/* Using standard mode which the speed up to 100Kb/s */
+#define CONFIG_SYS_I2C_SPEED		100000
+#define CONFIG_SYS_I2C_SPEED1		100000
+#define CONFIG_SYS_I2C_SPEED2		100000
+#define CONFIG_SYS_I2C_SPEED3		100000
+/* Address of device when used as slave */
+#define CONFIG_SYS_I2C_SLAVE		0x02
+#define CONFIG_SYS_I2C_SLAVE1		0x02
+#define CONFIG_SYS_I2C_SLAVE2		0x02
+#define CONFIG_SYS_I2C_SLAVE3		0x02
+#ifndef __ASSEMBLY__
+/* Clock supplied to I2C controller in unit of MHz */
+unsigned int cm_get_l4_sp_clk_hz(void);
+#define IC_CLK				(cm_get_l4_sp_clk_hz() / 1000000)
+#endif
+#endif /* CONFIG_DM_I2C */
+
 /* I2C EEPROM */
 #ifdef CONFIG_CMD_EEPROM
 #define CONFIG_SYS_I2C_EEPROM_ADDR		0x50
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/3 arm: socfpga: move legacy i2c defines to vining

Quoted 3 lines · Simon Goldschmidt

All socfpga boards exept for vining_fpga use DM_I2C. Move the non-DM i2c defines from socfpga_common.h to socfpga_vining_fpga.h to prevent i2c getting enabled for those boards when DM_I2C is deselected.

Can you just flip the board to DM I2C ? I can test the patch .

Quoted 80 lines

---

 include/configs/socfpga_common.h      | 26 --------------------------
 include/configs/socfpga_vining_fpga.h | 24 ++++++++++++++++++++++++
 2 files changed, 24 insertions(+), 26 deletions(-)
include/configs/socfpga_common.h +0 -26
index bd8f5c8c41..087ed6e96d 100644
@@ -137,32 +137,6 @@
 #define CONFIG_SYS_NAND_DATA_BASE	SOCFPGA_NANDDATA_ADDRESS
 #endif
 
-/*
- * I2C support
- */
-#ifndef CONFIG_DM_I2C
-#define CONFIG_SYS_I2C
-#define CONFIG_SYS_I2C_BASE		SOCFPGA_I2C0_ADDRESS
-#define CONFIG_SYS_I2C_BASE1		SOCFPGA_I2C1_ADDRESS
-#define CONFIG_SYS_I2C_BASE2		SOCFPGA_I2C2_ADDRESS
-#define CONFIG_SYS_I2C_BASE3		SOCFPGA_I2C3_ADDRESS
-/* Using standard mode which the speed up to 100Kb/s */
-#define CONFIG_SYS_I2C_SPEED		100000
-#define CONFIG_SYS_I2C_SPEED1		100000
-#define CONFIG_SYS_I2C_SPEED2		100000
-#define CONFIG_SYS_I2C_SPEED3		100000
-/* Address of device when used as slave */
-#define CONFIG_SYS_I2C_SLAVE		0x02
-#define CONFIG_SYS_I2C_SLAVE1		0x02
-#define CONFIG_SYS_I2C_SLAVE2		0x02
-#define CONFIG_SYS_I2C_SLAVE3		0x02
-#ifndef __ASSEMBLY__
-/* Clock supplied to I2C controller in unit of MHz */
-unsigned int cm_get_l4_sp_clk_hz(void);
-#define IC_CLK				(cm_get_l4_sp_clk_hz() / 1000000)
-#endif
-#endif /* CONFIG_DM_I2C */
-
 /*
  * QSPI support
  */
include/configs/socfpga_vining_fpga.h +24 -0
index 5517ed722d..2c6fee6ece 100644
@@ -16,6 +16,30 @@
 #define CONFIG_LOADADDR		0x01000000
 #define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR
 
+/* I2C support */
+#ifndef CONFIG_DM_I2C
+#define CONFIG_SYS_I2C
+#define CONFIG_SYS_I2C_BASE		SOCFPGA_I2C0_ADDRESS
+#define CONFIG_SYS_I2C_BASE1		SOCFPGA_I2C1_ADDRESS
+#define CONFIG_SYS_I2C_BASE2		SOCFPGA_I2C2_ADDRESS
+#define CONFIG_SYS_I2C_BASE3		SOCFPGA_I2C3_ADDRESS
+/* Using standard mode which the speed up to 100Kb/s */
+#define CONFIG_SYS_I2C_SPEED		100000
+#define CONFIG_SYS_I2C_SPEED1		100000
+#define CONFIG_SYS_I2C_SPEED2		100000
+#define CONFIG_SYS_I2C_SPEED3		100000
+/* Address of device when used as slave */
+#define CONFIG_SYS_I2C_SLAVE		0x02
+#define CONFIG_SYS_I2C_SLAVE1		0x02
+#define CONFIG_SYS_I2C_SLAVE2		0x02
+#define CONFIG_SYS_I2C_SLAVE3		0x02
+#ifndef __ASSEMBLY__
+/* Clock supplied to I2C controller in unit of MHz */
+unsigned int cm_get_l4_sp_clk_hz(void);
+#define IC_CLK				(cm_get_l4_sp_clk_hz() / 1000000)
+#endif
+#endif /* CONFIG_DM_I2C */
+
 /* I2C EEPROM */
 #ifdef CONFIG_CMD_EEPROM
 #define CONFIG_SYS_I2C_EEPROM_ADDR		0x50
Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

PATCH 1/3 arm: socfpga: move legacy i2c defines to vining

Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]> geschrieben:

Quoted 7 lines · Simon Goldschmidt
Quoted 3 lines

All socfpga boards exept for vining_fpga use DM_I2C. Move the non-DM i2c defines from socfpga_common.h to socfpga_vining_fpga.h to prevent i2c getting enabled for those boards when DM_I2C is deselected.

Can you just flip the board to DM I2C ? I can test the patch .

I tried that first and it wouldn't compile. But if you can test it (I can't), I can give it a 2nd look.

Regards,
Simon

Quoted 90 lines

Review

Quoted 7 lines

---

 include/configs/socfpga_common.h      | 26 --------------------------
 include/configs/socfpga_vining_fpga.h | 24 ++++++++++++++++++++++++
 2 files changed, 24 insertions(+), 26 deletions(-)
(quoted diff) +0 -0

b/include/configs/socfpga_common.h

Quoted 20 lines

index bd8f5c8c41..087ed6e96d 100644

include/configs/socfpga_common.h +0 -13
@@ -137,32 +137,6 @@
 #define CONFIG_SYS_NAND_DATA_BASE    SOCFPGA_NANDDATA_ADDRESS
 #endif
 
-/*
- * I2C support
- */
-#ifndef CONFIG_DM_I2C
-#define CONFIG_SYS_I2C
-#define CONFIG_SYS_I2C_BASE          SOCFPGA_I2C0_ADDRESS
-#define CONFIG_SYS_I2C_BASE1         SOCFPGA_I2C1_ADDRESS
-#define CONFIG_SYS_I2C_BASE2         SOCFPGA_I2C2_ADDRESS
-#define CONFIG_SYS_I2C_BASE3         SOCFPGA_I2C3_ADDRESS
-/* Using standard mode which the speed up to 100Kb/s */
-#define CONFIG_SYS_I2C_SPEED         100000
-#define CONFIG_SYS_I2C_SPEED1                100000
-#define CONFIG_SYS_I2C_SPEED2                100000

include/configs/socfpga_common.h line 162

Quoted 10 lines
include/configs/socfpga_common.h +0 -10
-#define CONFIG_SYS_I2C_SPEED3                100000
-/* Address of device when used as slave */
-#define CONFIG_SYS_I2C_SLAVE         0x02
-#define CONFIG_SYS_I2C_SLAVE1                0x02
-#define CONFIG_SYS_I2C_SLAVE2                0x02
-#define CONFIG_SYS_I2C_SLAVE3                0x02
-#ifndef __ASSEMBLY__
-/* Clock supplied to I2C controller in unit of MHz */
-unsigned int cm_get_l4_sp_clk_hz(void);
-#define IC_CLK                               (cm_get_l4_sp_clk_hz() /

1000000)

Review

Quoted 7 lines
include/configs/socfpga_common.h +0 -3
-#endif
-#endif /* CONFIG_DM_I2C */
-
 /*
  * QSPI support
  */
(quoted diff) +0 -0

b/include/configs/socfpga_vining_fpga.h

Quoted 18 lines

index 5517ed722d..2c6fee6ece 100644

include/configs/socfpga_vining_fpga.h +11 -0
@@ -16,6 +16,30 @@
 #define CONFIG_LOADADDR              0x01000000
 #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
 
+/* I2C support */
+#ifndef CONFIG_DM_I2C
+#define CONFIG_SYS_I2C
+#define CONFIG_SYS_I2C_BASE          SOCFPGA_I2C0_ADDRESS
+#define CONFIG_SYS_I2C_BASE1         SOCFPGA_I2C1_ADDRESS
+#define CONFIG_SYS_I2C_BASE2         SOCFPGA_I2C2_ADDRESS
+#define CONFIG_SYS_I2C_BASE3         SOCFPGA_I2C3_ADDRESS
+/* Using standard mode which the speed up to 100Kb/s */
+#define CONFIG_SYS_I2C_SPEED         100000
+#define CONFIG_SYS_I2C_SPEED1                100000
+#define CONFIG_SYS_I2C_SPEED2                100000

include/configs/socfpga_vining_fpga.h line 39

Quoted 10 lines
include/configs/socfpga_vining_fpga.h +10 -0
+#define CONFIG_SYS_I2C_SPEED3                100000
+/* Address of device when used as slave */
+#define CONFIG_SYS_I2C_SLAVE         0x02
+#define CONFIG_SYS_I2C_SLAVE1                0x02
+#define CONFIG_SYS_I2C_SLAVE2                0x02
+#define CONFIG_SYS_I2C_SLAVE3                0x02
+#ifndef __ASSEMBLY__
+/* Clock supplied to I2C controller in unit of MHz */
+unsigned int cm_get_l4_sp_clk_hz(void);
+#define IC_CLK                               (cm_get_l4_sp_clk_hz() /

1000000)

include/configs/socfpga_vining_fpga.h line 45

Quoted 7 lines
include/configs/socfpga_vining_fpga.h +3 -0
+#endif
+#endif /* CONFIG_DM_I2C */
+
 /* I2C EEPROM */
 #ifdef CONFIG_CMD_EEPROM
 #define CONFIG_SYS_I2C_EEPROM_ADDR           0x50

--
Best regards,
Marek Vasut

#4 lore raw

PATCH 1/3 arm: socfpga: move legacy i2c defines to vining

Quoted 10 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
> All socfpga boards exept for vining_fpga use DM_I2C. Move the non-DM > i2c defines from socfpga_common.h to socfpga_vining_fpga.h to prevent > i2c getting enabled for those boards when DM_I2C is deselected.

Quoted 5 lines

Can you just flip the board to DM I2C ? I can test the patch .

I tried that first and it wouldn't compile. But if you can test it (I can't), I can give it a 2nd look.

Yes please, let's get rid of this ad-hoc non-DM stuff.

Signature · 2 lines
Best regards,
Marek Vasut
#5 lore raw

PATCH 2/3 arm: socfpga: clean up socfpga_common.h

In reply to Simon Goldschmidt

Remove outdated defines (not used any more, outdated due to DM conversion) from socfpga_common.h.

---

 include/configs/socfpga_common.h | 13 -------------
 1 file changed, 13 deletions(-)
include/configs/socfpga_common.h +0 -13
index 087ed6e96d..e9b368d93a 100644
@@ -58,10 +58,6 @@
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
 						/* Boot argument buffer size */
 
-#ifndef CONFIG_SYS_HOSTNAME
-#define CONFIG_SYS_HOSTNAME	CONFIG_SYS_BOARD
-#endif
-
 /*
  * Cache
  */
@@ -150,15 +146,6 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
 #define CONFIG_CQSPI_REF_CLK		cm_get_qspi_controller_clk_hz()
 #endif
 
-/*
- * Designware SPI support
- */
-
-/*
- * Serial Driver
- */
-#define CONFIG_SYS_NS16550_SERIAL
-
 /*
  * USB
  */
Signature · 1 line
2.17.1
#6 lore raw

PATCH 2/3 arm: socfpga: clean up socfpga_common.h

Quoted 4 lines · Simon Goldschmidt

Remove outdated defines (not used any more, outdated due to DM conversion) from socfpga_common.h.

Quoted 37 lines

---

 include/configs/socfpga_common.h | 13 -------------
 1 file changed, 13 deletions(-)
include/configs/socfpga_common.h +0 -13
index 087ed6e96d..e9b368d93a 100644
@@ -58,10 +58,6 @@
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
 						/* Boot argument buffer size */
 
-#ifndef CONFIG_SYS_HOSTNAME
-#define CONFIG_SYS_HOSTNAME	CONFIG_SYS_BOARD
-#endif
-
 /*
  * Cache
  */
@@ -150,15 +146,6 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
 #define CONFIG_CQSPI_REF_CLK		cm_get_qspi_controller_clk_hz()
 #endif
 
-/*
- * Designware SPI support
- */
-
-/*
- * Serial Driver
- */
-#define CONFIG_SYS_NS16550_SERIAL
-
 /*
  * USB
  */
Signature · 2 lines
Best regards,
Marek Vasut
#8 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

In reply to Simon Goldschmidt

socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.

Since having this define overrides the 'bootm_size' env variable for the whole socfpga platform, let's remove this define from socfpga_common.h and instead rely on the 'bootm_size' env variable (which is initialized to 160 MiB in the same file's default env). This gives users the chance to override it in their own environment.

---

 include/configs/socfpga_common.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/socfpga_common.h +0 -2
index e9b368d93a..04e0f06230 100644
@@ -10,8 +10,6 @@
  */
 #define CONFIG_CLOCKS
 
-#define CONFIG_SYS_BOOTMAPSZ		(64 * 1024 * 1024)
-
 #define CONFIG_TIMESTAMP		/* Print image info with timestamp */
 
 /* add target to build it automatically upon "make" */
Signature · 1 line
2.17.1
#9 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 20 lines · Simon Goldschmidt

socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.

Since having this define overrides the 'bootm_size' env variable for the whole socfpga platform, let's remove this define from socfpga_common.h and instead rely on the 'bootm_size' env variable (which is initialized to 160 MiB in the same file's default env). This gives users the chance to override it in their own environment.

---

 include/configs/socfpga_common.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/socfpga_common.h +0 -0
index e9b368d93a..04e0f06230 100644

include/configs/socfpga_common.h line 15

Quoted 8 lines
include/configs/socfpga_common.h +0 -2
@@ -10,8 +10,6 @@
  */
 #define CONFIG_CLOCKS
 
-#define CONFIG_SYS_BOOTMAPSZ		(64 * 1024 * 1024)
-
 #define CONFIG_TIMESTAMP		/* Print image info with timestamp */
 
 /* add target to build it automatically upon "make" */

Can you at least "imply" it to 64 MiB, so we don't change the behavior ?

Signature · 2 lines
Best regards,
Marek Vasut
#10 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]> geschrieben:

Quoted 25 lines · Simon Goldschmidt
Quoted 4 lines

socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.

Since having this define overrides the 'bootm_size' env variable for the whole socfpga platform, let's remove this define from

socfpga_common.h

Review

Quoted 11 lines

and instead rely on the 'bootm_size' env variable (which is initialized to 160 MiB in the same file's default env). This gives users the chance to override it in their own environment.

---

 include/configs/socfpga_common.h | 2 --
 1 file changed, 2 deletions(-)
(quoted diff) +0 -0

b/include/configs/socfpga_common.h

Quoted 7 lines

index e9b368d93a..04e0f06230 100644

include/configs/socfpga_common.h +0 -0
@@ -10,8 +10,6 @@
  */
 #define CONFIG_CLOCKS
 
Quoted 9 lines

include/configs/socfpga_common.h

Quoted 3 lines
include/configs/socfpga_common.h +0 -2
-#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024 * 1024)
-
 #define CONFIG_TIMESTAMP             /* Print image info with timestamp

*/

include/configs/socfpga_common.h line 15

Quoted 3 lines
include/configs/socfpga_common.h +0 -0
 /* add target to build it automatically upon "make" */
 

Can you at least "imply" it to 64 MiB, so we don't change the behavior ?

You mean change the "boot_size" value in default environment to 64 MiB? Sure.

Regards,
Simon

#11 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 39 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
> socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB. >
> Since having this define overrides the 'bootm_size' env variable for > the whole socfpga platform, let's remove this define from socfpga_common.h
> and instead rely on the 'bootm_size' env variable (which is initialized
> to 160 MiB in the same file's default env). This gives users the > chance to override it in their own environment.
>
> Signed-off-by: Simon Goldschmidt <[email protected] <mailto:[email protected]>>
> ---
>
>  include/configs/socfpga_common.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index e9b368d93a..04e0f06230 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -10,8 +10,6 @@
>   */
>  #define CONFIG_CLOCKS
>
> -#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024 * 1024) > -
>  #define CONFIG_TIMESTAMP             /* Print image info with timestamp */
>
>  /* add target to build it automatically upon "make" */ >

Quoted 5 lines

Can you at least "imply" it to 64 MiB, so we don't change the behavior ?

You mean change the "boot_size" value in default environment to 64 MiB? Sure.

Sure, just so we won't change the behavior, some people like to run gigantic kernels.

Signature · 2 lines
Best regards,
Marek Vasut
#12 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected]> geschrieben:

Quoted 42 lines · Simon Goldschmidt
Quoted 9 lines

Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
> socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB. >
> Since having this define overrides the 'bootm_size' env variable

for

Quoted 23 lines
Quoted 1 line

the whole socfpga platform, let's remove this define from

    socfpga_common.h
    > and instead rely on the 'bootm_size' env variable (which is
    initialized
    > to 160 MiB in the same file's default env). This gives users the
    > chance to override it in their own environment.
    >
    > Signed-off-by: Simon Goldschmidt <[email protected]
    <mailto:[email protected]>>
    > ---
    >
    >  include/configs/socfpga_common.h | 2 --
    >  1 file changed, 2 deletions(-)
    >
    > diff --git a/include/configs/socfpga_common.h
    b/include/configs/socfpga_common.h
    > index e9b368d93a..04e0f06230 100644
    > --- a/include/configs/socfpga_common.h
    > +++ b/include/configs/socfpga_common.h
    > @@ -10,8 +10,6 @@
    >   */
    >  #define CONFIG_CLOCKS
    >
Quoted 8 lines
    > -#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024 * 1024)
    > -
    >  #define CONFIG_TIMESTAMP             /* Print image info with
    timestamp */
    >
    >  /* add target to build it automatically upon "make" */
    >
    Can you at least "imply" it to 64 MiB, so we don't change the
Quoted 9 lines

behavior ?

Quoted 4 lines

You mean change the "boot_size" value in default environment to 64 MiB? Sure.

Sure, just so we won't change the behavior, some people like to run gigantic kernels.

Well, 28th this patch, the size should grow from 64 MiB (from the define) to 160 MiB (bootm_size value). I figured that would be ok for everyone... But if you want me to shrink that back to 64 MiB, I'm ok with that either...

Regards,
Simon

#13 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 58 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
>
>
> Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected] <mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
>
>     On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
>     > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB. >     >
>     > Since having this define overrides the 'bootm_size' env variable for
>     > the whole socfpga platform, let's remove this define from >     socfpga_common.h
>     > and instead rely on the 'bootm_size' env variable (which is >     initialized
>     > to 160 MiB in the same file's default env). This gives users the >     > chance to override it in their own environment.
>     >
>     > Signed-off-by: Simon Goldschmidt <[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>>>
>     > ---
>     >
>     >  include/configs/socfpga_common.h | 2 --
>     >  1 file changed, 2 deletions(-)
>     >
>     > diff --git a/include/configs/socfpga_common.h
>     b/include/configs/socfpga_common.h
>     > index e9b368d93a..04e0f06230 100644
>     > --- a/include/configs/socfpga_common.h
>     > +++ b/include/configs/socfpga_common.h
>     > @@ -10,8 +10,6 @@
>     >   */
>     >  #define CONFIG_CLOCKS
>     >
>     > -#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024 * 1024) >     > -
>     >  #define CONFIG_TIMESTAMP             /* Print image info with >     timestamp */
>     >
>     >  /* add target to build it automatically upon "make" */ >     >
>     Can you at least "imply" it to 64 MiB, so we don't change the behavior ?
>
>
> You mean change the "boot_size" value in default environment to 64 MiB?
> Sure.

Quoted 8 lines

Sure, just so we won't change the behavior, some people like to run gigantic kernels.

Well, 28th this patch, the size should grow from 64 MiB (from the define) to 160 MiB (bootm_size value). I figured that would be ok for everyone... But if you want me to shrink that back to 64 MiB, I'm ok with that either...

160 is fine too.

Signature · 2 lines
Best regards,
Marek Vasut
#14 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Am Mi., 9. Jan. 2019, 22:39 hat Marek Vasut <[email protected]> geschrieben:

Quoted 65 lines · Simon Goldschmidt
Quoted 14 lines

Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

    On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
    >
    >
    > Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]
    <mailto:[email protected]>
    > <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
    >
    >     On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
    >     > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.
Quoted 8 lines
    >     >
    >     > Since having this define overrides the 'bootm_size' env
    variable for
    >     > the whole socfpga platform, let's remove this define from
    >     socfpga_common.h
    >     > and instead rely on the 'bootm_size' env variable (which is
    >     initialized
    >     > to 160 MiB in the same file's default env). This gives users

the

Quoted 16 lines
Quoted 3 lines
Quoted 3 lines

chance to override it in their own environment.

Signed-off-by Simon Goldschmidt
    <[email protected]
    <mailto:[email protected]>
    >     <mailto:[email protected]
    <mailto:[email protected]>>>
    >     > ---
    >     >
    >     >  include/configs/socfpga_common.h | 2 --
    >     >  1 file changed, 2 deletions(-)
    >     >
    >     > diff --git a/include/configs/socfpga_common.h
    >     b/include/configs/socfpga_common.h
    >     > index e9b368d93a..04e0f06230 100644
    >     > --- a/include/configs/socfpga_common.h
Quoted 8 lines
    >     > +++ b/include/configs/socfpga_common.h
    >     > @@ -10,8 +10,6 @@
    >     >   */
    >     >  #define CONFIG_CLOCKS
    >     >
    >     > -#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024 * 1024)
    >     > -
    >     >  #define CONFIG_TIMESTAMP             /* Print image info

with

Quoted 16 lines
Quoted 5 lines

timestamp */
>
> /* add target to build it automatically upon "make" */ >
Can you at least "imply" it to 64 MiB, so we don't change the

    behavior ?
    >
    >
    > You mean change the "boot_size" value in default environment to 64
    MiB?
    > Sure.

    Sure, just so we won't change the behavior, some people like to run
    gigantic kernels.
Quoted 7 lines
Quoted 4 lines

Well, 28th this patch, the size should grow from 64 MiB (from the define) to 160 MiB (bootm_size value). I figured that would be ok for everyone... But if you want me to shrink that back to 64 MiB, I'm ok with that either...

160 is fine too.

Ok, so no V2 for this one. I'll check i2c DM tomorrow.

Regards,
Simon

Quoted 1 line
#15 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 86 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:39 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 10:34 PM, Simon Goldschmidt wrote:
>
>
> Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
>
>     On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
>     >
>     >
>     > Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected] <mailto:[email protected]>
>     <mailto:marex at denx.de <mailto:[email protected]>>
>     > <mailto:marex at denx.de <mailto:[email protected]> <mailto:marex at denx.de <mailto:[email protected]>>>> geschrieben:
>     >
>     >     On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
>     >     > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB. >     >     >
>     >     > Since having this define overrides the 'bootm_size' env >     variable for
>     >     > the whole socfpga platform, let's remove this define from >     >     socfpga_common.h
>     >     > and instead rely on the 'bootm_size' env variable (which is
>     >     initialized
>     >     > to 160 MiB in the same file's default env). This gives users the
>     >     > chance to override it in their own environment. >     >     >
>     >     > Signed-off-by: Simon Goldschmidt
>     <[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>>
>     >     <mailto:[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>>>>
>     >     > ---
>     >     >
>     >     >  include/configs/socfpga_common.h | 2 --
>     >     >  1 file changed, 2 deletions(-)
>     >     >
>     >     > diff --git a/include/configs/socfpga_common.h >     >     b/include/configs/socfpga_common.h
>     >     > index e9b368d93a..04e0f06230 100644
>     >     > --- a/include/configs/socfpga_common.h
>     >     > +++ b/include/configs/socfpga_common.h
>     >     > @@ -10,8 +10,6 @@
>     >     >   */
>     >     >  #define CONFIG_CLOCKS
>     >     >
>     >     > -#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024 * 1024) >     >     > -
>     >     >  #define CONFIG_TIMESTAMP             /* Print image info with
>     >     timestamp */
>     >     >
>     >     >  /* add target to build it automatically upon "make" */ >     >     >
>     >     Can you at least "imply" it to 64 MiB, so we don't change the
>     behavior ?
>     >
>     >
>     > You mean change the "boot_size" value in default environment to 64
>     MiB?
>     > Sure.
>
>     Sure, just so we won't change the behavior, some people like to run
>     gigantic kernels.
>
>
> Well, 28th this patch, the size should grow from 64 MiB (from the > define) to 160 MiB (bootm_size value). I figured that would be ok for > everyone... But if you want me to shrink that back to 64 MiB, I'm ok > with that either...

Quoted 4 lines

160 is fine too.

Ok, so no V2 for this one. I'll check i2c DM tomorrow.

Thanks, appreciated.

Signature · 2 lines
Best regards,
Marek Vasut
#16 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 88 lines · Marek Vasut
Quoted 86 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:39 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 10:34 PM, Simon Goldschmidt wrote:
>
>
> Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
>
> On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
> >
> >
> > Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]
<mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>
> > <mailto:marex at denx.de <mailto:[email protected]>
<mailto:marex at denx.de <mailto:[email protected]>>>> geschrieben:
> >
> > On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
> > > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.
> > >
> > > Since having this define overrides the 'bootm_size' env
> variable for
> > > the whole socfpga platform, let's remove this define from
> > socfpga_common.h
> > > and instead rely on the 'bootm_size' env variable
(which is
> > initialized
> > > to 160 MiB in the same file's default env). This gives
users the
> > > chance to override it in their own environment.
> > >
> > > Signed-off-by: Simon Goldschmidt
> <[email protected]
<mailto:[email protected]>
> <mailto:[email protected]
<mailto:[email protected]>>
> > <mailto:[email protected]
<mailto:[email protected]>
> <mailto:[email protected]
<mailto:[email protected]>>>>
> > > ---
> > >
> > > include/configs/socfpga_common.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h
> > > index e9b368d93a..04e0f06230 100644
> > > --- a/include/configs/socfpga_common.h
> > > +++ b/include/configs/socfpga_common.h
> > > @@ -10,8 +10,6 @@
> > > */
> > > #define CONFIG_CLOCKS
> > >
> > > -#define CONFIG_SYS_BOOTMAPSZ (64 * 1024 * 1024)
> > > -
> > > #define CONFIG_TIMESTAMP /* Print image
info with
> > timestamp */
> > >
> > > /* add target to build it automatically upon "make" */
> > >
> > Can you at least "imply" it to 64 MiB, so we don't
change the
> behavior ?
> >
> >
> > You mean change the "boot_size" value in default environment
to 64
> MiB?
> > Sure.
>
> Sure, just so we won't change the behavior, some people like
to run
> gigantic kernels.
>
>
> Well, 28th this patch, the size should grow from 64 MiB (from the > define) to 160 MiB (bootm_size value). I figured that would be ok for > everyone... But if you want me to shrink that back to 64 MiB, I'm ok > with that either...

Quoted 6 lines
Quoted 4 lines

160 is fine too.

Ok, so no V2 for this one. I'll check i2c DM tomorrow.

Thanks, appreciated.

I had a quick look, but I2C eemprom access has change too much from legacy to DM for me to just dry-code that.

Hoever, I just saw the PHY1 extension board for my SoCrates has an I2C eeprom, too. So I'll first try to get that running before just converting the Vining. But this
will probably need more time.

Regards,
Simon

#17 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 96 lines · Simon Goldschmidt
Quoted 88 lines · Marek Vasut
Quoted 86 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:39 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 10:34 PM, Simon Goldschmidt wrote:
>
>
> Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
>
> On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
> >
> >
> > Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]
<mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>
> > <mailto:marex at denx.de <mailto:[email protected]>
<mailto:marex at denx.de <mailto:[email protected]>>>> geschrieben:
> >
> > On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
> > > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.
> > >
> > > Since having this define overrides the 'bootm_size' env
> variable for
> > > the whole socfpga platform, let's remove this define from
> > socfpga_common.h
> > > and instead rely on the 'bootm_size' env variable
(which is
> > initialized
> > > to 160 MiB in the same file's default env). This gives
users the
> > > chance to override it in their own environment.
> > >
> > > Signed-off-by: Simon Goldschmidt
> <[email protected]
<mailto:[email protected]>
> <mailto:[email protected]
<mailto:[email protected]>>
> > <mailto:[email protected]
<mailto:[email protected]>
> <mailto:[email protected]
<mailto:[email protected]>>>>
> > > ---
> > >
> > > include/configs/socfpga_common.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h
> > > index e9b368d93a..04e0f06230 100644
> > > --- a/include/configs/socfpga_common.h
> > > +++ b/include/configs/socfpga_common.h
> > > @@ -10,8 +10,6 @@
> > > */
> > > #define CONFIG_CLOCKS
> > >
> > > -#define CONFIG_SYS_BOOTMAPSZ (64 * 1024 * 1024)
> > > -
> > > #define CONFIG_TIMESTAMP /* Print image
info with
> > timestamp */
> > >
> > > /* add target to build it automatically upon "make" */
> > >
> > Can you at least "imply" it to 64 MiB, so we don't
change the
> behavior ?
> >
> >
> > You mean change the "boot_size" value in default environment
to 64
> MiB?
> > Sure.
>
> Sure, just so we won't change the behavior, some people like
to run
> gigantic kernels.
>
>
> Well, 28th this patch, the size should grow from 64 MiB (from the > define) to 160 MiB (bootm_size value). I figured that would be ok for > everyone... But if you want me to shrink that back to 64 MiB, I'm ok > with that either...

Quoted 6 lines
Quoted 4 lines

160 is fine too.

Ok, so no V2 for this one. I'll check i2c DM tomorrow.

Thanks, appreciated.

Quoted 7 lines

I had a quick look, but I2C eemprom access has change too much from legacy to DM for me to just dry-code that.

Hoever, I just saw the PHY1 extension board for my SoCrates has an I2C eeprom, too. So I'll first try to get that running before just converting the Vining. But this
will probably need more time.

The MW opens next week, so that's fine .

Signature · 2 lines
Best regards,
Marek Vasut
#18 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 100 lines · Marek Vasut
Quoted 99 lines · Simon Goldschmidt
Quoted 88 lines · Marek Vasut
Quoted 86 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:39 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

On 1/9/19 10:34 PM, Simon Goldschmidt wrote:
>
>
> Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
>
> On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
> >
> >
> > Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]
<mailto:[email protected]>
> <mailto:marex at denx.de <mailto:[email protected]>>
> > <mailto:marex at denx.de <mailto:[email protected]>
<mailto:marex at denx.de <mailto:[email protected]>>>> geschrieben:
> >
> > On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
> > > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.
> > >
> > > Since having this define overrides the 'bootm_size' env
> variable for
> > > the whole socfpga platform, let's remove this define from
> > socfpga_common.h
> > > and instead rely on the 'bootm_size' env variable
(which is
> > initialized
> > > to 160 MiB in the same file's default env). This gives
users the
> > > chance to override it in their own environment.
> > >
> > > Signed-off-by: Simon Goldschmidt
> <[email protected]
<mailto:[email protected]>
> <mailto:[email protected]
<mailto:[email protected]>>
> > <mailto:[email protected]
<mailto:[email protected]>
> <mailto:[email protected]
<mailto:[email protected]>>>>
> > > ---
> > >
> > > include/configs/socfpga_common.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h
> > > index e9b368d93a..04e0f06230 100644
> > > --- a/include/configs/socfpga_common.h
> > > +++ b/include/configs/socfpga_common.h
> > > @@ -10,8 +10,6 @@
> > > */
> > > #define CONFIG_CLOCKS
> > >
> > > -#define CONFIG_SYS_BOOTMAPSZ (64 * 1024 * 1024)
> > > -
> > > #define CONFIG_TIMESTAMP /* Print image
info with
> > timestamp */
> > >
> > > /* add target to build it automatically upon "make" */
> > >
> > Can you at least "imply" it to 64 MiB, so we don't
change the
> behavior ?
> >
> >
> > You mean change the "boot_size" value in default environment
to 64
> MiB?
> > Sure.
>
> Sure, just so we won't change the behavior, some people like
to run
> gigantic kernels.
>
>
> Well, 28th this patch, the size should grow from 64 MiB (from the > define) to 160 MiB (bootm_size value). I figured that would be ok for > everyone... But if you want me to shrink that back to 64 MiB, I'm ok > with that either...

Quoted 6 lines
Quoted 4 lines

160 is fine too.

Ok, so no V2 for this one. I'll check i2c DM tomorrow.

Thanks, appreciated.

I had a quick look, but I2C eemprom access has change too much from legacy to DM for me to just dry-code that.

Quoted 6 lines
Quoted 4 lines

Hoever, I just saw the PHY1 extension board for my SoCrates has an I2C eeprom, too. So I'll first try to get that running before just converting the Vining. But this
will probably need more time.

The MW opens next week, so that's fine .

I failed to find the time to do this. It did not "just work" and I could not get it to run in the short time I had for this. Could we still merge 2/3 and 3/3 for this release? Or even leave the vining I2C cleanup to that board's maintainer (don't know who that is actually) and apply 1/3 too?

Regards,
Simon

#19 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

Quoted 123 lines · Simon Goldschmidt
Quoted 120 lines · Marek Vasut
Quoted 118 lines · Simon Goldschmidt
Quoted 101 lines · Marek Vasut
Quoted 99 lines · Simon Goldschmidt

Am Mi., 9. Jan. 2019, 22:39 hat Marek Vasut <[email protected] <mailto:[email protected]>> geschrieben:

     On 1/9/19 10:34 PM, Simon Goldschmidt wrote:
     >
     >
     > Am Mi., 9. Jan. 2019, 22:31 hat Marek Vasut <[email protected] <mailto:[email protected]>
     > <mailto:marex at denx.de <mailto:[email protected]>>> geschrieben:
     >
     >     On 1/9/19 10:30 PM, Simon Goldschmidt wrote:
     >     >
     >     >
     >     > Am Mi., 9. Jan. 2019, 22:27 hat Marek Vasut <[email protected]
     <mailto:[email protected]>
     >     <mailto:marex at denx.de <mailto:[email protected]>> >     > <mailto:marex at denx.de <mailto:[email protected]> <mailto:marex at denx.de <mailto:[email protected]>>>> geschrieben:
     >     >
     >     >     On 1/9/19 8:56 PM, Simon Goldschmidt wrote:
     >     >     > socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.
     >     >     >
     >     >     > Since having this define overrides the 'bootm_size' env
     >     variable for
     >     >     > the whole socfpga platform, let's remove this define from
     >     >     socfpga_common.h
     >     >     > and instead rely on the 'bootm_size' env variable (which is
     >     >     initialized
     >     >     > to 160 MiB in the same file's default env). This gives
     users the
     >     >     > chance to override it in their own environment. >     >     >
     >     >     > Signed-off-by: Simon Goldschmidt
     >     <[email protected] <mailto:[email protected]>
     >     <mailto:[email protected] <mailto:[email protected]>>
     >     >     <mailto:[email protected] <mailto:[email protected]>
     >     <mailto:[email protected] <mailto:[email protected]>>>>
     >     >     > ---
     >     >     >
     >     >     >  include/configs/socfpga_common.h | 2 -- >     >     >  1 file changed, 2 deletions(-)
     >     >     >
     >     >     > diff --git a/include/configs/socfpga_common.h >     >     b/include/configs/socfpga_common.h
     >     >     > index e9b368d93a..04e0f06230 100644
     >     >     > --- a/include/configs/socfpga_common.h >     >     > +++ b/include/configs/socfpga_common.h >     >     > @@ -10,8 +10,6 @@
     >     >     >   */
     >     >     >  #define CONFIG_CLOCKS
     >     >     >
     >     >     > -#define CONFIG_SYS_BOOTMAPSZ         (64 * 1024
* 1024)
     >     >     > -
     >     >     >  #define CONFIG_TIMESTAMP             /* Print image
     info with
     >     >     timestamp */
     >     >     >
     >     >     >  /* add target to build it automatically upon "make" */
     >     >     >
     >     >     Can you at least "imply" it to 64 MiB, so we don't change the
     >     behavior ?
     >     >
     >     >
     >     > You mean change the "boot_size" value in default environment
     to 64
     >     MiB?
     >     > Sure.
     >
     >     Sure, just so we won't change the behavior, some people like
     to run
     >     gigantic kernels.
     >
     >
     > Well, 28th this patch, the size should grow from 64 MiB (from the
     > define) to 160 MiB (bootm_size value). I figured that would be ok for
     > everyone... But if you want me to shrink that back to 64 MiB, I'm ok
     > with that either...

Quoted 6 lines
Quoted 4 lines

     160 is fine too.

Ok, so no V2 for this one. I'll check i2c DM tomorrow.

Thanks, appreciated.

I had a quick look, but I2C eemprom access has change too much from legacy
to DM for me to just dry-code that.

Hoever, I just saw the PHY1 extension board for my SoCrates has an I2C eeprom,
too. So I'll first try to get that running before just converting the Vining. But this
will probably need more time.

Quoted 7 lines
Quoted 1 line

The MW opens next week, so that's fine .

I failed to find the time to do this. It did not "just work" and I could not get it to run in the short time I had for this. Could we still merge 2/3 and 3/3 for this release? Or even leave the vining I2C cleanup to that board's maintainer (don't know who that is actually) and apply 1/3 too?

Can you rebase/repost those patches , so I can take a look ? Unless they are fixes, those will be for next.

Signature · 2 lines
Best regards,
Marek Vasut
#20 lore raw

PATCH 3/3 arm: socfpga: remove CONFIG_SYS_BOOTMAPSZ

In reply to Simon Goldschmidt
Quoted 9 lines · Simon Goldschmidt

socfpga_common.h defines CONFIG_SYS_BOOTMAPSZ to 64 MiB.

Since having this define overrides the 'bootm_size' env variable for the whole socfpga platform, let's remove this define from socfpga_common.h and instead rely on the 'bootm_size' env variable (which is initialized to 160 MiB in the same file's default env). This gives users the chance to override it in their own environment.

Thanks,
Stefan