Skip to contentSkip to conversation

arm64: dts: lx2160a: add sata node support

PATCH Superseded Peng Ma 2 participants 2 messages Jan 14, 2019 – Jan 16, 2019

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Peng Ma

author
#0 lore raw

PATCH v2 1/1 arm64: dts: lx2160a: add sata node support

Add sata node support and Enable sata support

---
changed for V2:
- put the 'status' at the end of property list
- add lx2160aqds sata support

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44 +++++++++++++++++++++
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +16 -0
index 99a22ab..0289955 100644
@@ -110,3 +110,19 @@
 &usb1 {
 	status = "okay";
 };
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..aacca27 100644
@@ -117,3 +117,19 @@
 &usb1 {
 	status = "okay";
 };
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +44 -0

49 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw
Quoted 1 line · Peng Ma

Add sata node support and Enable sata support

I would suggest you reword the commit log like below:

Add SATA device nodes for fsl-lx2160a and enable support for QDS and RDB boards.

Quoted 17 lines

---
changed for V2:
- put the 'status' at the end of property list
- add lx2160aqds sata support

 arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44 +++++++++++++++++++++
 3 files changed, 76 insertions(+), 0 deletions(-)
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +0 -0
index 99a22ab..0289955 100644

arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts line 114

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +2 -0
@@ -110,3 +110,19 @@
 &usb1 {
 	status = "okay";
 };
+
+&sata0 {

Please sort the labeling nodes alphabetically.

Shawn

Quoted 43 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +14 -0
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +16 -0
index 6481e5f..aacca27 100644
@@ -117,3 +117,19 @@
 &usb1 {
 	status = "okay";
 };
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +0 -0
index a79f5c1..4390aea 100644

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 766

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +2 -0
@@ -762,5 +762,49 @@
 				     <GIC_SPI 209 IRQ_TYPE_LEVEL_HIGH>;
 			dma-coherent;
 		};
+
+		sata0: sata@3200000 {

Please sort nodes with unit-address in order of the address.

Shawn

Quoted 47 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +42 -0
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata1: sata@3210000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3210000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata2: sata@3220000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3220000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
+
+		sata3: sata@3230000 {
+			compatible = "fsl,lx2160a-ahci";
+			reg = <0x0 0x3230000 0x0 0x10000>,
+			      <0x7 0x100520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 3>;
+			dma-coherent;
+			status = "disabled";
+		};
 	};
 };
Signature · 1 line
1.7.1