Skip to contentSkip to conversation

net: phy: don't include asm/irq.h directly

PATCH Applied Heiner Kallweit 4 participants 6 messages Jan 15, 2019 – Jan 17, 2019

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 net: phy: don't include asm/irq.h directly

There's no need to and one shouldn't include asm/irq.h directly.

---
 drivers/net/phy/mdio_bus.c   | 2 --
 drivers/net/phy/phy.c        | 2 --
 drivers/net/phy/phy_device.c | 2 --
 3 files changed, 6 deletions(-)
drivers/net/phy/mdio_bus.c +0 -2
index 2e59a8419..741f27228 100644
@@ -39,8 +39,6 @@
 #include <linux/io.h>
 #include <linux/uaccess.h>
 
-#include <asm/irq.h>
-
 #define CREATE_TRACE_POINTS
 #include <trace/events/mdio.h>
 
drivers/net/phy/phy.c +0 -2
index 189cd2048..f95753eda 100644
@@ -36,8 +36,6 @@
 #include <linux/uaccess.h>
 #include <linux/atomic.h>
 
-#include <asm/irq.h>
-
 #define PHY_STATE_STR(_state)			\
 	case PHY_##_state:			\
 		return __stringify(_state);	\
drivers/net/phy/phy_device.c +0 -2
index a4df9f873..f7ec6cdf8 100644
@@ -37,8 +37,6 @@
 #include <linux/uaccess.h>
 #include <linux/of.h>
 
-#include <asm/irq.h>
-
 MODULE_DESCRIPTION("PHY library");
 MODULE_AUTHOR("Andy Fleming");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.20.1
maintainer
#1 lore raw

drivers/net/phy/phy.c line 40

Quoted 10 lines
drivers/net/phy/phy.c +0 -2
index 189cd2048..f95753eda 100644
@@ -36,8 +36,6 @@
 #include <linux/uaccess.h>
 #include <linux/atomic.h>
 
-#include <asm/irq.h>
-

Hi Heiner

There is a call to request_threaded_irq() and free_irq() in this file. So it should probably include linux/irq.h.

Andrew

author maintainer
#2 lore raw
Quoted 8 lines · Andrew Lunn
Quoted 8 lines
drivers/net/phy/phy.c +0 -0
index 189cd2048..f95753eda 100644
@@ -36,8 +36,6 @@
 #include <linux/uaccess.h>
 #include <linux/atomic.h>
 
Quoted 8 lines

drivers/net/phy/phy.c line 40

Quoted 2 lines
drivers/net/phy/phy.c +0 -2
-#include <asm/irq.h>
-

Hi Heiner

There is a call to request_threaded_irq() and free_irq() in this file. So it should probably include linux/irq.h.

Both functions are declared in linux/interrupt.h which is included. If you look into linux/irq.h a comment at the very beginning states that this file shouldn't be included by generic code.

Quoted 2 lines

Andrew

Heiner