net: phy: don't include asm/irq.h directly
Subsystems (3)
Heiner Kallweit
maintainerPATCH 1/1 net: phy: don't include asm/irq.h directly
There's no need to and one shouldn't include asm/irq.h directly.
--- drivers/net/phy/mdio_bus.c | 2 -- drivers/net/phy/phy.c | 2 -- drivers/net/phy/phy_device.c | 2 -- 3 files changed, 6 deletions(-)
drivers/net/phy/mdio_bus.c +0 -2
@@ -39,8 +39,6 @@#include <linux/io.h> #include <linux/uaccess.h> -#include <asm/irq.h> -#define CREATE_TRACE_POINTS #include <trace/events/mdio.h>
drivers/net/phy/phy.c +0 -2
@@ -36,8 +36,6 @@#include <linux/uaccess.h> #include <linux/atomic.h> -#include <asm/irq.h> -#define PHY_STATE_STR (_state) \ case PHY_##_state: \ return __stringify(_state); \
drivers/net/phy/phy_device.c +0 -2
@@ -37,8 +37,6 @@#include <linux/uaccess.h> #include <linux/of.h> -#include <asm/irq.h> -MODULE_DESCRIPTION ("PHY library" );MODULE_AUTHOR ("Andy Fleming" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.20.1
Andrew Lunn
maintainerdrivers/net/phy/phy.c line 40
Quoted 10 lines
drivers/net/phy/phy.c +0
-2@@ -36,8 +36,6 @@#include <linux/uaccess.h> #include <linux/atomic.h> -#include <asm/irq.h> -
Hi Heiner
There is a call to request_threaded_irq() and free_irq() in this file. So it should probably include linux/irq.h.
Andrew
Heiner Kallweit
maintainerQuoted 8 lines · Andrew Lunn
Quoted 8 lines
drivers/net/phy/phy.c +0
-0@@ -36,8 +36,6 @@#include <linux/uaccess.h> #include <linux/atomic.h>
Quoted 8 lines
drivers/net/phy/phy.c line 40
Quoted 2 lines
drivers/net/phy/phy.c +0
-2-#include <asm/irq.h> -Hi Heiner
There is a call to
request_threaded_irq()andfree_irq()in this file. So it should probably includelinux/irq.h.
Both functions are declared in linux/interrupt.h which is included. If you look into linux/irq.h a comment at the very beginning states that this file shouldn't be included by generic code.
Quoted 2 lines
Andrew
Heiner
Quoted 3 lines · Heiner Kallweit
There's no need to and one shouldn't include
asm/irq.hdirectly.Signed-off-by Heiner Kallweit <[email protected]>
Andrew
Quoted 3 lines · Heiner Kallweit
There's no need to and one shouldn't include
asm/irq.hdirectly.Signed-off-by Heiner Kallweit <[email protected]>
Signature · 1 line
Florian
From: Heiner Kallweit <[email protected]>
Date: Tue, 15 Jan 2019 21:40:51 +0100
Quoted 3 lines
There's no need to and one shouldn't include
asm/irq.hdirectly.Signed-off-by Heiner Kallweit <[email protected]>
Applied.