Skip to contentSkip to conversation

KVM: PPC: Ultravisor: Include ultravisor header file.

PATCH In review Ram Pai 2 participants 2 messages Jan 22, 2019 PowerPC

lore
Share & tools
lore

Ram Pai

author
#0 lore raw

PATCH 2/13 KVM: PPC: Ultravisor: Include ultravisor header file.

This file contains the definitions of all ultracalls.

---
 arch/powerpc/include/asm/ucall-api.h        |  5 +++++
 arch/powerpc/include/uapi/asm/uapi_uvcall.h | 10 ++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 arch/powerpc/include/asm/ucall-api.h
 create mode 100644 arch/powerpc/include/uapi/asm/uapi_uvcall.h
arch/powerpc/include/asm/ucall-api.h new file +5 -0
new file mode 100644
index 0000000..3833b55
@@ -0,0 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_POWERPC_UCALL_API_H
+#define _ASM_POWERPC_UCALL_API_H
+#include <uapi/asm/uapi_uvcall.h>
+#endif	/* _ASM_POWERPC_UCALL_API_H */
arch/powerpc/include/uapi/asm/uapi_uvcall.h new file +10 -0
new file mode 100644
index 0000000..7e213a1
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Ultravisor calls.
+ *
+ * Copyright 2018, IBM Corporation.
+ *
+ */
+#ifndef UAPI_UC_H
+#define UAPI_UC_H
+#endif /* #ifndef UAPI_UC_H */
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 1 line · Ram Pai

This file contains the definitions of all ultracalls.

"will contain", perhaps?

Quoted 4 lines
---
 arch/powerpc/include/asm/ucall-api.h        |  5 +++++
 arch/powerpc/include/uapi/asm/uapi_uvcall.h | 10 ++++++++++

This is the wrong place for these definitions. The "u" in uapi stands for "user", and this directory is for the definition of the API that the kernel provides to userspace. This file should just go in the normal arch/powerpc/include/asm directory, and it shouldn't have "uapi" in its name.

Paul.