platform/x86: Fix unmet dependency warning for ACPI_CMPC
Subsystems (3)
PATCH v2 1/2 platform/x86: Fix unmet dependency warning for ACPI_CMPC
Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_LCD_SUPPORT.
Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix
WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
Selected by [y]:
- ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -904,7 +904,7 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" - depends on ACPI && INPUT + depends on ACPI && INPUT && BACKLIGHT_LCD_SUPPORT depends on RFKILL || RFKILL=n select BACKLIGHT_CLASS_DEVICE help
Signature · 1 line
2.19.0
PATCH v2 2/2 platform/x86: Fix unmet dependency warning for SAMSUNG_Q10
Add BACKLIGHT_LCD_SUPPORT for SAMSUNG_Q10 to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
SAMSUNG_Q10 selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_LCD_SUPPORT.
Copy BACKLIGHT_LCD_SUPPORT dependency into SAMSUNG_Q10 to fix:
WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] Selected by [y]:
- SAMSUNG_Q10 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y]
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1127,7 +1127,7 @@ config INTEL_OAKTRAIL config SAMSUNG_Q10 tristate "Samsung Q10 Extras" - depends on ACPI + depends on ACPI && BACKLIGHT_LCD_SUPPORT select BACKLIGHT_CLASS_DEVICE ---help--- This driver provides support for backlight control on Samsung Q10
Signature · 1 line
2.19.0
Re: [for next][PATCH v2 2/2] platform/x86: Fix unmet dependency warning for SAMSUNG_Q10
Quoted 7 lines · Sinan Kaya
Add
BACKLIGHT_LCD_SUPPORTforSAMSUNG_Q10to fix the
warning: unmet direct dependencies detected forBACKLIGHT_CLASS_DEVICE.
SAMSUNG_Q10selectsBACKLIGHT_CLASS_DEVICEbutBACKLIGHT_CLASS_DEVICEdepends onBACKLIGHT_LCD_SUPPORT.
Quoted 6 lines
Copy
BACKLIGHT_LCD_SUPPORTdependency intoSAMSUNG_Q10to fix:WARNING: unmet direct dependencies detected for
BACKLIGHT_CLASS_DEVICE
Depends on [n]:HAS_IOMEM[=y] &&BACKLIGHT_LCD_SUPPORT[=n] Selected by [y]:
-SAMSUNG_Q10[=y] && X86 [=y] &&X86_PLATFORM_DEVICES[=y] && ACPI [=y]
Thanks for the fix.
One comment below though.
drivers/platform/x86/Kconfig config INTEL_OAKTRAIL · line 1130
Quoted 5 lines
config
SAMSUNG_Q10
tristate "Samsung Q10 Extras"drivers/platform/x86/Kconfig +1
-1- depends on ACPI + depends on ACPI && BACKLIGHT_LCD_SUPPORT
I would like rather see it on a separate line in both patches.
Rafael, you may take it if it feels comfortable.
Quoted 6 lines
select
BACKLIGHT_CLASS_DEVICE
---help---
This driver provides support for backlight control on Samsung Q10
--
2.19.0
Signature · 2 lines
With Best Regards, Andy Shevchenko