platform/x86: Fix unmet dependency warning for ACPI_CMPC
Subsystems (3)
PATCH v3 1/2 platform/x86: Fix unmet dependency warning for ACPI_CMPC
Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_LCD_SUPPORT.
Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix
WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
Selected by [y]:
- ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
--- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/Kconfig +1 -0
@@ -905,6 +905,7 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" depends on ACPI && INPUT + depends on BACKLIGHT_LCD_SUPPORT depends on RFKILL || RFKILL=n select BACKLIGHT_CLASS_DEVICE help
Signature · 1 line
2.19.0
PATCH v3 2/2 platform/x86: Fix unmet dependency warning for SAMSUNG_Q10
Add BACKLIGHT_LCD_SUPPORT for SAMSUNG_Q10 to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
SAMSUNG_Q10 selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_LCD_SUPPORT.
Copy BACKLIGHT_LCD_SUPPORT dependency into SAMSUNG_Q10 to fix:
WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] Selected by [y]:
- SAMSUNG_Q10 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y]
--- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/Kconfig +1 -0
@@ -1129,6 +1129,7 @@ config INTEL_OAKTRAIL config SAMSUNG_Q10 tristate "Samsung Q10 Extras" depends on ACPI + depends on BACKLIGHT_LCD_SUPPORT select BACKLIGHT_CLASS_DEVICE ---help--- This driver provides support for backlight control on Samsung Q10
Signature · 1 line
2.19.0
Quoted 7 lines · Sinan Kaya
Add
BACKLIGHT_LCD_SUPPORTforACPI_CMPCto fix the
warning: unmet direct dependencies detected forBACKLIGHT_CLASS_DEVICE.
ACPI_CMPCselectsBACKLIGHT_CLASS_DEVICEbutBACKLIGHT_CLASS_DEVICEdepends onBACKLIGHT_LCD_SUPPORT.
Quoted 7 lines
Copy
BACKLIGHT_LCD_SUPPORTdependency intoACPI_CMPCto fixWARNING: unmet direct dependencies detected for
BACKLIGHT_CLASS_DEVICE
Depends on [n]:HAS_IOMEM[=y] &&BACKLIGHT_LCD_SUPPORT[=n]
Selected by [y]:
-ACPI_CMPC[=y] && X86 [=y] &&X86_PLATFORM_DEVICES[=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
for both patches in case Rafael takes care of them.
Quoted 20 lines
Signed-off-by Sinan Kaya <[email protected]>--- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/Kconfig +1
-1@@ -905,6 +905,7 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" depends on ACPI && INPUT + depends on BACKLIGHT_LCD_SUPPORT depends on RFKILL || RFKILL=n select BACKLIGHT_CLASS_DEVICE help --2.19.0
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 16 lines · CET Andy Shevchenko
Quoted 7 lines · Sinan Kaya
Add
BACKLIGHT_LCD_SUPPORTforACPI_CMPCto fix the
warning: unmet direct dependencies detected forBACKLIGHT_CLASS_DEVICE.
ACPI_CMPCselectsBACKLIGHT_CLASS_DEVICEbutBACKLIGHT_CLASS_DEVICEdepends onBACKLIGHT_LCD_SUPPORT.Quoted 7 lines
Copy
BACKLIGHT_LCD_SUPPORTdependency intoACPI_CMPCto fixWARNING: unmet direct dependencies detected for
BACKLIGHT_CLASS_DEVICE
Depends on [n]:HAS_IOMEM[=y] &&BACKLIGHT_LCD_SUPPORT[=n]
Selected by [y]:
-ACPI_CMPC[=y] && X86 [=y] &&X86_PLATFORM_DEVICES[=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
Quoted 3 lines
Acked-by Andy Shevchenko <[email protected]>for both patches in case Rafael takes care of them.
So both applied, thanks!