Skip to contentSkip to conversation

Add Fieldbus subsystem + support HMS Profinet card

PATCH Superseded Sven Van Asbroeck 3 participants 22 messages Jan 24, 2019 – Mar 12, 2019

Subsystems (2)

v8 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v8 cover Add Fieldbus subsystem + support HMS Profinet card

This patch:
1. adds a Fieldbus subsystem
2. adds support for the HMS Industrial Networks AB Profinet card.

1. Fieldbus subsystem
---------------------

Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus. The framework is designed to provide a generic interface to Fieldbus Devices from both the Linux Kernel and the userspace.

2. Add support for HMS Profinet Card
------------------------------------

Profinet is an industry technical standard for data communication over Industrial Ethernet, designed for collecting data from, and controlling, equipment in industrial systems, with a particular strength in delivering data under tight time constraints (on the order of 1ms or less).

The profinet card itself is connected to the system via an industrial bus called 'anybus'.

I have followed the bus driver/client driver pattern, and created an anybus bus driver, plus a client driver for the profinet card.

In case this patch set gets (eventually) accepted, drivers for other anybus client cards may follow: flnet, cc-link, ...

The anybus slot on the host is located on an 'anybus controller', which is custom h/w designed by arcx. It exposes a dual anybus host implementation, plus a power readout unrelated to the anybus.

v8:
allow fieldbus core to be built as a module (define as tristate). use IS_ENABLED() in fieldbus_dev.h to conditionally compile dummy functions. anybuss_core.ko uses symbols from fieldbus_dev.ko. Use "top level kbuild
file" method to make this work.
See Documentation/kbuild/modules.txt, section 6.3
Confirm licence choice: GPL-v2 only. no changes.

v7:
use %zu printf formatter to display size_t

v6:
Randy Dunlap:
correctly/consistently indent Kconfig
spelling/punctuation improvements

Greg KH:
suggestion: simplify /sys/class/fieldbus_dev/fieldbus_devX/ -> /sys/class/fieldbus_dev/X/
can't simplify: create_device() also determines the name of the associated char device. simplification would result in a char device named /dev/X ?
applied above suggestion to arcx-controller driver, this works ok as it does not
have associated char device
class name left as-is (fieldbus_dev) to differentiate between
"fieldbus controller" and "fieldbus device" in the future
makefile clean-up
sysfs attributes: snprintf -> sprintf
except card_name, as it's externally provided and could potentially be > PAGE_SIZE
enabled/online sysfs attributes converted to "0/1" values
using kstrtobool()

v5:
Greg KH:
fix licence nit
consistent use of e-mail address
replaced raw sysfs attribute with kobject_uevent() call keep __ATTRIBUTE_GROUPS because we need is_visible field
Rob Herring:
controller devicetree entry now requires multiple address
regions and interrupts
controller child node(s) now mapped to child devices by
slot/host position (using devicetree reg = <>)
architectural overhaul to align closely to existing pci arch:

pci anybus
--------------------------------------------------------------------------------
Common bus code (spec), pci/pci_driver.c anybus/dev_core.c
calls bus_register() no of compatible no of compatible
--------------------------------------------------------------------------------
Device on bus, calls
XXX_client_driver_register() hwmon/k8temp.c fieldbus/hms-profinet.c
--------------------------------------------------------------------------------
Controller, silicon driver pci/pcie-tango.c anybus/arcx-anybus.c
platform_driver calls platform_driver calls
pci_host_probe() anybus_host_common_probe()

v4:
general
create fieldbus_dev subsystem, with standardized 'simple'
userspace interface (sysfs + cdev)
remove redundant __packed keywords
use __be16/32 types wherever values are explicitly big-endian
hms-profinet:
remove configuration code, and uapi headers: not supported (yet)
when registering as a fieldbus_dev.
anybuss-host:
use struct kref to reference-count tasks
replace busy loops with usleep_range() loop after 10 tries use threaded irq so time_before_eq(jiffies, timeout) will
continue to work
allow client devices to be assigned a devicetree node,
in the same way as pci/mmc/...

v3:
devicetree-bindings
adding the vendor prefix is now a separate commit
anybus-bridge:
moved misc driver to drivers/bus/ converted of_gpio_* to gpiod_* abstractions can power readout is now a fixed-voltage regulator
anybuss-host:
converted refcounts from atomic_t to refcount_t fixed potential use-after-free
hms-profinet:
applied minor kernel build robot suggestion

v2:
added architecture overview comments to host driver completely reworked anybus-bridge driver, it becomes a reset controller anybuss-host driver now needs devicetree entry, link to reset controller I will hold off on kernel-doc until the overall architecture gets
more validation / approval
fixed Kconfig, comment-style, document ioctl magic numbers removed redundant pwm dependency
renamed enable-gpios to reset-gpios
stop driving reset-gpio after unloading driver
use interrupt-parent / interrupts method to describe interrupts
in the devicetree
convert references 'i.MX WEIM parallel bus' to 'parallel bus' replace devicetree functions with more generic platform_get_resource()
platform_get_irq()
added device unique data to add_device_randomness()

v1:
first shot

Sven Van Asbroeck (6):
fieldbus_dev: add Fieldbus Device subsystem.
anybus-s: support HMS Anybus-S bus
anybus-s: support the Arcx anybus controller
dt-bindings: anybus-controller: document devicetree binding
dt-bindings: Add vendor prefix for arcx / Archronix
fieldbus_dev: support HMS Profinet IRT industrial controller

 Documentation/ABI/testing/fieldbus-dev-cdev   |   31 +
 .../ABI/testing/sysfs-class-fieldbus-dev      |   62 +
 .../fieldbus/arcx,anybus-controller.txt       |   71 +
 .../devicetree/bindings/vendor-prefixes.txt   |    1 +
 Documentation/fieldbus_dev/fieldbus_dev.txt   |   66 +
 drivers/Kconfig                               |    2 +
 drivers/Makefile                              |    1 +
 drivers/fieldbus/Kconfig                      |   18 +
 drivers/fieldbus/Makefile                     |    7 +
 drivers/fieldbus/anybuss/Kconfig              |   39 +
 drivers/fieldbus/anybuss/Makefile             |   10 +
 drivers/fieldbus/anybuss/arcx-anybus.c        |  399 +++++
 drivers/fieldbus/anybuss/hms-profinet.c       |  223 +++
 drivers/fieldbus/anybuss/host.c               | 1459 +++++++++++++++++
 drivers/fieldbus/dev_core.c                   |  348 ++++
 include/linux/anybuss-client.h                |  104 ++
 include/linux/anybuss-controller.h            |   47 +
 include/linux/fieldbus_dev.h                  |  105 ++
 18 files changed, 2993 insertions(+)
 create mode 100644 Documentation/ABI/testing/fieldbus-dev-cdev
 create mode 100644 Documentation/ABI/testing/sysfs-class-fieldbus-dev
 create mode 100644 Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt
 create mode 100644 Documentation/fieldbus_dev/fieldbus_dev.txt
 create mode 100644 drivers/fieldbus/Kconfig
 create mode 100644 drivers/fieldbus/Makefile
 create mode 100644 drivers/fieldbus/anybuss/Kconfig
 create mode 100644 drivers/fieldbus/anybuss/Makefile
 create mode 100644 drivers/fieldbus/anybuss/arcx-anybus.c
 create mode 100644 drivers/fieldbus/anybuss/hms-profinet.c
 create mode 100644 drivers/fieldbus/anybuss/host.c
 create mode 100644 drivers/fieldbus/dev_core.c
 create mode 100644 include/linux/anybuss-client.h
 create mode 100644 include/linux/anybuss-controller.h
 create mode 100644 include/linux/fieldbus_dev.h
Signature · 1 line
2.17.1
#1 lore raw

PATCH v8 1/6 fieldbus_dev: add Fieldbus Device subsystem.

Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)

They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus.

This framework is designed to provide a generic interface to Fieldbus Devices from both the Linux Kernel and the userspace.

---
 Documentation/ABI/testing/fieldbus-dev-cdev   |  31 ++
 .../ABI/testing/sysfs-class-fieldbus-dev      |  62 ++++
 Documentation/fieldbus_dev/fieldbus_dev.txt   |  66 ++++
 drivers/Kconfig                               |   2 +
 drivers/Makefile                              |   1 +
 drivers/fieldbus/Kconfig                      |  19 +
 drivers/fieldbus/Makefile                     |   9 +
 drivers/fieldbus/dev_core.c                   | 348 ++++++++++++++++++
 include/linux/fieldbus_dev.h                  | 105 ++++++
 9 files changed, 643 insertions(+)
 create mode 100644 Documentation/ABI/testing/fieldbus-dev-cdev
 create mode 100644 Documentation/ABI/testing/sysfs-class-fieldbus-dev
 create mode 100644 Documentation/fieldbus_dev/fieldbus_dev.txt
 create mode 100644 drivers/fieldbus/Kconfig
 create mode 100644 drivers/fieldbus/Makefile
 create mode 100644 drivers/fieldbus/dev_core.c
 create mode 100644 include/linux/fieldbus_dev.h
Documentation/ABI/testing/fieldbus-dev-cdev new file +31 -0
new file mode 100644
index 000000000000..2c71f63ce0f9
@@ -0,0 +1,31 @@
+What:		/dev/fieldbus_devX
+Date:		December 2018
+KernelVersion:	4.21
+Contact:	Sven Van Asbroeck <[email protected]>
+Description:
+		The cdev interface to drivers for Fieldbus Device Memory
+			(aka. Process Memory).
+
+		The following file operations are supported:
+
+		open(2)
+		Create an I/O context associated with the file descriptor.
+
+		read(2)
+		Read from Process Memory's "read area".
+		Clears POLLERR | POLLPRI from the file descriptor.
+
+		write(2)
+		Write to Process Memory's "write area".
+
+		poll(2), select(2), epoll_wait(2) etc.
+		When a "Process Memory Read Area Changed" event occurs,
+		POLLERR | POLLPRI will be set on the file descriptor.
+		Note that POLLIN | POLLOUT events are always set, because the
+		process memory area is always readable and writable.
+
+		close(2)
+		Free up the I/O context that was associated
+		with the file descriptor.
+
+Users:		TBD
Documentation/ABI/testing/sysfs-class-fieldbus-dev new file +62 -0

62 lines not on this page · raw message

Documentation/fieldbus_dev/fieldbus_dev.txt new file +66 -0

66 lines not on this page · raw message

drivers/Kconfig +2 -0
index 4f9f99057ff8..fb5681aec645 100644
@@ -226,6 +226,8 @@ source "drivers/visorbus/Kconfig"
 
 source "drivers/siox/Kconfig"
 
+source "drivers/fieldbus/Kconfig"
+
 source "drivers/slimbus/Kconfig"
 
 endmenu
drivers/Makefile +1 -0
index e1ce029d28fd..6c9b3b708405 100644
@@ -186,3 +186,4 @@ obj-$(CONFIG_MULTIPLEXER)	+= mux/
 obj-$(CONFIG_UNISYS_VISORBUS)	+= visorbus/
 obj-$(CONFIG_SIOX)		+= siox/
 obj-$(CONFIG_GNSS)		+= gnss/
+obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus/
drivers/fieldbus/Kconfig new file +19 -0
new file mode 100644
index 000000000000..b1d071cb096e
@@ -0,0 +1,19 @@
+menuconfig FIELDBUS_DEV
+	tristate "Fieldbus Device Support"
+	help
+	  Support for Fieldbus Device Adapters.
+
+	  Fieldbus device (client) adapters allow data exchange with a PLC aka.
+	  "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)
+
+	  They are typically used when a Linux device wants to expose itself
+	  as an actuator, motor, console light, switch, etc. over the fieldbus.
+
+	  This framework is designed to provide a generic interface to Fieldbus
+	  Devices from both the Linux Kernel and the userspace.
+
+	  If unsure, say no.
+
+if FIELDBUS_DEV
+
+endif
drivers/fieldbus/Makefile new file +9 -0
new file mode 100644
index 000000000000..23877def5803
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for fieldbus_dev drivers.
+#
+
+obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus_dev.o
+fieldbus_dev-y			:= dev_core.o
+
+# Devices
drivers/fieldbus/dev_core.c new file +348 -0

348 lines not on this page · raw message

include/linux/fieldbus_dev.h new file +105 -0

105 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.

Quoted 1 line · Sven Van Asbroeck

+static DEFINE_IDA(fieldbus_ida);

You forget to destroy this ida structure when the module is removed. It's a common thing to get wrong :(

thanks,

greg k-h

#3 lore raw

Re: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.

Quoted 6 lines · Greg KH
Quoted 2 lines

+static DEFINE_IDA(fieldbus_ida);

You forget to destroy this ida structure when the module is removed. It's a common thing to get wrong :(

But fieldbus_ida is allocated on the heap. So as long as calls to ida_simple_get() and ida_simple_remove() are matched, there should be no resource leak?

What am I missing?

#4 lore raw

Re: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.

Quoted 8 lines · Sven Van Asbroeck
Quoted 6 lines · Greg KH
Quoted 2 lines

+static DEFINE_IDA(fieldbus_ida);

You forget to destroy this ida structure when the module is removed. It's a common thing to get wrong :(

Quoted 5 lines

But fieldbus_ida is allocated on the heap. So as long as calls to ida_simple_get() and ida_simple_remove() are matched, there should be no resource leak?

What am I missing?

the ida structure does some internal allocations and ida_destroy() has to be called when your code is being removed to properly free it.

Again, it's not obvious at all, but it is needed :(

thanks,

greg k-h

#5 lore raw

PATCH v8 2/6 anybus-s: support HMS Anybus-S bus

In reply to Sven Van Asbroeck

The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the application to focus on other tasks.

Typical applications are frequency inverters, HMI and visualization devices, instruments, scales, robotics, PLC’s and intelligent measuring devices.

Official documentation:
https://www.anybus.com/docs/librariesprovider7/default-document-library/
manuals-design-guides/hms-hmsi-27-275.pdf

---
 drivers/fieldbus/Kconfig           |    3 +-
 drivers/fieldbus/Makefile          |    3 +-
 drivers/fieldbus/anybuss/Kconfig   |    9 +
 drivers/fieldbus/anybuss/Makefile  |    7 +
 drivers/fieldbus/anybuss/host.c    | 1459 ++++++++++++++++++++++++++++
 include/linux/anybuss-client.h     |  104 ++
 include/linux/anybuss-controller.h |   47 +
 7 files changed, 1628 insertions(+), 4 deletions(-)
 create mode 100644 drivers/fieldbus/anybuss/Kconfig
 create mode 100644 drivers/fieldbus/anybuss/Makefile
 create mode 100644 drivers/fieldbus/anybuss/host.c
 create mode 100644 include/linux/anybuss-client.h
 create mode 100644 include/linux/anybuss-controller.h
drivers/fieldbus/Kconfig +1 -2
index b1d071cb096e..61286b77ad13 100644
@@ -14,6 +14,5 @@ menuconfig FIELDBUS_DEV
 
 	  If unsure, say no.
 
-if FIELDBUS_DEV
+source "drivers/fieldbus/anybuss/Kconfig"
 
-endif
drivers/fieldbus/Makefile +1 -2
index 23877def5803..c21056bdb3d2 100644
@@ -3,7 +3,6 @@
 # Makefile for fieldbus_dev drivers.
 #
 
-obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus_dev.o
+obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus_dev.o anybuss/
 fieldbus_dev-y			:= dev_core.o
 
-# Devices
drivers/fieldbus/anybuss/Kconfig new file +9 -0
new file mode 100644
index 000000000000..5b495f25c11e
@@ -0,0 +1,9 @@
+config HMS_ANYBUSS_BUS
+	tristate "HMS Anybus-S Bus Support"
+	select REGMAP
+	depends on OF && FIELDBUS_DEV
+	help
+	  Driver for the HMS Industrial Networks Anybus-S bus.
+	  You can attach a single Anybus-S compatible card to it, which
+	  typically provides fieldbus and industrial ethernet
+	  functionality.
drivers/fieldbus/anybuss/Makefile new file +7 -0
new file mode 100644
index 000000000000..236579aa7270
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for anybuss drivers.
+#
+
+obj-$(CONFIG_HMS_ANYBUSS_BUS)	+= anybuss_core.o
+anybuss_core-y			+= host.o
drivers/fieldbus/anybuss/host.c new file +1459 -0

1,459 lines not on this page · raw message

include/linux/anybuss-client.h new file +104 -0

104 lines not on this page · raw message

include/linux/anybuss-controller.h new file +47 -0

47 lines not on this page · raw message

Signature · 1 line
2.17.1
#6 lore raw

PATCH v8 3/6 anybus-s: support the Arcx anybus controller

In reply to Sven Van Asbroeck

Add a driver for the Arcx anybus controller.

This device implements two Anybus-S hosts (buses), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus, modelled as a regulator.

---
 drivers/fieldbus/Makefile              |   1 -
 drivers/fieldbus/anybuss/Kconfig       |  14 +
 drivers/fieldbus/anybuss/Makefile      |   2 +
 drivers/fieldbus/anybuss/arcx-anybus.c | 399 +++++++++++++++++++++++++
 4 files changed, 415 insertions(+), 1 deletion(-)
 create mode 100644 drivers/fieldbus/anybuss/arcx-anybus.c
drivers/fieldbus/Makefile +0 -1
index c21056bdb3d2..bdf645d41344 100644
@@ -5,4 +5,3 @@
 
 obj-$(CONFIG_FIELDBUS_DEV)	+= fieldbus_dev.o anybuss/
 fieldbus_dev-y			:= dev_core.o
-
drivers/fieldbus/anybuss/Kconfig +14 -0
index 5b495f25c11e..7e563a78be13 100644
@@ -7,3 +7,17 @@ config HMS_ANYBUSS_BUS
 	  You can attach a single Anybus-S compatible card to it, which
 	  typically provides fieldbus and industrial ethernet
 	  functionality.
+
+if HMS_ANYBUSS_BUS
+
+config ARCX_ANYBUS_CONTROLLER
+	tristate "Arcx Anybus-S Controller"
+	depends on OF && GPIOLIB
+	help
+	  Select this to get support for the Arcx Anybus controller.
+	  It connects to the SoC via a parallel memory bus, and
+	  embeds up to two Anybus-S buses (slots).
+	  There is also a CAN power readout, unrelated to the Anybus,
+	  modelled as a regulator.
+
+endif
drivers/fieldbus/anybuss/Makefile +2 -0
index 236579aa7270..7198b080926b 100644
@@ -5,3 +5,5 @@
 
 obj-$(CONFIG_HMS_ANYBUSS_BUS)	+= anybuss_core.o
 anybuss_core-y			+= host.o
+
+obj-$(CONFIG_ARCX_ANYBUS_CONTROLLER) += arcx-anybus.o
drivers/fieldbus/anybuss/arcx-anybus.c new file +399 -0

399 lines not on this page · raw message

Signature · 1 line
2.17.1
#7 lore raw

PATCH v8 4/6 dt-bindings: anybus-controller: document devicetree binding

In reply to Sven Van Asbroeck

From: Sven Van Asbroeck <[email protected]>

This patch adds devicetree binding documentation for the Arcx anybus controller.

---
 .../fieldbus/arcx,anybus-controller.txt       | 71 +++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt
Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt new file +71 -0
new file mode 100644
index 000000000000..b1f9474f36d5
@@ -0,0 +1,71 @@
+* Arcx Anybus-S controller
+
+This chip communicates with the SoC over a parallel bus. It is
+expected that its Device Tree node is specified as the child of a node
+corresponding to the parallel bus used for communication.
+
+Required properties:
+--------------------
+
+  - compatible : The following chip-specific string:
+        "arcx,anybus-controller"
+
+  - reg : three areas:
+	index 0: bus memory area where the cpld registers are located.
+	index 1: bus memory area of the first  host's dual-port ram.
+	index 2: bus memory area of the second host's dual-port ram.
+
+  - reset-gpios : the GPIO pin connected to the reset line of the controller.
+
+  - interrupts : two interrupts:
+		index 0: interrupt connected to the first  host
+		index 1: interrupt connected to the second host
+	Generic interrupt client node bindings are described in
+	interrupt-controller/interrupts.txt
+
+Optional: use of subnodes
+-------------------------
+
+The card connected to a host may need additional properties. These can be
+specified in subnodes to the controller node.
+
+The subnodes are identified by the standard 'reg' property. Which information
+exactly can be specified depends on the bindings for the function driver
+for the subnode.
+
+Required controller node properties when using subnodes:
+- #address-cells: should be one.
+- #size-cells: should be zero.
+
+Required subnode properties:
+- reg: Must contain the host index of the card this subnode describes:
+		<0>	for the first  host on the controller
+		<1>	for the second host on the controller
+	Note that only a single card can be plugged into a host, so the host
+	index uniquely describes the card location.
+
+Example of usage:
+-----------------
+
+This example places the bridge on top of the i.MX WEIM parallel bus, see:
+Documentation/devicetree/bindings/bus/imx-weim.txt
+
+&weim {
+	controller@0,0 {
+		compatible = "arcx,anybus-controller";
+		reg = <0 0 0x100>, <0 0x400000 0x800>, <1 0x400000 0x800>;
+		reset-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <1 IRQ_TYPE_LEVEL_LOW>, <5 IRQ_TYPE_LEVEL_LOW>;
+		/* fsl,weim-cs-timing is a i.MX WEIM bus specific property */
+		fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100
+				0x00000000 0xa0000240 0x00000000>;
+		/* optional subnode for a card plugged into the first host */
+		#address-cells = <1>;
+		#size-cells = <0>;
+		card@0 {
+			reg = <0>;
+			/* card specific properties go here */
+		};
+	};
+};
Signature · 1 line
2.17.1
#8 lore raw

PATCH v8 5/6 dt-bindings: Add vendor prefix for arcx / Archronix

In reply to Sven Van Asbroeck

From: Sven Van Asbroeck <[email protected]>

arcx Inc. is an engineering company which provides advanced embedded systems and consulting services.

Archronix is a technology design and product engineering firm specializing in hardware control systems and enabling software. Clients include OEM's in the transportation, aerospace, medical and commercial sectors.

Websites:

	http://www.arcx.com/
	http://www.archronix.com/
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 389508584f48..7c84df526018 100644
@@ -35,6 +35,7 @@ aptina	Aptina Imaging
 arasan	Arasan Chip Systems
 archermind ArcherMind Technology (Nanjing) Co., Ltd.
 arctic	Arctic Sand
+arcx	arcx Inc. / Archronix Inc.
 aries	Aries Embedded GmbH
 arm	ARM Ltd.
 armadeus	ARMadeus Systems SARL
Signature · 1 line
2.17.1
#9 lore raw

PATCH v8 6/6 fieldbus_dev: support HMS Profinet IRT industrial controller

In reply to Sven Van Asbroeck

The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface.

Official documentation:
https://www.anybus.com/docs/librariesprovider7/default-document-library
/manuals-design-guides/hms-hmsi-168-52.pdf

This implementation is an Anybus-S client driver, designed to be instantiated by the Anybus-S bus driver when it discovers the Profinet card.

If loaded successfully, the driver registers itself as a fieldbus_dev, and userspace can access it through the fieldbus_dev interface.

---
 drivers/fieldbus/anybuss/Kconfig        |  16 ++
 drivers/fieldbus/anybuss/Makefile       |   1 +
 drivers/fieldbus/anybuss/hms-profinet.c | 223 ++++++++++++++++++++++++
 3 files changed, 240 insertions(+)
 create mode 100644 drivers/fieldbus/anybuss/hms-profinet.c
drivers/fieldbus/anybuss/Kconfig +16 -0
index 7e563a78be13..2ae2daf71d70 100644
@@ -20,4 +20,20 @@ config ARCX_ANYBUS_CONTROLLER
 	  There is also a CAN power readout, unrelated to the Anybus,
 	  modelled as a regulator.
 
+config HMS_PROFINET
+	tristate "HMS Profinet IRT Controller (Anybus-S)"
+	depends on FIELDBUS_DEV && HMS_ANYBUSS_BUS
+	help
+	  If you say yes here you get support for the HMS Industrial
+	  Networks Profinet IRT Controller.
+
+	  It will be registered with the kernel as a fieldbus_dev,
+	  so userspace can interact with it via the fieldbus_dev userspace
+	  interface(s).
+
+	  This driver can also be built as a module. If so, the module
+	  will be called hms-profinet.
+
+	  If unsure, say N.
+
 endif
drivers/fieldbus/anybuss/Makefile +1 -0
index 7198b080926b..3ad3dcc6be56 100644
@@ -7,3 +7,4 @@ obj-$(CONFIG_HMS_ANYBUSS_BUS)	+= anybuss_core.o
 anybuss_core-y			+= host.o
 
 obj-$(CONFIG_ARCX_ANYBUS_CONTROLLER) += arcx-anybus.o
+obj-$(CONFIG_HMS_PROFINET)	+= hms-profinet.o
drivers/fieldbus/anybuss/hms-profinet.c new file +223 -0

223 lines not on this page · raw message

Signature · 1 line
2.17.1
#10 lore raw

Re: [PATCH v8 6/6] fieldbus_dev: support HMS Profinet IRT industrial controller

Quoted 9 lines · Sven Van Asbroeck

The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface.

Official documentation:
https://www.anybus.com/docs/librariesprovider7/default-document-library
/manuals-design-guides/hms-hmsi-168-52.pdf

Quoted 8 lines

This implementation is an Anybus-S client driver, designed to be instantiated by the Anybus-S bus driver when it discovers the Profinet card.

If loaded successfully, the driver registers itself as a fieldbus_dev, and userspace can access it through the fieldbus_dev interface.

This email address doesn't match your "From:" line in the email :(

You also seem to switch between 3 different addresses for this patchset, pick one please :)

thanks,

greg k-h

#11 lore raw
In reply to Sven Van Asbroeck
Quoted 5 lines · Sven Van Asbroeck

This patch:
1. adds a Fieldbus subsystem
2. adds support for the HMS Industrial Networks AB Profinet card.

Is there any feedback I may address? Any improvements I could make? Any clarifications?

If not, what would be the next step for this patchset?

Many thanks,
Sven

#12 lore raw
Quoted 11 lines · Sven Van Asbroeck
Quoted 5 lines · Sven Van Asbroeck

This patch:
1. adds a Fieldbus subsystem
2. adds support for the HMS Industrial Networks AB Profinet card.

Is there any feedback I may address? Any improvements I could make? Any clarifications?

If not, what would be the next step for this patchset?

I would like to see other people review and put their "name" on the patchset either with a "reviewed-by:" or "ack" or something. Don't force me to be the only one who reviews the patchset :(

thanks,

greg k-h

#13 lore raw
Quoted 3 lines · Greg KH

I would like to see other people review and put their "name" on the patchset either with a "reviewed-by:" or "ack" or something.

That's what I would love to see too !

And I agree with you that a patchset like this needs more review. Probably a lot more. Especially the fieldbus userspace interface.

The question is: how can I generate interest? Other than starting an advertising campaign or spamming developers :)

I guess this is one of the ways a patch can die: lack of interest by the wider community?

#14 lore raw
Quoted 7 lines · Sven Van Asbroeck
Quoted 3 lines · Greg KH

I would like to see other people review and put their "name" on the patchset either with a "reviewed-by:" or "ack" or something.

That's what I would love to see too !

Quoted 8 lines

And I agree with you that a patchset like this needs more review. Probably a lot more. Especially the fieldbus userspace interface.

The question is: how can I generate interest? Other than starting an advertising campaign or spamming developers :)

I guess this is one of the ways a patch can die: lack of interest by the wider community?

Well, who wants this code? Who uses it? Find those people and get them to review it. If no one wants it or uses it, that kind of implies that it's not needed :)

thanks,

greg k-h

#15 lore raw
Quoted 4 lines · Greg KH

Well, who wants this code? Who uses it? Find those people and get them to review it. If no one wants it or uses it, that kind of implies that it's not needed :)

We have customers who (will) talk to this ABI from userspace, but they are not 'Linux-y' enough to come to the mailing list and meaningfully review the userspace ABI.

IMHO the current reality of Fieldbus on Linux is companies rolling their own proprietary out-of-tree interfaces and drivers. They do this partly because there is no existing community or infrastructure. So there is no incentive to be involved with mainline, which could also explain why no-one is commenting on this Fieldbus ABI.

Chicken-and-egg problem ?

Greg, could I convince you to take this Fieldbus subsystem in drivers/staging? Perhaps its presence may kickstart or seed a Linux Fieldbus community. Being in staging/ also means that we can tweak the userspace ABI to our heart's content if more people/requirements come in.

If there's been no meaningful activity in, say, one year from now, you may decide to send this whole subsystem to /dev/null.

Sven

#16 lore raw

Am 11.03.19 um 18:02 schrieb Sven Van Asbroeck:

Quoted 18 lines · Greg KH
Quoted 4 lines

Well, who wants this code? Who uses it? Find those people and get them to review it. If no one wants it or uses it, that kind of implies that it's not needed :)

We have customers who (will) talk to this ABI from userspace, but they are not 'Linux-y' enough to come to the mailing list and meaningfully review the userspace ABI.

IMHO the current reality of Fieldbus on Linux is companies rolling their own proprietary out-of-tree interfaces and drivers. They do this partly because there is no existing community or infrastructure. So there is no incentive to be involved with mainline, which could also explain why no-one is commenting on this Fieldbus ABI.

Chicken-and-egg problem ?

Quoted 7 lines

Greg, could I convince you to take this Fieldbus subsystem in drivers/staging? Perhaps its presence may kickstart or seed a Linux Fieldbus community. Being in staging/ also means that we can tweak the userspace ABI to our heart's content if more people/requirements come in.

If there's been no meaningful activity in, say, one year from now, you may decide to send this whole subsystem to /dev/null.

I have two unfinished drivers that might benefit, for Hilscher netX 52 (multi-protocol) and Microchip LAN9252 (EtherCAT), as well as a Linux port for Infineon XMC4500 that might be expanded to XMC4800 (EtherCAT).

But currently -ENOTIME for review or development, sorry.

Staging sounds like a plan, if that allows us to still break the ABI.

Can't make any guarantees whether I might get to them within one year, as my LoRa project has been turning into a Black Hole. ;)

Are you at Netdev 0x13 later this month? That might be an opportunity to discuss the network-related parts such as Profinet and EtherCAT.

Cheers,
Andreas

https://github.com/afaerber/netx-module
https://github.com/afaerber/lan9252-module

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
#17 lore raw

Hi Andreas,

Quoted 8 lines · Andreas Färber

I have two unfinished drivers that might benefit, for Hilscher netX 52 (multi-protocol) and Microchip LAN9252 (EtherCAT), as well as a Linux port for Infineon XMC4500 that might be expanded to XMC4800 (EtherCAT).

But currently -ENOTIME for review or development, sorry.

Staging sounds like a plan, if that allows us to still break the ABI.

Those devices have very similar functionality to the h/w we use. It would be awesome if we could find common ground here. And the userspace ABI design could definitely benefit from 2-3 extra supported devices to verify it against.

Quoted 3 lines

Are you at Netdev 0x13 later this month? That might be an opportunity to discuss the network-related parts such as Profinet and EtherCAT.

Will send you an off-list message.

Cheers,
Sven

#18 lore raw
In reply to Sven Van Asbroeck
Quoted 18 lines · Sven Van Asbroeck
Quoted 4 lines · Greg KH

Well, who wants this code? Who uses it? Find those people and get them to review it. If no one wants it or uses it, that kind of implies that it's not needed :)

We have customers who (will) talk to this ABI from userspace, but they are not 'Linux-y' enough to come to the mailing list and meaningfully review the userspace ABI.

IMHO the current reality of Fieldbus on Linux is companies rolling their own proprietary out-of-tree interfaces and drivers. They do this partly because there is no existing community or infrastructure. So there is no incentive to be involved with mainline, which could also explain why no-one is commenting on this Fieldbus ABI.

Chicken-and-egg problem ?

Quoted 7 lines

Greg, could I convince you to take this Fieldbus subsystem in drivers/staging? Perhaps its presence may kickstart or seed a Linux Fieldbus community. Being in staging/ also means that we can tweak the userspace ABI to our heart's content if more people/requirements come in.

If there's been no meaningful activity in, say, one year from now, you may decide to send this whole subsystem to /dev/null.

That sounds like a good plan, I'll take that. Want to respin the patches with the code in drivers/staging/ and I'll be glad to queue them up after 5.1-rc1 is out.

thanks,

greg k-h

#19 lore raw
Quoted 4 lines · Greg KH

That sounds like a good plan, I'll take that. Want to respin the patches with the code in drivers/staging/ and I'll be glad to queue them up after 5.1-rc1 is out.

Awesome ! You can expect it in the next few days.
I'll also incorporate the last review feedback.

#20 lore raw
In reply to Greg KH
Quoted 4 lines · Greg KH

That sounds like a good plan, I'll take that. Want to respin the patches with the code in drivers/staging/ and I'll be glad to queue them up after 5.1-rc1 is out.

Andreas Farber suggested that the patchset may have more success reaching its target audience by cross-posting in netdev, and maybe linux-serial + linux-gpio. Does that sound ok? Any other group where the patchset might be welcome?

Greg, are you ok with holding off taking the patch for a few days, to give the netdev/serial/gpio people a chance to react?

#21 lore raw
Quoted 6 lines · Sven Van Asbroeck
Quoted 4 lines · Greg KH

That sounds like a good plan, I'll take that. Want to respin the patches with the code in drivers/staging/ and I'll be glad to queue them up after 5.1-rc1 is out.

Quoted 7 lines

Andreas Farber suggested that the patchset may have more success reaching its target audience by cross-posting in netdev, and maybe linux-serial + linux-gpio. Does that sound ok? Any other group where the patchset might be welcome?

Greg, are you ok with holding off taking the patch for a few days, to give the netdev/serial/gpio people a chance to react?

I can't take anything until after 5.1-rc1 is out. I have no rush, please take your time, get it right :)

greg k-h